From patchwork Thu Jul 6 14:27:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marco Pagani X-Patchwork-Id: 116763 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp2636393vqx; Thu, 6 Jul 2023 08:18:47 -0700 (PDT) X-Google-Smtp-Source: APBJJlFXlBGGYQ6Y2aON8twbu+DEWKeX8Z4a7L9Q7Xkbt6tTMvbkve7PkFDhnIr4GsUQLJHs+y1N X-Received: by 2002:a17:903:11cf:b0:1b8:9b1b:ab53 with SMTP id q15-20020a17090311cf00b001b89b1bab53mr2462569plh.20.1688656726751; Thu, 06 Jul 2023 08:18:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688656726; cv=none; d=google.com; s=arc-20160816; b=VFWCS1XdEV2o6FWbO3iYM8tLmzLnYlDNS/6joRYOraw8pe9RBCCzKnN95T+8E7KAcc QpscV0UI8SFS4sxnovd5tV6Za+uWLgMlW5NL9C1jiGNVz0YZZPqpfX78W/N4yrinIqLa jB31CHCo6USn8C0mcZsAfT6leo0gcFwj5zT8qsvlTkg7f7wKUI7kS1jU6sk+grQeZoyB WjUf116smtYHCNnTqvC9j6wES9Z23NfTBcLr7VtgLtpMY7ptxQD/Ze8MoUAzuoytSwoh DefE5NmV0Gt5CpouPozQYWaY65uXnOPG7pTizzadQR+UQD62dfw6lJ0cBejrS5wflaz/ +5iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bOMqxFOjwhp1sr/qCndFS1unAUJRkXxGEaTi00qWpSg=; fh=M37Ydd+BXMWH9O/XP+uN5l3PQrnD/ZjHRj9NyKzE96w=; b=lcOXiHiF3n79nXNKF0klUY/H81paqhqWZ0csKwQC1Y+J5BreTjpP/Vo37jJnLtGg2V TWBoq7FHpJzwsAhEgj0SeHb6TyxvW5QX+WAoJarwbneTfId63bBFTUCV9ycIVOhbPpWy pzeNWt/JzkJjp5kIIn55OCPcnzV4gJjTLaNPlWziIe+/P/VwdOrYXxF2z1vnSKmV898x 4xlRpDK+0T5kt4wXcrHfFcS7nOB4e3qtKlROgsm51cYwHOscnVH3Xeiz2+F67P1Yvh4G yLUQeosV3NIG7L8vZ4CPdekiIXbyDomeuVzvSasCr7l+le4p9g4XoIxYKUBM/guYFm3H ux4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VGbavcYm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w5-20020a1709029a8500b001b87e0a8780si1453812plp.36.2023.07.06.08.18.32; Thu, 06 Jul 2023 08:18:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VGbavcYm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232776AbjGFO3C (ORCPT + 99 others); Thu, 6 Jul 2023 10:29:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231979AbjGFO3B (ORCPT ); Thu, 6 Jul 2023 10:29:01 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 992991725 for ; Thu, 6 Jul 2023 07:28:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688653695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bOMqxFOjwhp1sr/qCndFS1unAUJRkXxGEaTi00qWpSg=; b=VGbavcYmjoO1rEqbyobi/I90nGkNEIscqr6Fi/8ycC3SPEAvTzoTEj/xp+KOS5/QqaZjt/ EpmpxWWYGu9GIh5/V5RsO8XNPR90Y/cA9fs7stkxYjFgCXCB7GI0nXQ1x+xbGEU2YeX7xr /AYlzM67fDgI4mHtnJLqBZrfXLK7exY= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-389-sZtePH3OMMqonXXz6I_svg-1; Thu, 06 Jul 2023 10:28:14 -0400 X-MC-Unique: sZtePH3OMMqonXXz6I_svg-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-634dacfa27bso9444926d6.3 for ; Thu, 06 Jul 2023 07:28:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688653694; x=1691245694; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bOMqxFOjwhp1sr/qCndFS1unAUJRkXxGEaTi00qWpSg=; b=eYqcgyn6LGBs7GI4VnJ+h+dj3eV2GxV631M2VmoVDJ4GdMBlXV+wI+HJhrpBzwkU5Y LEHiZ83mbkR/fqCkO2ezM5AOHbZ7lQT31bz9tqH4EV1zS7mPsuZpB58gxKUBTYqMdYQ7 /M9rdnjS7eyaq11rWOYAAWEff2PcmM0yoI4jDSeeR3u4tqk79bIXv2RB8PWtQPNNzEzG bvVd4YxIyTExn7H0JeAXBphvbjxVX/8s/Q4aMevYkqv5qTASs2rmtcKgWaxJJoDMKZpD daPLAHMZCCsvw5hvabWlUzXKUmC1RWvkYRr3aDtgnM9Par2jh+au3w330guWZloQtezC amZg== X-Gm-Message-State: ABy/qLYoKKvOx5n2kOTtr8n8UoNhcyixp/oz1SKU/6vj9rKkfvjfrF31 Ve31WyIyUG/8pH7VgxWGEtvSDmpFXaT09hFFp4wcHbjt3ws2a9Itdz06Hib94xtXjL1/+r6x9VA KxE+PlW/40zTuLJwLJ6GPvW8= X-Received: by 2002:a0c:cd09:0:b0:62d:fddb:1856 with SMTP id b9-20020a0ccd09000000b0062dfddb1856mr1632414qvm.43.1688653693402; Thu, 06 Jul 2023 07:28:13 -0700 (PDT) X-Received: by 2002:a0c:cd09:0:b0:62d:fddb:1856 with SMTP id b9-20020a0ccd09000000b0062dfddb1856mr1632397qvm.43.1688653693121; Thu, 06 Jul 2023 07:28:13 -0700 (PDT) Received: from klayman.redhat.com (net-2-34-24-242.cust.vodafonedsl.it. [2.34.24.242]) by smtp.gmail.com with ESMTPSA id r21-20020a0cb295000000b0063631be090csm923526qve.125.2023.07.06.07.28.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 07:28:12 -0700 (PDT) From: Marco Pagani To: Moritz Fischer , Wu Hao , Xu Yilun , Tom Rix Cc: Marco Pagani , linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org Subject: [RFC PATCH 1/2] fpga: region: fix kernel-doc Date: Thu, 6 Jul 2023 16:27:54 +0200 Message-ID: <20230706142755.124879-2-marpagan@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230706142755.124879-1-marpagan@redhat.com> References: <20230706142755.124879-1-marpagan@redhat.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770684915890703714?= X-GMAIL-MSGID: =?utf-8?q?1770684915890703714?= - Fix the following warnings issued by the kernel-doc script: drivers/fpga/fpga-region.c:46: warning: No description found for return value of 'fpga_region_get' drivers/fpga/fpga-region.c:97: warning: No description found for return value of 'fpga_region_program_fpga' drivers/fpga/fpga-region.c:295: warning: No description found for return value of 'fpga_region_init' - Remove the "and registers a reconfig notifier" part from the description of fpga_region_init() since it does not register an of_overlay notifier anymore. - Remove the outdated "if @np is not an FPGA Region" case from the return description of fpga_region_get() and replace it with the case when try_module_get() fails. Signed-off-by: Marco Pagani Reviewed-by: Randy Dunlap Acked-by: Xu Yilun --- drivers/fpga/fpga-region.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c index ccf6fdab1360..c9d065a6961b 100644 --- a/drivers/fpga/fpga-region.c +++ b/drivers/fpga/fpga-region.c @@ -38,9 +38,10 @@ EXPORT_SYMBOL_GPL(fpga_region_class_find); * * Caller should call fpga_region_put() when done with region. * - * Return fpga_region struct if successful. - * Return -EBUSY if someone already has a reference to the region. - * Return -ENODEV if @np is not an FPGA Region. + * Return: + * * fpga_region struct if successful. + * * -EBUSY if someone already has a reference to the region. + * * -ENODEV if can't take parent driver module refcount. */ static struct fpga_region *fpga_region_get(struct fpga_region *region) { @@ -91,7 +92,7 @@ static void fpga_region_put(struct fpga_region *region) * The caller will need to call fpga_bridges_put() before attempting to * reprogram the region. * - * Return 0 for success or negative error code. + * Return: 0 for success or negative error code. */ int fpga_region_program_fpga(struct fpga_region *region) { @@ -288,8 +289,9 @@ static void fpga_region_dev_release(struct device *dev) } /** - * fpga_region_init - init function for fpga_region class - * Creates the fpga_region class and registers a reconfig notifier. + * fpga_region_init - creates the fpga_region class. + * + * Return: 0 on success or ERR_PTR() on error. */ static int __init fpga_region_init(void) { From patchwork Thu Jul 6 14:27:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marco Pagani X-Patchwork-Id: 116747 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp2622798vqx; Thu, 6 Jul 2023 08:02:29 -0700 (PDT) X-Google-Smtp-Source: APBJJlFtoKYfUydbI78w0uVA6ZpIcm1Y1TTsYGc7GYxUVBQGlgZ0eFGN+CaZy5AYl9xd96Hdo6sD X-Received: by 2002:a05:6a00:1953:b0:668:731b:517e with SMTP id s19-20020a056a00195300b00668731b517emr2295311pfk.24.1688655748956; Thu, 06 Jul 2023 08:02:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688655748; cv=none; d=google.com; s=arc-20160816; b=IKWe42PdY8q6UD48z2duc37epohSgHF9TbOpJWqQm2o9WE3I8F9R6vT46UjLNL3iTO Pa5vrW+ibOxioQCk+gp7XICP6LRwyIneM3QvPnS9MNqp0dLZ9JEka3XYrkzwCaEQJNll MgFwElwvvzMmmPduJFx7Rn5HqCwAyD37Css2xi4Un0zQao2DKWPZqxeHlw+j/wUOEIl7 nFo4+qVLWt1r3Xulr+Izp9oWbFc2r/o0+udfHI9cotaDLM8FQBa4DFpyojUbpVoy7QVK uc6yZ1urYmlosNRuH2V/o1G972uEyJkAhjaRj8TrDlG8rFm0pF5uU7nD0HKN3x0/ZxxC 0eEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EiEyy1Zz1RJBfezlwrqTDqR5fyYdhtm3nESopN9SQeo=; fh=M37Ydd+BXMWH9O/XP+uN5l3PQrnD/ZjHRj9NyKzE96w=; b=AW2ppy4opN9YGmKEwZdhyaebrxgHKRN8xnxKNuQUj5rXz1RMhOanWxpsJsNOayjxQr gcO6MUcL/gzHkS95DF4eWiuaGhb4GVQg0Fgv+LKYVW1zNE2n+EWvDE7juDXM+OtONQmA l/1K0FXfmkFgQ/Ld0x8ppnNkUsoZdPQarBuesxDgCO6HFDyI5T5l2W+NS9L6hUgLVe9x voKS3/hTItfmEee8MUxykcxD6D78DcWcwekolYiVgNmhyTINQLWQMOJkerW9qo9u37wd wVgyj59nYxGFt9/EIIS9aHgyPQb5+2Vc74I+AosKWPCA1ZRRek2xRSjggtiBYAYL033v 2b7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bitsf8QC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p5-20020a634f45000000b0054ff42d3833si1689433pgl.336.2023.07.06.08.02.02; Thu, 06 Jul 2023 08:02:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bitsf8QC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232877AbjGFO3L (ORCPT + 99 others); Thu, 6 Jul 2023 10:29:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232840AbjGFO3J (ORCPT ); Thu, 6 Jul 2023 10:29:09 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCBD1173F for ; Thu, 6 Jul 2023 07:28:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688653706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EiEyy1Zz1RJBfezlwrqTDqR5fyYdhtm3nESopN9SQeo=; b=bitsf8QC53jH+qq80hQINAg+HDLYDAsZV6UBUhLctL16JHsca1He4G/Sua3B9TNXKMU7Un q6ZTOiXFe20ixst3ZGL0nHrLWWkN/jWpsK/i7iXHNsUmTctXwEiMl+QUJFdKoJalgI9zQG b6RlHCJbPDK2OYK8KH080Am2q2U90DQ= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-93-ERAfOp2hMLqOXWJXbggOXw-1; Thu, 06 Jul 2023 10:28:24 -0400 X-MC-Unique: ERAfOp2hMLqOXWJXbggOXw-1 Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-78cc6fa9ad0so146570241.0 for ; Thu, 06 Jul 2023 07:28:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688653704; x=1691245704; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EiEyy1Zz1RJBfezlwrqTDqR5fyYdhtm3nESopN9SQeo=; b=X5wwIf5ozspL4WwZIDnknB/jwtB5jjFXR5y+UX4rX0et6KerlVg9Sof1+G1iLvMYY0 g0qQ756MsYgjvtsbjhGl554OuR4DpzVjUO20/W0Dt8sKryhIGHEGJYMxe9Sr0vcCDY5A CCPgyA5BJk94dtoooubtwzjTVJUep8V1LvSoed3QpvdC6XC95bqah9NmJX0EQURpRIOL BZxIA6xiL9OgGCyHtqvk5cXxg6MKDH5cItF51NgYtXsB5NHMu7SiHJIUELvDr92HNVxo u+zFkMhA8wFy4ODoojQX+e/YpyZu/q0YUEeBkSLmpxLABn3qrBMP2gD3EOJPaAYJNmPI 2SrQ== X-Gm-Message-State: ABy/qLbL8G3mqSQVxshhZrdpR8WgrmeC74diLY8Yr3xewxk08chCQx7w iOikDzNUw+YF1xhKjOuY8KekoRZsJDp5d4ka6JYG7HYz8aPMzHmclEHH/EDlX9f/+hVZeuclLl+ JNEFsQheOJybXjK0jDsoOHIU= X-Received: by 2002:a67:f78f:0:b0:443:6792:38a with SMTP id j15-20020a67f78f000000b004436792038amr666508vso.34.1688653704257; Thu, 06 Jul 2023 07:28:24 -0700 (PDT) X-Received: by 2002:a67:f78f:0:b0:443:6792:38a with SMTP id j15-20020a67f78f000000b004436792038amr666502vso.34.1688653703990; Thu, 06 Jul 2023 07:28:23 -0700 (PDT) Received: from klayman.redhat.com (net-2-34-24-242.cust.vodafonedsl.it. [2.34.24.242]) by smtp.gmail.com with ESMTPSA id r21-20020a0cb295000000b0063631be090csm923526qve.125.2023.07.06.07.28.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 07:28:23 -0700 (PDT) From: Marco Pagani To: Moritz Fischer , Wu Hao , Xu Yilun , Tom Rix Cc: Marco Pagani , linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org Subject: [RFC PATCH 2/2] fpga: bridge: fix kernel-doc Date: Thu, 6 Jul 2023 16:27:55 +0200 Message-ID: <20230706142755.124879-3-marpagan@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230706142755.124879-1-marpagan@redhat.com> References: <20230706142755.124879-1-marpagan@redhat.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770683890652772635?= X-GMAIL-MSGID: =?utf-8?q?1770683890652772635?= Fix the following warnings issued by the kernel-doc script: drivers/fpga/fpga-bridge.c:99: warning: No description found for return value of 'of_fpga_bridge_get' drivers/fpga/fpga-bridge.c:163: warning: No description found for return value of 'fpga_bridges_enable' drivers/fpga/fpga-bridge.c:187: warning: No description found for return value of 'fpga_bridges_disable' drivers/fpga/fpga-bridge.c:238: warning: No description found for return value of 'of_fpga_bridge_get_to_list' drivers/fpga/fpga-bridge.c:268: warning: No description found for return value of 'fpga_bridge_get_to_list' - Extend the return description of of_fpga_bridge_get() to include the case when try_module_get() fails. Signed-off-by: Marco Pagani Reviewed-by: Randy Dunlap Acked-by: Xu Yilun --- drivers/fpga/fpga-bridge.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c index a6c25dee9cc1..0b76c67c50e5 100644 --- a/drivers/fpga/fpga-bridge.c +++ b/drivers/fpga/fpga-bridge.c @@ -87,12 +87,13 @@ static struct fpga_bridge *__fpga_bridge_get(struct device *dev, /** * of_fpga_bridge_get - get an exclusive reference to an fpga bridge * - * @np: node pointer of an FPGA bridge - * @info: fpga image specific information + * @np: node pointer of an FPGA bridge. + * @info: fpga image specific information. * - * Return fpga_bridge struct if successful. - * Return -EBUSY if someone already has a reference to the bridge. - * Return -ENODEV if @np is not an FPGA Bridge. + * Return: + * * fpga_bridge struct pointer if successful. + * * -EBUSY if someone already has a reference to the bridge. + * * -ENODEV if @np is not an FPGA Bridge or can't take parent driver refcount. */ struct fpga_bridge *of_fpga_bridge_get(struct device_node *np, struct fpga_image_info *info) @@ -155,9 +156,9 @@ EXPORT_SYMBOL_GPL(fpga_bridge_put); * fpga_bridges_enable - enable bridges in a list * @bridge_list: list of FPGA bridges * - * Enable each bridge in the list. If list is empty, do nothing. + * Enable each bridge in the list. If list is empty, do nothing. * - * Return 0 for success or empty bridge list; return error code otherwise. + * Return: 0 for success or empty bridge list or an error code otherwise. */ int fpga_bridges_enable(struct list_head *bridge_list) { @@ -179,9 +180,9 @@ EXPORT_SYMBOL_GPL(fpga_bridges_enable); * * @bridge_list: list of FPGA bridges * - * Disable each bridge in the list. If list is empty, do nothing. + * Disable each bridge in the list. If list is empty, do nothing. * - * Return 0 for success or empty bridge list; return error code otherwise. + * Return: 0 for success or empty bridge list or an error code otherwise. */ int fpga_bridges_disable(struct list_head *bridge_list) { @@ -230,7 +231,7 @@ EXPORT_SYMBOL_GPL(fpga_bridges_put); * * Get an exclusive reference to the bridge and it to the list. * - * Return 0 for success, error code from of_fpga_bridge_get() otherwise. + * Return: 0 for success, error code from of_fpga_bridge_get() otherwise. */ int of_fpga_bridge_get_to_list(struct device_node *np, struct fpga_image_info *info, @@ -260,7 +261,7 @@ EXPORT_SYMBOL_GPL(of_fpga_bridge_get_to_list); * * Get an exclusive reference to the bridge and it to the list. * - * Return 0 for success, error code from fpga_bridge_get() otherwise. + * Return: 0 for success, error code from fpga_bridge_get() otherwise. */ int fpga_bridge_get_to_list(struct device *dev, struct fpga_image_info *info,