From patchwork Thu Jul 6 11:42:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 116653 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp2513935vqx; Thu, 6 Jul 2023 05:14:20 -0700 (PDT) X-Google-Smtp-Source: APBJJlFZY7AkeRnMkmHC/AwwPtvoFewrUNEQoqHzOQm2CU4vidh/ke/tMGDCJ4GpXHolRfhJknbL X-Received: by 2002:a17:90a:8c89:b0:263:50ec:2f67 with SMTP id b9-20020a17090a8c8900b0026350ec2f67mr1197245pjo.0.1688645660010; Thu, 06 Jul 2023 05:14:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688645659; cv=none; d=google.com; s=arc-20160816; b=EymwGZsMABmlGViD6VW2QVj11WmkWMoBXwK2kc4ngTkRYdoFuwyMu2vhulGqgxZf75 frla4F/pcKaXaasPCR+EyOIUWqN1w9ZSk9XzuxKCrg7J18y5VW+D/jHUjfiPeqNKu+cJ mUWeNy3qOI3DuHM/7RhNjmHQAW8tISVDiO/w5j6krys8JxBHkhoupuatZB5Q4dTAL57B 6X/Ee7+24ftMBxUf0SbNJRmnSGwGJb7X4gOmQEL1h6u+b/16RBwacZAnpEk1r1x5ooP1 yTtWzxO3qlJ68on/d7NGX75ykptgpbL5PJbVRRmj8jqxlh6U28L6X2FDbu/pJFvPlSwg yoFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=QFf6t39H4lZDv2O/jFUU/00sY+cm9b1A/XP5rjFyugI=; fh=gEa+jXONTRUMy72sPLZS/6Tev+RvK53AuTJh7z6JgZA=; b=kdQB/KLjzeuNMX6D7pyVSxb00CAyeb6gqSMRs+g9F/7zsFMb0g1+nRCFGnILwHPQtS k5rxjOy0m4Kwme1L7U3Pw0JlPv0e86bi45C6+9fYJ2DyTHpqLRGoKf0EqL8EYdz+OsIs e5oxBeTfJbfvvz3cA2kZ+lbg5RrSJhuN6d84cC4zQnzAOn6JBjIP6q/6y7mOHEHZ8MSM GptNVSXiaFNCIaHWH98vhN3VDuidlvv6lobeswt0z0apmcDuB6Lep8C9D8x7kZ2BER07 7Je8K3DqFows8BAHeeF5b2EcndOIRxVFbL/j7IccFXdszwVID91s3ovrZZnLAHUR125C LiCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s7-20020a634507000000b0055af072945dsi1300274pga.812.2023.07.06.05.14.03; Thu, 06 Jul 2023 05:14:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232257AbjGFLmf (ORCPT + 99 others); Thu, 6 Jul 2023 07:42:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229693AbjGFLmd (ORCPT ); Thu, 6 Jul 2023 07:42:33 -0400 Received: from michel.telenet-ops.be (michel.telenet-ops.be [IPv6:2a02:1800:110:4::f00:18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87A6B1FD5 for ; Thu, 6 Jul 2023 04:42:11 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:5979:7b6f:39a:b9cb]) by michel.telenet-ops.be with bizsmtp id Hni62A00145Xpxs06ni620; Thu, 06 Jul 2023 13:42:08 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qHNN3-000faq-HA; Thu, 06 Jul 2023 13:42:05 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qHNN7-000QkF-Ro; Thu, 06 Jul 2023 13:42:05 +0200 From: Geert Uytterhoeven To: Mark Brown , Greg Kroah-Hartman , "Rafael J . Wysocki" , Lee Jones , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Benjamin Gray , Christophe Leroy Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 1/3] regmap: Replace "default y if" by select Date: Thu, 6 Jul 2023 13:42:02 +0200 Message-Id: <525c37a568b10623ffb2d108850afd7e37f9350e.1688643442.git.geert@linux-m68k.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770673311455559967?= X-GMAIL-MSGID: =?utf-8?q?1770673311455559967?= Merely setting the default to enabled is no guarantee that a Kconfig option is actually enabled. While this works for an invisible option, the user can still disable it manually if the option is visible. Hence since the REGMAP option was made visible if KUNIT_ALL_TESTS is enabled, the user can now manually disable REGMAP, causing build failures if any of the REGMAP_* configuration options are enabled. Fix this by replacing "default y if ..." by individual "select REGMAP" statements for all users. Fixes: 70a640c0efa76674 ("regmap: REGMAP_KUNIT should not select REGMAP") Reported-by: Benjamin Gray Closes: https://lore.kernel.org/r/20230705003024.1486757-1-bgray@linux.ibm.com Reported-by: Christophe Leroy Closes: https://lore.kernel.org/r/d8437dd4-63b6-13fb-22fd-9b92c661071c@csgroup.eu Signed-off-by: Geert Uytterhoeven --- drivers/base/regmap/Kconfig | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig index 0db2021f7477f2ab..e25cc619c75de3d9 100644 --- a/drivers/base/regmap/Kconfig +++ b/drivers/base/regmap/Kconfig @@ -5,7 +5,6 @@ config REGMAP bool "Register Map support" if KUNIT_ALL_TESTS - default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SOUNDWIRE || REGMAP_SOUNDWIRE_MBQ || REGMAP_SCCB || REGMAP_I3C || REGMAP_SPI_AVMM || REGMAP_MDIO || REGMAP_FSI) select IRQ_DOMAIN if REGMAP_IRQ select MDIO_BUS if REGMAP_MDIO help @@ -25,10 +24,12 @@ config REGMAP_KUNIT config REGMAP_AC97 tristate + select REGMAP config REGMAP_I2C tristate depends on I2C + select REGMAP config REGMAP_SLIMBUS tristate @@ -37,23 +38,29 @@ config REGMAP_SLIMBUS config REGMAP_SPI tristate depends on SPI + select REGMAP config REGMAP_SPMI tristate depends on SPMI + select REGMAP config REGMAP_W1 tristate depends on W1 + select REGMAP config REGMAP_MDIO tristate + select REGMAP config REGMAP_MMIO tristate + select REGMAP config REGMAP_IRQ bool + select REGMAP config REGMAP_RAM tristate @@ -61,23 +68,29 @@ config REGMAP_RAM config REGMAP_SOUNDWIRE tristate depends on SOUNDWIRE + select REGMAP config REGMAP_SOUNDWIRE_MBQ tristate depends on SOUNDWIRE + select REGMAP config REGMAP_SCCB tristate depends on I2C + select REGMAP config REGMAP_I3C tristate depends on I3C + select REGMAP config REGMAP_SPI_AVMM tristate depends on SPI + select REGMAP config REGMAP_FSI tristate depends on FSI + select REGMAP From patchwork Thu Jul 6 11:42:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 116650 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp2510621vqx; Thu, 6 Jul 2023 05:09:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlHsaBWKPoMCmRJA5OhgKlWa24KTq45n5GO8iaeEBgfJZieIlOt2b2nW0/9QgN+KJwZnR+KF X-Received: by 2002:a05:6a00:194d:b0:668:7b5b:c1aa with SMTP id s13-20020a056a00194d00b006687b5bc1aamr1862677pfk.20.1688645373870; Thu, 06 Jul 2023 05:09:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688645373; cv=none; d=google.com; s=arc-20160816; b=EltzdH8ZgoiwkixxwmOfD+yeJy2bgH768wUCmgViVYLdYRMVRy8LocUiqO9lXayFOr 73JX2nB+6Dui+7Hc7KzMJhy0N0FPCsI+extdHHvF11gQ4CvHs6pxj9x/leH/qy98S1UG ZAuVNXCqc4NsIDT1EIP1svJ41Q+ESa9hEAz0bUGWW08WXPIrTHzgavYLpC4nTI2BGBSD kzP4kgYlJmmy3lZ1MNDz8Pb0RO+iSGstJagJ/WWr66qvrKAKhzNhsDs5EMN5z/0cYJ4J DgVLgx02cTDZaqZXz+v3ViSdm68jt7bPg5HUw1SF8TmgRQP6utS+3yZPhmEICLJ/lF6z KPCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=zWs8bwHH6cZjAmtCgxp9HJ8bEp8/99TbL0yjvu7oPvs=; fh=gEa+jXONTRUMy72sPLZS/6Tev+RvK53AuTJh7z6JgZA=; b=uJDnHcvvG6T4Q88tlgK8/YVKiYPmx7l0oOVGVAjVoHk/oEkpnuleIh8h08BKoNimNy QwOCvOgQI8n2awSyUx/HTroDM/LTj2iwSjDFBZODDUd1kgY9ri6qqF9tpUKhgl8cPLPF 388A3VcMV0VbGZthhh92EoJwtrbJTBQ6ZmZM/agsLWEdkDhUWD1w64JMLycZPFEJlrBT vp3eXLRYfZa7i9zH31u2g6iPHWR7EhZKIJdq6FNz9xAzLTGQJdZBOnw2Ha/L9SWpNbkx datxlmHgtLTEmK7jIbEDWSwVaLi+qod9qpUjFMYpp219V2ipNtHbE1rnK96qzoLNKLNY NjsA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i63-20020a638742000000b0055792e57c89si1372943pge.450.2023.07.06.05.09.20; Thu, 06 Jul 2023 05:09:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229693AbjGFLmh (ORCPT + 99 others); Thu, 6 Jul 2023 07:42:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232505AbjGFLmd (ORCPT ); Thu, 6 Jul 2023 07:42:33 -0400 Received: from laurent.telenet-ops.be (laurent.telenet-ops.be [IPv6:2a02:1800:110:4::f00:19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8697B1BEE for ; Thu, 6 Jul 2023 04:42:11 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:5979:7b6f:39a:b9cb]) by laurent.telenet-ops.be with bizsmtp id Hni62A00445Xpxs01ni6ha; Thu, 06 Jul 2023 13:42:08 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qHNN3-000fav-Hy; Thu, 06 Jul 2023 13:42:06 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qHNN7-000QkI-Td; Thu, 06 Jul 2023 13:42:05 +0200 From: Geert Uytterhoeven To: Mark Brown , Greg Kroah-Hartman , "Rafael J . Wysocki" , Lee Jones , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Benjamin Gray , Christophe Leroy Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 2/3] regmap: REGMAP_SLIMBUS should select REGMAP Date: Thu, 6 Jul 2023 13:42:03 +0200 Message-Id: <7519324a34015e1c046227269409fef688889f4f.1688643442.git.geert@linux-m68k.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770673011183055454?= X-GMAIL-MSGID: =?utf-8?q?1770673011183055454?= If CONFIG_SND_SOC_WCD934X=y, CONFIG_COMPILE_TEST=y, CONFIG_MFD_WCD934X=n, CONFIG_REGMAP=n: sound/soc/codecs/wcd934x.c:518:38: error: array type has incomplete element type ‘struct regmap_range_cfg’ 518 | static const struct regmap_range_cfg wcd934x_ifc_ranges[] = { | ^~~~~~~~~~~~~~~~~~ Fix this by making REGMAP_SLIMBUS select REGMAP. Drop the selection of REGMAP by MFD_WCD934X, as this is not needed (now both REGMAP_SLIMBUS and REGMAP_IRQ select REGMAP). Signed-off-by: Geert Uytterhoeven Acked-by: Lee Jones --- drivers/base/regmap/Kconfig | 1 + drivers/mfd/Kconfig | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig index e25cc619c75de3d9..c3a260ed4e864959 100644 --- a/drivers/base/regmap/Kconfig +++ b/drivers/base/regmap/Kconfig @@ -34,6 +34,7 @@ config REGMAP_I2C config REGMAP_SLIMBUS tristate depends on SLIMBUS + select REGMAP config REGMAP_SPI tristate diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 0b6af476f554a191..5857dad2c64828fa 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -2121,7 +2121,6 @@ config MFD_STMFX config MFD_WCD934X tristate "Support for WCD9340/WCD9341 Codec" depends on SLIMBUS - select REGMAP select REGMAP_SLIMBUS select REGMAP_IRQ select MFD_CORE From patchwork Thu Jul 6 11:42:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 116661 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp2525276vqx; Thu, 6 Jul 2023 05:33:44 -0700 (PDT) X-Google-Smtp-Source: APBJJlGW+RMHV/yNwls5JzxY39YRZyj6qsRuwzKeVv3Y1W5SrZFOjQopG/Zrj+O4EhqWl5rPEKIe X-Received: by 2002:a17:902:d2c1:b0:1b8:6245:1235 with SMTP id n1-20020a170902d2c100b001b862451235mr7888521plc.13.1688646824040; Thu, 06 Jul 2023 05:33:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688646824; cv=none; d=google.com; s=arc-20160816; b=huNTJ7sX0OokHo+Tn00oe1ctdTFzQYeuaolSgCzYOvhuE5hW6RpDj3vc5m2SNKUKPX sxizZxy4jHhZxIoyBGvvZ1AQonVSGKE9CZbjzalli/JSgn3AwaeUTFI0wu1BvwjAtSv6 KWVbwU2OrC7Ge3MCX0fkGAabCcLKga176Y0j+o6y8Mq/fQwLl4wg5LoApBfrAdFaNQMI Cp2eWv4xMp0+8zPtdJiGnAXQOqqlxFAJzLNeVDtM3JVJE67lBnYolNpIFOAKJNPOAUmw cgXxNPMlDwCUgK9yK1TVKc/o/zQQC0ytnv/n2ya3zo9yQhO9mV5dqDQb3q8jM6lBMtfs LdUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=9mtVpfK5Tb1s6mFYurgK2QpcjmY8qvxqFtG1cECg/vQ=; fh=gEa+jXONTRUMy72sPLZS/6Tev+RvK53AuTJh7z6JgZA=; b=lPtUWE5DEGk1gEnjKBTQFuytKLi96hB1UN7P+4KP0I3S05rG/FBzl3TEfrAmS8GGr8 EdX5ZFih3wCs6y/ed+2kW1LPUXbPeBypYDrA7c3EcIj1Irp6ZrjCbFUWzm8vTc+OrZeV Ec37389PhlF/1nWlRrtYTBFieDAflK2v2rZJOLeZ/7sUlpcz0BrqQrvF2fCYVYH9hc8t nq9x7wLHYzCtIiyyU1U+78cGtWkfb/MI+xA5cfSwgdKhGcjf7y9fRcjOAEecF7zb9kq3 Wb4a0dxUlVpS7ZRZlcsg9585OLWoaNW5508tivYBV6355irDNyyZOzDKM+V/Rn/BSzfD FaAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b11-20020a170902bd4b00b001aaea258805si1228847plx.134.2023.07.06.05.33.30; Thu, 06 Jul 2023 05:33:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232630AbjGFLmj (ORCPT + 99 others); Thu, 6 Jul 2023 07:42:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232523AbjGFLme (ORCPT ); Thu, 6 Jul 2023 07:42:34 -0400 Received: from laurent.telenet-ops.be (laurent.telenet-ops.be [IPv6:2a02:1800:110:4::f00:19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86DF01BFE for ; Thu, 6 Jul 2023 04:42:11 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:5979:7b6f:39a:b9cb]) by laurent.telenet-ops.be with bizsmtp id Hni62A00545Xpxs01ni6hb; Thu, 06 Jul 2023 13:42:08 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qHNN3-000fay-Ik; Thu, 06 Jul 2023 13:42:06 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qHNN7-000QkN-Ut; Thu, 06 Jul 2023 13:42:05 +0200 From: Geert Uytterhoeven To: Mark Brown , Greg Kroah-Hartman , "Rafael J . Wysocki" , Lee Jones , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Benjamin Gray , Christophe Leroy Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 3/3] ASoC: codecs: SND_SOC_WCD934X should select REGMAP_IRQ Date: Thu, 6 Jul 2023 13:42:04 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770674385282322162?= X-GMAIL-MSGID: =?utf-8?q?1770674532528151265?= If CONFIG_SND_SOC_WCD934X=y, CONFIG_COMPILE_TEST=y, CONFIG_MFD_WCD934X=n, CONFIG_REGMAP_IRQ=n: aarch64-linux-gnu-ld: sound/soc/codecs/wcd934x.o: in function `wcd934x_codec_probe': wcd934x.c:(.text+0x33cc): undefined reference to `regmap_irq_get_virq' aarch64-linux-gnu-ld: sound/soc/codecs/wcd934x.o: in function `wcd934x_comp_probe': wcd934x.c:(.text+0x4cb0): undefined reference to `regmap_irq_get_virq' aarch64-linux-gnu-ld: wcd934x.c:(.text+0x4cc0): undefined reference to `regmap_irq_get_virq' aarch64-linux-gnu-ld: wcd934x.c:(.text+0x4cd0): undefined reference to `regmap_irq_get_virq' aarch64-linux-gnu-ld: wcd934x.c:(.text+0x4ce0): undefined reference to `regmap_irq_get_virq' aarch64-linux-gnu-ld: sound/soc/codecs/wcd934x.o:wcd934x.c:(.text+0x4cf0): more undefined references to `regmap_irq_get_virq' follow Fix this by making SND_SOC_WCD934X select REGMAP_IRQ. Signed-off-by: Geert Uytterhoeven --- sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 2a62dbd5339e4a3a..958499050c8b6a3f 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1942,6 +1942,7 @@ config SND_SOC_WCD934X tristate "WCD9340/WCD9341 Codec" depends on COMMON_CLK depends on SLIMBUS + select REGMAP_IRQ select REGMAP_SLIMBUS select SND_SOC_WCD_MBHC depends on MFD_WCD934X || COMPILE_TEST