From patchwork Wed Jul 5 13:00:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Dapp X-Patchwork-Id: 116122 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp1848882vqx; Wed, 5 Jul 2023 06:00:55 -0700 (PDT) X-Google-Smtp-Source: APBJJlFNOfdRUfWzbmKc/aujfO38gD6a86IJpQ/ISRExtKboa0IFBRO6AoH6scQV07U02C8QFP9U X-Received: by 2002:a17:906:bc88:b0:96a:3f29:40d9 with SMTP id lv8-20020a170906bc8800b0096a3f2940d9mr11888929ejb.25.1688562055533; Wed, 05 Jul 2023 06:00:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688562055; cv=none; d=google.com; s=arc-20160816; b=EeIdAnDW+Ir8t1QUM/u5fVRCdvTFMCO5DuYF1f2L6UUWes2nKSYWC60c5BpaMDVA0t 5iwSw45CMwIZcWVU8ZRxFseEMkqeQ+l5sAUfH8aAI1QNJe0LB4daVuYL/fBjOtkLdgqg abbZ3LUudNjA5eBDtCT6TEjacI+QmYvAm8AZo+J90DRc1P+hx63eNj33Pu+zEPb48MCn V+iSRLBtlex2qn/qYX07sQeNNR/v59s0SgHPLFx/4593RPcS5UdMD3vkzawAft5zrWyf PrICsyCNiJiNP+ASWT/nPtdQMP6ulgtXT4kUPcr/Lvn7c4g90hGeRzKr5IyRD5qI7sOB Ki/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:subject:to:content-language:cc:user-agent :mime-version:date:message-id:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=tKnA72UW9DzgjIE1dOPus2VErkgSANyIF/Z3JU8apcQ=; fh=0vXgoIsEThH6Qba7saR4QWpKnBkTEEL72tevRHKcYxQ=; b=HmZc5t5c0q0XemrC6M5GJJnfHkBOpLB0VYr0f8bC1oUyIOxMYTM8rk7RkQsONAP0mV sX+b5BFZIgmdrXDiUvaJoCwdLXdUIzozMciGoOJB986IIVnJQZzwyNjBofRi3IXe13eP ycNRFIns7Khts0uncbMd4h3EreqfCy+XO08Zuvh3TJA1M3DqjmU3vqVF7wxfgosAfwTt OBowxqThUlfVPWxzh+K5/zcBOL1TJLCravMZ68l60JvLILe5vta077dAjxyuKhv754+9 aPqkbkpItZQbNC+lZ6yxclH2RV+0AGe9BYmP9yvwDSEi0qNJ9LETrODGs6m0wvAIkhgG +9eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=LSKpRJn7; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id ch26-20020a170906c2da00b00965a6d6b536si13712951ejb.335.2023.07.05.06.00.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 06:00:55 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=LSKpRJn7; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E79D73858423 for ; Wed, 5 Jul 2023 13:00:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E79D73858423 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1688562052; bh=tKnA72UW9DzgjIE1dOPus2VErkgSANyIF/Z3JU8apcQ=; h=Date:Cc:To:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=LSKpRJn7weI9kg2ur2opKlERnieFIk8ez3TFEYjnSfYF9bW0e/xp+02Ak3Jd+JCMW ed2BrD41Yq7OGgdi1sus+m8wFod7/vlTT6jthbV8N3cVju1DIlA04UoOL2M+G0nVT9 6Rrs+K4YcdPxOQZtiQEN0c9ogelVjnZ/ewnTYfoY= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id F0FD43858C5E for ; Wed, 5 Jul 2023 13:00:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F0FD43858C5E Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3fbc244d384so66141095e9.0 for ; Wed, 05 Jul 2023 06:00:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688562003; x=1691154003; h=content-transfer-encoding:subject:from:to:content-language:cc :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tKnA72UW9DzgjIE1dOPus2VErkgSANyIF/Z3JU8apcQ=; b=KPKiBJsVwcyseOCWV9I4NUPGK2IlIJDYnc6McaKJugSOQzNNiVEgRuHsWX7bYXTnVi GOX+bwF5bKYNsxUoNfj1aSrKlE+eOfOPctqlnUVwGVXONMTg9txXYu+w6MdgEWWPFNKR 4kz4PUcH9nJ6f4GcodHSHDbMt6sMIjIlLksCpFFN4XQzm5TGd8O9alBF0J2O2oGk8sex bx4+ZIPeelddRxBZgeoWLrc5NybR2eK54it0+lBd8vD2nqwlIbArZLZ4IY3MD5iHEWaf OJxCRHWzsXso2bGt3zDdOPHkMa+pmfkQ8u7SfE3JDwUj1IAQKmFbz8TTl6xz3OiK9FuV vi+A== X-Gm-Message-State: AC+VfDz0C7mN33flTntoGxMCEJIw/BxZF7/jjk6LKEEHfpXIHa7QDnrf w3th4M/ugFwFaIwRT4Ongk/uwA5rZ+TnHQ== X-Received: by 2002:a05:600c:218f:b0:3fa:a6ce:54ad with SMTP id e15-20020a05600c218f00b003faa6ce54admr13057297wme.6.1688562002871; Wed, 05 Jul 2023 06:00:02 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id x11-20020adff0cb000000b0031424f4ef1dsm13792300wro.19.2023.07.05.06.00.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 06:00:02 -0700 (PDT) Message-ID: Date: Wed, 5 Jul 2023 15:00:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Cc: rdapp.gcc@gmail.com Content-Language: en-US To: gcc-patches , palmer , Kito Cheng , "juzhe.zhong@rivai.ai" , jeffreyalaw Subject: [PATCH] RISC-V: Change truncate to float_truncate in narrowing X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Robin Dapp via Gcc-patches From: Robin Dapp Reply-To: Robin Dapp Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770585645855555256?= X-GMAIL-MSGID: =?utf-8?q?1770585645855555256?= Hi, Juzhe noticed that several floating-point conversion tests FAIL on 32 bit. This is due to the autovect FP narrowing patterns using a truncate instead of a float_truncate which results in a combine ICE. It would try to e.g. simplify a unary operation by simplify_const_unary_operation which obviously expects a float_truncate and not a truncate for a floating-point mode. Regards Robin gcc/ChangeLog: * config/riscv/autovec.md: Use float_truncate. --- gcc/config/riscv/autovec.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/config/riscv/autovec.md b/gcc/config/riscv/autovec.md index 466b27d5c49..3884dfc363c 100644 --- a/gcc/config/riscv/autovec.md +++ b/gcc/config/riscv/autovec.md @@ -473,7 +473,7 @@ (define_expand "extend2" ;; ------------------------------------------------------------------------- (define_insn_and_split "trunc2" [(set (match_operand: 0 "register_operand" "=vr") - (truncate: + (float_truncate: (match_operand:VWEXTF_ZVFHMIN 1 "register_operand" " vr")))] "TARGET_VECTOR && can_create_pseudo_p ()" "#" @@ -493,7 +493,7 @@ (define_insn_and_split "trunc2" ;; ------------------------------------------------------------------------- (define_expand "trunc2" [(set (match_operand: 0 "register_operand") - (truncate: + (float_truncate: (match_operand:VQEXTF 1 "register_operand")))] "TARGET_VECTOR && (TARGET_ZVFHMIN || TARGET_ZVFH)" {