From patchwork Tue Jul 4 16:01:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Marek X-Patchwork-Id: 115847 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp1327372vqx; Tue, 4 Jul 2023 09:14:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlG8XCoJBeBraYP+wbHssWpzGvzO3UT0ctWuD49HWsGRSEfZRuothR/YegpSSjV7JtT1znrA X-Received: by 2002:a17:903:2343:b0:1b8:73e9:e3c3 with SMTP id c3-20020a170903234300b001b873e9e3c3mr16819184plh.57.1688487272349; Tue, 04 Jul 2023 09:14:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688487272; cv=none; d=google.com; s=arc-20160816; b=KKGyvyIIl8bB4wKSXSmWQcrf0K0hqcOvQSpKcg4U8hPhLJruumUOwDZuwm/jrdbzBX ugvJSdAh+S3YLjaNPc/WssDrmxDKNt0YIz6aDjjDQ88DT6mcF/kd/Y7US6Ru1Ct8zcdt sOJs+FNC7hck5SSfeGwiaixQFx65j+HKUtVtVyOmsx90g/cj+bNBwaT+Wgm2i4idx+LX t3UJ15Qc2N9axsBervUpxeuratsMpUcYtm8hJYJJmE+DSfxalNybvKTev4r0XxO935Gy 37U/j5lFRcpFOFkgojxX9cOLK9CWu2icgw7lmBVLpBcfoZ8Nb4C24ra0Kj/umUC8KIcu JFKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=vGounWSX2Ta3v2i79JYImPXzwvWuhBfpeJNjehKi004=; fh=ApxtifOwurwOHTBSGoZcdzHvkaO/c4hnzN2iZ2uh/iQ=; b=a1CWlWZYgqiBo+t46yeTGLo65hvWE1BXL5qF3iqEp3UK9R3yFgQBvGGNQiJqQaX0yJ Td16Hzqw4YBMocE1NsTiTHCI7tsTp7xlVoO9PQuAwmZenMUMIBZh4/ieVS9KcqSi+GGo VjkP3L1xma4d43W3SQJt5llFFE6hKYeHh4NQhGJ9RmfJqKH/yGAwEH9CjFOXISL+Tva2 j3yQ+QIU/RTPVPBCAzEWPHPze5FP+FD/NSKa950CJpUgY9HXkmT18zju9doAIVPXbGpC OH3IVdWyqcyO4/WlzPErYtgo1keS7R7M8IlVVO6IZ+XmvRNd4GY6fHyMim7rq+Za1+PL Wuog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@marek-ca.20221208.gappssmtp.com header.s=20221208 header.b=rc0Z7y7T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k13-20020a170902ce0d00b001b025aba9f2si22228780plg.22.2023.07.04.09.14.16; Tue, 04 Jul 2023 09:14:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@marek-ca.20221208.gappssmtp.com header.s=20221208 header.b=rc0Z7y7T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231409AbjGDQCe (ORCPT + 99 others); Tue, 4 Jul 2023 12:02:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230090AbjGDQCc (ORCPT ); Tue, 4 Jul 2023 12:02:32 -0400 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E3DCE7A for ; Tue, 4 Jul 2023 09:02:30 -0700 (PDT) Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-766fd5f9536so425214385a.3 for ; Tue, 04 Jul 2023 09:02:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek-ca.20221208.gappssmtp.com; s=20221208; t=1688486550; x=1691078550; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vGounWSX2Ta3v2i79JYImPXzwvWuhBfpeJNjehKi004=; b=rc0Z7y7TRSX2d+1KPwiGFAhYt8WzwvmJqI3TYwOtVT7uvUJyHaeN5LaGt1mKP6LKnC uKq/8vW9itima9B31SpAz2mexuJEkJdzIMVLK3cmvR/s+Y7cz9KbMRjSAgMJ+7VFtPVG dIJu6aXSkK+O7myNN/V/OfAmFqOzWcohTDSY287Ugp/Fag9pxnuwih1IXXP6cNdp9XKK lmXRumrxbC3Uemv/foXY+rq8vEePWATO3BKLYjB3LRWaqrVZhwfReNd4+XXK5P6fmFHk ikG+Oh3DBXvPMPhfFoQHTQiPEtlhp2z93JMi/J6KDiEtY7ZJC7WpFdzK/n0WaokgzzGA kRQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688486550; x=1691078550; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vGounWSX2Ta3v2i79JYImPXzwvWuhBfpeJNjehKi004=; b=NmostboBlo+JGGqpS37LPP9XzUlxg3GtBX880mR2K1bnk6avnwUH/KUuZUUovccISk jeJONbnSJqZg3gZkSabgzv2FLF8PNnwgWvorHx936J9lSov2cwbRZ11BGegCEaP9cK3M MMeGmurMfvijSjvQXO514fl/AuzzMnc+8TcHs7rkUttCb6RK3nzj6BaeiRAwYIEWEhRw Yqova8Wr+35mZeQGs2B8gaB3km36D5IVjuuwsI8oHxaypWGmjzRGZy6qo/hhfNdq6UFo 4AMgVBT5VLbdztGBitbzfdBtqg0JjcLDVJ3wlyErBvLztntDLuYidsiQc8ytsKJPRhAn QnwA== X-Gm-Message-State: ABy/qLbFwYZQwBZibIV3Qm2Zi3vN8o9X//IdcFNizWfWofgfy5KNCfr7 k/xmmcsTElfnmKQLA93di1Et9A== X-Received: by 2002:a05:620a:4096:b0:765:575b:415 with SMTP id f22-20020a05620a409600b00765575b0415mr17754462qko.24.1688486549669; Tue, 04 Jul 2023 09:02:29 -0700 (PDT) Received: from localhost.localdomain (modemcable125.110-19-135.mc.videotron.ca. [135.19.110.125]) by smtp.gmail.com with ESMTPSA id l15-20020ad4444f000000b0062439f05b87sm12659236qvt.45.2023.07.04.09.02.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 09:02:29 -0700 (PDT) From: Jonathan Marek To: freedreno@lists.freedesktop.org Cc: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Neil Armstrong , Kalyan Thota , linux-arm-msm@vger.kernel.org (open list:DRM DRIVER FOR MSM ADRENO GPU), dri-devel@lists.freedesktop.org (open list:DRM DRIVER FOR MSM ADRENO GPU), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] drm/msm/dpu: add missing flush and fetch bits for DMA4/DMA5 planes Date: Tue, 4 Jul 2023 12:01:04 -0400 Message-Id: <20230704160106.26055-1-jonathan@marek.ca> X-Mailer: git-send-email 2.26.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770507229835562610?= X-GMAIL-MSGID: =?utf-8?q?1770507229835562610?= Note that with this, DMA4/DMA5 are still non-functional, but at least display *something* in modetest instead of nothing or underflow. Fixes: efcd0107727c ("drm/msm/dpu: add support for SM8550") Signed-off-by: Jonathan Marek Reviewed-by: Abhinav Kumar Tested-by: Neil Armstrong # on SM8550-QRD --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c index bbdc95ce374a..52222af5975f 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c @@ -51,7 +51,7 @@ static const u32 fetch_tbl[SSPP_MAX] = {CTL_INVALID_BIT, 16, 17, 18, 19, CTL_INVALID_BIT, CTL_INVALID_BIT, CTL_INVALID_BIT, CTL_INVALID_BIT, 0, - 1, 2, 3, CTL_INVALID_BIT, CTL_INVALID_BIT}; + 1, 2, 3, 4, 5}; static const struct dpu_ctl_cfg *_ctl_offset(enum dpu_ctl ctl, const struct dpu_mdss_cfg *m, @@ -206,6 +206,12 @@ static void dpu_hw_ctl_update_pending_flush_sspp(struct dpu_hw_ctl *ctx, case SSPP_DMA3: ctx->pending_flush_mask |= BIT(25); break; + case SSPP_DMA4: + ctx->pending_flush_mask |= BIT(13); + break; + case SSPP_DMA5: + ctx->pending_flush_mask |= BIT(14); + break; case SSPP_CURSOR0: ctx->pending_flush_mask |= BIT(22); break;