From patchwork Tue Jul 4 13:48:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugo Villeneuve X-Patchwork-Id: 115798 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp1238648vqx; Tue, 4 Jul 2023 06:55:47 -0700 (PDT) X-Google-Smtp-Source: APBJJlEz/LCp8j9oS+4COwbFLv2OJzOjnKMm0qBF6x2/xruYQVegspEgMUiILGQuOwgrsAnobvIX X-Received: by 2002:a05:6808:10d3:b0:3a3:95cb:bf2c with SMTP id s19-20020a05680810d300b003a395cbbf2cmr9203695ois.4.1688478947019; Tue, 04 Jul 2023 06:55:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688478946; cv=none; d=google.com; s=arc-20160816; b=PwIxMu9NbQwPVYFUYbkA3gh8oOLp+W6Tr7ubPMDI/ylU+ItKd5GN56PI2XTVLUy2mC ZHLSGskZ4VbjFCo5WOAzs8NIyfnifhJBPjCSpucfQUtvuzFUHcRDh4Us+Kj3LvSYNXNB MdHEh4svVfB1QwVWJZoq4lHBEih9EmHfSDyLz23TaFXeLakjIqlrnwrAOcgNdWdgp/01 Ak+8Bu2TphLRZnR2VuNrsSS6kWbF7599jsqKM6uiNSpe4gnM6C1RfFVenPcrW0GyUu4K qd+0ym5BStlhmSj9vNM3PGoZzlBTQVXaVgAE3vktPOD4/EYed6DvHlQw8YtP9q3S6PTT 0iJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :message-id:date:cc:to:from:dkim-signature; bh=HNYNRHK5hsHCp8PMqNz6J7/yBHySrFBR6MRM4TH+ur4=; fh=6gindUKuK6fjAGJPaCkRu0WctBGe9qYH1UhBBPqjn34=; b=U6XJArXL3cV2ZD4mNW2hnr4oFEYzQghMAu5gW6sYkXK8lHQZ3N01GnIGMMVVVvWMSj sw8l+7TGkmgWkCuK9BFoPCdRA4P2ufVhUftjcLhlYaqVdmU7viOuorEO5SBXhm3m0X37 TsF0iDE0eNdNDKcgQBKToZxntvGDXdv3vVBr6QUBXV2nE8QjAZHx8LzKtIbVlV5we3Y6 P5Aau0hZFs0FAslBB31xBuP0mTpXuySxU5bqQme+w4c7buAHZEPDEr4seB56zhT4ZuR3 g7zom37gCSi4bsfPN0rY3UoONKS1M54TLqudVcgD2e9xpEHCe+Rjk/rkfW9wn1hAfuTv vP1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=VwCB37Ua; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a63-20020a639042000000b0054fe43caa81si21910576pge.782.2023.07.04.06.55.31; Tue, 04 Jul 2023 06:55:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=VwCB37Ua; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231233AbjGDNs5 (ORCPT + 99 others); Tue, 4 Jul 2023 09:48:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231349AbjGDNsu (ORCPT ); Tue, 4 Jul 2023 09:48:50 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EA75E7E; Tue, 4 Jul 2023 06:48:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Cc:To :From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=HNYNRHK5hsHCp8PMqNz6J7/yBHySrFBR6MRM4TH+ur4=; b=V wCB37UaXR5waPMPgsDLeyvwiXlseaOEMShrWpq6ykspCJ7hLO7eXcwqwN12tHC8+WFGx3gQ4/ry0u ycJVRTSY/2sqZp9oKkMG9FsEp5vtHHyzc8DAGhSMh7u9I5UdO+zU3PKlM5/rSMZTKdRmG9eDENNoM ZB4+0M+Sm/qrlKpM=; Received: from modemcable061.19-161-184.mc.videotron.ca ([184.161.19.61]:50754 helo=localhost.localdomain) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1qGgO5-0007n8-3h; Tue, 04 Jul 2023 09:48:13 -0400 From: Hugo Villeneuve To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Cc: hugo@hugovil.com, Hugo Villeneuve , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 4 Jul 2023 09:48:00 -0400 Message-Id: <20230704134800.204542-1-hugo@hugovil.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 184.161.19.61 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Subject: [PATCH] arm64: dts: imx8mn-var-som: add missing pull-up for onboard PHY reset pinmux X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770498500225198949?= X-GMAIL-MSGID: =?utf-8?q?1770498500225198949?= From: Hugo Villeneuve For SOMs with an onboard PHY, the RESET_N pull-up resistor is currently deactivated in the pinmux configuration. When the pinmux code selects the GPIO function for this pin, with a default direction of input, this prevents the RESET_N pin from being taken to the proper 3.3V level (deasserted), and this results in the PHY being not detected since it is held in reset. Taken from RESET_N pin description in ADIN13000 datasheet: This pin requires a 1K pull-up resistor to AVDD_3P3. Activate the pull-up resistor to fix the issue. Fixes: ade0176dd8a0 ("arm64: dts: imx8mn-var-som: Add Variscite VAR-SOM-MX8MN System on Module") Signed-off-by: Hugo Villeneuve Reviewed-by: Fabio Estevam --- arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi index d3a67109d55b..b8946edf317b 100644 --- a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi @@ -358,7 +358,7 @@ MX8MN_IOMUXC_ENET_TXC_ENET1_RGMII_TXC 0x1f MX8MN_IOMUXC_ENET_RXC_ENET1_RGMII_RXC 0x91 MX8MN_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL 0x91 MX8MN_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL 0x1f - MX8MN_IOMUXC_GPIO1_IO09_GPIO1_IO9 0x19 + MX8MN_IOMUXC_GPIO1_IO09_GPIO1_IO9 0x159 >; };