From patchwork Mon Jul 3 14:58:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 115417 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp602790vqx; Mon, 3 Jul 2023 08:26:22 -0700 (PDT) X-Google-Smtp-Source: APBJJlF3ijlEu/wljLS6nNq1aoI+JDUzvA09f3Yz7zCp/nlkqMhFRmY/i+nKv6IUfchZmuEQ3lqz X-Received: by 2002:a05:6870:d61e:b0:192:6fce:d3be with SMTP id a30-20020a056870d61e00b001926fced3bemr8968838oaq.1.1688397981889; Mon, 03 Jul 2023 08:26:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688397981; cv=none; d=google.com; s=arc-20160816; b=MGHaYCICL0G0PIjkzdddseAO2ln0Q0QLWkCnzDExnmy7fseqXPDseWK47s4UN4m0V+ jD8X8f7Efdn++Vi0qnJEBh062PcMh8n1GjXguwjNloxLz6eZxNwY8vlB2AwYSbDmvQ/Q fHxphAPWIdR8TH9ROgS0J57NWGMp8omTunASdSYGqm6LNovSbuBjeciAxm+hqiIkl3j+ JzrG3hMGIs2Z02VjRpCl3uDcfq8mKMcHtY4eO5LLTORlaKx25c39/gQeqIkoOmhgZrM9 iwO91NfXJwgL9RmZmGiH2z395h9JGdvE1sx/9xnSDk7wI6LcytuElM6EYeO6DIIxa5Ak liLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=7+UMKUN2pHfdmq0rlcSgmmkmE6W+UmI1NLNs5wfiGtM=; fh=vM053QlYUPlFOVrt4qdlsrJI1gz/fRqqYkwqwGDcHAU=; b=zgxE4usNHcyfZLuTUQDSw3fPJCF5n9pKcnyOX2LXefJ6Syw3mZxsfZKxcvjNWiksxd HJRRtsYZcDm14+Ghx/SoaVfET5/ATGJwnMJdL/+CVpgZvN4PccbbFrLGGOZf8dkXdoPT 3stzVkby40HH6DXGwsBN+z3lhsb2+AkxD/Ihf5YYbKxv436S4EPbeXIGxMmw9CsroAd3 GuO7Tj1SdbIsv1u87q0Q453mkCrdWhMdELAgU/DmQqDr6Th5sur0BmfSAFL3rA/A7/0a mSwpo4F1hqsjyyA/S93Zg6GCdxMpLAS5KqYznsao+qsUS3C9UBTnc0aNmNRaW++KS+hb Yq9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Y7nE4vB8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s18-20020a635252000000b0055b6a717367si7121016pgl.45.2023.07.03.08.26.08; Mon, 03 Jul 2023 08:26:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Y7nE4vB8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231222AbjGCO6s (ORCPT + 99 others); Mon, 3 Jul 2023 10:58:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbjGCO6r (ORCPT ); Mon, 3 Jul 2023 10:58:47 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E5EFE41; Mon, 3 Jul 2023 07:58:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688396326; x=1719932326; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Eaq+kIyDnmuZd4kwGRL+DNWZzWxEKTUANC5sgsGgATs=; b=Y7nE4vB8LktoOe3uWBXND/pwPXWF2W/MszkQCnSCYXSVfERtOiDPEtQ2 7T447UcwWfrRpTdygWj23H2Xss4UBXLI/pyPoIXb4KeNCEjDy5Cr4gTST a5sTDIPcu+ByENMyN/bKrUZh6A9zxo8SmdGpOr4eeIfOF9asYm7yVk6l/ 3sd+8BzkIuhoWRg6gUvR/1Kf0DdAxjLJCDyCxhqcV/j1LEEJ0rdC3++j1 lKI873Iib/XhA1HP419NRNQuWFFqysixchUnXwA2YR1ackHwqjuVR2ufa ec+Qt0/a6O1t7AnXAfiLt132QnmqAbgd8LNB/4wzc8O9i+n8WVyngiVf5 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10760"; a="361761404" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="361761404" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2023 07:58:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10760"; a="695838542" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="695838542" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga006.jf.intel.com with ESMTP; 03 Jul 2023 07:58:43 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 53BB3170; Mon, 3 Jul 2023 17:58:46 +0300 (EEST) From: Andy Shevchenko To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Jonathan Corbet Subject: [PATCH v1 1/2] docs: printk-formats: Fix hex printing of signed values Date: Mon, 3 Jul 2023 17:58:38 +0300 Message-Id: <20230703145839.14248-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770413602177968111?= X-GMAIL-MSGID: =?utf-8?q?1770413602177968111?= The commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") obviously missed the point of sign promotion for the signed values lesser than int. In such case %x prints not the same as %h[h]x. Restore back those specifiers for the signed hex cases. Fixes: cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Signed-off-by: Andy Shevchenko Reviewed-by: Petr Mladek --- Documentation/core-api/printk-formats.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst index dfe7e75a71de..2f3a6e0b3fc4 100644 --- a/Documentation/core-api/printk-formats.rst +++ b/Documentation/core-api/printk-formats.rst @@ -15,9 +15,9 @@ Integer types If variable is of Type, use printk format specifier: ------------------------------------------------------------ - char %d or %x + char %d or %hhx unsigned char %u or %x - short int %d or %x + short int %d or %hx unsigned short int %u or %x int %d or %x unsigned int %u or %x @@ -27,9 +27,9 @@ Integer types unsigned long long %llu or %llx size_t %zu or %zx ssize_t %zd or %zx - s8 %d or %x + s8 %d or %hhx u8 %u or %x - s16 %d or %x + s16 %d or %hx u16 %u or %x s32 %d or %x u32 %u or %x From patchwork Mon Jul 3 14:58:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 115414 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp586095vqx; Mon, 3 Jul 2023 08:03:11 -0700 (PDT) X-Google-Smtp-Source: APBJJlEp7CbkIGsrrjS9xXOp2QLMPHVqWur85NsrY4oglaNrBSyd8RSiazOk1iQegWu8JUuExHpb X-Received: by 2002:a17:902:c246:b0:1b8:5827:8763 with SMTP id 6-20020a170902c24600b001b858278763mr10880794plg.4.1688396591343; Mon, 03 Jul 2023 08:03:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688396591; cv=none; d=google.com; s=arc-20160816; b=zIu/cmyHYFP+rZRaRIgM7iOKSdL0EIQM/DYjLeTx2sfC9sbMFLsShP9YG63rXuiKNj AEyuWwZBfbl2YA4hjZzJARm2Dw7R0FYAKIr1G4zYHoKlLbrXE2pK6faNsTs+B5bKLeJt FlVjXr12CHfobqV0XgOq0DvbJCNifmtQeq+UbI/L/TPRmm9wFeLWcgsWd5etrpW/nvfl 4moIfKvt4XCyB4uoRGVGfpfZP1f5RXOBoY/7iwRtLWmup75guyHi77BRUxhJmvG2Dttp N5YPsMGdJ64RFls1GP1Gnp+KXr6QQNl93WlcnNg4q5u/TgHpZixM4tcTT+uIEN9y6/db pbkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3XNa1uDg1+lmXfuTzTV+soDajTo8q/vtAJXk8QjvdAk=; fh=vM053QlYUPlFOVrt4qdlsrJI1gz/fRqqYkwqwGDcHAU=; b=kwmdN5Smjg0mOtMMZdGtHBstkt+2KY/XhIqgg3rauH6+lncZvXFPqoFdlHzmZPHIfA 3RQS+dFEepw4K5V87JO0Mh9SZqGiq6zOhjkH454X72DZKaMXU2c4td/0CdT5Fl8DBcxu LaXGrwFjP17LmqfXBfM+odDfUqLaCW5xdMgSqrI5oO1383D2q8mPlTDAfmP5CfrJ7W8e yqsOtmlisis/T9kOXDsYaUAsah/XjXh1TRn5+P1x2DdSgtL3Iic2sMCDYLk5w18/hn+M A8AMMBBvhEa6Od3GdlkycaRQTGHbKXieyYDuKo7waTyNNHwNSxmPq31/nRW4sBBexQOp v0OA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bPOzGRbY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u14-20020a170902e80e00b001aadba392c1si19469298plg.464.2023.07.03.08.02.56; Mon, 03 Jul 2023 08:03:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bPOzGRbY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231289AbjGCO6t (ORCPT + 99 others); Mon, 3 Jul 2023 10:58:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229656AbjGCO6r (ORCPT ); Mon, 3 Jul 2023 10:58:47 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98940E43; Mon, 3 Jul 2023 07:58:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688396326; x=1719932326; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FHly7jrfHT4AJToL1z+8Wr8S5HSfEj4odBZvKbf6Fns=; b=bPOzGRbYiVt3cFLrD43eMfIv0pft+1QeLtw2++9uNdd2xm/QgU5W+iRK JHIG1QkRg7sZtDljdZO7Zx+PcWUMVgq6AWAfTw+rsQzZSMBEexokmeIsx QVw57syQWub9+D7/2Afvs1w7E6qJY+EPV4qFrHtKgwEMiaIBvjXuTgL6x UoJTAfmB0JtBQQdTQmJPkIRGaIS/fPCkAxUSFUGBshLO9GbOpJ6GP8IX3 3DF+pjjahUrsIA12b4moZONZCE5hMEum77M/Ik1K106wXheoTtXEIGVL3 nqw8Hi3FJHH3J4KFNXI5zYkmJGc9s2gSdVSSKLmSohVDdvFJlIYKwO/53 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10760"; a="426587582" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="426587582" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2023 07:58:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10760"; a="718625424" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="718625424" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 03 Jul 2023 07:58:43 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 6170B13C; Mon, 3 Jul 2023 17:58:46 +0300 (EEST) From: Andy Shevchenko To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Jonathan Corbet Subject: [PATCH v1 2/2] docs: printk-formats: Treat char as always unsigned Date: Mon, 3 Jul 2023 17:58:39 +0300 Message-Id: <20230703145839.14248-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230703145839.14248-1-andriy.shevchenko@linux.intel.com> References: <20230703145839.14248-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770412144342739861?= X-GMAIL-MSGID: =?utf-8?q?1770412144342739861?= The Linux kernel switched to have char be equivalent to usigned char. Reflect this in the printk specifiers. Fixes: 3bc753c06dd0 ("kbuild: treat char as always unsigned") Signed-off-by: Andy Shevchenko Reviewed-by: Petr Mladek --- Documentation/core-api/printk-formats.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst index 2f3a6e0b3fc4..4451ef501936 100644 --- a/Documentation/core-api/printk-formats.rst +++ b/Documentation/core-api/printk-formats.rst @@ -15,8 +15,9 @@ Integer types If variable is of Type, use printk format specifier: ------------------------------------------------------------ - char %d or %hhx + signed char %d or %hhx unsigned char %u or %x + char %u or %x short int %d or %hx unsigned short int %u or %x int %d or %x