From patchwork Fri Oct 28 22:48:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 12581 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1080588wru; Fri, 28 Oct 2022 15:50:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5DBxtXGXArFbDQHTAq82W1sHY6Kqx2wYXKJwTBoSI82jgjGzGkZjOPAqiDP4u4jBiO6U7i X-Received: by 2002:a17:907:2719:b0:782:b261:e9eb with SMTP id w25-20020a170907271900b00782b261e9ebmr1542195ejk.104.1666997430398; Fri, 28 Oct 2022 15:50:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666997430; cv=none; d=google.com; s=arc-20160816; b=B+YD4Bba4INLcrxph31kWyw+6lb/ncKyqt8CuS46o/fVtaVg23fLHUzw0fngZYo/4P 5sPQIailrg80RAHtAjL2ZTAX1bnjjNcdeYyUlC39SVze8u1aeB0hde2JINmGjKAqqibn mZBxCKoe0QRVagabxgsOhfMp2kxMo6H0b6RFtO5Sn/lT/io7mKHmOKFfoKz14BvL16YF ixzkZ0LrH69eygZ4DjmN+m0c9wQawTNfPbSRaQYDeZD2SZapkgI1RJ8q8iPr03J03kAL c+0VUXhtRYN6RrpcNWBOeTIzcoaWanD8T0PwakF79EKVyseLlltCraLkS1dEPAC3V8e9 eATg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=8LWoRkfSMU+CJ60Tm7wanIclajGSfZYvjPsATtyTB9c=; b=t4NzXuHGpn76+NLQh9XlOCRgsrpYCh4Ta3w8msI2di1G6rnAnyG923BeX4ZVY8ayZ4 EmAEtP5MLbTKmONgbAvwLlzohFfGJb0fuiy1DOpPtzxo68SAys2F73Nt0f7BEZs08QLv F3hbfGY2msrAn5xIB22YAzboWu7ks3eh9gnbukJVB2jn7FDvDKefAJFGmheQ6mUEZL4H b8c+yyplBu4MOGM2AzDdxjIBeFZ6Gppkms3z/sXu3jcKneXZkNtJle8o9GRevrZJGfBA mNKsqKq3HPlsIvyaKNy89rm2eCfv1/eLICoFCxLca287w0cxeXFhZ3M3WozwM0LwAZFI N3kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kEf8pkaq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q31-20020a056402249f00b0044f2fb68fe6si2169739eda.495.2022.10.28.15.50.07; Fri, 28 Oct 2022 15:50:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kEf8pkaq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230266AbiJ1WtI (ORCPT + 99 others); Fri, 28 Oct 2022 18:49:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230218AbiJ1WtC (ORCPT ); Fri, 28 Oct 2022 18:49:02 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2432A1EA55A for ; Fri, 28 Oct 2022 15:48:21 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id g24so6050763plq.3 for ; Fri, 28 Oct 2022 15:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8LWoRkfSMU+CJ60Tm7wanIclajGSfZYvjPsATtyTB9c=; b=kEf8pkaqDLyKKPRro1RzlspOqf9bDj9K9tXuJIfimPasVBVuSbh3nXFfHuKj3Ygv/e Cb2woLyV/0T4hlBWtL+deoHGD9VfD6aKyLYcAQxvNFDXlnQhUFE87y+LQpwOsBtmz5z0 nYqVpW7KVwrtYp/ANLZ6FHgmzrBkDHxNW5lig= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8LWoRkfSMU+CJ60Tm7wanIclajGSfZYvjPsATtyTB9c=; b=dO1RqJX+lDwxwzt16vp+9PAhYna04k4cZXH5Gej9QZ67oRwCw/D1YfqX1UFxqT1cdq mX6noxIrsvXk/zHyound2sqBaHFHG9zWHmx6Vcbh/l+bkqC5kB1jZ0o729oVsq9HdSPW tOn7NE6BKQCUCdQZsB6+YgGGD/a8zDn7qSKAc0Z+0gwO8asAzewpeOe+l7QySdYlx/8B 5X5F7DfTWZVBqVeBYgf6WH13VMbIiannpmD4K+0jfBlacgNEzt0W3Rl7RQ4uGMy+Biyk ltvbk+vQI+79vQHD55JEMtDcTEZdLyHgFZ6qzhBLAtWkaSd00sremUVSOOqqD3WowHzg ATNg== X-Gm-Message-State: ACrzQf2ejmE7J9bqrum6DV8ntJaPgQo//EP7pfumoPxSpq7aotcRbgDy 0+efIZN7CYI9bPl6sOTtZ7djREmG6Z2gYg== X-Received: by 2002:a17:90a:c78a:b0:212:e56b:2b17 with SMTP id gn10-20020a17090ac78a00b00212e56b2b17mr1623176pjb.51.1666997300703; Fri, 28 Oct 2022 15:48:20 -0700 (PDT) Received: from localhost ([2620:15c:9d:2:65f9:c180:249c:190f]) by smtp.gmail.com with UTF8SMTPSA id 1-20020a17090a0e8100b002009db534d1sm3010415pjx.24.2022.10.28.15.48.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Oct 2022 15:48:20 -0700 (PDT) From: Brian Norris To: Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Xinhui Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Brian Norris Subject: [PATCH 1/2] drm/amdgpu: Move racy global PMU list into device Date: Fri, 28 Oct 2022 15:48:12 -0700 Message-Id: <20221028224813.1466450-1-briannorris@chromium.org> X-Mailer: git-send-email 2.38.1.273.g43a17bfeac-goog MIME-Version: 1.0 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747973497612024629?= X-GMAIL-MSGID: =?utf-8?q?1747973497612024629?= If there are multiple amdgpu devices, this list processing can be racy. We're really treating this like a per-device list, so make that explicit and remove the global list. Signed-off-by: Brian Norris --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 ++++ drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c | 12 +++++------- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index 0e6ddf05c23c..e968b7f2417c 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h @@ -1063,6 +1063,10 @@ struct amdgpu_device { struct work_struct reset_work; bool job_hang; + +#if IS_ENABLED(CONFIG_PERF_EVENTS) + struct list_head pmu_list; +#endif }; static inline struct amdgpu_device *drm_to_adev(struct drm_device *ddev) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c index 71ee361d0972..24f2055a2f23 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c @@ -23,6 +23,7 @@ #include #include +#include #include "amdgpu.h" #include "amdgpu_pmu.h" @@ -72,9 +73,6 @@ static ssize_t amdgpu_pmu_event_show(struct device *dev, amdgpu_pmu_attr->event_str, amdgpu_pmu_attr->type); } -static LIST_HEAD(amdgpu_pmu_list); - - struct amdgpu_pmu_attr { const char *name; const char *config; @@ -558,7 +556,7 @@ static int init_pmu_entry_by_type_and_add(struct amdgpu_pmu_entry *pmu_entry, pr_info("Detected AMDGPU %d Perf Events.\n", total_num_events); - list_add_tail(&pmu_entry->entry, &amdgpu_pmu_list); + list_add_tail(&pmu_entry->entry, &pmu_entry->adev->pmu_list); return 0; err_register: @@ -579,9 +577,7 @@ void amdgpu_pmu_fini(struct amdgpu_device *adev) { struct amdgpu_pmu_entry *pe, *temp; - list_for_each_entry_safe(pe, temp, &amdgpu_pmu_list, entry) { - if (pe->adev != adev) - continue; + list_for_each_entry_safe(pe, temp, &adev->pmu_list, entry) { list_del(&pe->entry); perf_pmu_unregister(&pe->pmu); kfree(pe->pmu.attr_groups); @@ -623,6 +619,8 @@ int amdgpu_pmu_init(struct amdgpu_device *adev) int ret = 0; struct amdgpu_pmu_entry *pmu_entry, *pmu_entry_df; + INIT_LIST_HEAD(&adev->pmu_list); + switch (adev->asic_type) { case CHIP_VEGA20: pmu_entry_df = create_pmu_entry(adev, AMDGPU_PMU_PERF_TYPE_DF, From patchwork Fri Oct 28 22:48:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 12582 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1081065wru; Fri, 28 Oct 2022 15:52:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4tPbeX6rl1j5FchA/psq07vcJhMoVr2HPsFhP79ETxoXBttjw84fD0SNDv3Yvf3nat38uF X-Received: by 2002:a17:906:6a18:b0:78d:7228:7a52 with SMTP id qw24-20020a1709066a1800b0078d72287a52mr1452687ejc.363.1666997526013; Fri, 28 Oct 2022 15:52:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666997526; cv=none; d=google.com; s=arc-20160816; b=Djy0skkaProob/yDfTbezGRjqn/do1ImJ70m3tNcIaPbN2hMsD6A2tw6QrNWecOzwC Upe6YkoK8j3nFGODDRU4XK+cMjHSLBnX4yngAUnyGxMUMtacoE1TEmLlXDQHZI2HK8zn 5ISM3evYEQ0Ye5v7gOqgAJ/YNDLb7aeRm1+rhuU0nnPOVuKSn2OgXqXQcTc1Bk+vDwVA gF7ERFxLlypjLYFF8ISIhlzgWuDsUNv4/ehJBlgkuUlyfzk4YMTOVPw7cY3+YZEghuUO 6VyYy5xB/GvCV+rhA86RfPrVqLI8lIT+npCWSXcsguVXRnEP9PvTsNImLXYcqS27hq+h WqNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=r0xiJp4XHOD7FpE79mlTo4FZ8hKLVDdbQ6PJGlmtm0c=; b=m/IfCGSMXUEN+5EV9HVuzbs4NY81CEMbIOxIKULzmXwKi+iAvV5r0RCdlH8ZnkPWho MQca5hbu9zapos08m3WOwFvHv20aa2fut+SdrAtn0hpqsY22wyjnffkAqMkR0s/6XZVA B01AqqAL9gDgBaMUIgvxk2LpEchSBIY1ng9YUD0l2umCa8bp9VdwfHEM2ZNpJ9gjpYYD xhPDM2W4tbwak05L9Y31bJn6S2ynZinzwZvKsPyt6duHFfazPYsHE4WNTilgsBMYMIPX AHZXo6rpve9Uvk9JUxoYJRBJw+uADf7BTJgn7K95tgRUHLcrWHx14Pd8xynawo14mNN1 Gi4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=mzDl6TMy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cr18-20020a170906d55200b0078e0324ee54si259165ejc.490.2022.10.28.15.51.42; Fri, 28 Oct 2022 15:52:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=mzDl6TMy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230121AbiJ1WtM (ORCPT + 99 others); Fri, 28 Oct 2022 18:49:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230224AbiJ1WtD (ORCPT ); Fri, 28 Oct 2022 18:49:03 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F2E61EA561 for ; Fri, 28 Oct 2022 15:48:23 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id r61-20020a17090a43c300b00212f4e9cccdso11115395pjg.5 for ; Fri, 28 Oct 2022 15:48:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r0xiJp4XHOD7FpE79mlTo4FZ8hKLVDdbQ6PJGlmtm0c=; b=mzDl6TMyHJf63jH7iKtcAAGM8XDN0rgDSAUs7hfgOey2i6dDPc9aOOCZYNZNETkm2j yVEIR85X+aSQjrVbZpYjQoDLmGgkswWXkfsecH1i+hYCnMCRGj96w+Nxrz2B/QCGVpZQ gtgV0voDj/MPBaheBlaJn/W0fjq4tkMXfBnrw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r0xiJp4XHOD7FpE79mlTo4FZ8hKLVDdbQ6PJGlmtm0c=; b=us+P5QHKaw9R6Pg+6ouWNJtttfJ4G7k5JOtQAJFKwKumYf47F+r2cC9fgErj7eHHSp pGey63k2+HajugNTcdXAfJ1Fiv1FejiRvrsd0/YL2KfcID8bKbdByAGBf2XEtA7/L7qp hVn+rf+MAbp9EhxyPwobjyrJlnwP5gqlToo9wwl9rxaacHN9CwbNwCFOjq60MKiMEAGb VLzPzJy80aSC9QXiyIUy/vG/K0lBBz3Fv10RIPboBzyFK8VHxRwAr+H1H0PYVL0he45r s81TsuJ+Tj8eATajKHfEETKeofa0ltMmWz2iAipWcNtRm6TOTe9+51TA9HqzOxq0plV9 oT0w== X-Gm-Message-State: ACrzQf2O/MnJOLSJEIXCdzWfxDrPtexB1ytWWbjPrw0N/eEY/eAvEhkY DOmqezFuWGPSmhi+MaZQWDrYnQ== X-Received: by 2002:a17:902:848c:b0:17a:b4c0:a02b with SMTP id c12-20020a170902848c00b0017ab4c0a02bmr1355571plo.122.1666997302622; Fri, 28 Oct 2022 15:48:22 -0700 (PDT) Received: from localhost ([2620:15c:9d:2:65f9:c180:249c:190f]) by smtp.gmail.com with UTF8SMTPSA id bd13-20020a656e0d000000b0043c9da02729sm3161736pgb.6.2022.10.28.15.48.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Oct 2022 15:48:22 -0700 (PDT) From: Brian Norris To: Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Xinhui Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Brian Norris Subject: [PATCH 2/2] drm/amdgpu: Set PROBE_PREFER_ASYNCHRONOUS Date: Fri, 28 Oct 2022 15:48:13 -0700 Message-Id: <20221028154718.2.I30f27b240e63cc269076556407e6eddcf5177b5e@changeid> X-Mailer: git-send-email 2.38.1.273.g43a17bfeac-goog In-Reply-To: <20221028224813.1466450-1-briannorris@chromium.org> References: <20221028224813.1466450-1-briannorris@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747973597598656146?= X-GMAIL-MSGID: =?utf-8?q?1747973597598656146?= This driver often takes over 200ms to start, so it can improve boot speed to probe it asynchronously. I did a short review of the driver, and apart from an issue fixed in the parent patch ("drm/amdgpu: Move racy global PMU list into device"), there don't appear to be many cross-device dependencies or racy accesses to global state, so this should be safe. This driver was pinpointed as part of a survey of top slowest initcalls (i.e., are built in, and probing synchronously) on a lab of ChromeOS systems. Signed-off-by: Brian Norris --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 3c9fecdd6b2f..2d180e48df1b 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c @@ -2793,7 +2793,10 @@ static struct pci_driver amdgpu_kms_pci_driver = { .probe = amdgpu_pci_probe, .remove = amdgpu_pci_remove, .shutdown = amdgpu_pci_shutdown, - .driver.pm = &amdgpu_pm_ops, + .driver = { + .pm = &amdgpu_pm_ops, + .probe_type = PROBE_PREFER_ASYNCHRONOUS, + }, .err_handler = &amdgpu_pci_err_handler, .dev_groups = amdgpu_sysfs_groups, };