From patchwork Mon Jul 3 14:09:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 115390 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp564326vqx; Mon, 3 Jul 2023 07:27:43 -0700 (PDT) X-Google-Smtp-Source: APBJJlFQNV1nwpgfLARgp5ktMP1UR9HmU7n9/TikAjmYcxORUxvULMG7W66FVZMUD/d9aN5Y6PPF X-Received: by 2002:a17:902:ec88:b0:1a6:6bdb:b548 with SMTP id x8-20020a170902ec8800b001a66bdbb548mr10410285plg.1.1688394463475; Mon, 03 Jul 2023 07:27:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688394463; cv=none; d=google.com; s=arc-20160816; b=vgQ+jFvLVRDZHB0oNv0FrRlwmUuEinYSqREyyA/+6AkbRFryQrghoiYi8C5ye8hl3A vtjAQLBV5REA/tULm1I+q/2EzHoMvsUH9fO67oodL2CD0wAgDLeaHdEVEsgrvgxxUTO5 STU9XS4E8/kS7COSO7OXZNEs+k35/IuAYjfgCGlMMUJeTfUdKOb2Bu/XwgH+OTq7R2gm okIGXxvyYKU98kIQqW3tMMv2VhjHK4DI+cBz6bxbQxLOv+GMx79EgZldDitNI1U92mUC /ZSZAC7ukbw2hK3ka2zPlD3r+D9KZf7T5Ev3UvOfvm1xp86gNCGUa9bmXkhH48HqZQLn XX5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=dLl4/iIYFE99g+UI4J5yq7Sy2WMDWQl7ZmG/2UCTmTQ=; fh=RXyKyeyQzAcusT2OQA6dG83yFiRRvmf5xAXRiao8ycY=; b=mCsaRtTwYekejPDXvUJfk23hdzHaHvKGcXEHz8Ofr6kW6kavnHcuL4Y2w2FdMpyIyA esFxcDoujWeIhxvLDnteZ0LeUssI7eT/H7RSd89gFPQSzsA5hwnuI++FLwfSvtYH+7cZ 4aqAEZ3OTkJwcrDZFdDgUm+toTbwWyvMvz4gLJL1mCihVa1Tk/F06WDOV3twZxCSqcLu 6CKisdNe3xxz9eOdiTAmpSwJ1GkG3UF7yRzDhy3omguqM56x+ZzNuf8vF+r6BwvJsqjG 5uwjWIiNbuelCByefj3s1xV5yVvWQhVDCOQ5qF30LBY3GlCT1CT0GbKgfw3RiDiHTrQv Of7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fSYHgugs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n10-20020a170902e54a00b001b8946f3f53si2849361plf.645.2023.07.03.07.27.28; Mon, 03 Jul 2023 07:27:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fSYHgugs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230120AbjGCOKF (ORCPT + 99 others); Mon, 3 Jul 2023 10:10:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230359AbjGCOKD (ORCPT ); Mon, 3 Jul 2023 10:10:03 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FDF9106 for ; Mon, 3 Jul 2023 07:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688393389; x=1719929389; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=YOrJBVE9SyEgwY+WN9IMaBLHIF3QU0EF4DUsRLc6TyA=; b=fSYHgugssxD7NNYlOmSprYF1J4yt3MZuNyjEaFR2jCXOvzQsmMmml51q 0EkxYio74QqDb30ibOgIhMO/zGIZbC5zWzH+bBJ/bpVacS/haqgxCF5qC b13hA5o576+Av0aBO6t3V7ZJH2OtRuev+RQzp1yeyUPzAHCW2HD5fjX/D s5cK2Dq67M6usyL845zdolfCrNyQH6nwp9V7wsiMCzo7Yi3nNrEtE5gCF ZA/0pUKv9W9IY3l6Dwh+vVnz+Zk0bt/N4IbdmXmjUHnZVQDmABdlhIYjx kGa4s6/sYdh1jCqV5lcJXRmUQgGFdyjWfqAv8XWufGTMlEIG2GmSd19+U w==; X-IronPort-AV: E=McAfee;i="6600,9927,10760"; a="366375376" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="366375376" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2023 07:09:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10760"; a="695822929" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="695822929" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga006.jf.intel.com with ESMTP; 03 Jul 2023 07:09:21 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id B2C49170; Mon, 3 Jul 2023 17:09:24 +0300 (EEST) From: Andy Shevchenko To: linux-kernel@vger.kernel.org Cc: Lee Jones , Andy Shevchenko Subject: [PATCH v2 1/2] mfd: ipaq-micro: Use %*ph for printing hexdump of a small buffer Date: Mon, 3 Jul 2023 17:09:22 +0300 Message-Id: <20230703140923.2840-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770409912848392248?= X-GMAIL-MSGID: =?utf-8?q?1770409912848392248?= The kernel already has a helper to print a hexdump of a small buffer via pointer extension. Use that instead of open coded variant. In long term it helps to kill pr_cont() or at least narrow down its use. Signed-off-by: Andy Shevchenko --- v2: split another change to a separate patch (Lee) drivers/mfd/ipaq-micro.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c index 6d3968458e81..cddfd2e808f2 100644 --- a/drivers/mfd/ipaq-micro.c +++ b/drivers/mfd/ipaq-micro.c @@ -131,10 +131,7 @@ static void micro_rx_msg(struct ipaq_micro *micro, u8 id, int len, u8 *data) break; default: dev_err(micro->dev, - "unknown msg %d [%d] ", id, len); - for (i = 0; i < len; ++i) - pr_cont("0x%02x ", data[i]); - pr_cont("\n"); + "unknown msg %d [%d] %*ph\n", id, len, len, data); } spin_unlock(µ->lock); } From patchwork Mon Jul 3 14:09:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 115396 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp574166vqx; Mon, 3 Jul 2023 07:43:28 -0700 (PDT) X-Google-Smtp-Source: APBJJlEnKVLfAufXLgL7ouiQGz89Tmi2V5s6cVN8s8qhj8xIsBfgm/sBydyfsH4rgD8mAu2lthWm X-Received: by 2002:a17:902:e485:b0:1b8:2a4d:3e91 with SMTP id i5-20020a170902e48500b001b82a4d3e91mr10456797ple.6.1688395408603; Mon, 03 Jul 2023 07:43:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688395408; cv=none; d=google.com; s=arc-20160816; b=lrImioVW4u1tyJD4HEUVtMkGdjJ5FqRB1hMaHRaDoPI2Ud52ZC3oCDBhJgb3M5WY7f vVXhuI/GsdOxUANkyHanmDlviJGiODxHH2tVGNX5tVBoyYejrN3pjDv68Ficz7fLb71V OzPyiz5f1YBk/9nHAxJVJhTDfFMZmgO/tWUwwlGssDv8b65vM//B46AosZA9Raid8KRv 5PK3z66rcWiugaPYbIU/U9ikBsh17eojynGqM+sj7ExwtUlZJNlw75rL8CEwOy8D1wQv Ibs2t8xRdofUI95yMgWbc2MtpsZvwP9Ultpli/jeJcm4R1/fTBebGb9zzgkuWNTVS25i +p3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/xDUI5Q906ciUbfcDiykpf9BVkc6g7s8NDLUda0HoY8=; fh=RXyKyeyQzAcusT2OQA6dG83yFiRRvmf5xAXRiao8ycY=; b=SwLZWRlS7VfRnsvANLIRDAu5GrozrdQ+JJnvubeGZyMJrzTcWHaawOrSKVLdff7y5N RngHInIcFS4WF+RZWo1qGybmxfOsY9+hfZYWWNsJbmyj2vV5ZEEiQTU4FgQyixuC4rff bJP42SrrKGVNMbf+ftcEadqyO+K2/Jvy18eVtss70QskjKYG/NxXKsyhX4E8Cgd78ggV mUN5fzALj9G6hQgKObdbPF/ZIa9wfy718Szwg7GDsEGToBXlhL+foaER4Ka576gxk6xa cJ7LmBd54tgRZOf5z4mVU4VFhMv5/tk8CCDrexLzsvEiYfa+mKp8HRnqb8G8II5pZFcr PLhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=E5QstPWr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e19-20020a170902f1d300b001b86492d71bsi7604130plc.562.2023.07.03.07.43.12; Mon, 03 Jul 2023 07:43:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=E5QstPWr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229930AbjGCOKZ (ORCPT + 99 others); Mon, 3 Jul 2023 10:10:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231140AbjGCOKG (ORCPT ); Mon, 3 Jul 2023 10:10:06 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9971C10C6 for ; Mon, 3 Jul 2023 07:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688393390; x=1719929390; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pkVtFXlRR5kYwBtMS5BvxTwSslZj/ncacXtF+PbTuz0=; b=E5QstPWrPosXM80XRoSpT+3ebkXnXOD1iWLzAVfyohX//iifKt8/TjgW rCGDP1r88SxBRB0ZIN7HOFlUS1iUdlPgdfEo/6eiZ/PQrmZxi4MfFsT9X 5Jg0ZymGDp0B940S8UqG2OyWQtd8RO7ZwnBRunkEfwcvZYx4jnbCQQYrW qe9zstKA5F7giM/Pqh5J7VVWYGlF8GSY+gywU6M3P80qCiaPC+z4hnixH V5SCmXVoGtPz5vSjjiTvHrI4qzSk74Zeow0ASmc8x8L2UGTriAadpIGYH FFI67VOjKr50ojhhg0ZM8pCev/ETt3+Axwzf36jDO5vaV5aG+h15zzsqA Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10760"; a="347678393" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="347678393" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2023 07:09:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10760"; a="863097210" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="863097210" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 03 Jul 2023 07:09:21 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id C388013C; Mon, 3 Jul 2023 17:09:24 +0300 (EEST) From: Andy Shevchenko To: linux-kernel@vger.kernel.org Cc: Lee Jones , Andy Shevchenko Subject: [PATCH v2 2/2] mfd: ipaq-micro: Add missing break for the default case Date: Mon, 3 Jul 2023 17:09:23 +0300 Message-Id: <20230703140923.2840-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230703140923.2840-1-andriy.shevchenko@linux.intel.com> References: <20230703140923.2840-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770410904059045345?= X-GMAIL-MSGID: =?utf-8?q?1770410904059045345?= Even default case should have a break statement to make code robust against changes (e.g., adding a case after the default one). Add missing break for the default case. --- v2: new patch drivers/mfd/ipaq-micro.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c index cddfd2e808f2..57fb7874fc91 100644 --- a/drivers/mfd/ipaq-micro.c +++ b/drivers/mfd/ipaq-micro.c @@ -132,6 +132,7 @@ static void micro_rx_msg(struct ipaq_micro *micro, u8 id, int len, u8 *data) default: dev_err(micro->dev, "unknown msg %d [%d] %*ph\n", id, len, len, data); + break; } spin_unlock(µ->lock); }