From patchwork Mon Jul 3 13:00:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Gross X-Patchwork-Id: 115356 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp522780vqx; Mon, 3 Jul 2023 06:26:45 -0700 (PDT) X-Google-Smtp-Source: APBJJlHqV1eY4eoGNWXT95nTvVMjkobXecsT9QBd/r75sU1UBk0AAs/3V9WjCK/zxEGKfPfSnn+R X-Received: by 2002:a05:6a20:549e:b0:12e:2fdb:7865 with SMTP id i30-20020a056a20549e00b0012e2fdb7865mr7978498pzk.0.1688390804817; Mon, 03 Jul 2023 06:26:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688390804; cv=none; d=google.com; s=arc-20160816; b=Qkc5lnqSTVS3qwKW0CXp9xPOcRFJi1/ayhqbXhw/qO6uSgfktbrHuZQ5Zs3GDxFoEA m1DiM9QYKv+AmvM+93HqimvPWbP+93pkJzRBWvf+dQIwJKUKPIDvwtMUKl5FM7rHDwWR Tn+OFEahLfXJFsNk3pyJcxkcBbS3RHAnuM5PChbx2oF0LCat3TNZBZFZJZir0RrTxkds H9ZI1R34UAn52JrEHoCnBgTXJ7dmUZwcblDc1+G8UFrVKbMkDcSwBnLJJLO22qhf8ktX vPrauLo2c8DejppY5QJ0GKqWeCftjIwSzqfGigViEM5aNtpVs7XFN9+bcK2Jka7B5KL/ ddog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=g/qfo8Cb33qUzg9p/sYx93BIkx/lh9MH46SOSdnmyf8=; fh=xP7rPEwwmYjRFdY4LvohNByAc3I2TDa74iPJEEVDE0E=; b=JtyypgTkEBWNh/VOg5KLfNVCpT2hN9JOvMSs4Pkvwg+aswZvQCiuF15XdZcx7nDxLh h+nBEtfpUIKD78HoS+w5Ym+Aq34FfnpX13HRWkss/BoaX8iEVj9kCyAiAVSYKZ6TjoqK 5ydR5/S88l6LkmrTPZvzd8ECPsOnkyJyE9OzPFnEP9GaMeZNlvhywDVjV0+aqkLI694G A+lIUQ48lBcciXoCe55a01evnSiDKvOhH0UfJjixWouka7o2IwUdE6iWtXcsVtT3MSB0 ghdAd/SPa7zTk3M2fU29Bm4BPRzeS7YeECnV3cZE9kSb/v4X0Qx72mbW8ulDgpUzOZGe O6Fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=E0ValWnb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w67-20020a636246000000b0055752f5a119si18920663pgb.517.2023.07.03.06.26.22; Mon, 03 Jul 2023 06:26:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=E0ValWnb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230177AbjGCNAs (ORCPT + 99 others); Mon, 3 Jul 2023 09:00:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbjGCNAq (ORCPT ); Mon, 3 Jul 2023 09:00:46 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82022E67 for ; Mon, 3 Jul 2023 06:00:36 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E3FD2218F3; Mon, 3 Jul 2023 13:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1688389234; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=g/qfo8Cb33qUzg9p/sYx93BIkx/lh9MH46SOSdnmyf8=; b=E0ValWnb8323NYs3nZ1reUyn9xcW6UnT/WjrnwfuddpLUbUcW8umrJK2eBg3GMgbEVZlc5 e7Op8WL+1NzVEDBRQL2foLY3SM64CFvRMXs5yP/7PJD1wYpI7+kCyTD72S180Jsu1OyMFY Lwnv8tdJ/g8zVtBTGNEHkHjIPCjEI1g= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9A656138FC; Mon, 3 Jul 2023 13:00:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2xVZJHLGomSYCgAAMHmgww (envelope-from ); Mon, 03 Jul 2023 13:00:34 +0000 From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org Subject: [PATCH] x86/xen: fix secondary processor fpu initialization Date: Mon, 3 Jul 2023 15:00:32 +0200 Message-Id: <20230703130032.22916-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770406076370618678?= X-GMAIL-MSGID: =?utf-8?q?1770406076370618678?= Moving the call of fpu__init_cpu() from cpu_init() to start_secondary() broke Xen PV guests, as those don't call start_secondary() for APs. Fix that by adding the call of fpu__init_cpu() to cpu_bringup(), which is the Xen PV replacement of start_secondary(). Fixes: b81fac906a8f ("x86/fpu: Move FPU initialization into arch_cpu_finalize_init()") Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky --- arch/x86/xen/smp_pv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c index d5ae5de2daa2..cef78b8c89f4 100644 --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -63,6 +63,7 @@ static void cpu_bringup(void) cr4_init(); cpuhp_ap_sync_alive(); cpu_init(); + fpu__init_cpu(); touch_softlockup_watchdog(); /* PVH runs in ring 0 and allows us to do native syscalls. Yay! */