From patchwork Mon Jul 3 10:36:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: YunQiang Su X-Patchwork-Id: 115301 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp422803vqx; Mon, 3 Jul 2023 03:37:20 -0700 (PDT) X-Google-Smtp-Source: APBJJlGE18+rnlbLIKqpynNCHHgZ3CyAkINfOTZz7eQaZUVHe+7qIy4B6hPoZCNncG99WeCo3JH6 X-Received: by 2002:a05:6402:1606:b0:51e:bc7:585c with SMTP id f6-20020a056402160600b0051e0bc7585cmr2573241edv.41.1688380640740; Mon, 03 Jul 2023 03:37:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1688380640; cv=pass; d=google.com; s=arc-20160816; b=CPcZWrq5mHE0dTZcc1h+7/5GO4jsuq2CYvKn1fXqMW9FxLVLw9qN+g+6nV8QQXAunU U6XfGJ2LNBjbBdhGh9z92Y9ZTLDtTEv16hSOeMCJHb6lpqfFmppA/gy4OEWDeEoUZTTH c10HNPNQe0xYMvRfR27eURqM2UanqPXV2TGx+JM4voHxTACYDVaTbOnzhP+SPuUYVH5j nYKju9YkZe5GHr6CRt4mBDcgrVSX9mweP8kfycGumqcM8LJYawY7nG66j+t7Ky3X50j3 wjcviUeub/MQkpmK4lXGPlJQuh716lmLNwQgmsDiP+HV7h0qfuQO3/uF53dU1J6opYoz kEKg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version :content-transfer-encoding:message-id:date:subject:cc:to:from :dkim-signature:dmarc-filter:delivered-to; bh=9BQCnlv8ZHrB0wM8XjyUKRZVYO0/xdeivElWdUp6A8E=; fh=j7jXDC/uFDGL8cxf6cfXp7wjPYpkTHIAVhaTd8yNQ1g=; b=lpVkNP7zS6ABufBz8eeo4CMy63/h4rcftkKtE0kW36YhuOdC9ahNXnPH2KnA7jCqL3 WwNu5ODmTyaOkbPhy7dL12pTiQK3DkYcFILrAseIM42K5JEBKZVbFrFiSUfNqanwhsPq Wb5AUt8eDoZe6xitw8BauO/EOmsWSJX5Oq8eZV2DhicpYELoFvAKHMbaRIq+WApO7GVi droVzzG0SSkL4CYLmqD+idEDIjHFuvHJla+qU6D2IqE7Ifw71QRpxBIG0UQKuqx06OGb Q/pOWJdAbVUrqb5Nr2FVmV3PZ3+lFEQWvViJb9R4IWCRQVEs9YA8fAXlYg/1yOuNTd8U intg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@cipunited.onmicrosoft.com header.s=selector1-cipunited-onmicrosoft-com header.b=xP+3hBo5; arc=pass (i=1 spf=pass spfdomain=cipunited.com dkim=pass dkdomain=cipunited.com dmarc=pass fromdomain=cipunited.com); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id e17-20020a056402105100b005186d1e66c7si11583951edu.288.2023.07.03.03.37.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 03:37:20 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@cipunited.onmicrosoft.com header.s=selector1-cipunited-onmicrosoft-com header.b=xP+3hBo5; arc=pass (i=1 spf=pass spfdomain=cipunited.com dkim=pass dkdomain=cipunited.com dmarc=pass fromdomain=cipunited.com); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7BE303857C44 for ; Mon, 3 Jul 2023 10:37:19 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2090.outbound.protection.outlook.com [40.107.255.90]) by sourceware.org (Postfix) with ESMTPS id 5FECA3858D1E for ; Mon, 3 Jul 2023 10:37:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5FECA3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cipunited.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cipunited.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UN53w5I8a7f+39vSHfT0apaTzUUc/MoisYh8L3GNnpl5VXdXOp2GOBRIqIM4a6qpP8uX0WtGyJGuwIYtPXKcUP6lolQebF/Q7Izm/KIJVyMOkkUmM2LDLEOpyUAI8/D76RPW4snuiZlV6jHGvWWQdlh9EhzYghoABrDEPqy4NEQhlnV+kGWVyLw9WBEpgactV49341NolNxswRrhuF4kfLepXpLY+Oyro0ZrEIYA6+GxufQTLeWgqr0AJpCLopjc9JZgXMyD0o/zU0fAel3YRHY6TxiXER7i1xygjNibKXZQnPTU4MqUsI1m9C93IxuDCPi98m4ZYxBUv9Fw26ddtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9BQCnlv8ZHrB0wM8XjyUKRZVYO0/xdeivElWdUp6A8E=; b=mpdAAT1U5LrgqL45184+uesZ97gaqgA5dPuLZBKQc78AWb+adVpS+C2ZLPcgvbJwYW4PGc257rStUNR5kp2Wx4RmFluDJb+Tb8snL5fZsfX4x2nQSlX36vI6LhcErZVJ3r1c4E6IzQ+yeLwv5izxgdqwes7nPIZYcZcYu73qbLEE91a4JyDIEtXXZ/XPIee7Jj4rw7fxBakPq0u4m6w+V9XYCSHaHDXRjS+D7gJ6pPnkbqzobfaOTvgL/jwwMJksIcPuEjTV0hAxXr+/gFC48iyL778OuGmlQI/7UVVUkEprfbQm9GGOXz4jKP+RbQzWvjbqumhQ1T8ikITBCLQgBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cipunited.com; dmarc=pass action=none header.from=cipunited.com; dkim=pass header.d=cipunited.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cipunited.onmicrosoft.com; s=selector1-cipunited-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9BQCnlv8ZHrB0wM8XjyUKRZVYO0/xdeivElWdUp6A8E=; b=xP+3hBo5I8+s14ts5NQZAXTupIntKYXBnOTpnR756Vb4HLVHOvdxT4nOgru01lqtIfoDdrqH0/pYkiMCBtNalTF05jSthRNHOQ8UYKV3IvX7hJpHF+I3G+AqK9Tjmq7KH6ciYCzIHsUsxSp+77FwFIXUONu0XYIYSZ1QcwDhTgw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cipunited.com; Received: from TYZPR04MB6117.apcprd04.prod.outlook.com (2603:1096:400:25a::9) by SI2PR04MB4154.apcprd04.prod.outlook.com (2603:1096:4:ff::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 10:37:05 +0000 Received: from TYZPR04MB6117.apcprd04.prod.outlook.com ([fe80::d2b4:bc09:619a:118c]) by TYZPR04MB6117.apcprd04.prod.outlook.com ([fe80::d2b4:bc09:619a:118c%6]) with mapi id 15.20.6544.024; Mon, 3 Jul 2023 10:37:04 +0000 From: YunQiang Su To: binutils@sourceware.org Cc: macro@orcam.me.uk, YunQiang Su Subject: [PATCH] MIPS: Don't __gnu_lto_slim to .scommon Date: Mon, 3 Jul 2023 18:36:47 +0800 Message-Id: <20230703103647.3162351-1-yunqiang.su@cipunited.com> X-Mailer: git-send-email 2.30.2 X-ClientProxiedBy: SG2PR06CA0240.apcprd06.prod.outlook.com (2603:1096:4:ac::24) To TYZPR04MB6117.apcprd04.prod.outlook.com (2603:1096:400:25a::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYZPR04MB6117:EE_|SI2PR04MB4154:EE_ X-MS-Office365-Filtering-Correlation-Id: 84798296-0e87-428b-e174-08db7bb1715d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 66D+xMDkEf0sS57SC8cgaLqvlIPe2EDoRC56fwP09v69fIg6Mt+Hp8/MI5IVE7hLoeLzvuO8vMIKd5JEooGiWCoYPzcVMfe0dKNEOkjO/uiWOXZ+p3PDSJAsuq565V5/QaNKiuFwlTOSnWzYSYjTY3lVjHF39PBkHMZWWInVU5fAmFvrf9qpxqP8k/YsE5Gs07VY+5KsS6Y3PddA8eXlsezGTZbSIKdqVYUA4kso6Lv7l3Z4atlHJ+/yyHNhOcSB3VenfS2hM18PhmDT5YeWkQbUOalOmTeT8nTo17WI8OvyzyBYsYIPJJtxAjdNlz4V11YpzPbe3+6jIn4+f8OO0Zs6A85bRS6rPICTZn9jIx9shtQ5montNcjfYd5fra4HOFvIWCNMc/GIrQ2K8EgOnlVAHzciTl8wg1z5jWQE9P4V1jRMrmfLonS6vXtFkyYTnP1lFptaL4XIl31/Zh4dng2pN7S4IaduFNmhNsexDXEPPHUPk0o/yxjyL1c6TIRFcms1VN4kDImeTAXlzM90uC6CGWlCRF9fknu5BixOLkoKf6X9GZeCaT5SX7xZ9UDBzG+lQZegdt0Q1VmdYeA5/BvIsup5y8ieLWWrdPh8nVnhga3N+12qSbX/1lt0wIOjbO6+s61zvHG7Y7VW2AvEeQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR04MB6117.apcprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(136003)(376002)(396003)(39830400003)(346002)(451199021)(4744005)(2906002)(41300700001)(5660300002)(8936002)(8676002)(36756003)(86362001)(186003)(2616005)(478600001)(107886003)(26005)(6512007)(6506007)(1076003)(6666004)(6486002)(52116002)(316002)(6916009)(4326008)(66476007)(66556008)(66946007)(38100700002)(38350700002)(83380400001)(142923001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: oeN4vf/RIGbQbPZAO43qCNcrAYmP0/al7rYEym1yZ1Lh4Mm6HJgAalxQ2rNaANINUq3TbFXJAcuAP+0frNaxqXVFpxUns1o49uZp/UKfKJwGTYS01lXhhCCWbLBWPG2sueTO+K4O8vfbX4cxm5EeHLmvCZJ6Nc9H9IF7mQcYg3Sf4e7Pw6sNrbY/Ph5ljE05PoKb7ZbzD2YnyKDPflnETbxQL6hoQM5n30px92vP1Fo0RI8MYNpb7zGLVRLEv5MpJRFfYr6G0dgyKChVh7l2NcD72JDAJyZEgUktuWrIr+JaHyusKvUtDWg8h5WvQTKow3WIaFysXlYaGZ/4uqpGPYlEtVnNCOV75F9/KTLvrM6lga4x3UVBXl/U6xZcdTsfWaxo0HoTdvzul6/JwCctiDTay8uHP5C1ABvpHtFhP8g5IvY9S9KqWqN0LhXWC+CGAhgpU6GEcuft9sDCTOITI81SIcH9C5d7LkylcsSSVFTDw3UonIpw5gsh/0vdVECdpkJkMrpvQNsuld2zKDlrgyVJGhOyheZwpf3TWdaQxYTfTPhbcMom/D3+OzLkYUgVVhxYFAR27ifOljPjsCFFVDalc//3DSfhp7fejSsJo4bQSuDhi06Ea2BlxSDawVrCh1VlaHlukev1XXwAS6uqvU8wU3OBEdnsEQGWwRCwCjuOQXgb5yxqkzu3L1erdjbMocE2OfS8Dy69IoDdCO7ySbYstPugpptJYKOCZgZml++aP8oG5FhX0uLv4WlbhwbJOW+CO1b/pr+P8sjIf8+kPjNkFKtzEMA69RVkgjo/A1/LglyAr7zo8wtDA5q2te3Jx6EARKjrVNXZupV9YwVB74Ir6M6Plh4fH/VLIwyx8ErlHgZvvMOJAeHl/sieTX4fJxqeMhpfiky/A2Klhf7x3fAtjhDa9Mra3LKInz5pI4JL99yxI2pfVpXFZ3WEIV0fwaKAHifjeVfRvU6etR/LXhkV045IPPqMldFW3UQlSEfKErX0o17uv7zhHPE8lA2Ez/Vrjs+tazFtzzcwJE1uxi98YFtIMAES+8tRYk/DeaelMfwICLX57M+/ISj7Bjcu6zJ94qaAcuPF8ke0lqJfAgIZa70QKrkGVTmq3I8qGCETT0VG3zCwiDJdwZDzlBX7kMTYriw3e+H+8tjg8OBf7T0ib5IR+Iazgosls5qNNDp3OXjCqZlLPimGhq+msIwLonv7SLxw3nB5MxNQjVDlQ2UyJHqePA5yGF/MRMmv5HRexvdZneo3JBxTkPt+iMsIN7++SsDlLf7xwY3o1/qzkidIIJPo/iGZU64yRCdCTK1016pzPVGhv2CSbkR0/qzO4Oo1U1zF1xs7GTT8XpuirUE1QQOA05wrK4RpzaSdHG49JFBXP1uicZcgbObjHoRHN2TWfiUL89AHhNazA+oj/o93Wi8Ei76QEWvLpO07F+LiM6HB9Pkf/Bl19Ob5JwyxKglz1i7wuj3i2I+YNQFxqS4gWvifKc4T7iL+suQV7dMAKkWgd0ijMJsIDJvfurOGS7ev9fxcX55QTfLO7kq/SRtbjY8n7kVWAigZb2FO4toyxefRsZzSsqKkghfmTlHXKDOQU79jA+0otwe+SUX41w== X-OriginatorOrg: cipunited.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84798296-0e87-428b-e174-08db7bb1715d X-MS-Exchange-CrossTenant-AuthSource: TYZPR04MB6117.apcprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 10:37:04.7177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e31cf5b5-ee69-4d5f-9c69-edeeda2458c0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IQTGfBJnLRnWQX/VNQTGPqG0u7SqoIgg0w92xR1SVNr0pQeNEOBuTB89FA/O3S3/kVGXbqBrFU7NTUw67B0mMbm60GOgSPkor9So5LCYObs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR04MB4154 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770395418353878422?= X-GMAIL-MSGID: =?utf-8?q?1770395418353878422?= The LTO plugin doesn't expect __gnu_lto_slim is marked as COMMON, and in .scommon section. Let's skip __gnu_lto_slim when detect symbols that should be moved to .scommon. This patch can fix testcase: PR ld/15323 (3) PR ld/15323 (4) for MIPS. --- bfd/elfxx-mips.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/bfd/elfxx-mips.c b/bfd/elfxx-mips.c index 71f2dc9d779..63742de009c 100644 --- a/bfd/elfxx-mips.c +++ b/bfd/elfxx-mips.c @@ -7861,6 +7861,10 @@ _bfd_mips_elf_add_symbol_hook (bfd *abfd, struct bfd_link_info *info, switch (sym->st_shndx) { case SHN_COMMON: + /* __gnu_lto_slim shouldn't mark as COMMON and move to .scommon: + lto plugin doesn't expect so. */ + if (strcmp (*namep, "__gnu_lto_slim") == 0) + break; /* Common symbols less than the GP size are automatically treated as SHN_MIPS_SCOMMON symbols. */ if (sym->st_size > elf_gp_size (abfd)