From patchwork Mon Jul 3 07:22:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 115200 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp342322vqx; Mon, 3 Jul 2023 00:24:04 -0700 (PDT) X-Google-Smtp-Source: APBJJlHhbTcODndf+zdMo8yCAhYhw+izS5+o0ZRZzJt0fcqC6EGLNmEK1YWkMmZvjC+0YrmVdcn8 X-Received: by 2002:a05:6402:4496:b0:51d:d41b:26a5 with SMTP id er22-20020a056402449600b0051dd41b26a5mr6187430edb.14.1688369044370; Mon, 03 Jul 2023 00:24:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688369044; cv=none; d=google.com; s=arc-20160816; b=bPgt8NtWcgk+otZpMhQK6LDVB8PCPRoyMcVvcviU6Wvoi1RxMAArSIfDteL4ZTY2Ue D9mmujSk6R0BL16WpK2UMAanwNqKqneWz2FmltFsQoR7AmD5Msv5O+aV2lRN8YsqKFI3 JJ+dkFjNoiL0PTlkxxmpGq0feGTXnJqwkEYxxNHx00ORjQ0a+ju1u1rzl9pu3lh9gAGP o9JDhvRfsAGuusfU6KlUAetTh1+EqXDe4f2pBN3cvO2wD44dA5L+5/WMPy/61zWNQNzf K2BneqoV+oFurHjoDIrPVbhiaIUA6G5DfR8R/tHE1GcfAFTy2R/e6YgoX/lsO6WHohJs u7CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:sender:errors-to:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:user-agent:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=+lDxwDeKGdbgwLyI5qbciRRq9T9ZwNa1VBpPwpFDaGI=; fh=hPrbWPhweUx4V0GV9uXJqbyAzg2ABmTz7kczrAQqMmM=; b=jX1PRxbm6Tqz+FXN+CjP0/5yPr7XDHQdlZmnIoaatJ+FhathoGDVSWIh7xPIDmFWsy aMqnaDqgwImfEbr/1wV1R7IjLt/4JRZgFyN0jndb5tX2ut1NILtNY+JyH+1HxkwfGEyK NSjN4EoC74TZHavcr3/MazB/rjT5M8UEk6Fib72U8u8+pOfCOQ1RjHR0F2rDeGLE4pCr YcX21m8XQ0bxSltgoyXtQXWoGbf0pKjOXfzLxZIf9PRJH1PyfZjxZk1pcW1F12VwLvlC wWp4uY9r5F0HnKyRRRPighr5Lph7+87S3TSF/cDRHifb0BQQoNOxr9Ja9nUvK6i42oy7 Chbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="pB63/0Je"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id s24-20020a056402165800b0051ddfabf157si4960567edx.178.2023.07.03.00.24.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 00:24:04 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="pB63/0Je"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 17BB83858C1F for ; Mon, 3 Jul 2023 07:24:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 17BB83858C1F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1688369043; bh=+lDxwDeKGdbgwLyI5qbciRRq9T9ZwNa1VBpPwpFDaGI=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=pB63/0JerrK655a/FDbrKS/HX2KlGEIOp2KHlqDDpNleWPWeUjFPElq8mp2EIfmyb Ig0bqlID0/rOrQA+O51arDMuHGXXEr3LyW/5c20PXwOnh8OH8X4fsP7rByX4H7oUUx o5c1mBcR9YJeBBck3gToxwtud2FTccrZeIzcZM3k= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id CB0AA3857C71 for ; Mon, 3 Jul 2023 07:22:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB0AA3857C71 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id C1F64218F6 for ; Mon, 3 Jul 2023 07:22:36 +0000 (UTC) Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id B89082C141 for ; Mon, 3 Jul 2023 07:22:36 +0000 (UTC) Date: Mon, 3 Jul 2023 07:22:36 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/110506 - ICE in pattern recog with TYPE_PRECISION User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" Message-Id: <20230703072403.17BB83858C1F@sourceware.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770383258993916418?= X-GMAIL-MSGID: =?utf-8?q?1770383258993916418?= The following re-orders checks to make sure we check TYPE_PRECISION on an integral type. Bootstrap and regtest running on x86_6-unknown-linux-gnu. PR tree-optimization/110506 * tree-vect-patterns.cc (vect_recog_rotate_pattern): Re-order TYPE_PRECISION access with INTEGRAL_TYPE_P check. * gcc.dg/pr110506-2.c: New testcase. --- gcc/testsuite/gcc.dg/pr110506-2.c | 18 ++++++++++++++++++ gcc/tree-vect-patterns.cc | 4 ++-- 2 files changed, 20 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/pr110506-2.c diff --git a/gcc/testsuite/gcc.dg/pr110506-2.c b/gcc/testsuite/gcc.dg/pr110506-2.c new file mode 100644 index 00000000000..aabca0fa156 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr110506-2.c @@ -0,0 +1,18 @@ +/* { dg-do compile } */ +/* { dg-options "-O2" } */ + +typedef unsigned uint32_t; +typedef uint32_t uint32x4 __attribute__((vector_size(16))); +typedef struct { + uint32x4 b, d; +} prng_t; +prng_t prng_rand_128_r_x; +int main_flags; +int main() { + uint32_t ref_crc[] = {7, 3}; + uint32x4 e = (prng_rand_128_r_x.b << 27) + (prng_rand_128_r_x.b >> 32 - 27); + prng_rand_128_r_x.d = e; + if (ref_crc[main_flags]) + __builtin_abort (); + return 0; +} diff --git a/gcc/tree-vect-patterns.cc b/gcc/tree-vect-patterns.cc index 25f7f8e1e44..de20e9d59cb 100644 --- a/gcc/tree-vect-patterns.cc +++ b/gcc/tree-vect-patterns.cc @@ -3726,8 +3726,8 @@ vect_recog_rotate_pattern (vec_info *vinfo, return NULL; if (TREE_CODE (oprnd0) != SSA_NAME - || TYPE_PRECISION (TREE_TYPE (lhs)) != TYPE_PRECISION (type) - || !INTEGRAL_TYPE_P (type)) + || !INTEGRAL_TYPE_P (type) + || TYPE_PRECISION (TREE_TYPE (lhs)) != TYPE_PRECISION (type)) return NULL; stmt_vec_info def_stmt_info;