From patchwork Mon Jul 3 07:22:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 115199 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp342010vqx; Mon, 3 Jul 2023 00:23:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlGdLZgGcq/tVVwnT3fxyFU4j7f6mNojhaeEoqRmOz62EgPE07RxVfwFrkQstdPL6o1ZHHJW X-Received: by 2002:a05:651c:228:b0:2b6:a429:386f with SMTP id z8-20020a05651c022800b002b6a429386fmr6801261ljn.22.1688368988964; Mon, 03 Jul 2023 00:23:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688368988; cv=none; d=google.com; s=arc-20160816; b=qqlU4p2yA076mSJbaPaJop1iCiXdr8HHim2RvgnHrU/fkBajr5Fwa5kS9/6fWK82lb yG9Cgcpeb1xlg9xj2l9kTSbQZKRS2okCXmItxha8wcxE3vG9OGcrBIgHtiCWU5kHlE4D oP0Ub6ZUdbTC0EEfdKU3FtuBTuzmKC2GVKrOdUoD7RJnDwXHi5TNjSTi5BVlVUVY945R I+9wItcA2h3P4HlWwxH1n/GfB0VSeT0iUXDVbbFzT2CLf1iPfWunlfRA0zpsumgbE7WX +NHcAJ3C0ISGYhtsZ4mhGHd5Iig6N2L4oZTVroFTIKD67KDO/Z/LgCDSF9n8RaL1bQbz Y/jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:sender:errors-to:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:user-agent:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=kTJkDPK8N917l4pX3knUwsO9RFMGbPmCwmJ2TWL/Gto=; fh=hPrbWPhweUx4V0GV9uXJqbyAzg2ABmTz7kczrAQqMmM=; b=jrw4QxGp52MNerfVNXgn2jQJ6QyfIfQ8I1AVfWA39sY4SMTAQjAJUfAgDtGN78e2uH TLmQTWaHHjqmYLXht5/IOjBxgk16lT+B32CVDleyz6SLFRRx3PTrtfrAOiKeXYy0SLam hApDj1c05AHP9kvGE6g0fqeGqt6o/RTSWEkrn+5YrQbQb5yc8VGRAvxfHq9WGX0LSeF0 RQ8s10ejW/ZoxEx8czBVdiBVs8uMsy9SGyoKjzaJaZtQgbv9A9Tb1d3EUxKP5Jd807eg fzmSVZ/BPcY8i69tVOG5KWiVUCQ3OId9A79QixxsvOg6ZSmb+W3eWSIwXqBKFKKBaGAs Ju4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=G1kO9ejO; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id q25-20020a056402033900b0051dec1232ecsi4365553edw.517.2023.07.03.00.23.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 00:23:08 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=G1kO9ejO; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9E9D73858438 for ; Mon, 3 Jul 2023 07:23:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9E9D73858438 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1688368987; bh=kTJkDPK8N917l4pX3knUwsO9RFMGbPmCwmJ2TWL/Gto=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=G1kO9ejO0zfGWiGoYKHv4tojUaWdqf5OO6tpflwuflj5ZNV7Ixn2QXmKEgSGZvZIU McHPxsb+l4AGE1EcLIhHDL1a+zS4IzoZd1VW1w2HtDvdmnfOjN1EIVaWPm7HYJ7INN Qnsw5B2bni6Ejy94lbHDFZUT991TCsUdbj7BXOx8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id C9DB73858D28 for ; Mon, 3 Jul 2023 07:22:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C9DB73858D28 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id BBEA01F8AC for ; Mon, 3 Jul 2023 07:22:23 +0000 (UTC) Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id B24DB2C141 for ; Mon, 3 Jul 2023 07:22:23 +0000 (UTC) Date: Mon, 3 Jul 2023 07:22:23 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/110506 - bogus non-zero mask in CCP for vector types User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" Message-Id: <20230703072307.9E9D73858438@sourceware.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770383200670260274?= X-GMAIL-MSGID: =?utf-8?q?1770383200670260274?= get_value_for_expr was blindlessly using TYPE_PRECISION to produce a mask for vector typed entities which the new tree checking now catches. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/110506 * tree-ssa-ccp.cc (get_value_for_expr): Check for integral type before relying on TYPE_PRECISION to produce a nonzero mask. * gcc.dg/pr110506.c: New testcase. --- gcc/testsuite/gcc.dg/pr110506.c | 24 ++++++++++++++++++++++++ gcc/tree-ssa-ccp.cc | 1 + 2 files changed, 25 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/pr110506.c diff --git a/gcc/testsuite/gcc.dg/pr110506.c b/gcc/testsuite/gcc.dg/pr110506.c new file mode 100644 index 00000000000..10dbd4e6ce6 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr110506.c @@ -0,0 +1,24 @@ +/* { dg-do compile } */ +/* { dg-options "-O2" } */ + +struct { + long *sp; + long *csp; +} neko_interp_loop_vm; +int neko_interp_loop_vm_2; +void neko_interp_loop() +{ + void *pc[] = {&&LabelAccGlobal, &&LabelPhysCompare, &&LabelTailCall, + &&LabelLoop, &&LabelMakeArray2}; + long *sp, *csp = neko_interp_loop_vm.csp; +LabelAccGlobal: + neko_interp_loop_vm.sp = sp; + neko_interp_loop_vm.csp = csp; + goto * 0; +LabelTailCall: + csp = sp -= neko_interp_loop_vm_2; +LabelMakeArray2: +LabelPhysCompare: +LabelLoop: + goto * 0; +} diff --git a/gcc/tree-ssa-ccp.cc b/gcc/tree-ssa-ccp.cc index 26d5e445abd..0d0f02a8442 100644 --- a/gcc/tree-ssa-ccp.cc +++ b/gcc/tree-ssa-ccp.cc @@ -682,6 +682,7 @@ get_value_for_expr (tree expr, bool for_bits_p) } if (val.lattice_val == VARYING + && INTEGRAL_TYPE_P (TREE_TYPE (expr)) && TYPE_UNSIGNED (TREE_TYPE (expr))) val.mask = wi::zext (val.mask, TYPE_PRECISION (TREE_TYPE (expr)));