From patchwork Fri Jun 30 14:27:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 114742 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp10419768vqr; Fri, 30 Jun 2023 07:41:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Cv52ljRzPAwvlOEB7wMNp+LDuSoUQ1vmU8+bNLUL5yhYhKjb8Est+XBh8I4Wc8GwRRvpE X-Received: by 2002:a05:6830:1282:b0:6b8:691c:88ae with SMTP id z2-20020a056830128200b006b8691c88aemr2874181otp.33.1688136119161; Fri, 30 Jun 2023 07:41:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688136119; cv=none; d=google.com; s=arc-20160816; b=P9peq77mFqSwZHFgFF7jcOIbdY4F+Qox7vG4HHDwDuizHuuYw20A7aKqKWXa5DduuT d/khU0y3VWO7j7jU3wwU/pT6lnsHgWyH1BL8jMpVvDlLP5ty75i4QjFes6cJ68KdPV0a p+9njKX7uzNeadshfM57i4z9lEwdm9w2WDJPGMMnul3jglU71vvYMOoE+MMF6XwlTthd s696TEGnEvQxW6MIvJBbFzoMuwOWSLqPAd4gOHTx1dN/rge6Zx6aCpkCzGWLEyo8jXyw 2Y1ts65zpsMKjd1iSd94VE4Wdlwqk0ao3+upBVfYZJ8j/DVWAl9HeNGmmLi3KIq1yfvA YK0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dI1a8mXHMK6zcZe8LYP5Hp9K72J94RCIPnfvjCHb0gw=; fh=0TkepFmYXz4U6PH+EYFSuuWUUWn95KEjZbqs8NbnrCg=; b=GWH4dCP9KG42c4i6NwM8FnJ8Mrk/M9IGXdRUsP19Ns7J8OqrBTyYsnrIP3aHGmioty E4zGxqkw3gpfQq3gGZJCR2QnaaksPkR0TwBHIYqSJVNV084GdJQCMFb5WUsdge3+pon/ yVKid64e92aumRseIgKxyzYA6oqPc79x0uzhYpG0QkLftyPdEclyrib4P4Kj4BYYejOD 3EV/J+Czm+0jZA9AzHcDQ3R/yxQwi03vUJUZaLUkWX2xMD9iQxRfHib3Mn416o3qnFsg jeDlvmaZcVKYDaUOaMGSzeEZgjiWhW5JK8sdn0+xumr8s5CwUzw147sW2woQw5YZ9v4D 0beg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Rp+wfgt/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j4-20020a632304000000b0051b65f4d94asi12424991pgj.484.2023.06.30.07.41.44; Fri, 30 Jun 2023 07:41:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Rp+wfgt/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232523AbjF3O1l (ORCPT + 99 others); Fri, 30 Jun 2023 10:27:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230462AbjF3O1V (ORCPT ); Fri, 30 Jun 2023 10:27:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF5C93AAB for ; Fri, 30 Jun 2023 07:27:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 67D3761767 for ; Fri, 30 Jun 2023 14:27:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB990C433CC; Fri, 30 Jun 2023 14:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688135238; bh=NRFErKcwJ/XzcSK0nLh18CLPEbv6pza++M+LD175n/g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Rp+wfgt/fmfucldMXsQFVG5qrpdRwt2MhBa4hhvoo9tTSd9s8F6S09guVvviSPh/b bvOMCWwmWygIQDX8yK6ABQIriIUp8fSs+G96HhRVrxiNbzy/Jzjym4F4HEXRvJr38o gC1AOgAl0g1w86zqKQY7JJuc/k18l98/0N+CmP+cNX7oB5wTM7wwvtQEAtZD/9Ir5F mGDRP0qyjIWKfFkJ2vWj9TyXN7gTh5by1Z+O3tZKJQKV65lK9/L+Zc2tQgIUr1nrKA YXv08G+0rd0aWGx3sd2Nr0LQsBCE87E0E+qlvOnS2I9yA/SEKhID5PrCkmf02qkMXs Mrgz7snhumXqQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1qFF5p-0001O7-8o; Fri, 30 Jun 2023 16:27:25 +0200 From: Johan Hovold To: Mark Brown , Srinivas Kandagatla Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 1/5] ASoC: codecs: wcd938x: fix mbhc impedance loglevel Date: Fri, 30 Jun 2023 16:27:13 +0200 Message-Id: <20230630142717.5314-2-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20230630142717.5314-1-johan+linaro@kernel.org> References: <20230630142717.5314-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770139019230337369?= X-GMAIL-MSGID: =?utf-8?q?1770139019230337369?= Demote the MBHC impedance measurement printk, which is not an error message, from error to debug level. While at it, fix the capitalisation of "ohm" and add the missing space before the opening parenthesis. Fixes: bcee7ed09b8e ("ASoC: codecs: wcd938x: add Multi Button Headset Control support") Signed-off-by: Johan Hovold --- sound/soc/codecs/wcd938x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index e3ae4fb2c4db..b8a52a1a63d5 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -2165,8 +2165,8 @@ static inline void wcd938x_mbhc_get_result_params(struct wcd938x_priv *wcd938x, else if (x1 < minCode_param[noff]) *zdet = WCD938X_ZDET_FLOATING_IMPEDANCE; - pr_err("%s: d1=%d, c1=%d, x1=0x%x, z_val=%d(milliOhm)\n", - __func__, d1, c1, x1, *zdet); + pr_debug("%s: d1=%d, c1=%d, x1=0x%x, z_val=%d (milliohm)\n", + __func__, d1, c1, x1, *zdet); ramp_down: i = 0; while (x1) { From patchwork Fri Jun 30 14:27:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 114740 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp10419337vqr; Fri, 30 Jun 2023 07:41:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4kja1XriF/M0ViimVSGxqDVSP2aUTxGNLGzDDIMWiREvdCTIiMCprcWwNVR+JNBd8U3ucc X-Received: by 2002:a05:6870:6b0c:b0:1b0:7f57:1e28 with SMTP id mt12-20020a0568706b0c00b001b07f571e28mr3363801oab.11.1688136080196; Fri, 30 Jun 2023 07:41:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688136080; cv=none; d=google.com; s=arc-20160816; b=N5CGUUqJje+pw7RjMHtgST69ZfiEInOCurU12bimFC9USZQkKqQREsGrqC+ONhcTgd +oHYa02OptsGVClBaiYjiGHUaR3V4Hh5BT3l7WR+wPoTKF9tRS0OO0zUapbFQOSNOs7O 0YPHESrRIGWSrRWqtw1+5JrQ9VDfGb4lW69bVb24VI7RtOelZeKvpjV5WyuIidla7LPR B4a2wARgz/uQBjpUFMtgAfIsiFtBLFq2bZtgYop1Q0wvbN4lo0INqU1PzV8alU/MAudh ZF35A6I7GFsMiNNZB52uijw1D+pf+9G+I/wWzLW5vUCgOo/qs09jTOxoxzrnFNEbgWv5 WJ9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vWU2JMRJaGve+eD+XZyjVG4sjh/xuLGVp1jgR1xkszQ=; fh=0TkepFmYXz4U6PH+EYFSuuWUUWn95KEjZbqs8NbnrCg=; b=R28O3y1TZkjRNhdk+vhMO5HB/rMeQ7rKEGs5SC9i/3DHnXqqUrJGcvXCdz/9Nvi5V5 IRWS7keQvbcG8mA8ZBaQiPoVfdGigncLzdQ4okdJObO9KLrfN5Z46PF9XDk4Sw0Qv1jN S2nazsFvqiWj31R/opQQzk8T7CCg4Hfd07dkAH0R6Ho/XfohxCDg9m/ekuY+qWcX5sTC p+3G2c3Lf4+7O6FdeCHa4gUrOPSkilXsABoAZmfeBtTds7bTpgdnlp7ofCPueWnFLAzb zmrVf9aE55vxcrlllcxoZNjKmbQTG+yo8WGv6YF2dq9jWMdkcoDZCqDyKCvKkvJDF9F6 DZOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EEH5d8nm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 13-20020a17090a08cd00b00263355e8183si5460194pjn.114.2023.06.30.07.41.05; Fri, 30 Jun 2023 07:41:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EEH5d8nm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232002AbjF3O1b (ORCPT + 99 others); Fri, 30 Jun 2023 10:27:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbjF3O1U (ORCPT ); Fri, 30 Jun 2023 10:27:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D43E135AF for ; Fri, 30 Jun 2023 07:27:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4BF5A61763 for ; Fri, 30 Jun 2023 14:27:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB908C433CA; Fri, 30 Jun 2023 14:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688135238; bh=PQzafQPINWzNCKfU5qAbB7q39zv1fe5dtlRulHQmlWU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EEH5d8nmZCFHaRW8Qfwvrw5eNUf+1b2fNeJWl2yEjsEaYvYJH0AzcfYcAfP2rHAe7 sBLFMDTvsOaXYOYCudL0iFFfRwKwwgEXgrlXqC4nG23beyJK+aJUOXQInbZy20Tle5 3YUWnL39h1Q68uJzcvO+S1WxjG+0y392YKXRo15u8y2hZOIFBW06lIlUlIb2LG2IQ9 W66LzIPVxrsK2xDEh2qvjNdaP89h+TF+u9CzC9JRo7aRyQS0XBnFMVTYed/WyuGWvY z+I1c8vDDYWSksfECI0r9E/HS6Sk+9WKQ4ZbhU2M8AVAK243u3Gkw4DgxlGC3YjOaz uQ4eGCn4tJXjw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1qFF5p-0001OQ-BJ; Fri, 30 Jun 2023 16:27:25 +0200 From: Johan Hovold To: Mark Brown , Srinivas Kandagatla Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 2/5] ASoC: codecs: wcd938x: drop inline keywords Date: Fri, 30 Jun 2023 16:27:14 +0200 Message-Id: <20230630142717.5314-3-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20230630142717.5314-1-johan+linaro@kernel.org> References: <20230630142717.5314-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770138978089647873?= X-GMAIL-MSGID: =?utf-8?q?1770138978089647873?= The compiler is generally better at deciding what functions should be inlined than driver authors are. Drop the bogus inline keyword from two functions that were neither very small or used in a single place. Signed-off-by: Johan Hovold --- sound/soc/codecs/wcd938x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index b8a52a1a63d5..5ce15b622a91 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -2124,7 +2124,7 @@ static int wcd938x_mbhc_micb_ctrl_threshold_mic(struct snd_soc_component *compon return wcd938x_mbhc_micb_adjust_voltage(component, micb_mv, MIC_BIAS_2); } -static inline void wcd938x_mbhc_get_result_params(struct wcd938x_priv *wcd938x, +static void wcd938x_mbhc_get_result_params(struct wcd938x_priv *wcd938x, s16 *d1_a, u16 noff, int32_t *zdet) { @@ -2231,8 +2231,8 @@ static void wcd938x_mbhc_zdet_ramp(struct snd_soc_component *component, *zr = zdet; } -static inline void wcd938x_wcd_mbhc_qfuse_cal(struct snd_soc_component *component, - int32_t *z_val, int flag_l_r) +static void wcd938x_wcd_mbhc_qfuse_cal(struct snd_soc_component *component, + int32_t *z_val, int flag_l_r) { s16 q1; int q1_cal; From patchwork Fri Jun 30 14:27:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 114738 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp10419032vqr; Fri, 30 Jun 2023 07:40:55 -0700 (PDT) X-Google-Smtp-Source: APBJJlF9kfB1Kcdd1mrBUily+CXvrPkwk/iz3nlJcUfRaP6U4n+Dr1qXJ1LSjL+C5QudBDRTpzKs X-Received: by 2002:a17:90b:2551:b0:263:a37:fcc3 with SMTP id nw17-20020a17090b255100b002630a37fcc3mr2098157pjb.5.1688136055301; Fri, 30 Jun 2023 07:40:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688136055; cv=none; d=google.com; s=arc-20160816; b=RKDRk6SRmVKYs0d1Gpkholm2X3MWzoa0xTs8OmGbBG/meXcYHg1QqMLDAlnIQnOa6J BD1Hm7K2mqnRAUTNsk9HPwrPw5njbNl5N1AJmYX1r7HBLbCv3TwPV1FKDzeAReMPPuMo F3u2oho73f121bcYKxZbO4qfx38xWAX9WKiPbuS3YjQJXFIZ12utFDMOljKyJlzDMcbf 4J0rL/R8DgM4FajKlzBT65z+94Wrjg41zMLFP71PvfFrLv2KEX7Tt04IYI3DYjOkXyMP FawFVefR4YtDCz1iaEUyi4vYRFtO8JqkQsb3dJaNk7gs14JPpSP+Ap1tukcEY0tAVS1o pu+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=m+7yl9ujpfdqfQH67tzVsP9io5DxMZctSHuxh5Dt77k=; fh=0TkepFmYXz4U6PH+EYFSuuWUUWn95KEjZbqs8NbnrCg=; b=G+f1Op97F1Go3xmw07dD1/47xx6SvdJ92ufzX3o3sDT+aCyIcgvHMx1AaDbFfOLP08 b6pk4CnwvM8pYZygcgoTfo54bBscQN8rzozH6846z1q8vd/DHEon/gqSL+BhYEn6B7fX b+WoWNVW3twwnjEZKFl93NxW7q/wFKj1QgAC68XQaJfOiLUu2s6R4vpQSCqE0I+Oo2c8 vgfXg4gr9uFQUFVNsS2i6pz3YR55hQ8QQJlp+EbRx88dedVLB1L2w3CQ+e+ptCXQ23Qf RzGzjbArxXPdS2OWEGLdXjNXM851FA4j/2QhkcKAyFKCq0fP1xpWoHRtmzoX6QhPYUpZ o63Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=D424TjQi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 13-20020a17090a08cd00b00263355e8183si5460194pjn.114.2023.06.30.07.40.40; Fri, 30 Jun 2023 07:40:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=D424TjQi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232176AbjF3O1p (ORCPT + 99 others); Fri, 30 Jun 2023 10:27:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231675AbjF3O1Y (ORCPT ); Fri, 30 Jun 2023 10:27:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1114935AF for ; Fri, 30 Jun 2023 07:27:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D61B061771 for ; Fri, 30 Jun 2023 14:27:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B36E4C433CD; Fri, 30 Jun 2023 14:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688135238; bh=P6YVdCFm2ZOkpCnCJ7xlyVk9dprYs6KAI7jlHUrVE5Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D424TjQiXcZcj4i/3v89N3a4BuqKXQtLcEZgEl+wCzeh7iNUv9wFPGkfd+0jwWfcF p4pMrS4+tXjRGn/TwKglozLY4ew3h/f+zgCLPdyKpxacvKwkQA1ab0X9/DTvw15rGy 2SzNG29ZYSKYlrOtNDqgn3Y0WMNdqhEPRR3xPTg4Y9ZUzgjl1j7bPYSboYsYysFPHY +rMGkUb3Kg96Cul1BwADFXFtywQbLLUwaJUL0T0bS+qPNzIgEJz0lDRm/Sd5uu1olg 04l1NbsWscLKr++r95aPcKmkuLf90puLbVydfB0tcAUzmSQeKxeFhputmq4UrPxsrk qBS6Ed5P+q0tA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1qFF5p-0001OS-Ds; Fri, 30 Jun 2023 16:27:25 +0200 From: Johan Hovold To: Mark Brown , Srinivas Kandagatla Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 3/5] ASoC: codecs: wcd938x: use dev_printk() for impedance logging Date: Fri, 30 Jun 2023 16:27:15 +0200 Message-Id: <20230630142717.5314-4-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20230630142717.5314-1-johan+linaro@kernel.org> References: <20230630142717.5314-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770138952006006147?= X-GMAIL-MSGID: =?utf-8?q?1770138952006006147?= Pass the component structure also to the wcd938x_mbhc_get_result_params() helper so that the component device can be used for logging consistently. Signed-off-by: Johan Hovold --- sound/soc/codecs/wcd938x.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index 5ce15b622a91..ddefe4af0b1e 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -2124,10 +2124,11 @@ static int wcd938x_mbhc_micb_ctrl_threshold_mic(struct snd_soc_component *compon return wcd938x_mbhc_micb_adjust_voltage(component, micb_mv, MIC_BIAS_2); } -static void wcd938x_mbhc_get_result_params(struct wcd938x_priv *wcd938x, +static void wcd938x_mbhc_get_result_params(struct snd_soc_component *component, s16 *d1_a, u16 noff, int32_t *zdet) { + struct wcd938x_priv *wcd938x = snd_soc_component_get_drvdata(component); int i; int val, val1; s16 c1; @@ -2154,8 +2155,8 @@ static void wcd938x_mbhc_get_result_params(struct wcd938x_priv *wcd938x, usleep_range(5000, 5050); if (!c1 || !x1) { - pr_err("%s: Impedance detect ramp error, c1=%d, x1=0x%x\n", - __func__, c1, x1); + dev_err(component->dev, "Impedance detect ramp error, c1=%d, x1=0x%x\n", + c1, x1); goto ramp_down; } d1 = d1_a[c1]; @@ -2165,8 +2166,8 @@ static void wcd938x_mbhc_get_result_params(struct wcd938x_priv *wcd938x, else if (x1 < minCode_param[noff]) *zdet = WCD938X_ZDET_FLOATING_IMPEDANCE; - pr_debug("%s: d1=%d, c1=%d, x1=0x%x, z_val=%d (milliohm)\n", - __func__, d1, c1, x1, *zdet); + dev_dbg(component->dev, "%s: d1=%d, c1=%d, x1=0x%x, z_val=%d (milliohm)\n", + __func__, d1, c1, x1, *zdet); ramp_down: i = 0; while (x1) { @@ -2210,7 +2211,7 @@ static void wcd938x_mbhc_zdet_ramp(struct snd_soc_component *component, WCD938X_ANA_MBHC_ZDET, 0x80, 0x80); dev_dbg(component->dev, "%s: ramp for HPH_L, noff = %d\n", __func__, zdet_param->noff); - wcd938x_mbhc_get_result_params(wcd938x, d1_a, zdet_param->noff, &zdet); + wcd938x_mbhc_get_result_params(component, d1_a, zdet_param->noff, &zdet); regmap_update_bits(wcd938x->regmap, WCD938X_ANA_MBHC_ZDET, 0x80, 0x00); @@ -2224,7 +2225,7 @@ static void wcd938x_mbhc_zdet_ramp(struct snd_soc_component *component, WCD938X_ANA_MBHC_ZDET, 0x40, 0x40); dev_dbg(component->dev, "%s: ramp for HPH_R, noff = %d\n", __func__, zdet_param->noff); - wcd938x_mbhc_get_result_params(wcd938x, d1_a, zdet_param->noff, &zdet); + wcd938x_mbhc_get_result_params(component, d1_a, zdet_param->noff, &zdet); regmap_update_bits(wcd938x->regmap, WCD938X_ANA_MBHC_ZDET, 0x40, 0x00); From patchwork Fri Jun 30 14:27:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 114744 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp10421985vqr; Fri, 30 Jun 2023 07:45:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ736GPtQWyuAm9eZIxglyBDvyU2Ch+M748bGOQIHFVfgalCHQOY00ukymfZpbZDp9TDDREX X-Received: by 2002:a05:6a20:7d93:b0:106:c9b7:c932 with SMTP id v19-20020a056a207d9300b00106c9b7c932mr3025153pzj.1.1688136326271; Fri, 30 Jun 2023 07:45:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688136326; cv=none; d=google.com; s=arc-20160816; b=XC6hJmbVjnk/mrReFuIn/qCQNG+bxA9kApCl62kbFCfWHEAjeV9hYnEMfH8xTSlUcB 0wi2VMCKTPQwoknp825skahDfwuTfIKGmBketwoH09OcfQ0vdRwptanzarbBlge33dmk 1uZW/e9VN6rbgqoMNJucjc6LrnNeIdk6/iYjjkhDImU/4fVMMtDTws+98+bnHugfPhno AH9BxOw3o/f8x9haw4UMiGauINdpEbEJqSiDciTw+t8uqSYRS245KwaHEXi7ffPaa4Lv WJ4pOMgSaH2aYE34sFSkzkecKAeRIbzo9dCPTGDeP8nlHogL+p+v7jehP14t0PZ6OIpW nk9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SCjJyDgYWs0mhGO4j6jSgEJiWz/Y0CUQTjrC1iE7u9g=; fh=0TkepFmYXz4U6PH+EYFSuuWUUWn95KEjZbqs8NbnrCg=; b=GmLO0a3hU8rDT4UqRM0V/nFHnhxXZt9QCT7winoBIjsXiclK5+uWDTmvjStmqoEd9p LFFBDq3CKDoLm29T770A0DEoKnh1Mn9bm1g2Sf9rd5YD+fE5dw8bbSbSaXHh2XOMsdiX KiLviwRLKngzTFK4Wk+oqSPwQIydRidwF+k/HfQPh14PNFqJ/M83KdJpM7+HQPN8oX16 SoMr1DKerG3+MVlVWygTh6bhxIM24QoaV+HTqryc0qb4bsZ2cJtvSAzZMwXXsix0uhFe MlfF0jLjsZsJVivjqTDz2OMEv87KzV8+/tAFSFUBnGwxzA931qk/tzjkHJ4Miql5eauB 7G5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jcldJ0KI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n7-20020a6543c7000000b0055384329027si5124903pgp.566.2023.06.30.07.44.54; Fri, 30 Jun 2023 07:45:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jcldJ0KI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232307AbjF3O1f (ORCPT + 99 others); Fri, 30 Jun 2023 10:27:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230106AbjF3O1V (ORCPT ); Fri, 30 Jun 2023 10:27:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F26B33AAD for ; Fri, 30 Jun 2023 07:27:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6C44761769 for ; Fri, 30 Jun 2023 14:27:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB857C433C8; Fri, 30 Jun 2023 14:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688135238; bh=d1TV3UMh6xoeemuKnST1bo2dXdckO3q+r8QUrL0X6V0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jcldJ0KIiGOHCLdh9VVbIIOMTDdsd6uLObALf9+N/4QXztMgUhpnzo07D6JSEprGM ysVwMdU2PImvgsB5pqYjIvXZMsmeeULwOILdMeIoJXSwnjfIErW6dM4eX1nbNAAJXY V9JcWcfAE4AfzWdwEc1M4M77rRKpZVqIQwUz3MiMlfa2v7hLL3SFBbvGoiSa+xN5H5 OfzWVaRpKNjExA124iP9Ph2a1ewcq91hqNWwCiKAMNmSwWeO7QJdoOU5wS78uBPvXy fzqKb+BQ2096laCMex5jcQuh3ulVn45f94C2JgpZgoQgM6iNWghg5jSYM2fyJqS3/W W3WQTNgRXUdWg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1qFF5p-0001OU-GP; Fri, 30 Jun 2023 16:27:25 +0200 From: Johan Hovold To: Mark Brown , Srinivas Kandagatla Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 4/5] ASoC: codecs: wcd934x: demote impedance printk Date: Fri, 30 Jun 2023 16:27:16 +0200 Message-Id: <20230630142717.5314-5-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20230630142717.5314-1-johan+linaro@kernel.org> References: <20230630142717.5314-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770139236720840807?= X-GMAIL-MSGID: =?utf-8?q?1770139236720840807?= Demote the MBHC impedance measurement printk, which is only needed for development and debugging, to debug level. While at it, fix the capitalisation of "ohm" and add the missing space before the opening parenthesis. Signed-off-by: Johan Hovold --- sound/soc/codecs/wcd934x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c index c0d1fa36d841..9d724b5710f7 100644 --- a/sound/soc/codecs/wcd934x.c +++ b/sound/soc/codecs/wcd934x.c @@ -2683,7 +2683,7 @@ static inline void wcd934x_mbhc_get_result_params(struct wcd934x_codec *wcd934x, else if (x1 < minCode_param[noff]) *zdet = WCD934X_ZDET_FLOATING_IMPEDANCE; - dev_info(wcd934x->dev, "%s: d1=%d, c1=%d, x1=0x%x, z_val=%d(milliOhm)\n", + dev_dbg(wcd934x->dev, "%s: d1=%d, c1=%d, x1=0x%x, z_val=%di (milliohm)\n", __func__, d1, c1, x1, *zdet); ramp_down: i = 0; From patchwork Fri Jun 30 14:27:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 114741 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp10419600vqr; Fri, 30 Jun 2023 07:41:43 -0700 (PDT) X-Google-Smtp-Source: APBJJlEq5tyeZstqrayqIaoX2EES//FEeSSZ2F8Sj446t56B//861Wre9/4Ka47pIk3bOs2m11Eh X-Received: by 2002:a17:90a:28a2:b0:263:30d6:dca with SMTP id f31-20020a17090a28a200b0026330d60dcamr2329161pjd.29.1688136103104; Fri, 30 Jun 2023 07:41:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688136103; cv=none; d=google.com; s=arc-20160816; b=cEQtx3fBL9+hYYHn6xXQbxEZTCOscy9qms1a9fcT5gqR2pQdzkEsyI/CffBEBdiIYO Mv7smhyZXlH+nG2qwIeVjuwpJ6nmr4E4t7sOaagIQr4x7dV+QxHx/SXqSGDUDPsuYAEs I7ZCzHFfR+g7l2/xeAkgouKTLhRM0QtS39PWH52QNADGoL6HZUJa3f+ErR5wmL/xbRUu 8dckilDVPjGcpYujyZDbuc5HZz+0G6hRcP7J9MBRA3i+3VJjMfosv6lTYRpQ2g4WVPQv vgHHGKEiuVC/qTRuwEPAXZrHPdFD4IUSnCtZ3tS1Sre03EDVVl8oVJgpyFJ3lk+tDzVu mkpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2Jm8bbFmRMaa/OhzjntxMetulNIziRZJONKbcmJThBk=; fh=0TkepFmYXz4U6PH+EYFSuuWUUWn95KEjZbqs8NbnrCg=; b=bwm+8ogX2VCffBPZ83CZ7/o9PQHcBwWC8C4W2vHop/PqNX3hc7g50UTeTJ7OJqcIV/ sLXXyffHpByMcGE58NlYc6iexkn+/GLatAEP8/64xN6JxsJNzcoKubG4u2aHpcjIDzip tW573t91M2aUNX5q93x3nJgxVH+7KvgIa0mcetA04KpiM3AsF1i9b5E2P8h+71h0mZc/ uW8rVdxHKIhlI5SWRXPxF/d52WGDTdkzbc9IXvAkOAwe8OH5yBBYbvymxixxWL31FApz tfsBOsYG7DzsHby6ubHDWaYPj1cvmTWL1gxpdda4IsD9O+xplRHpuXGF2jZcggzshhPh nfNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eYqZFelz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v12-20020a17090a520c00b0025e8357c3a7si14765816pjh.70.2023.06.30.07.41.28; Fri, 30 Jun 2023 07:41:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eYqZFelz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230106AbjF3O1i (ORCPT + 99 others); Fri, 30 Jun 2023 10:27:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231245AbjF3O1V (ORCPT ); Fri, 30 Jun 2023 10:27:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F37593AAE for ; Fri, 30 Jun 2023 07:27:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 60EC961764 for ; Fri, 30 Jun 2023 14:27:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB87AC433C9; Fri, 30 Jun 2023 14:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688135238; bh=lrVbd0JoMGVuCAGlTtBwHS0krlYpo5gW52m7Wo7fi6w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eYqZFelz3wt7y/0/q3o7bAsYRDLYrKrsMemIk08HP9xdO/MwqGzw09bWbTrSyYu8c KNNrYRnbad1Z5fuRBL2+xKFmpTirqeRQeexighNf8Whe3vS0ogxc1O86yFCD1VWbbB Ft5KD1t8MCf3RnPvebkrKv3PXpfcc5ntWi158pa6b6T1CfuFviR4KsRLEWbCWPpwgg 8whZvA/RiPAuV1j9Vo+85OxGwWa1QrLo4K86BSDV1ZmFXEoQOYuzuoHH8vr46aA2aO Zt91COgZM3Fovf1l0SK8cZzoX/YsQQ6KQnEN2v230F4nPMlXMds6q3A0tdRc4Tkz9i Hwvsy/8BSTC5Q== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1qFF5p-0001OY-Iu; Fri, 30 Jun 2023 16:27:25 +0200 From: Johan Hovold To: Mark Brown , Srinivas Kandagatla Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 5/5] ASoC: codecs: wcd934x: drop inline keywords Date: Fri, 30 Jun 2023 16:27:17 +0200 Message-Id: <20230630142717.5314-6-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20230630142717.5314-1-johan+linaro@kernel.org> References: <20230630142717.5314-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770139002775952128?= X-GMAIL-MSGID: =?utf-8?q?1770139002775952128?= The compiler is generally better at deciding what functions should be inlined than driver authors are. Drop the bogus inline keyword from two functions that were neither very small or used in a single place. Signed-off-by: Johan Hovold --- sound/soc/codecs/wcd934x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c index 9d724b5710f7..a17cd75b969b 100644 --- a/sound/soc/codecs/wcd934x.c +++ b/sound/soc/codecs/wcd934x.c @@ -2642,7 +2642,7 @@ static int wcd934x_mbhc_micb_ctrl_threshold_mic(struct snd_soc_component *compon return rc; } -static inline void wcd934x_mbhc_get_result_params(struct wcd934x_codec *wcd934x, +static void wcd934x_mbhc_get_result_params(struct wcd934x_codec *wcd934x, s16 *d1_a, u16 noff, int32_t *zdet) { @@ -2740,8 +2740,8 @@ static void wcd934x_mbhc_zdet_ramp(struct snd_soc_component *component, *zr = zdet; } -static inline void wcd934x_wcd_mbhc_qfuse_cal(struct snd_soc_component *component, - int32_t *z_val, int flag_l_r) +static void wcd934x_wcd_mbhc_qfuse_cal(struct snd_soc_component *component, + int32_t *z_val, int flag_l_r) { s16 q1; int q1_cal;