From patchwork Fri Oct 28 18:11:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tanjuate Brunostar X-Patchwork-Id: 12513 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp974552wru; Fri, 28 Oct 2022 11:15:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM77DkvY5QKsAjg5kcBOZFK+HbsgXAZnXc2NHoq0u/gf/kfTCWK+KchmPlAvf1BmrnLlTBoz X-Received: by 2002:a63:8143:0:b0:46f:5e58:7866 with SMTP id t64-20020a638143000000b0046f5e587866mr650618pgd.447.1666980906321; Fri, 28 Oct 2022 11:15:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666980906; cv=none; d=google.com; s=arc-20160816; b=LP9NnofKJh3ZbKGpkt8iqcEpjCmZaRfXoJsBz9eMGXChU+f2bM4vUd9XFVNwwSrhZH 6FTThNyI+QsXyYvVPwMfpaEGR9i1mbGopVzvLVJStztZdHiFOhay5kVWGD9MekLVT6f3 t8X3IwADt10Oh9LQVmLjoiyfhapxBokce1fRizqQFMlKWkhsuKzV3ReTnK85h15xg71z ANNn+EJRruIj9pKJK/8+Qkha3r4JZrsgztv58xTHnAOxEjrV9FJIYNcZ8J/MUr1yNjGF ONuMD0/lMzs6ePDcUk7GrZfmkZWRNVW+m0Z+z1RQKWZtFonb9bEf2M9+QGogo32IirpN Ijcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=GQRb83QAFePKhKbHLajNFJKcMixGfgCDUPELEyoVamM=; b=fuuEHGTbwY/9kqKqXTkc2ADQRvUGXn/n2fSimX2sDUUPJ8w2fBZuAbMTueb4ETTk+O KXtuYyYNLUCpsclR2x2pB86mWzF8FapLuCss968/CwXZXZu9gxGCj1HMAO76/ZxMuB0E eY9iLQCjy5oYSqLswLsy9HxLjCtdnG82WgTTsDeBZfYFHiHmeINaXPotsZhgCg50b/8j ibS0xXjnaug1cZ8MLxqyL2veGSScxGjAkhXrBYNbntcnSY0uN20nvzhyF6O/FEqr9Z82 yBqzzpXZ5UXPtSVSd3AfsoA8EQxguxqqfaS1FJNjWUWDLz9iph3nVC7XKb3g1LndLGlY g7JA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=AOogLAxX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m4-20020a170902768400b00178aec118c9si5394580pll.378.2022.10.28.11.14.52; Fri, 28 Oct 2022 11:15:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=AOogLAxX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230128AbiJ1SMH (ORCPT + 99 others); Fri, 28 Oct 2022 14:12:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230084AbiJ1SLy (ORCPT ); Fri, 28 Oct 2022 14:11:54 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D2B3230802 for ; Fri, 28 Oct 2022 11:11:51 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id d3so9387945ljl.1 for ; Fri, 28 Oct 2022 11:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=GQRb83QAFePKhKbHLajNFJKcMixGfgCDUPELEyoVamM=; b=AOogLAxXP23eX2lBQvcI9TTavczm05ANMT+Ta8nBkkZBnhTHLmAq0YrFr+A20kLRMZ ESb+7b1nf5BzYGYw1nkQbq8VHtYGOHaPGcbDWW+N+Ic9yFaKS9HCDQ8rc7tGbeSglfG8 Ok8ZrLbDZIFUA9/My1EovkQCWn4mTkp8o+S8snQaZRq8GOIzxbmxb6kfAyaRxCvIswOJ ZuMPzxuiIpzxCSvOe9dhuFDGRpT2G3VA1fRvHdXlOqIHEryBaL37Tcyfx11XPorYvOUY kD1IKR4ErIQ6fRuvPXvllJSriT62XXDswCQz1ulOjNcM+h6oPX6P8uNEZvUHPzeKuR8J 7+Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GQRb83QAFePKhKbHLajNFJKcMixGfgCDUPELEyoVamM=; b=rR1Kb8HYX3IphuJKewppJH+z8XjYyHX5+PIzxMrlDtDwZW0kWlU9cJDp7jr/pa+gGw ynjenOcTxZzdXOdI5fuu6XE1J5yOlkZY0I21YbtE3cfJLuS75qJvJZD2SF2rnGQtY0RI sm95+rOHuebc/zVf18mNxI2jKKqUJMivS71PQMZEFJbG6aRJMGVyNcfCGYYjHTeyRp1o 34NZkRngxoVIyJ+ao5/bQTKv/l5qZl/TFQgbOKL/Dc3LcyR75+84uz64P1O3xOmW/KSz 5SZdLunJzbrJawDyIWMT6VNZc7DmMEJy3QHGEtQMtO7TbRbYjdr0++rUmPl8I6yLY+75 L5fQ== X-Gm-Message-State: ACrzQf1zYymHnfI5/Xe3XjDwnEwSmQl+xoWz7VXHdf25eoK3NjyUDzAp KZ53bu8WV/7pRBuoWTOF6ro7lVTVD4uv2A== X-Received: by 2002:a2e:b892:0:b0:26f:ec13:e712 with SMTP id r18-20020a2eb892000000b0026fec13e712mr317706ljp.50.1666980709749; Fri, 28 Oct 2022 11:11:49 -0700 (PDT) Received: from elroy-temp-vm ([20.240.130.248]) by smtp.gmail.com with ESMTPSA id o4-20020ac24944000000b0048aa9d67483sm654736lfi.160.2022.10.28.11.11.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 11:11:49 -0700 (PDT) Date: Fri, 28 Oct 2022 18:11:48 +0000 From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, linux-staging@lists.linux.dev Subject: [PATCH] staging: vt6655: fix lines of code ending in a '(' Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747912606771699218?= X-GMAIL-MSGID: =?utf-8?q?1747956170962235018?= fix several checkpatch errors related to lines ending with a '(' by joining some lines of code and indenting properly to increase visibility Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 165 ++++++++++++++-------------------- 1 file changed, 69 insertions(+), 96 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 1e5036121665..7eb7c6eb5cf0 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -139,15 +139,11 @@ static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate) * PK_TYPE_11GB 2 * PK_TYPE_11GA 3 */ -static -unsigned int -s_uGetTxRsvTime( - struct vnt_private *pDevice, - unsigned char byPktType, - unsigned int cbFrameLength, - unsigned short wRate, - bool bNeedAck -) +static unsigned int s_uGetTxRsvTime(struct vnt_private *pDevice, + unsigned char byPktType, + unsigned int cbFrameLength, + unsigned short wRate, + bool bNeedAck) { unsigned int uDataTime, uAckTime; @@ -214,20 +210,16 @@ static __le16 get_rtscts_time(struct vnt_private *priv, } /* byFreqType 0: 5GHz, 1:2.4Ghz */ -static -unsigned int -s_uGetDataDuration( - struct vnt_private *pDevice, - unsigned char byDurType, - unsigned int cbFrameLength, - unsigned char byPktType, - unsigned short wRate, - bool bNeedAck, - unsigned int uFragIdx, - unsigned int cbLastFragmentSize, - unsigned int uMACfragNum, - unsigned char byFBOption -) +static unsigned int s_uGetDataDuration(struct vnt_private *pDevice, + unsigned char byDurType, + unsigned int cbFrameLength, + unsigned char byPktType, + unsigned short wRate, + bool bNeedAck, + unsigned int uFragIdx, + unsigned int cbLastFragmentSize, + unsigned int uMACfragNum, + unsigned char byFBOption) { bool bLastFrag = false; unsigned int uAckTime = 0, uNextPktTime = 0, len; @@ -316,17 +308,13 @@ s_uGetDataDuration( } /* byFreqType: 0=>5GHZ 1=>2.4GHZ */ -static -__le16 -s_uGetRTSCTSDuration( - struct vnt_private *pDevice, - unsigned char byDurType, - unsigned int cbFrameLength, - unsigned char byPktType, - unsigned short wRate, - bool bNeedAck, - unsigned char byFBOption -) +static __le16 s_uGetRTSCTSDuration(struct vnt_private *pDevice, + unsigned char byDurType, + unsigned int cbFrameLength, + unsigned char byPktType, + unsigned short wRate, + bool bNeedAck, + unsigned char byFBOption) { unsigned int uCTSTime = 0, uDurTime = 0; @@ -409,22 +397,18 @@ s_uGetRTSCTSDuration( return cpu_to_le16((u16)uDurTime); } -static -__le16 -s_uFillDataHead( - struct vnt_private *pDevice, - unsigned char byPktType, - void *pTxDataHead, - unsigned int cbFrameLength, - unsigned int uDMAIdx, - bool bNeedAck, - unsigned int uFragIdx, - unsigned int cbLastFragmentSize, - unsigned int uMACfragNum, - unsigned char byFBOption, - unsigned short wCurrentRate, - bool is_pspoll -) +static __le16 s_uFillDataHead(struct vnt_private *pDevice, + unsigned char byPktType, + void *pTxDataHead, + unsigned int cbFrameLength, + unsigned int uDMAIdx, + bool bNeedAck, + unsigned int uFragIdx, + unsigned int cbLastFragmentSize, + unsigned int uMACfragNum, + unsigned char byFBOption, + unsigned short wCurrentRate, + bool is_pspoll) { struct vnt_tx_datahead_ab *buf = pTxDataHead; @@ -555,19 +539,15 @@ s_uFillDataHead( return buf->duration; } -static -void -s_vFillRTSHead( - struct vnt_private *pDevice, - unsigned char byPktType, - void *pvRTS, - unsigned int cbFrameLength, - bool bNeedAck, - bool bDisCRC, - struct ieee80211_hdr *hdr, - unsigned short wCurrentRate, - unsigned char byFBOption -) +static void s_vFillRTSHead(struct vnt_private *pDevice, + unsigned char byPktType, + void *pvRTS, + unsigned int cbFrameLength, + bool bNeedAck, + bool bDisCRC, + struct ieee80211_hdr *hdr, + unsigned short wCurrentRate, + unsigned char byFBOption) { unsigned int uRTSFrameLen = 20; @@ -750,19 +730,15 @@ s_vFillRTSHead( } } -static -void -s_vFillCTSHead( - struct vnt_private *pDevice, - unsigned int uDMAIdx, - unsigned char byPktType, - void *pvCTS, - unsigned int cbFrameLength, - bool bNeedAck, - bool bDisCRC, - unsigned short wCurrentRate, - unsigned char byFBOption -) +static void s_vFillCTSHead(struct vnt_private *pDevice, + unsigned int uDMAIdx, + unsigned char byPktType, + void *pvCTS, + unsigned int cbFrameLength, + bool bNeedAck, + bool bDisCRC, + unsigned short wCurrentRate, + unsigned char byFBOption) { unsigned int uCTSFrameLen = 14; @@ -868,21 +844,17 @@ s_vFillCTSHead( - * unsigned int cbFrameSize, Hdr+Payload+FCS */ -static -void -s_vGenerateTxParameter( - struct vnt_private *pDevice, - unsigned char byPktType, - struct vnt_tx_fifo_head *tx_buffer_head, - void *pvRrvTime, - void *pvRTS, - void *pvCTS, - unsigned int cbFrameSize, - bool bNeedACK, - unsigned int uDMAIdx, - void *psEthHeader, - unsigned short wCurrentRate -) +static void s_vGenerateTxParameter(struct vnt_private *pDevice, + unsigned char byPktType, + struct vnt_tx_fifo_head *tx_buffer_head, + void *pvRrvTime, + void *pvRTS, + void *pvCTS, + unsigned int cbFrameSize, + bool bNeedACK, + unsigned int uDMAIdx, + void *psEthHeader, + unsigned short wCurrentRate) { u16 fifo_ctl = le16_to_cpu(tx_buffer_head->fifo_ctl); bool bDisCRC = false; @@ -954,11 +926,12 @@ s_vGenerateTxParameter( } } -static unsigned int -s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType, - unsigned char *pbyTxBufferAddr, - unsigned int uDMAIdx, struct vnt_tx_desc *pHeadTD, - unsigned int is_pspoll) +static unsigned int s_cbFillTxBufHead(struct vnt_private *pDevice, + unsigned char byPktType, + unsigned char *pbyTxBufferAddr, + unsigned int uDMAIdx, + struct vnt_tx_desc *pHeadTD, + unsigned int is_pspoll) { struct vnt_td_info *td_info = pHeadTD->td_info; struct sk_buff *skb = td_info->skb;