From patchwork Fri Jun 30 07:18:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rodolfo Giometti X-Patchwork-Id: 114604 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp10170682vqr; Fri, 30 Jun 2023 00:35:28 -0700 (PDT) X-Google-Smtp-Source: APBJJlHU7nMJYma8JOwQvdcn+WqhyjK0s1/ZoWms1M1yxnA62uXskoyzWtI00Sej+8lgoYbaZ6WD X-Received: by 2002:a17:90a:be16:b0:262:c2a1:c029 with SMTP id a22-20020a17090abe1600b00262c2a1c029mr1793559pjs.2.1688110528601; Fri, 30 Jun 2023 00:35:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688110528; cv=none; d=google.com; s=arc-20160816; b=BZTt2MPudbg6vHnNiBrOablRJ/4fom4KUdMhBEkTHl/S3GGPlt6huIqqujabiIadRC tcnk7X50BVUXvY5WFGHgFFYEhp7KvGoBVwwUON/TVk+yL8F39YwKUlyE5Ekl4BngEo7u sOuGyIl1PyKMxi9Pz7D2qejmzd2c/RgOhPE4/sJH2y6TQAnVaL8Dhkd7bDt0Lt66dKU/ ZImdCKlAAZzlEdkqmr/BYA+oHl/HB/iHo05so+VxY59fNTfmKkz62MeT4SO60BEGdCTc 7YYUwYWAfXv9kM8BO8iVHOba/PG0ernIVur8cSV63s8zBYWm8MtQZqPWrz5jFr5fMIUZ rBJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=jqtikzMgrdxKTNyqVwM1H8QBWP7BWl7C4vx+emrIAEU=; fh=ayOBfCdFfc8MiFgBHUtWYwIXecWXC00SwPRExd+ocLo=; b=jrPWocTW7R3HBASIfxsaaLVZ2fxbB+UjeAjHWUiSGLE48vWfAj1cItQucOuEzDrA1z YyURMknFWiAIGz4gdb2NSpvxo0GVX2KELrhZGWe3uzzhx9uJKavcb5LPE3BVuHofKAqc gXw2bMdTVLq5wBJe4ZyDgKnD10iVvs2tatnWZZyzYr5+WMtJfUpVOl1jGbWWK9EMwbjs gOwwy+hx+TBmmf0C9Ac6utwkKhGi02IAFzfHKlBGErcWLh7UDLubb9EiQyRXmYzyPRFn voqAy4LmIHiNLXIdJwXeB/IvmrUJBx9xRNSR9dp5yB3V9O/ORwnud3nc3N2399AYRE4c lHJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@aruba.it header.s=a1 header.b=O1vfhkdI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e1-20020a17090a6f8100b00262c43dbd58si11909482pjk.23.2023.06.30.00.35.15; Fri, 30 Jun 2023 00:35:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@aruba.it header.s=a1 header.b=O1vfhkdI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232159AbjF3HTU (ORCPT + 99 others); Fri, 30 Jun 2023 03:19:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232180AbjF3HSy (ORCPT ); Fri, 30 Jun 2023 03:18:54 -0400 Received: from smtpcmd12131.aruba.it (smtpcmd12131.aruba.it [62.149.156.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AD1F19BA for ; Fri, 30 Jun 2023 00:18:52 -0700 (PDT) Received: from polimar.homenet.telecomitalia.it ([79.0.204.227]) by Aruba Outgoing Smtp with ESMTPSA id F8P2qe5pmwtegF8P2qinBt; Fri, 30 Jun 2023 09:18:49 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1688109529; bh=vzmN4kJ3h47heL9B7a4O2NpUoBSMDfUBOXPHa+mny4w=; h=From:To:Subject:Date:MIME-Version; b=O1vfhkdI1zTrqCaCJIJEQD3Rkdmi4dggT8/z7HOsyJnEp5qOq8Sc7NjlnkLLvwqIq b2Odfl8u66oue6snszfSdlrc7UpizJ1vPqkcoKx6lcy+Gqjz/oF8vh+AtlGcEd1CM6 tNBqHkh8nVUDMIZ32CNNcYEktjqVeHAtV2gZeewxcmtsq/YTWOBnKYs7tysKW5WJ7p QWTw6FqdINR5NaCs1N2tCjEMAhNNZnqTtksq/xH9Uqs5oqBSpSHUfFDHhvy6aZqKU9 muu6GRZ+QkXCXMqF5g6lbCNeEqHxmZo7aFW1SyagCQym1nM1ThHrab8hIx4e1DbtQz MlZH9U1HKf+ig== From: Rodolfo Giometti To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Charlie Johnston , Rodolfo Giometti Subject: [PATCH 1/2] include/uapi pps.h: increase PPS_MAX_SOURCES value Date: Fri, 30 Jun 2023 09:18:25 +0200 Message-Id: <20230630071826.105501-1-giometti@enneenne.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CMAE-Envelope: MS4xfH/fmpQtNa7krYCUIJp18QipuTeXnS7k65LZHqKFjv+ecqqzgsEctZ+Z2uMSFFhohYiIdUGzrsbMFP6QSAUkBMxoz1p45oiy21BknMamhPiWJe3TNZBI H0sdV9Mllqba/jsyK/sfvLe6fV2fX84KLyYZvzLh/61VmuAccJREUbRsN5lknsujQZ7sQUheYIYk504lG+ZXz4lEG94v0KyIyVZk+VG/bLRNjqOCiBiZrOa/ z8fM7f4XXmkxuLLQEDcKIfJbZHqhOk61kELSzVJyWPIK1+ION18a2f6qJSGrrIyT2wiKVm5oQhQlAvQOzXLKpUyFu7Z+TFjiInnwbWlxJwg= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770112185987130138?= X-GMAIL-MSGID: =?utf-8?q?1770112185987130138?= From: Charlie Johnston For consistency with what others use for minors, this change sets PPS_MAX_SOURCES to MINORMASK. The PPS_MAX_SOURCES value is currently set to 16. In some cases this was not sufficient for a system. For example, a system with multiple (4+) PCIe cards each with 4 PTP-capable ethernet interfaces could run out of the available PPS major:minors if each interface registers a PPS source. Signed-off-by: Charlie Johnston Acked-by: Rodolfo Giometti --- include/uapi/linux/pps.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/pps.h b/include/uapi/linux/pps.h index 009ebcd8ced5..90f2e86020ba 100644 --- a/include/uapi/linux/pps.h +++ b/include/uapi/linux/pps.h @@ -26,7 +26,7 @@ #include #define PPS_VERSION "5.3.6" -#define PPS_MAX_SOURCES 16 /* should be enough... */ +#define PPS_MAX_SOURCES MINORMASK /* Implementation note: the logical states ``assert'' and ``clear'' * are implemented in terms of the chip register, i.e. ``assert'' From patchwork Fri Jun 30 07:18:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rodolfo Giometti X-Patchwork-Id: 114599 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp10167096vqr; Fri, 30 Jun 2023 00:27:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Q82yvr9IkXRUvrWo835Lmro/2bnwFYRyOT2FBpcb7n2B6oTDUFIjJAJdqb2fe3UmlQjNQ X-Received: by 2002:a05:6602:1612:b0:783:6e76:6bc7 with SMTP id x18-20020a056602161200b007836e766bc7mr3347640iow.2.1688110075586; Fri, 30 Jun 2023 00:27:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688110075; cv=none; d=google.com; s=arc-20160816; b=TQYElVysX2aM1PHfk6tS0v8N37wBD8J65AwotzTDTKqep+0kkIpdXu0rHAEcwYkCIS dWo+FwikdvYJWTbSQaU6zmuNQd1WMC9nJ51hVwLgOaJcROpVgKcA/ucSsQ1G121cdqZQ LX/blWfFZZqbjJQRm/nZjCap8rLso2bZuJ7AyOo54LmWYEyZmyZzI4s+Vmqf+rYYC0u5 ivuloscfqpRmoynGCdna6eq//6r5fcmzFual/TTalNQClesQnP7wbU8XAxdY/fW7bCTb 7o0YMBIdGV8ZzRG2/Ebh0UKMwpFAlOL1LaCkJSwgC68q8ZnGPP3TyLBEf7vGiz4gGjl5 Mj4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lcksmT+j3dvrGVE0znQsMXKzAYoy6l9c+LDbLT3F9C0=; fh=EMuwq4M6OvdxCYN7uXvrk5VMMSOj47BLh5bHSiK9ceA=; b=m8p7ljQjFuvGLYLw4bdb6BrFACBnmewLdicT3O56GMRFcl3rJ2xTQp+Fi6Acu0sfP/ YGi/yiSAX4HL7ChWbcDVfuLdntO8KHLEYrzzInhNG5NwFUacMDTkizGjbYkE8a7KvV/D X5sXdyiOwlgx+9+4zTHhht9842TRO+9hDb5OadoFz//FbZ5zS0UKJb754GPHdZZ4u8dr LQG9kJ5sOsQtzjts7feGZTRTK2SxfUFOG9O+mLlxfGXC4zy670dER0emQCURSbvu2esw uiLXrNXwAWuxonMxUqmGweP7conGCo4ts9stNQJZhxoN+ehSIy0eSYKUkXra17oV1UPr bPLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@aruba.it header.s=a1 header.b=UN5RMAXk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x5-20020a654145000000b005533aa71fabsi11163736pgp.572.2023.06.30.00.27.42; Fri, 30 Jun 2023 00:27:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@aruba.it header.s=a1 header.b=UN5RMAXk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232288AbjF3HTX (ORCPT + 99 others); Fri, 30 Jun 2023 03:19:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229945AbjF3HS6 (ORCPT ); Fri, 30 Jun 2023 03:18:58 -0400 Received: from smtpcmd12131.aruba.it (smtpcmd12131.aruba.it [62.149.156.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 013F01BDB for ; Fri, 30 Jun 2023 00:18:56 -0700 (PDT) Received: from polimar.homenet.telecomitalia.it ([79.0.204.227]) by Aruba Outgoing Smtp with ESMTPSA id F8P2qe5pmwtegF8PAqinFy; Fri, 30 Jun 2023 09:18:56 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1688109536; bh=QcsExrNJ6u1tiwlvDyvY9CDAytYAHUcGn+MfPz/pR+M=; h=From:To:Subject:Date:MIME-Version; b=UN5RMAXkMviYnp4jYmmiMtNiGPPtedCJdjUMe2Ej4XT4YDqTxeseIAB1U4IeM41fK MvDwYgL+2+9eYCWALRY4Xy8sTL4fdhgtinJSVIZ9eIJ1INOwpQb6d1U2uuC/nsm0u6 qhIH6w6fkMO/PZBUAcgIoEfjeMU5fMNxPTWVhNIa8IOgj8XSuhsD6YHVWaB/80lwX+ th5Rmm9bWhS+dvQh18yrgxergV5MNowvQNxbDLNasVjDi3fbjkCcmtvusq4Ac3u2G0 d4H8zr8EzObwBsOshfwbMvUaVbIx4oFNDe2HsRzK5O4bS0odj3IwFl1oEjXiNIg1xV GephMKN94FF6A== From: Rodolfo Giometti To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Rodolfo Giometti Subject: [PATCH 2/2] include/uapi pps.h: drop not needed PPS_MAX_SOURCES define Date: Fri, 30 Jun 2023 09:18:26 +0200 Message-Id: <20230630071826.105501-2-giometti@enneenne.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230630071826.105501-1-giometti@enneenne.com> References: <20230630071826.105501-1-giometti@enneenne.com> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfEKXjkKELrLkuV21oCJBEGONFsFIcn/35iHv7RHB6PVXRFxSfWMKWwHLolc88Ky7whnKEmwZVxVcyv2EZ3vOt7ciRgBmxCA2yGmnURGFEKrbSKOyjkxp GLyV6wTzwvj+L85OKaqiosjgUVD9TID+V9Ea9WLYbOO1nlTxfZ0UQ+hfZ9diJ0yIRSQ10aKT/gHX/LWUIHoddVIPPK2GNTJKeU1MbFSkWRvX8yN9ZjASp3bq 4Ks3PdGZiwGlUdYteuQz8m/SDOswsWVbCO83Tg+4y8UzvLmdUK0QorZnl+6lSbDy X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770111710717949590?= X-GMAIL-MSGID: =?utf-8?q?1770111710717949590?= Userspace PPS clients should not known about how many PPS sources can be defined within the system (nor the rfc2783 say so), so we can safely drop this define since is not used anymore in the kernel too. Signed-off-by: Rodolfo Giometti --- drivers/pps/pps.c | 6 +++--- include/uapi/linux/pps.h | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/pps/pps.c b/drivers/pps/pps.c index 5d19baae6a38..1a6131608036 100644 --- a/drivers/pps/pps.c +++ b/drivers/pps/pps.c @@ -354,7 +354,7 @@ int pps_register_cdev(struct pps_device *pps) * Get new ID for the new PPS source. After idr_alloc() calling * the new source will be freely available into the kernel. */ - err = idr_alloc(&pps_idr, pps, 0, PPS_MAX_SOURCES, GFP_KERNEL); + err = idr_alloc(&pps_idr, pps, 0, MINORMASK, GFP_KERNEL); if (err < 0) { if (err == -ENOSPC) { pr_err("%s: too many PPS sources in the system\n", @@ -449,7 +449,7 @@ EXPORT_SYMBOL(pps_lookup_dev); static void __exit pps_exit(void) { class_destroy(pps_class); - unregister_chrdev_region(pps_devt, PPS_MAX_SOURCES); + unregister_chrdev_region(pps_devt, MINORMASK); } static int __init pps_init(void) @@ -463,7 +463,7 @@ static int __init pps_init(void) } pps_class->dev_groups = pps_groups; - err = alloc_chrdev_region(&pps_devt, 0, PPS_MAX_SOURCES, "pps"); + err = alloc_chrdev_region(&pps_devt, 0, MINORMASK, "pps"); if (err < 0) { pr_err("failed to allocate char device region\n"); goto remove_class; diff --git a/include/uapi/linux/pps.h b/include/uapi/linux/pps.h index 90f2e86020ba..8a4096f18af1 100644 --- a/include/uapi/linux/pps.h +++ b/include/uapi/linux/pps.h @@ -26,7 +26,6 @@ #include #define PPS_VERSION "5.3.6" -#define PPS_MAX_SOURCES MINORMASK /* Implementation note: the logical states ``assert'' and ``clear'' * are implemented in terms of the chip register, i.e. ``assert''