From patchwork Thu Jun 29 18:43:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Wunderlich X-Patchwork-Id: 114394 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp9841908vqr; Thu, 29 Jun 2023 11:51:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4AzmFtYffFnBbFOX0r18NGYTpGesEWoACd2f9Ky+0f2e99xuk4TdrFqos0UQxDnC1HC67z X-Received: by 2002:a05:6a20:d90b:b0:126:7d25:b0e0 with SMTP id jd11-20020a056a20d90b00b001267d25b0e0mr455027pzb.24.1688064712895; Thu, 29 Jun 2023 11:51:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688064712; cv=none; d=google.com; s=arc-20160816; b=oB3wQ+vLSq4of3fBAkh1Mc+GZ9X6PUYu6CsZ/kje6iXshl95MB1A6Z8X5dQD6QDPWJ /0gJZ0xp5qsFHRruJzOL2+rSoMlC9mHN8nPMdizt5oOP3C1KMjuRrcQcFw7o/eooSwcp Rla/jQmnhBH+mT5XxvxOX3q4EQyGMYIrfFL2BRY8zjumX8sjnq/eN4OQfX0TZ+s5VvjY 7EJRZeaDgM+EoxCx3YdjxlIiVonMhPLfL9XetECMiP1/ZvgKd0DIclTWlAm8pG4OxFvN F4C7d53OVzrFAbxv8N/IJOKNEh5LRitHnKC878E0VNfQttZu6UnHdTuOYi4d/N/5VbPJ oeDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KKwn4pI+xbCMED6ZrjRNts/9bUc9vmXTiZ+7Mh6MCJo=; fh=p58pEyGs9ZVmc0iWCS1JcSbg7GM1EacYwgZCiW6CZHo=; b=FEIXriRgunsi2iN7FVaAgeRA1qCGrXAfPb3BDglLoCNgOXUpzCLFO2r3tgD3hVLI7L Rhc1j4+b1kTyk8ZrqY7OB9SwcmZXr49jsEeg3w8U6eMS1VdDXzNt2mPCS8RT9gdICcIu 5hKGqQRT1Rq0Xfy/kmxOtFbSXAhEkzag8cp1wIS8nSQNT2vbOCu76Pk0hQVP9VvTeBol aarQUOBMOI2cp0vBAOo+c5qOxjdWzQNEhXDIYN/bQpjHcQJrJrEHHniCgAdlKwzw466I +8m/bakF8LNY2y8uIlkfWApE5YhG0FJ/CvC60La9Dc6u2my8sTPcIwf6ckDMUyETKBuO 5ZPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mailerdienst.de header.s=20200217 header.b=IuoPkO4n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u10-20020a63140a000000b0053f33ec5635si10956698pgl.865.2023.06.29.11.51.36; Thu, 29 Jun 2023 11:51:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mailerdienst.de header.s=20200217 header.b=IuoPkO4n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232761AbjF2Snv (ORCPT + 99 others); Thu, 29 Jun 2023 14:43:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232445AbjF2Snk (ORCPT ); Thu, 29 Jun 2023 14:43:40 -0400 Received: from mxout3.routing.net (mxout3.routing.net [IPv6:2a03:2900:1:a::8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26D252693; Thu, 29 Jun 2023 11:43:36 -0700 (PDT) Received: from mxbox2.masterlogin.de (unknown [192.168.10.89]) by mxout3.routing.net (Postfix) with ESMTP id A99DF605D2; Thu, 29 Jun 2023 18:43:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailerdienst.de; s=20200217; t=1688064213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KKwn4pI+xbCMED6ZrjRNts/9bUc9vmXTiZ+7Mh6MCJo=; b=IuoPkO4nES4sD7aKHkl3yJuMO9wW83z8euR0VrDgqxiD4ItrWnf57ouhYuJaBZxvn7Awcd tosMG8V2vFIr8FsCGgrRB+ucVrOwuzr7W6gmpfqDmh5KydHrSgF6VohYv5O4ANOqpcWYRq +H0bMt/M9A8r6wQyhcwS1Xu8ysdteoQ= Received: from frank-G5.. (fttx-pool-157.180.227.241.bambit.de [157.180.227.241]) by mxbox2.masterlogin.de (Postfix) with ESMTPSA id C0D411007BC; Thu, 29 Jun 2023 18:43:32 +0000 (UTC) From: Frank Wunderlich To: linux-mediatek@lists.infradead.org Cc: Frank Wunderlich , Chaotian Jing , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Wenbin Mei , Sam Shih , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/2] dt-bindings: mmc: mtk-sd: drop assigned-clocks/clock-parents Date: Thu, 29 Jun 2023 20:43:17 +0200 Message-Id: <20230629184318.551317-2-linux@fw-web.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230629184318.551317-1-linux@fw-web.de> References: <20230629184318.551317-1-linux@fw-web.de> MIME-Version: 1.0 X-Mail-ID: d645d265-62e5-466c-9f7d-58ccb7702d42 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, T_SPF_TEMPERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770064144369598442?= X-GMAIL-MSGID: =?utf-8?q?1770064144369598442?= From: Frank Wunderlich MT7986 has 2 clock-parents and these properties are not needed in driver binding. So drop them completely. Signed-off-by: Frank Wunderlich Acked-by: Conor Dooley --- v2: - drop assigned-clock* completely based on discussion with Krzysztof in v1 --- Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml index 46eefdd19a2c..3fffa467e4e1 100644 --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml @@ -91,16 +91,6 @@ properties: should switch dat1 pin to GPIO mode. maxItems: 1 - assigned-clocks: - description: - PLL of the source clock. - maxItems: 1 - - assigned-clock-parents: - description: - parent of source clock, used for HS400 mode to get 400Mhz source clock. - maxItems: 1 - hs400-ds-delay: $ref: /schemas/types.yaml#/definitions/uint32 description: From patchwork Thu Jun 29 18:43:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Wunderlich X-Patchwork-Id: 114395 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp9841945vqr; Thu, 29 Jun 2023 11:51:58 -0700 (PDT) X-Google-Smtp-Source: APBJJlGndXxc+3PTtx2FyCrkhAIgFcimrP9UyUsoVbYqjdB1l9rxEzlaDwfQPMNvk2ZfFz+sGc0c X-Received: by 2002:a05:6a00:80d:b0:66c:6678:3776 with SMTP id m13-20020a056a00080d00b0066c66783776mr880558pfk.7.1688064718496; Thu, 29 Jun 2023 11:51:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688064718; cv=none; d=google.com; s=arc-20160816; b=ztq4MwPyV+Gwr4qP8PwP/8Q/LKOLII79Nn8RVFwH8dbP7ftBPtLCoQaY8rCCOxZ9ng viFRdhOybOEL/269sr9J2Kx6ADRZZmHGNw2sb4BNBzKe5Shz7o8sxbVOGc4NgtI/Thf1 nZ2z8UDTCphtJmr1Tzkju1GVE+rONC5BXSI1OnbNBejLS2CRkEUXcSNw/ycCw7wKMC2n vkVktecHGQnSjyYmWfx15d+Kzxx14sRaDQJQEJD11DDztf5EtnhHOlkq+scpP94LnsND uM5UVhoxHcS50h6AQMKx9oItS5b47CMlWjfokmq+G9ShTjwXYHcxjA108iOxa+YZmkG2 5g3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=I8cdP6cF+nwTWlyfboIiQYyzWM6TGbsre5s255hDw1E=; fh=1D+qc4sAXkKNnQ3PxQy1SeTEtOqvF9vaWKsCr9vTrE0=; b=QPn/sOQJloBJvtLrsN9XMWBOsE4O7GlaMKDeyOOan1BWeqKnx1O+RhAdbF995a0ofc hdHoaf+MDXwZIYDPi12osutsqEwXZrsqP9bfWsuNcyS9wXSb3uyOL/rBR/lf9CZIcqL6 2xnlFKUgbzKTazqaJQKppcgvmMsl1j9jBp6gt9K5XuWjMml/xsmrFqcDW+2QQLVzM836 yvmtOdVQRFwh3zK1B0JUVm7soRQMEjfGbCma/nF2daDEa6ZdqOmFnPJV2MgZNt86Ea01 u+/cJdiMvRyjlG9n+IijlbvmNwKneHl1Bu3gPuLZ7+PjNRwDj+F1ZpnK9eYktg8mVXXP eISg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mailerdienst.de header.s=20200217 header.b=OGbX55DG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p3-20020a056a000b4300b0066879f2c3c8si6955866pfo.244.2023.06.29.11.51.40; Thu, 29 Jun 2023 11:51:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mailerdienst.de header.s=20200217 header.b=OGbX55DG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232345AbjF2Sn6 (ORCPT + 99 others); Thu, 29 Jun 2023 14:43:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232480AbjF2Sno (ORCPT ); Thu, 29 Jun 2023 14:43:44 -0400 Received: from mxout3.routing.net (mxout3.routing.net [IPv6:2a03:2900:1:a::8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 757AF2D55; Thu, 29 Jun 2023 11:43:36 -0700 (PDT) Received: from mxbox2.masterlogin.de (unknown [192.168.10.89]) by mxout3.routing.net (Postfix) with ESMTP id 92923605D4; Thu, 29 Jun 2023 18:43:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailerdienst.de; s=20200217; t=1688064214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I8cdP6cF+nwTWlyfboIiQYyzWM6TGbsre5s255hDw1E=; b=OGbX55DGj/xtkG/hWVz4Qo4R1i22zFNmJxp55CTfnwcpyzy+ao4f+YL/q9cUmFsKtmh3WQ SfRGV00+DKFU+AFks3cdLH1xvu04AOhJ1j452P0Cwd2PdgQB6gWydKc7cZXbj/KnAUW/gn Ox6Nxq39V7ltXPJoF8QFFi+sFdSePNc= Received: from frank-G5.. (fttx-pool-157.180.227.241.bambit.de [157.180.227.241]) by mxbox2.masterlogin.de (Postfix) with ESMTPSA id 916DD10009B; Thu, 29 Jun 2023 18:43:33 +0000 (UTC) From: Frank Wunderlich To: linux-mediatek@lists.infradead.org Cc: Frank Wunderlich , Chaotian Jing , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Wenbin Mei , Sam Shih , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Eric Woudstra , stable@vger.kernel.org Subject: [PATCH v2 2/2] arm64: dts: mt7986: fix emmc hs400 mode without uboot initialization Date: Thu, 29 Jun 2023 20:43:18 +0200 Message-Id: <20230629184318.551317-3-linux@fw-web.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230629184318.551317-1-linux@fw-web.de> References: <20230629184318.551317-1-linux@fw-web.de> MIME-Version: 1.0 X-Mail-ID: 79a3025b-a2bb-4026-a6d2-40902656f0e4 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, T_SPF_TEMPERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770064150550437180?= X-GMAIL-MSGID: =?utf-8?q?1770064150550437180?= From: Eric Woudstra Eric reports errors on emmc with hs400 mode when booting linux on bpi-r3 without uboot [1]. Booting with uboot does not show this because clocks seem to be initialized by uboot. Fix this by adding assigned-clocks and assigned-clock-parents like it's done in uboot [2]. [1] https://forum.banana-pi.org/t/bpi-r3-kernel-fails-setting-emmc-clock-to-416m-depends-on-u-boot/15170 [2] https://github.com/u-boot/u-boot/blob/master/arch/arm/dts/mt7986.dtsi#L287 Cc: stable@vger.kernel.org Fixes: 513b49d19b34 ("arm64: dts: mt7986: add mmc related device nodes") Signed-off-by: Eric Woudstra Signed-off-by: Frank Wunderlich Reviewed-by: AngeloGioacchino Del Regno --- arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi index 68539ea788df..207510abda89 100644 --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi @@ -374,6 +374,10 @@ mmc0: mmc@11230000 { reg = <0 0x11230000 0 0x1000>, <0 0x11c20000 0 0x1000>; interrupts = ; + assigned-clocks = <&topckgen CLK_TOP_EMMC_416M_SEL>, + <&topckgen CLK_TOP_EMMC_250M_SEL>; + assigned-clock-parents = <&apmixedsys CLK_APMIXED_MPLL>, + <&topckgen CLK_TOP_NET1PLL_D5_D2>; clocks = <&topckgen CLK_TOP_EMMC_416M_SEL>, <&infracfg CLK_INFRA_MSDC_HCK_CK>, <&infracfg CLK_INFRA_MSDC_CK>,