From patchwork Thu Jun 29 18:26:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 114391 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp9829817vqr; Thu, 29 Jun 2023 11:26:36 -0700 (PDT) X-Google-Smtp-Source: APBJJlHgRcRXzHWrLcMLWpskacwuzfH8/ohvRW6fUj6SX4FXAX8LH5nvG7AIBeZA19GFwIKjXn3j X-Received: by 2002:a05:6512:360d:b0:4fb:9884:43d8 with SMTP id f13-20020a056512360d00b004fb988443d8mr565286lfs.43.1688063196730; Thu, 29 Jun 2023 11:26:36 -0700 (PDT) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id n25-20020a05640206d900b0051d8ad06774si6277022edy.619.2023.06.29.11.26.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jun 2023 11:26:36 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=O0rmP2j+; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 410863858412 for ; Thu, 29 Jun 2023 18:26:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 410863858412 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1688063195; bh=fVzsdSQI9OvFVlq8hSeLXZkQRHHflZlqBpmy0YiJ9fk=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=O0rmP2j+4UNd+5ixlBHMPnK5E3YJuvoktiXrxLeiAs768vtToATyytJffyDATe7+G bzqcPDoDCyjsgkcM49OczECdh8io5FmSRYrojVkcFJ24/fGBAFzPiJPd0maDAIb5rW vouNs8CeTMv7VshJty+qv4Fd+4sL63tt74mVasIs= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id B95B03858CD1 for ; Thu, 29 Jun 2023 18:26:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B95B03858CD1 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35TH47XF028554 for ; Thu, 29 Jun 2023 18:26:25 GMT Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3rf40ebq9d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 29 Jun 2023 18:26:25 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 35TGoCC2004004 for ; Thu, 29 Jun 2023 18:26:24 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2173.outbound.protection.outlook.com [104.47.55.173]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3rdpxdsqaf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 29 Jun 2023 18:26:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=me4L/fIJ7jueHt07JYtxAifjoU67dgVRszRx7rqKSfEBRi6fKcFUoaRlXNrhAna/7+t7f29G+wo7xVluNPsNcUPlT/+FICrRV51ejTEFWtAu2wfBq53bIUWJ1qQ1uPdvgfHUG/7QmnG0oNnq9SzneagzuiFgku+bt4LLYEXnM96YlggEQxvU/rNM/hnDiOd5P/9AMAbT73kkcOQcNVxAARvD4Pq9YCwXFlSHwc81Z7scI0Qz2FS4QXNVoknQfzxeDTIpWD0Kh7KTDAMVbj1W4owmpFw8L545rcrRh/TehymBttl/2RlewMPJuNLQ/VXFY+RsCz/Hf3WADbatYZTq9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fVzsdSQI9OvFVlq8hSeLXZkQRHHflZlqBpmy0YiJ9fk=; b=duXQYqsVqOgG0Ugya9twga1tDlIQHPtQrPQDa0mA0XP7P1KKe4GyKkE4KuS6nS+wH47nWZ5zklnLyELwqnNcoBnxdiLElOxLgN8HrmSBY+Q8Vc9YkV84BHHDC2GxnC4I/9VEI8njoYTY2FlfxHpZbl9dtUFNZgBMGtWgkJp16fJiJYHpiFSZa93ELTt42YAnU9pSy6VP0k0zxSeM8oJNGmsWSxqxTb98kqBqJsVGJ2JgzCBRt0Bdl16ClIqVGHl3ZUrD0R1XIhza5pnxo8egDiNsA0gKm06HSfEQqdOMHayuJd6rf/jiEhPJv49Fs9QZMTEYoRy9qBjuVFENUanDvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by CH2PR10MB4248.namprd10.prod.outlook.com (2603:10b6:610:7e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Thu, 29 Jun 2023 18:26:22 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6521.026; Thu, 29 Jun 2023 18:26:22 +0000 To: binutils@sourceware.org Cc: Indu Bhagat Subject: [COMMITTED] libsframe: fix sframe_find_fre for pltN entries Date: Thu, 29 Jun 2023 11:26:18 -0700 Message-Id: <20230629182618.2351051-1-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 X-ClientProxiedBy: MW4PR04CA0202.namprd04.prod.outlook.com (2603:10b6:303:86::27) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|CH2PR10MB4248:EE_ X-MS-Office365-Filtering-Correlation-Id: e82f26e2-76f2-4cbd-d04b-08db78ce56fd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: khNlpXcL43Sh2rMeaScxGOsx7E7+PJK+hM4GVdXMm7tNVgrfBhbEgGATOFywzK8aGHus/OyJdHNn/2oMdGiwJx0yXy9qZTN35sAKf5XDPivh61oNiV0KdF6/4IE0H3xFzrHB2MYGBiQgyUDPbkJC6fnM0Qek/QSO1CkuUrRM8n9J7FsPBuZKjQb7JQmhjscS1edafBhwI1qDIKkzGX5Py+4Oj5HSgx2xYZyv2ckAnFUE1kXtPhrWnCurSjN0ayUfj8NgQG1sZcxGHrJCja2KMa9GWJqsbHKE8fx86WhA9PzcC3mme57il0OhbvpTki1gH+oksozKE5nLZo+tVJM7dq08HjyaYWcC0Ugj+PYWnlyTTkfIYbnIKlM/C0P01RksUgtuPIoLMMiWueq83Vk5kNf+Ymm7PZ6ZPLGpz9eFC4fV0QHu+d4HZWReMLs1wUHXvX2P69cVGwh8ioswvI5IdmRIdWGjOkzRRJ+PJqXZobRT9Ib52zVXtyRuy2hDQGNvURk60u+x0v+LJVFSRgKGjeg7lyqgkiv+ftU0Hncd04aAa8CCMZmCjjjQAyNafgRL X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(396003)(376002)(136003)(346002)(39860400002)(451199021)(6512007)(66899021)(8936002)(26005)(66556008)(4326008)(66476007)(66946007)(6916009)(44832011)(86362001)(316002)(41300700001)(8676002)(5660300002)(38100700002)(6506007)(107886003)(36756003)(6486002)(186003)(2906002)(6666004)(83380400001)(1076003)(2616005)(478600001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: bo5TujM2lYsVFet4Uf1OiGgYEnnWumX59et1s+L0HwXrShWid8oaE2b/VbErYb/9h/c58Ma/ptU0eYmAf91Av9hgiY23LrF0ofnJuY3MABNe75OdVnKhZbLZCtjUim6UFG+F72sn1XxQ21UIZB4N8/AXUuRY6wvszMTBhRKCJJQyD+aNu38+FkAetyoY232l31EHTsQTTF2H+xk4Xf6Sgc8+FEnmKuODABYAXSmlWQrl1Nlr4ZLf0YlxdG0SGPTCY7TyfwG5VywtEJveFngmNd7M6cSUzc0l/RuOpHH8DYsH0B487IOsooG2H2AnawT4scUUl3PBPB7X5s2d//YQejkd0/R4/kGQAztT4Bg6tAz4QcnqeiZefUSuOO5Vfay5kmCIFOs6cuv+mb9hWNI5DvpifKzStKtjr6e6uDQIs1ozCR4edYYqE0qxwjmvzWaP04vXwqVbQNJD17BBa8s0dpQmDntyNSlEiZpF5x0oklZCIytqRJQw5urZiBGKZtFmHF66che9NiQAJGLVZfii2V2qX82jy6DxjpvicUrzgw+4akcWjzt5KsbOoAV7tgQoH0G3u5fVVc09W+71Hjp8r9sPmF8cnsWUy6I1vXwQ0kb9CugUVgYqlmL9/A+7oydxm++9a2dLY5Nnr6GOwsMHc/kDguaFuU9oxIAOWzNl27VHaUgkXS+fwLJyyRwaDpyMEJdACTIzGG3akjUltd30suzdUccrLaDrzD2lGXDnKQtfjj8FzhLWVKVQqNzfiZILvDtSZRm0cBXJI+9bfAwRsB4ubpB28pW8WtUu8V38bWOyxF8i5+r0gz/3GaHVmU9Lbrrx0PNBXtH+Yh0CFWOiscQcSXm4kaiz1nN+AnhcZq/OKXnZyuIK8Ugla7BrSd6FigxoUSoApm2JVIk9V+NYL/eQ/deM/Z2i9g3jxl7SY+Mc1WAJEb/xb40nv1Su5u+aATOqlmtnRdi34cyD14VR4gRn46GwVBiqj79KdbI6e7gngEF8ZsKpByNaEOh2Y554eUJNrZ6WfrbXPxtCacY7SdG8gauA3XJmcLg+praw8p8k5U/d4AsU0Vbeyo753aKxSrGcPFSAyDHx2Yr/dlGH9kjK2OmP1YF0tITKEp+XjfxXWlRuwOLh7pMQ1CYQR7JSRKD/arx9Ea+LxxND2vPvm29vn8x30DC3NxVCc4AnVD8SzTWJrzmgDJaAKuWgxN7OuowTzrGBxkWbpwNzM0LyRf05hWGooX0OQL9i6LBoBCgPb4ju0R20YoXL7jFMYkQgKr7YplylHMv0r9rBh8vcQOmtvZAXO9nmw85Xknv64slDqmaDjpGaGsXKARUYy9m06kzVbMcbnNWxHmWoX7zJ/pdNcj/ZY93rPBvYd+OiYdf0oYphhQvMdUqhvvanJRGMnHxjYx46b76H1Srxjr8rShEAWbl+TT7nrV106kr8/77ytjJSfwbA6iorgXctav7ZN2hy8P7kq+YslGqxCsmYqNZozQIE+CpddnhJoEm2kuzzkWiWjBMINh71yxktsumWRMOgX0atzyle3pPq/TTdqJXihikLJeP85sKWXktQTrdqdfMX8Jy0bz41k4RLTLbQ X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: pfj1rSmYmQZ3syBqlqpjEOo8BPYx9LCVtEw+9ThR+9P1s16xDDq63HBz72nw69xd+LsB1Cv20m0NEaDMOJ0Oxfnk9x9jga40WrZ5oTBAdl2yEm3KmiSlto2LDT9xMyPL+AG/RXMxHvhNdF9SdpJH39mBNpA1xL/ledvp5AGylMlu7/oD4EasedIcAaF+XzZnqlI4hx+w1f+G78TniQ/NpT9t02QXPv2Nn5Sokqtfhp299Yab5/SPv8tVTKONjwnJICthHXWq90ybILniMYLIr0Atz1al1yILIOm975d7VosFLei+rpr1IhFB5d5TeUMUE3gNn9EDPccFwTluoIHUE6fWblGAKVAO2/5yeiJHxM3TslTJ+ruAEsNzNu4kXUkDnbjpBO4hdUDstGE1zmaWycllorayOYlF3Sa72fc2yWIX7hn8m29N4zTkNkv5B9tKsRnSVcIuAQB/SdJXQ7iO8C7P+e+CEusqEYqGJzRr4CWQMsquQuV5mHhHdfekzoBzudblCKnNM5GFk1gCMvUFnpu2u7REdMf77G+qWS5aAdrdS21XnltD3PKUEuVtkxRM+mFPydgn6fMEOT4UyDOh1znHLwr6awTufRPtq5oV6SN3Tc2Ww3+etkLSTcrGYqlE2ty0v57ryfXD9iYV7KCYMWQ/NW+lFAznbmLQqqc2CHpeHoRB87yHeU4uETPYju0sIO7ALi3SmBZga6iMSuTK4W8hS+WWbJVrJ8KsZ/kUM3zreTQtstUBpI5NA+fdOyN7 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e82f26e2-76f2-4cbd-d04b-08db78ce56fd X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 18:26:22.4247 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +RqklgA3MZNmBZyvUvFqVQwyFYwoSAVBw56TJz3Ruk393qs88e5TvlJwBTl6Qr7zWJtpwlR59wXr7D/UhidCOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4248 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-29_06,2023-06-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 spamscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306290166 X-Proofpoint-GUID: mMB30v4AOVkyJA-V5AH3X2H3dRecyArS X-Proofpoint-ORIG-GUID: mMB30v4AOVkyJA-V5AH3X2H3dRecyArS X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Binutils From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770062554639348487?= X-GMAIL-MSGID: =?utf-8?q?1770062554639348487?= For a toy application on x86_64, for example, following is the SFrame stack trace information for the 3 pltN entries of 16 bytes each: func idx [1]: pc = 0x401030, size = 48 bytes STARTPC[m] CFA FP RA 0000000000000000 sp+8 u u 000000000000000b sp+16 u u The data in first column is the start_ip_offset. Also note that the FDE is of type SFRAME_FDE_TYPE_PCMASK (denoted by the [m] on LHS). Where each pltN (note: excluding plt0 entry) entry looks like: 401030: jmp *0x2fca(%rip) 401036: push $0x0 40103b: jmp 401020<_init+0x20> 401040: jmp *0x2fc2(%rip) 401046: push $0x1 40104b: jmp 401020<_init+0x20> 401050: jmp *0x2fba(%rip) 401056: push $0x2 40105b: jmp 401020<_init+0x20> Now, to find SFrame stack trace information from an FDE of type SFRAME_FDE_TYPE_PCMASK, sframe_find_fre () was doing an operation like, (start_ip_offset & 0xf) >= (pc & 0xf) This works for pltN entry of size, say, less than 16 bytes. But if the pltN entries or similar code stubs (for which SFrame FDE of type SFRAME_FDE_TYPE_PCMASK may be used), evolve to be of size > 16 bytes, this will cease to work. To match the range covered by the SFrame FRE, one should instead perform a modulo operation. The constant for the modulo operation must be the size of the pltN entry. Further, this constant should ideally be encoded in the format, as it may be different for each ABI. In SFrame Version 2 of the format, we will move towards encoding it explicitly in the SFrame FDE. For now, fix up the logic to at least move towards modulo operation. libsframe/ * sframe.c (sframe_fre_check_range_p): New definition. (sframe_find_fre): Refactor a bit and use the new definition above. include/ * sframe.h (SFRAME_FDE_TYPE_PCMASK): Update comment. libsframe/doc/ * sframe-spec.texi: Fix the text for SFRAME_FDE_TYPE_PCMASK FDE type. --- include/sframe.h | 4 +- libsframe/doc/sframe-spec.texi | 6 ++- libsframe/sframe.c | 78 ++++++++++++++++++++++++---------- 3 files changed, 62 insertions(+), 26 deletions(-) diff --git a/include/sframe.h b/include/sframe.h index c3dbb3a4097..cdf275f69e4 100644 --- a/include/sframe.h +++ b/include/sframe.h @@ -117,8 +117,8 @@ extern "C" /* Unwinders perform a (PC >= FRE_START_ADDR) to look up a matching FRE. */ #define SFRAME_FDE_TYPE_PCINC 0 -/* Unwinders perform a (PC & FRE_START_ADDR_AS_MASK >= FRE_START_ADDR_AS_MASK) - to look up a matching FRE. */ +/* Unwinders perform a (PC % REP_BLOCK_SIZE >= FRE_START_ADDR) to look up a + matching FRE. */ #define SFRAME_FDE_TYPE_PCMASK 1 typedef struct sframe_preamble diff --git a/libsframe/doc/sframe-spec.texi b/libsframe/doc/sframe-spec.texi index 5155410bdc8..a37a6f91414 100644 --- a/libsframe/doc/sframe-spec.texi +++ b/libsframe/doc/sframe-spec.texi @@ -451,8 +451,10 @@ entries and trampolines. @item SFRAME_FDE_TYPE_PCMASK @tab 1 @tab Unwinders perform a @* -(PC & FRE_START_ADDR_AS_MASK >= FRE_START_ADDR_AS_MASK) -to look up a matching FRE. +(PC % REP_BLOCK_SIZE @* + >= FRE_START_ADDR) +to look up a matching FRE. REP_BLOCK_SIZE is the size in bytes of the +repeating block of program instructions. @end multitable diff --git a/libsframe/sframe.c b/libsframe/sframe.c index 29142436b84..fd966cfffd4 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -362,6 +362,53 @@ sframe_decoder_get_funcdesc_at_index (sframe_decoder_ctx *ctx, return fdep; } +/* Check whether for the given FDEP, the SFrame Frame Row Entry identified via + the START_IP_OFFSET and the END_IP_OFFSET, provides the stack trace + information for the PC. */ + +static bool +sframe_fre_check_range_p (sframe_func_desc_entry *fdep, + int32_t start_ip_offset, int32_t end_ip_offset, + int32_t pc) +{ + int32_t start_ip, end_ip; + int32_t func_start_addr; + uint32_t rep_block_size; + uint32_t fde_type; + int32_t masked_pc; + bool mask_p; + bool ret; + + ret = false; + /* FIXME - the rep_block_size should be encoded in the format somehow. For + AMD64, each pltN entry stub in .plt is 16 bytes. */ + rep_block_size = 16; + + if (!fdep) + return ret; + + func_start_addr = fdep->sfde_func_start_address; + fde_type = sframe_get_fde_type (fdep); + mask_p = (fde_type == SFRAME_FDE_TYPE_PCMASK); + + if (!mask_p) + { + start_ip = start_ip_offset + func_start_addr; + end_ip = end_ip_offset + func_start_addr; + ret = ((start_ip <= pc) && (end_ip >= pc)); + } + else + { + /* For FDEs for repetitive pattern of insns, we need to return the FRE + where pc % rep_block_size is between start_ip_offset and + end_ip_offset. */ + masked_pc = pc % rep_block_size; + ret = ((start_ip_offset <= masked_pc) && (end_ip_offset >= masked_pc)); + } + + return ret; +} + static int flip_fre (char *fp, uint32_t fre_type, size_t *fre_size) { @@ -1056,19 +1103,14 @@ sframe_find_fre (sframe_decoder_ctx *ctx, int32_t pc, { sframe_frame_row_entry cur_fre; sframe_func_desc_entry *fdep; - uint32_t fre_type, fde_type; - uint32_t end_ip_offset, i; - int32_t start_ip, end_ip; + uint32_t fre_type, fde_type, i; + int32_t start_ip_offset; int32_t func_start_addr; + int32_t end_ip_offset; const char *fres; size_t size = 0; int err = 0; - /* For regular FDEs (i.e. fde_type SFRAME_FDE_TYPE_PCINC), - where the start address in the FRE is an offset from start pc, - use a bitmask with all bits set so that none of the address bits are - ignored. In this case, we need to return the FRE where - (PC >= FRE_START_ADDR) */ - uint64_t bitmask = 0xffffffff; + bool mask_p; if ((ctx == NULL) || (frep == NULL)) return sframe_set_errno (&err, SFRAME_ERR_INVAL); @@ -1080,14 +1122,7 @@ sframe_find_fre (sframe_decoder_ctx *ctx, int32_t pc, fre_type = sframe_get_fre_type (fdep); fde_type = sframe_get_fde_type (fdep); - - /* For FDEs for repetitive pattern of insns, we need to return the FRE - such that (PC & FRE_START_ADDR_AS_MASK >= FRE_START_ADDR_AS_MASK). - so, update the bitmask to the start address. */ - /* FIXME - the bitmask should be picked per ABI or encoded in the format - somehow. For AMD64, the pltN entry stub is 16 bytes. */ - if (fde_type == SFRAME_FDE_TYPE_PCMASK) - bitmask = 0xf; + mask_p = (fde_type == SFRAME_FDE_TYPE_PCMASK); fres = ctx->sfd_fres + fdep->sfde_func_start_fre_off; func_start_addr = fdep->sfde_func_start_address; @@ -1098,15 +1133,14 @@ sframe_find_fre (sframe_decoder_ctx *ctx, int32_t pc, if (err) return sframe_set_errno (&err, SFRAME_ERR_FRE_INVAL); - start_ip = func_start_addr + cur_fre.fre_start_addr; + start_ip_offset = cur_fre.fre_start_addr; end_ip_offset = sframe_fre_get_end_ip_offset (fdep, i, fres + size); - end_ip = func_start_addr + end_ip_offset; - if ((start_ip & bitmask) > (pc & bitmask)) + /* First FRE's start_ip must be more than pc for regular SFrame FDEs. */ + if (i == 0 && !mask_p && (start_ip_offset + func_start_addr) > pc) return sframe_set_errno (&err, SFRAME_ERR_FRE_INVAL); - if (((start_ip & bitmask) <= (pc & bitmask)) - && (end_ip & bitmask) >= (pc & bitmask)) + if (sframe_fre_check_range_p (fdep, start_ip_offset, end_ip_offset, pc)) { sframe_frame_row_entry_copy (frep, &cur_fre); return 0;