From patchwork Thu Jun 29 08:12:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 114210 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp9475058vqr; Thu, 29 Jun 2023 01:13:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6F5c15BgEtU/JbNvPLv58fPbQCxyPTfkrL533yfZeq8SbPCYe4+UlNCgw9Zr0Y+Kzj4Ior X-Received: by 2002:a17:907:3f29:b0:973:8cb7:4d81 with SMTP id hq41-20020a1709073f2900b009738cb74d81mr39180452ejc.49.1688026390319; Thu, 29 Jun 2023 01:13:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688026390; cv=none; d=google.com; s=arc-20160816; b=H1wkPaBBXra39tTVC8txUuuYuaa4qR+ZWI5o0T3fC8+HuHCNod3tmkC3z3xAnF855V GIyQQzu1AO/s0ZDt0+F0qiFhiwa+cW1plYimpmj17nbrHZUPtEGjPpS4LAPrnQscSmpf 66v5Wvlc2BGdg30lIivMMid34QQlujc4k9tUo0VaCW8qwWbSLP2OMGmx+S4gAJxVBp82 STvgRL2m9+sIwSOSbYNLwana7M7p7lNB8Sx43518QPo2MNmyeY8KHJumSvwIfNCVlkKQ p9PmuGLtu7zTlniSlRCrBw06m/KxHyN7PCzhOD3JfeUQeeMT71bHhyMzTEaGU3Mmzv7H j0Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:sender:errors-to:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:user-agent:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=ko0nH4jH+NVFoVn+nGGpWUtxCCFeuSGiiDIwEMv3MQ4=; fh=hPrbWPhweUx4V0GV9uXJqbyAzg2ABmTz7kczrAQqMmM=; b=W5wI+PeiPAz5oDdop3KzemEq+YuKPgTXmUo/GkHNcGKKX8SAIzabnrAmbSK/0vuF+g 1cR7UT4OZjVgBByFeQ9SIH6B5oLHgk6p9E6Mm7+7SIX0O3wUzR5DWD/tGrGWAQUmIxVZ x5K9nvpQcGvTToaEtWVUQGLnldNExZyjWE7Dpvi2npbJ4OsDvwHB6HZhL+g2CFcqb0Gh iEt70R/n3ulcR9KaFDxYRbYeCgaRbFt3o4HW74CR5vFgygXjyqeFm72QonSOSvNKmrqY L4JwMY2G8q7zFZrj67omQkbkPuFEfzUwgEJ7jbclA5i7z+H05NxdkAbMKptjc2pK6Uqe JXMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=DIl3MGdP; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id z20-20020a170906945400b0098e31cd141dsi5593390ejx.744.2023.06.29.01.13.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jun 2023 01:13:10 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=DIl3MGdP; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 965F13858C74 for ; Thu, 29 Jun 2023 08:13:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 965F13858C74 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1688026381; bh=ko0nH4jH+NVFoVn+nGGpWUtxCCFeuSGiiDIwEMv3MQ4=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=DIl3MGdPo9UB5D+aafidfpjAPrSZ6nzVZyid9B3vfcpEhRIFwX3igwISGpQAFr8NT WckJ7NOMBFvD5cnaTDviPlbCDBQk25UaRTwupJ6KzVSCd6yyeKHojdoaQ65cFhlPGu MS07C19qt9TnO8l3VFU3SbgDmPNuevbtm9fv8GqQ= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id CBE293858C1F for ; Thu, 29 Jun 2023 08:12:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CBE293858C1F Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id E7D0C21864 for ; Thu, 29 Jun 2023 08:12:18 +0000 (UTC) Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id DC36B2C141 for ; Thu, 29 Jun 2023 08:12:18 +0000 (UTC) Date: Thu, 29 Jun 2023 08:12:18 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [PATCH] c/110454 - ICE with bogus TYPE_PRECISION use User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" Message-Id: <20230629081301.965F13858C74@sourceware.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770023960269383944?= X-GMAIL-MSGID: =?utf-8?q?1770023960269383944?= The following sinks TYPE_PRECISION to properly guarded use places. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed as obvious. PR c/110454 gcc/c/ * c-typeck.cc (convert_argument): Sink formal_prec compute to where TYPE_PRECISION is valid to use. * gcc.dg/Wtraditional-conversion-3.c: New testcase. --- gcc/c/c-typeck.cc | 5 +++-- gcc/testsuite/gcc.dg/Wtraditional-conversion-3.c | 9 +++++++++ 2 files changed, 12 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/Wtraditional-conversion-3.c diff --git a/gcc/c/c-typeck.cc b/gcc/c/c-typeck.cc index 22e240a3c2a..7cf411155c6 100644 --- a/gcc/c/c-typeck.cc +++ b/gcc/c/c-typeck.cc @@ -3385,8 +3385,6 @@ convert_argument (location_t ploc, tree function, tree fundecl, conversions. */ if (warn_traditional_conversion || warn_traditional) { - unsigned int formal_prec = TYPE_PRECISION (type); - if (INTEGRAL_TYPE_P (type) && SCALAR_FLOAT_TYPE_P (valtype)) warning_at (ploc, OPT_Wtraditional_conversion, @@ -3429,6 +3427,8 @@ convert_argument (location_t ploc, tree function, tree fundecl, else if (SCALAR_FLOAT_TYPE_P (type) && SCALAR_FLOAT_TYPE_P (valtype)) { + unsigned int formal_prec = TYPE_PRECISION (type); + /* Warn if any argument is passed as `float', since without a prototype it would be `double'. */ if (formal_prec == TYPE_PRECISION (float_type_node) @@ -3472,6 +3472,7 @@ convert_argument (location_t ploc, tree function, tree fundecl, && INTEGRAL_TYPE_P (type) && INTEGRAL_TYPE_P (valtype)) { + unsigned int formal_prec = TYPE_PRECISION (type); tree would_have_been = default_conversion (val); tree type1 = TREE_TYPE (would_have_been); diff --git a/gcc/testsuite/gcc.dg/Wtraditional-conversion-3.c b/gcc/testsuite/gcc.dg/Wtraditional-conversion-3.c new file mode 100644 index 00000000000..796f2eb8845 --- /dev/null +++ b/gcc/testsuite/gcc.dg/Wtraditional-conversion-3.c @@ -0,0 +1,9 @@ +/* { dg-options "-Wtraditional-conversion -Wno-psabi" } */ + +typedef int __attribute__((__vector_size__ (4))) V; + +void +foo (V v) +{ + foo (v); +}