From patchwork Wed Jun 28 15:33:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 113957 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp9018110vqr; Wed, 28 Jun 2023 08:37:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ76c1nYvM9FqEiBqsWMvJ+y/vSVwVXmfPVziFz9kSJCNiFFwQAPu6M+J3Q2zEsEzAD9AM5C X-Received: by 2002:a2e:990a:0:b0:2b5:8bb9:4dd6 with SMTP id v10-20020a2e990a000000b002b58bb94dd6mr14503165lji.12.1687966673273; Wed, 28 Jun 2023 08:37:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687966673; cv=none; d=google.com; s=arc-20160816; b=i0U0TvMHqlr0hqH0QuHr/C9KnKA6Pstutk5aMzUx/hlCfTQabZ8LLb2zpE77wcE/n5 p2Ox5D/QxfCjjzbiulMNiuvGzaq1+HP5LIkTRmsyupG2KOleTNcoh04MGf1hgaAjz5om mBUkE0qJDfbWVcC3MeJULSHYXJ89vkeAKtLgYrjWKHrpRTFkXgY81sxNWEbD6ciwaYTU 1ECYc/4YviOf9csMz30fL/4VJksPJXGTkNMzCn00bmmbZr19ww7dk6ZwEmcPI4Qhmi/f Mq05YLrrKe1EvfjZXkv0IHghbobzIG9NXZn+WWihuEB25HAlcJ3IW0SsDw3PCN6WQrrW vhRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=QUot3id03Fi4Q0nI8wc0vO323eixpfAxso0J0rUzMvU=; fh=YEBSwHLBxseWd1htZdUMtd2T+IT5f789+YFsDanJEZY=; b=z+L1tk18aCGdbJ/jBfOFngTBoiZmZYeZRE3jqmKhe5Hmo2GofQz9CM0G9jsMG6WteQ mcQArl20bt5bU64IA2epl2dS1/yozH0EwsFaJeuBhTwBgrODrahlo/hTHlOJcNo1B4GZ 9J+bWOVtqhCpXnsTbkby3tZoSImww3sfJv/WLUftxmytp0CIvMcb39YTtuIr2MYZb5NL +lYyj9ZBpNBR9BRmA1/G3ArpmCkenUNqg/ZgsmBQypGKo3Fap/OTk50B+oJh1lRiCyxn LEWM3I3P+MopJYlwni4cThmNUw0pNZodFeGXSdSF6NRaWvsTiG9vg/2Q+XnRRVp0IMUR qaHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NSAl2M3Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bm6-20020a170906c04600b00982a36463c9si5772348ejb.518.2023.06.28.08.37.28; Wed, 28 Jun 2023 08:37:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NSAl2M3Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232662AbjF1Pfa (ORCPT + 99 others); Wed, 28 Jun 2023 11:35:30 -0400 Received: from mga09.intel.com ([134.134.136.24]:20036 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232553AbjF1PeV (ORCPT ); Wed, 28 Jun 2023 11:34:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687966461; x=1719502461; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=UM29w6YmyINBXCk6A+fAcfZ7rP6qST6yVT5akSdbQhM=; b=NSAl2M3Qb7rt9maR/OndmlJiJtvLSUjGJRAKOR45dstxFoaY0psrg0p8 6y1td1N3yEAjfrvrSh/WNQz6bU2p/3keXXnPBrj+NnVHkx5yBTsYaD/bB CRfg3+4KIrOWWIs+LAhmuU8qzIQ/m6+qPEH0cl2Iqj32LXnh7g98t9oc+ We1mga/xAsbx6NyNR9upN2QuNt78EtfO5tHI6kKGJtsrXWhl2llVPNGQJ wY8KURaXyV8A2mpu+gct9Fy60ueF6uXZZ6GRPpREn5Cl+eTXL9eJ9f3Bc bkDwjukQq+IJtEpyTZu2FMeGJJNPFbni9OtHU5X+bfFusI6zvpXLgGwGI w==; X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="364427621" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="364427621" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2023 08:33:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="782344837" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="782344837" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP; 28 Jun 2023 08:33:47 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 4BDDDE1; Wed, 28 Jun 2023 18:33:48 +0300 (EEST) From: Andy Shevchenko To: Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Andy Shevchenko Subject: [PATCH v1 1/1] kasan: Replace strreplace() with strchrnul() Date: Wed, 28 Jun 2023 18:33:42 +0300 Message-Id: <20230628153342.53406-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769961342236014879?= X-GMAIL-MSGID: =?utf-8?q?1769961342236014879?= We don't need to traverse over the entire string and replace occurrences of a character with '\0'. The first match will suffice. Hence, replace strreplace() with strchrnul(). Signed-off-by: Andy Shevchenko --- mm/kasan/report_generic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/kasan/report_generic.c b/mm/kasan/report_generic.c index 51a1e8a8877f..63a34eac4a8c 100644 --- a/mm/kasan/report_generic.c +++ b/mm/kasan/report_generic.c @@ -264,6 +264,7 @@ static void print_decoded_frame_descr(const char *frame_descr) while (num_objects--) { unsigned long offset; unsigned long size; + char *p; /* access offset */ if (!tokenize_frame_descr(&frame_descr, token, sizeof(token), @@ -282,7 +283,7 @@ static void print_decoded_frame_descr(const char *frame_descr) return; /* Strip line number; without filename it's not very helpful. */ - strreplace(token, ':', '\0'); + p[strchrnul(token, ':') - token] = '\0'; /* Finally, print object information. */ pr_err(" [%lu, %lu) '%s'", offset, offset + size, token);