From patchwork Tue Jun 27 19:51:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 113564 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp8435488vqr; Tue, 27 Jun 2023 12:53:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6jLwlC7r7KZIKUlYvEuCiV2iC51JV3vuifVGj1VPOWFHdJL1BTwxnd/CFKUuEoovIxjNiX X-Received: by 2002:a17:907:6da2:b0:98e:48cc:4cbf with SMTP id sb34-20020a1709076da200b0098e48cc4cbfmr7941778ejc.26.1687895591113; Tue, 27 Jun 2023 12:53:11 -0700 (PDT) Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id x26-20020a1709064bda00b00991f9f3b83bsi1802935ejv.228.2023.06.27.12.53.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 12:53:11 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=xMhtv9ow; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 79E403856DD6 for ; Tue, 27 Jun 2023 19:52:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 79E403856DD6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1687895571; bh=kCDhClx4cPKSGvGDH66n6miMUd5DZ9THHk5UVfjtCTw=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=xMhtv9ow1ERsCd0yJy8yAIa9Y3GFWX4/EWXenhlwg1TIHwAZyCEulzL5wDdFyZv9h gDgw6I7Cmum+sHrkPil5IgXHSv7KPW4P88Ec3IumzE7zL23Fgh6SAnZcYsj2X9o8dz EN6uoZmsedTXENMpMNONCU2ogfo6VYh4UtwuM6aU= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 0777D385841C for ; Tue, 27 Jun 2023 19:52:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0777D385841C Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35RJCFKI008598 for ; Tue, 27 Jun 2023 19:52:23 GMT Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3rf40e44u1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 27 Jun 2023 19:52:23 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 35RJlRXN003969 for ; Tue, 27 Jun 2023 19:52:22 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2172.outbound.protection.outlook.com [104.47.59.172]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3rdpxb0uc5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 27 Jun 2023 19:52:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OUfRAT4WzYSzVQMM+UbgHdmeipyMeY5svFByPumZAQ5qhv2sPbrKVtzlJ0U5htLJ4VvR+Vp925tCgtnv3uyHFgz/LvfXxcu6p6N+h+xzNf6t4nuANMaHWzShH4n7jItKnNHGEzU6M6HY3PB1nfqEv9Ba+pLdSHvGirpbIZIZbcqmmV+Xbo2oiY7lCuFJ19uvzoNJjzu+YK1/dfJ5RKkI8gt4XEsdD2nJ7Jvk2QYSqdb9oRaV8UjAshPQLxepYo6cdyQOrtqcc9mCVT8oTCDXwwl55LmPOorB5xlbwZmrh0sQIK64vqSWw1jS01NF48iuIIi01Ci0EPWpGG6lWdvRHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kCDhClx4cPKSGvGDH66n6miMUd5DZ9THHk5UVfjtCTw=; b=LSYGi1Gv9mrsRvEJc+0pdD/qjbFmCnOedMe6TGHGcIKEsUqrPduN2lFJEQIuGf2wRyzbwl6nMVb1d0ap3FLarSE+iSh32fP+1Ug5Y6g/1XqBhBg0lFavmd8Ax7niEdkt1qFqRxf1gTVNzKsMY5DwKceKQYLi/O89HkV/RZuCph5dtglZ6on/u7WSaiuIPZB6AU4QK30z3HIMsfzwLoJ9r1Vds3Lle/df9oSdWeoHyAnoEQhn8bKcVk4Zerbg9f7N8TgUfNISaqaLvuUP4fIXNwUh0UMUHe/m7PFirERSlMmiBRwveCd89masWet5RrliOVcdrrg+ZS3/wXtDzFNyRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by BLAPR10MB5361.namprd10.prod.outlook.com (2603:10b6:208:325::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Tue, 27 Jun 2023 19:52:19 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6521.026; Tue, 27 Jun 2023 19:52:19 +0000 To: binutils@sourceware.org Cc: Indu Bhagat Subject: [COMMITTED] libsframe: use uint8_t for return type of sframe_fre_get_base_reg_id Date: Tue, 27 Jun 2023 12:51:23 -0700 Message-Id: <20230627195126.1955051-9-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230627195126.1955051-1-indu.bhagat@oracle.com> References: <20230627195126.1955051-1-indu.bhagat@oracle.com> X-ClientProxiedBy: MW4PR04CA0174.namprd04.prod.outlook.com (2603:10b6:303:85::29) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|BLAPR10MB5361:EE_ X-MS-Office365-Filtering-Correlation-Id: 640d6dfe-8434-4e35-bf49-08db7748040d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xbIkkguB1SrhBTppalUOnJPDfYiGkogIdY8Q9PGm7nknPNg5dwBRUQQ2b9oJUje14U5jRYiP4NbyB9sCLmUamZhTOF0gWj/IWlLF1bow30qFjsFAnrHRWTlPdBF0ehL5g01gBrq0jst6BI0j+f82YYhithDX1GB4TEUEddt/7iNz6QIDCUnTYi7TEumFmlhyK5kjNIXrkbvqpMW6L+w/xMrQE/oLpe6t7vEPS33bApUigwmX2yiXH9kONfdvFqZrRK4hJWbUnbSgnTS3ZOQKpbG3UYUAHVe90riBqnEdUqGVWSDOwoLiNccVwp8VC+DDESODsyIcrYQpxpd0qwHXhJ2SpowM1XYZtZs3t23trSM6BPG1URtszGWCwp6iBG+k5PVaSA1Tj4grW0gG/YSJNsXOJ5PE2WAmkYyRzrtT+tThiZUp7V4hJ/gdfoVZqAxbVbNxjJfAAYhDEKH2NTVSRgiaUjvY7FG+hLx7iFACVb9n39Ng/QzAsemMUP3QB6ErWbcOiMJP/p74mVl0Go0td6dLAZYv7q/EiQxXHBTb6VSA8PR2H29APkY1gFWHT5BB X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(346002)(39860400002)(396003)(366004)(136003)(451199021)(1076003)(107886003)(6486002)(83380400001)(6666004)(26005)(2906002)(2616005)(6512007)(6506007)(478600001)(186003)(5660300002)(44832011)(36756003)(38100700002)(316002)(4326008)(66946007)(66476007)(41300700001)(8936002)(8676002)(66556008)(86362001)(6916009); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ocBCbJdigvlWAPr+GlJirzNeKi42icAjk8lUbLmyT3TM21nSBWbsvBDKSz3A60htPqZIOgOlb/niK7T5//luy5vzfokYfMwW85w+2DVnislu+gURQsHJyIqPsQ7FrMrqBXE9sVzxvQ3MaleU4Hj0Z+qf9Wrdp6vSOjhSDPdDzZD49pd8gSXHBYG61MoAgzgXyIE8Q0MN7cWwKYuHGLBedjaMBXyUWbg6+mvrgQjOwBBjFimCfU/LHtpqars36jxf83vCS89tirshtlH/9A2Rtou9ROx4WtUGqYQIJjWk+F4xWZrnCJE9+IOHz5kBD6oM/McQ8d42BvfzYKBkQN6bF8Xvd9u8J+8LCyDfhYCtOALVh1c0frGdCRdCZS6HKP9Ix30XQsaBOSLhmgTAU367yNkW9S8a88CN3BpkjFBDlaYFhD3gmgKOtY+YpEnL71KDXjcoNdDQ6uRYKfY9jZg/MHqj3yj063zUE6NAXYnPZr8ATUUiw1kHiNE1LJ/1iCgQMBMKW4/wcXWUttc0LrNBd68UlJbRi7LvThg+Rwwn2YfL4MwlR6HrFg8NH/K2TWoLXNOahlOFmWbvrr6ZLDUBWezbdE82jqJjObe+Es6VnrbTC6YATWnluRigyRrJYJqX5+el6AQjnPtQavk157siHXMwITL9K1GyNKtRyi0aqnMilu0Y9QJC4l0pSS2S6ObzuG8IjYL3YjyPaRWBkpC6spbXi1HR3A1c+vowVVcqdEfKLPLENjK4749/ToYuNj5K4oDVMk/yV0XO4dtulyjFaSN4Hlx1AU/QdvFjCSZ8vU3kMlhHCHeWq3ennlvKY8YuIAT8i/90C8QiXjxH15T8jmVSmi/sVpEg7BWR6R57ltIBFeYSwTHZZ4AqkriQCdV/WTlWgBIdhTKlqXfm/81w+YtmaR+8N8GqeOXT5bPKMj2COg5ZatNfZwJ3/UOO3CYTmuWHCcui0BAJghsLKVuebtXuCAXojgyvLs3zM2N5FZjk2ZkhTvBnTUYxM0fzI9roKEnY3iux2Ep6FoiuQZcbr7Ujn4sUegOO2m/5USapvz+xTIlg6K9BFK5krAJAn2iOarXlW6qZINlW4D8kiL6f/mwvqKR2eY+dGiOjjTUv19b6AqdrS3DOfR1KOeLTaKHW0+/NDaxOJctAG99e7tjW/p7qIBUPJPcdCIMIcAKja0jtHpoDUURm5xsZRl9Y8jyHhjly6oZ7lRJwJGXRMkKl83BbheJU4m81cPDinZNIuKQSdu2zjTXkgAo3Yu+o3y7/oKQBOdPebKiDuUBHePXmHkH78X1eYZLWE99y9iuoWF0I0RyrZ8k7jWNzJBeXPPOyHhv5/DLZw2unPdkWKxkm568YDv1WXv3m1lVT2qwd1DHamoLcGCOcr/nzv8fZPvj3xpQyEtzXztg7UnRBf4ccze2Otb6q3oJaURCFqIKi5wuNuYnFS/a89J49DbyvM3dW2LmlBtrGtVdXvM7gxEJTO9CCMJAxFFrZUwZUqrHumZcTlbhQmIHtN4PuXaj8P+6seDu09uS3nPwNFMCXo4TVuzCpUkDhFZr5X3VlLTKXQpBRWRFwTt6Z72mHLbp12f0R X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LUrETJxIr/mhibbX55lASAafqKqGCkDIzpopeyQAq3tyBAr+ZMkCxtaOrqroUNagxT1exCc08pSoCElsf+pHhpmtOLtjBAn40T9Um/VEFvcP+ykL3W/pt/C23nKTY8hnxu70xzIh47ssmNabHoexMd7GkBx26+g9p/T7zAps2YnuUpml4eetD7Xpt88tzuRKtFXPXVjPwDmLDlx6wlh0lsrwwOT//OXijnqBJZsjHI3T+UV3X0FOtVSzSXPxrgU1E2QwmjcjEPUXZt3BZPICweYBjSD8JknriYUpveSxW7BOArDdG7x0SR+rWdwnNdJHD7eGBUXEXztYax3UqZsSs1kLoQR3BOp7EmwMdUTV8WBalzsLnhvyumWZrvu2upOrtE0X/oIsVh6+mWV3UIq5HVlhYvy1LjNxqJifKEBrMGly+6Ei7VEP1GYPkebI9FHhg+y2f7gPO6TEKQWFjuoh5Bwi/JcSWSApNM/rVAWd0KV0Fnq1alyWUUXve61eZaPbXUA/6sD00RcS71N+iGOvMM1qGTtTwWP8HcQTG2HiMK51dC77b4FwHyaer/tHFs45mDW+plVjENVBiekO3QzyLB/pCf5HSu/adZjzKnMh2+m7D+qYyO9Y31mLG2Dv3WB9rA1ta/YGw9JXAaogDAObgzIQ9W/C6yFPm2M591rzOzqStM0BMB6Wiyu5IJphOTmUn2D9NZxi15Tn2YcScVroHiVIugvABv6/Jejm9l1Q+eb0Q6PrJ+Ow1M5oIYPzkRNJ X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 640d6dfe-8434-4e35-bf49-08db7748040d X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 19:52:19.4836 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O5Egpocm4/tHAZiRMvZoSkscycr/u5VNHaCd84+SVZ0ZU37R1HYYyZiKfS7VGYYkXd2JGe+y1jUVSAdtXZRIog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5361 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-27_14,2023-06-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 spamscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306270180 X-Proofpoint-GUID: BV7zfl5pUdrkIpPvh298FK9DMjI4oR0u X-Proofpoint-ORIG-GUID: BV7zfl5pUdrkIpPvh298FK9DMjI4oR0u X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Binutils From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769886807252612998?= X-GMAIL-MSGID: =?utf-8?q?1769886807252612998?= Use a more appropriate data type. include/ * sframe-api.h (sframe_fre_get_base_reg_id): Use uint8_t as return type. libsframe/ * sframe-dump.c (dump_sframe_func_with_fres): Use uint8_t type for base reg id. * sframe.c (sframe_fre_get_base_reg_id): Use uin8_t as return type. --- include/sframe-api.h | 2 +- libsframe/sframe-dump.c | 2 +- libsframe/sframe.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/sframe-api.h b/include/sframe-api.h index e62a7a38285..46614925c68 100644 --- a/include/sframe-api.h +++ b/include/sframe-api.h @@ -173,7 +173,7 @@ extern void dump_sframe (sframe_decoder_ctx *decoder, uint64_t addr); /* Get the base reg id from the FRE info. Sets errp if fails. */ -extern unsigned int +extern uint8_t sframe_fre_get_base_reg_id (sframe_frame_row_entry *fre, int *errp); /* Get the CFA offset from the FRE. If the offset is invalid, sets errp. */ diff --git a/libsframe/sframe-dump.c b/libsframe/sframe-dump.c index 37ce9d70eb3..4799652f727 100644 --- a/libsframe/sframe-dump.c +++ b/libsframe/sframe-dump.c @@ -105,7 +105,7 @@ dump_sframe_func_with_fres (sframe_decoder_ctx *sfd_ctx, int32_t cfa_offset = 0; int32_t fp_offset = 0; int32_t ra_offset = 0; - unsigned int base_reg_id = 0; + uint8_t base_reg_id = 0; int err[3] = {0, 0, 0}; sframe_frame_row_entry fre; diff --git a/libsframe/sframe.c b/libsframe/sframe.c index 2d7e4a4a462..b885e3df5ec 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -618,7 +618,7 @@ sframe_calc_fre_type (size_t func_size) /* Get the base reg id from the FRE info. Set errp if failure. */ -unsigned int +uint8_t sframe_fre_get_base_reg_id (sframe_frame_row_entry *fre, int *errp) { if (fre == NULL)