From patchwork Tue Jun 27 11:38:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xinghui Li X-Patchwork-Id: 113387 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp8145834vqr; Tue, 27 Jun 2023 05:11:52 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5o9I+jfkms3DOnKdv6G6iKxt/cKsNP4qeleS9wu/yPux7xAzF1tPZC2jvfXfanZj34ZGDL X-Received: by 2002:a17:903:44a:b0:1b8:1371:8318 with SMTP id iw10-20020a170903044a00b001b813718318mr2577459plb.33.1687867911810; Tue, 27 Jun 2023 05:11:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687867911; cv=none; d=google.com; s=arc-20160816; b=g7dqyVG97e/OKTZ4662lvYAhtJfQnc9aicW5CnRo+bRJTod/m35vMdsNOLlmfeMxny GzVH7h4vJNN89IYa3s55bTJ0Fdn67phenOHP5p2GZ69Bm92R5LcjgOuMtUHnCMuNzw5f W8evpeSkF5Ujjl9Eg9HiogUNZkAU4/4wTMK8bVdqzGA3g7+l+fy7cCR1NF6C2FptcqA8 uXfNqnfnj4NWkbeMowCozO8dT8ffNv+cJ/28jU+ii8mFDc41wFrNgf3Sr41vVfisFT4w iA4onsD01J2cwPhhJ5ERrOtELq93kT4GCPMhy6g8eb/Peu/UYYu9ft+Prv1EB4vDjG8C jZew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=xEO3Nk6Y8XH6bTMW8nJppcuxQHpEE9aHNdQQmfT2ado=; fh=d9cVw99Yn2a7+IBFWJN98dNn1x+MLYJLgnw4OaxPEgs=; b=EZzzNBdxzPnzBrwpNwffeL0xVB0wQaFbgco0T8vn8cjcYYrjeYun66LR+C3Xoy0lDl CXz5bnKk+ppxC6hFZP1Byn0ZRH9BlnEaJ38DAFO78D2Y2Q+LZqvmdS+3k+3f9dIq+zLk jyp6E4D8SMKtLFKqTdAfv6RBvdhOP9Sa67ENSGbwKbkWLr6SxmeUtCSBBqlROSyRfIQ1 K4XkDvVBZTuCp5LX5GJ21umlQdj/tIJ2r1c/1vgg6T9eLxgvTY6f1TvtMEgwmuXLH53T TyqWz8pq6JBqPHObN3yzIpTmC3njjnV/LwbB7ppjCIvCj+zvz6SW1qlPSebhIfa23G5d np3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=Ykh79237; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o16-20020a170902d4d000b001b530ede2besi7447231plg.614.2023.06.27.05.11.16; Tue, 27 Jun 2023 05:11:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=Ykh79237; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231596AbjF0LiW (ORCPT + 99 others); Tue, 27 Jun 2023 07:38:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231651AbjF0LiP (ORCPT ); Tue, 27 Jun 2023 07:38:15 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF5F22712; Tue, 27 Jun 2023 04:38:13 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id d9443c01a7336-1b80512a7f2so13280265ad.3; Tue, 27 Jun 2023 04:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687865893; x=1690457893; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xEO3Nk6Y8XH6bTMW8nJppcuxQHpEE9aHNdQQmfT2ado=; b=Ykh79237L6j9Ib6rQESfFRbNpvxe1FrB4gQoazP9KifD3Wm81K+8wPiyx/LYR/7Aeu YmvyEge4bY5vzF3SlCDitPRfOfuV7c9RDOPGbtQfetsNHigRhvUpXf1T/Cw8LfaCBzux uJkYQKndrlvWa4xm0EjcAIlEYVmpi6mSqB5f/aGHYGsHb5WIqMI1tglwVnh0veDTGeDH 6Y01zwJwKpqJikkKXV+wbpMXkRBeS2nhu7EMBpH4ACkARZvSQvnI53G3pgEs74t3Z5aG +R+snEuP1cwlfuzaxfImywrLgO9zM8EXMvy+wCMIflGm71KltwBhDYSJZRkwvzTRlL3H m1Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687865893; x=1690457893; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xEO3Nk6Y8XH6bTMW8nJppcuxQHpEE9aHNdQQmfT2ado=; b=i5hqsYkqHwRZu1fXEIOG5iwpPluv7a5fBIk1ikQq2sWNgDGi2KM27h4v2L2nrYPags Beke+K+UIRrwBkSW3/M9wngcONufeMRcc3yMDgrHXrxFrDc7gIJFRFv7UGfbmF17PFul QATZ/lm/l6OMo/xyw4cAPglyO+8dIRaJoQOYYKICtXmNzNO3X2nByzn79OAWiMxLlTdU tuEBNduSK3w3hd99Yv7JjiK1uNEMlsCiV5bNJ44Cgr2Spe89NhQTq9IFrmTrRA4/jKc3 eJ0p/s+kXspLVYOz8BUqt0QCoUIJlSQXUfY+Ccg+i4BBib3RtDj6InU2Cgu52NSWnhta Jk7Q== X-Gm-Message-State: AC+VfDxvaXfxzufdzl1SOMQe5ke1twWGrMgXMAn6FmYfnK+Li4D4tZHd IBP1uRDGi3mk2PeqqO5/7kg= X-Received: by 2002:a17:903:189:b0:1b5:1467:c4e8 with SMTP id z9-20020a170903018900b001b51467c4e8mr7663857plg.15.1687865893120; Tue, 27 Jun 2023 04:38:13 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.9]) by smtp.gmail.com with ESMTPSA id u9-20020a170902e5c900b001b67a2896bdsm4280944plf.274.2023.06.27.04.38.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 04:38:12 -0700 (PDT) From: korantwork@gmail.com To: kw@linux.com, nirmal.patel@linux.intel.com Cc: linux-kernel@vger.kernel.org, hch@infradead.org, linux-pci@vger.kernel.org, Xinghui Li , Dan Carpenter Subject: [PATCH] PCI: vmd: Clean up an indentation issue reported by Smatch Date: Tue, 27 Jun 2023 19:38:08 +0800 Message-Id: <20230627113808.269716-1-korantwork@gmail.com> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769857783461685397?= X-GMAIL-MSGID: =?utf-8?q?1769857783461685397?= From: Xinghui Li There is one inconsistent indenting warning: "drivers/pci/controller/vmd.c:1058 vmd_resume() warn: inconsistent indenting" Fix it and remove the unnecessary if. Reported-by: Dan Carpenter Signed-off-by: Christoph Hellwig Signed-off-by: Xinghui Li --- drivers/pci/controller/vmd.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c index 990630ec57c6..356bbeb548fe 100644 --- a/drivers/pci/controller/vmd.c +++ b/drivers/pci/controller/vmd.c @@ -1055,10 +1055,7 @@ static int vmd_resume(struct device *dev) struct vmd_dev *vmd = pci_get_drvdata(pdev); int err, i; - if (vmd->irq_domain) - vmd_set_msi_remapping(vmd, true); - else - vmd_set_msi_remapping(vmd, false); + vmd_set_msi_remapping(vmd, !!vmd->irq_domain); for (i = 0; i < vmd->msix_count; i++) { err = devm_request_irq(dev, vmd->irqs[i].virq,