From patchwork Tue Jun 27 01:01:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krishna chaitanya chundru X-Patchwork-Id: 113180 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp7897630vqr; Mon, 26 Jun 2023 19:35:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7r+lO2d0B+EHCS/2yom+PAvpWRsLy3cldFHof8EnfWeUimcOIopon+CADxhgh7dslmHiEj X-Received: by 2002:a2e:b163:0:b0:2b6:a08d:e142 with SMTP id a3-20020a2eb163000000b002b6a08de142mr2861033ljm.7.1687833358817; Mon, 26 Jun 2023 19:35:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687833358; cv=none; d=google.com; s=arc-20160816; b=o7+eGJ9CIFJkHoO7cpiGBGZ3eVs0jySjR8kwNLc/D/wzMWapVHwYAG7fpBkUnuoA9h Nqik0OG7dU7AP/1P2SySlx1mnB9UgpMNllQyJzFjbd8FQx6ZJEgCp7lF30wM8xqMQAq1 73PdPFNYaDjlCTjl3YJ321btoeF0GtfkqaDBwsH/ZZ2Kn8bA0md0Ad5pktjn+R8fQiQt WA4KQ1SOKPjONyDf+JnMtxXGv0v6hgKCL+o56zY+aj+dVY33V4d9a4zS9gVgXzxgH2MR RESni+wcMEIk17oLw8rHO2w73jxkvUCOJJAjeJb3bGDXdvUYubCPp7okiF8G7h3LxQH4 dZew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=sDwBxXejWXDBtWl1o+jOBgjUmJEiZx7qI5LRlD/XWpY=; fh=satfFpoYLQu25EcWK2B58o60IjomO6VWZdUlxqx8/O0=; b=UAHGCvIWNa/jskTdU61r3zeb4abP1wipIw1mrpMXxFfwzj/t+xDpC/9a8jHT7/9vP+ Hx9WELOheeo+no3ZyN/ttNIfnQzjk45NTob82VwO+4hIiS944zbdCgnngsUXIj2uOgmF GQ/ZKLWk5ia2YGseSn1jtASBEfsoyWxTQqmXUVIehcOusUToRyRroJ40PcBT0k0yMRnN tcXB79SsJET5ZNrVMjpBFWDFmogK/z+zHcZY7DhV7Cj2EZ5HQKlLs7HMiv7lyP/vtczH PrSgA59LybTGBXaQenhkZpzpUtzKFUlw/ZrPqJ6VMMiFDNafcYJQAiyDMIAT/qFm26lX wq5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=E7s6Gknh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bf9-20020a0564021a4900b0051bed27d0cfsi3282602edb.625.2023.06.26.19.35.34; Mon, 26 Jun 2023 19:35:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=E7s6Gknh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229973AbjF0BB6 (ORCPT + 99 others); Mon, 26 Jun 2023 21:01:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbjF0BBy (ORCPT ); Mon, 26 Jun 2023 21:01:54 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 956A8FD; Mon, 26 Jun 2023 18:01:53 -0700 (PDT) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35R0u4w2011038; Tue, 27 Jun 2023 01:01:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=qcppdkim1; bh=sDwBxXejWXDBtWl1o+jOBgjUmJEiZx7qI5LRlD/XWpY=; b=E7s6GknhGubKLDBVMwMbPXtTljxjhz0dZ9PmpK2DKmzro0LI/j1InBpCnq7bMLHaVPTI uHmHuj12JtCI6OOJgdJ/jr/qWUnbsQhFBPvYxeZGuvyyZzSm+De5AELigHZVVrK7UjnZ Du2y28+prkL0r/r9VRBmi6K4bvO20lNYwSkHLvSrUvdrBvZs5+MzQa90eG7w8AZfSZ+J lNubEoCPouQi8Uje9BFUWpZ3PefSx05/naVdzWbuSuLM0FTx2jGioqwftLzLCepDnPqO n+rybvLvQGOivR4iXgZ+j9nzyg70LNzyCoqzWkeIXqpzJuGDYDtLjjYE1/wBqRg3D3Qb Og== Received: from apblrppmta01.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rfc0d9779-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jun 2023 01:01:46 +0000 Received: from pps.filterd (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 35R11h4u006812; Tue, 27 Jun 2023 01:01:43 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTP id 3rdsjkh3c2-1; Tue, 27 Jun 2023 01:01:43 +0000 Received: from APBLRPPMTA01.qualcomm.com (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 35R11hIs006713; Tue, 27 Jun 2023 01:01:43 GMT Received: from hu-sgudaval-hyd.qualcomm.com (hu-krichai-hyd.qualcomm.com [10.213.110.112]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTP id 35R11hPG006662; Tue, 27 Jun 2023 01:01:43 +0000 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 4058933) id BA9184AA9; Tue, 27 Jun 2023 06:31:42 +0530 (+0530) From: Krishna chaitanya chundru To: manivannan.sadhasivam@linaro.org Cc: helgaas@kernel.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_vbadigan@quicinc.com, quic_nitegupt@quicinc.com, quic_skananth@quicinc.com, quic_ramkri@quicinc.com, krzysztof.kozlowski@linaro.org, Krishna chaitanya chundru , Manivannan Sadhasivam , Andy Gross , Bjorn Andersson , Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Subject: [PATCH v5 1/3] dt-bindings: PCI: qcom: ep: Add interconnects path Date: Tue, 27 Jun 2023 06:31:29 +0530 Message-Id: <1687827692-6181-2-git-send-email-quic_krichai@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1687827692-6181-1-git-send-email-quic_krichai@quicinc.com> References: <1687827692-6181-1-git-send-email-quic_krichai@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: YqehASMTlpiQOY43AzczmrZvgwMFIA8H X-Proofpoint-ORIG-GUID: YqehASMTlpiQOY43AzczmrZvgwMFIA8H X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-26_20,2023-06-26_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 mlxlogscore=999 clxscore=1015 mlxscore=0 adultscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306270007 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769821552065937233?= X-GMAIL-MSGID: =?utf-8?q?1769821552065937233?= Some platforms may not boot if a device driver doesn't initialize the interconnect path. Mostly it is handled by the bootloader but we have starting to see cases where bootloader simply ignores them. Add the "pcie-mem" interconnect path as a required property to the bindings. Signed-off-by: Krishna chaitanya chundru Reviewed-by: Krzysztof Kozlowski Acked-by: Manivannan Sadhasivam --- Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml index 8111122..bc32e13 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml @@ -71,6 +71,13 @@ properties: description: GPIO used as WAKE# output signal maxItems: 1 + interconnects: + maxItems: 1 + + interconnect-names: + items: + - const: pcie-mem + resets: maxItems: 1 @@ -98,6 +105,8 @@ required: - interrupts - interrupt-names - reset-gpios + - interconnects + - interconnect-names - resets - reset-names - power-domains @@ -167,7 +176,9 @@ examples: - | #include #include + #include #include + pcie_ep: pcie-ep@1c00000 { compatible = "qcom,sdx55-pcie-ep"; reg = <0x01c00000 0x3000>, @@ -194,6 +205,8 @@ examples: interrupts = , ; interrupt-names = "global", "doorbell"; + interconnects = <&system_noc MASTER_PCIE &mc_virt SLAVE_EBI_CH0>; + interconnect-names = "pcie-mem"; reset-gpios = <&tlmm 57 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 53 GPIO_ACTIVE_LOW>; resets = <&gcc GCC_PCIE_BCR>; From patchwork Tue Jun 27 01:01:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krishna chaitanya chundru X-Patchwork-Id: 113177 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp7897091vqr; Mon, 26 Jun 2023 19:34:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6o5bOaSfpIeZl+wXwD6CQvs7F4iebQnKBl36ebMVSR6eIwyBl87JA3T5rbXhfWoYMfMb35 X-Received: by 2002:a05:6402:783:b0:51d:a94b:f8ef with SMTP id d3-20020a056402078300b0051da94bf8efmr387181edy.14.1687833265516; Mon, 26 Jun 2023 19:34:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687833265; cv=none; d=google.com; s=arc-20160816; b=YRnpIjiH3QHzua7z/niuPMydoNge2ZIuU5P1GFihIldQLLmxeskvnlnYwOf0clk3rJ VZG9tUT8IzYiLwitwbTP4Sv8fZ6VhNsifY/wS1XRnoLnIOeyT/wZUTOdjngA6vKyguCX eIO1z50RbxsLXKuUQknQV+zLRkVLLt3/5xUVnY/PJ7kK8Ir+UilG9hRVgsh/ozPqjcD4 QA3N2y93qnR6VgIKxTXt9pNgP6ARwe0GDaYyFuitpLQBa+J961nR+9OHcSktgyNN+kDU v3mYVA0ijw403vQ9SEWFq+KhX7w9CW3VmaiIvv8hXQDjcdSxTxKour7j0LgOq9xwd/g4 WgoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=CoQWJK6g3lHTk1rFQ7ZMbUKHdT1pWm6LxcNGSJjfyTs=; fh=9a3PWlW0sWMAnOREzZp2dy2Uqg1Q9qvhO0ww4RGf874=; b=D+WIOPScn+vqC3maPi63Cz+jdFOsPSUkgowcglAazJytlu7QjrsBaxhrI2Jvc/90eL WYJBfuZkFrE4choBRN+WHiDFSFgKk3mujd0nhe6np8w52Oei0RkdhZV8L9inUe9FK4V3 pFkU3S7FpM78hZ8pJkeTELseBYcreJlZRAkkUugRiwZE3BH4a4FEcjdYa80kurbz2toi 89HIsmzW1wQhfb56U7GAL3gZMiUmPnNBel3xdz+0oxuvB8eHUmXqQWZjDaTSf0gPCIgu rJ8MAuKbE3XEWME9PitafxpBXynIpyA9ZpBw9wJtFDoZhvGS1D81mUprysQf0AsIE8UX vzxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=X3Vze7y1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x1-20020aa7dac1000000b0051bdd99a9d5si3139430eds.423.2023.06.26.19.33.59; Mon, 26 Jun 2023 19:34:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=X3Vze7y1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229926AbjF0BBz (ORCPT + 99 others); Mon, 26 Jun 2023 21:01:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229724AbjF0BBw (ORCPT ); Mon, 26 Jun 2023 21:01:52 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 510F4E6F; Mon, 26 Jun 2023 18:01:51 -0700 (PDT) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35R10RSi027825; Tue, 27 Jun 2023 01:01:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=qcppdkim1; bh=CoQWJK6g3lHTk1rFQ7ZMbUKHdT1pWm6LxcNGSJjfyTs=; b=X3Vze7y1Zvj7/5XjU6co0qKcOeNPdgctjh0PHRmT7sqNSPIuS0XQeZDoXcwkh73qcGqk vpKtIA9WstTPz8s1kF9VGdr3sLQDQhwWoX97FwL8OYOCzIIppSVBwy69O9f/dSWsjL9i P9inu4PDXMRfnt6HBQcr4wZKWplZ5GetEeJiEAjipEp+xQVaeR4XUh6F/ZyFylCeNuRX Bv/iBq1Pvjbb0fNysIemph/Z2q675TaUlqJtb25rBs5zQeZI+qxFryukb5qCoRPbJ32P R7S6fEN+OV4rMlJ+cBdYfan87xk242XCg6KebMO3aIcz2ZSJffgVmtx0awoT/i1n1Y2+ tA== Received: from apblrppmta01.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rfcvts1jr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jun 2023 01:01:46 +0000 Received: from pps.filterd (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 35R11hjv006896; Tue, 27 Jun 2023 01:01:43 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTP id 3rdsjkh3cb-1; Tue, 27 Jun 2023 01:01:43 +0000 Received: from APBLRPPMTA01.qualcomm.com (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 35R11hZs006832; Tue, 27 Jun 2023 01:01:43 GMT Received: from hu-sgudaval-hyd.qualcomm.com (hu-krichai-hyd.qualcomm.com [10.213.110.112]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTP id 35R11hvv006761; Tue, 27 Jun 2023 01:01:43 +0000 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 4058933) id EA2A54AAA; Tue, 27 Jun 2023 06:31:42 +0530 (+0530) From: Krishna chaitanya chundru To: manivannan.sadhasivam@linaro.org Cc: helgaas@kernel.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_vbadigan@quicinc.com, quic_nitegupt@quicinc.com, quic_skananth@quicinc.com, quic_ramkri@quicinc.com, krzysztof.kozlowski@linaro.org, Krishna chaitanya chundru , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Subject: [PATCH v5 2/3] arm: dts: qcom: sdx65: Add interconnect path Date: Tue, 27 Jun 2023 06:31:30 +0530 Message-Id: <1687827692-6181-3-git-send-email-quic_krichai@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1687827692-6181-1-git-send-email-quic_krichai@quicinc.com> References: <1687827692-6181-1-git-send-email-quic_krichai@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: D7vehJOcGuySH1JAcnXRl86vOJoEoD9F X-Proofpoint-GUID: D7vehJOcGuySH1JAcnXRl86vOJoEoD9F X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-26_20,2023-06-26_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 adultscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 clxscore=1011 malwarescore=0 priorityscore=1501 mlxscore=0 mlxlogscore=838 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306270007 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769821453888058550?= X-GMAIL-MSGID: =?utf-8?q?1769821453888058550?= Add pcie-mem interconnect path to sdx65 target. Signed-off-by: Krishna chaitanya chundru Reviewed-by: Manivannan Sadhasivam --- arch/arm/boot/dts/qcom/qcom-sdx65.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi index 1a35830..77fa97c 100644 --- a/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi @@ -332,6 +332,9 @@ ; interrupt-names = "global", "doorbell"; + interconnects = <&system_noc MASTER_PCIE_0 &mc_virt SLAVE_EBI1>; + interconnect-names = "pcie-mem"; + resets = <&gcc GCC_PCIE_BCR>; reset-names = "core"; From patchwork Tue Jun 27 01:01:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krishna chaitanya chundru X-Patchwork-Id: 113175 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp7874530vqr; Mon, 26 Jun 2023 18:33:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6S7n3570nMZ4h6YpOWK3mRlLjqnoeInmbguVWazLpbZqDeczxIT9rrcJd9b+K/k25ebKDH X-Received: by 2002:a50:fb16:0:b0:51d:9830:8c43 with SMTP id d22-20020a50fb16000000b0051d98308c43mr3131956edq.3.1687829597550; Mon, 26 Jun 2023 18:33:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687829597; cv=none; d=google.com; s=arc-20160816; b=GrXMu7TK1HrpNebG8GFjEfaFT0SmH/5IaCLSKhcacHoDdPBDzaJX74DRuHWW/1hbi3 nKsCQzZPhUE9J0VsDvHs6qE1vA7kHpVViX/xpCKI6m49ABIF9O5exwfGT6vlIRS0T5EK wDaKIsCCtjdrIPVwCgBc5UIYPC1nA1mvsE7ezCnPLX3ou7JzwEfIPSiA6w7sRV3StZHW SgOl8WVYNVrF//thmnvF40dHuly/fmIjJpjbfsoRg8L+nSYXTXHA3su5AE2WLctpIPvb QU2CFaKMboBbvlf+/u7FtHhfpOM++bAdRPnoevmUxGgsaUkVfeBvs6BK2FfQJQjZWEGf Rkvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=FgB4bodO1ovCgHDSqrkKk5ANFL0PagqKtToIH6HGxVM=; fh=rZg3lIvN0abm+bcKRxTVDozxw/bYHp1ZLDp2JcSIm88=; b=UPtxOwV1MY0i1w4ZUJQ1cZPAthpGEIabVIun1ngdlzx7nhJkIxL/0iAFYLI7FBBd0k wD8PpDj5W0ym6RzTd4D3EZsdEG2HU9gP8f/pxKS4UWkeSOTgGYV78RtyzAUm6E3ev1Tn 9SHvHl3Fljj/k6dkqtYtl76UBBorOuW2lPg3dNFsl0ziQMFehiHjr1oqWHIwBDsewC9k m4UKAyPdvC1r0S2w3x7YHRhrgMq/BAwCf/iMeSGnbkerzks709uys5EsaxRHb6V8D5/Q FfTnGSCiPSgi7hpbgWDGDRTGM5XOgxMp3774nkJvwMjWk9VZlNpi+/L+KUJta/R8LzPj Kl6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=L1HyfEBh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q19-20020a056402041300b0051be99fde7bsi3144823edv.664.2023.06.26.18.32.53; Mon, 26 Jun 2023 18:33:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=L1HyfEBh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229984AbjF0BC6 (ORCPT + 99 others); Mon, 26 Jun 2023 21:02:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229689AbjF0BC4 (ORCPT ); Mon, 26 Jun 2023 21:02:56 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F2091FCF; Mon, 26 Jun 2023 18:02:19 -0700 (PDT) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35R0fxXH015642; Tue, 27 Jun 2023 01:01:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=qcppdkim1; bh=FgB4bodO1ovCgHDSqrkKk5ANFL0PagqKtToIH6HGxVM=; b=L1HyfEBhRozhTdArHdNgSRyuIGWGr3symhmU17e9EDAo+66MHGbFgQ0R+l/N8t/FtCkk YrAKWVWK3FSnb2J3+iEW8e4in8zIwyct3Pmw3Yy9SLW+BaIKMjb1L7ZEGbBB0DbYXX+b wHc4jdb5RCTnRfgVv1t18/3vwkzPxnxukS2RQM39P/4WCxl9R78Spy2oxyK6e4M3a3xT 48q4JUD3+f5ZvydZccl1Fe0MBtGeoMTjSi9LoAVuETW6Onus9mUOy2SrMzyuKRCD1cVc jp6NW8uTqQotIet66f2FxC7q7vQpFl4k8fOvpMJf1exw0bVaPUagVcF7H1g70avf+32b ZQ== Received: from apblrppmta01.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rfc0d977a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jun 2023 01:01:46 +0000 Received: from pps.filterd (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 35R11haJ006895; Tue, 27 Jun 2023 01:01:43 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTP id 3rdsjkh3ca-1; Tue, 27 Jun 2023 01:01:43 +0000 Received: from APBLRPPMTA01.qualcomm.com (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 35R10HFV005417; Tue, 27 Jun 2023 01:01:43 GMT Received: from hu-sgudaval-hyd.qualcomm.com (hu-krichai-hyd.qualcomm.com [10.213.110.112]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTP id 35R11hmQ006762; Tue, 27 Jun 2023 01:01:43 +0000 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 4058933) id 2ACB44AAC; Tue, 27 Jun 2023 06:31:43 +0530 (+0530) From: Krishna chaitanya chundru To: manivannan.sadhasivam@linaro.org Cc: helgaas@kernel.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_vbadigan@quicinc.com, quic_nitegupt@quicinc.com, quic_skananth@quicinc.com, quic_ramkri@quicinc.com, krzysztof.kozlowski@linaro.org, Krishna chaitanya chundru , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Bjorn Helgaas Subject: [PATCH v5 3/3] PCI: qcom-ep: Add ICC bandwidth voting support Date: Tue, 27 Jun 2023 06:31:31 +0530 Message-Id: <1687827692-6181-4-git-send-email-quic_krichai@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1687827692-6181-1-git-send-email-quic_krichai@quicinc.com> References: <1687827692-6181-1-git-send-email-quic_krichai@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: zHGx88Xi-MSCdPvJwLyn6YCTDTy45RD2 X-Proofpoint-ORIG-GUID: zHGx88Xi-MSCdPvJwLyn6YCTDTy45RD2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-26_20,2023-06-26_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 mlxlogscore=999 clxscore=1015 mlxscore=0 adultscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306270007 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769817608188273113?= X-GMAIL-MSGID: =?utf-8?q?1769817608188273113?= Add support to vote for ICC bandwidth based on the link speed and width. This patch is inspired from pcie-qcom driver to add basic interconnect support. Reference: commit c4860af88d0c ("PCI: qcom: Add basic interconnect support"). Signed-off-by: Krishna chaitanya chundru --- drivers/pci/controller/dwc/pcie-qcom-ep.c | 73 +++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c index 1435f51..b613817 100644 --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include #include @@ -28,6 +29,7 @@ #define PARF_SYS_CTRL 0x00 #define PARF_DB_CTRL 0x10 #define PARF_PM_CTRL 0x20 +#define PARF_PM_STTS 0x24 #define PARF_MHI_CLOCK_RESET_CTRL 0x174 #define PARF_MHI_BASE_ADDR_LOWER 0x178 #define PARF_MHI_BASE_ADDR_UPPER 0x17c @@ -128,11 +130,19 @@ /* DBI register fields */ #define DBI_CON_STATUS_POWER_STATE_MASK GENMASK(1, 0) +#define DBI_LINKCTRLSTATUS 0x80 +#define DBI_LINKCTRLSTATUS_SHIFT 16 + #define XMLH_LINK_UP 0x400 #define CORE_RESET_TIME_US_MIN 1000 #define CORE_RESET_TIME_US_MAX 1005 #define WAKE_DELAY_US 2000 /* 2 ms */ +#define PCIE_GEN1_BW_MBPS 250 +#define PCIE_GEN2_BW_MBPS 500 +#define PCIE_GEN3_BW_MBPS 985 +#define PCIE_GEN4_BW_MBPS 1969 + #define to_pcie_ep(x) dev_get_drvdata((x)->dev) enum qcom_pcie_ep_link_status { @@ -178,6 +188,8 @@ struct qcom_pcie_ep { struct phy *phy; struct dentry *debugfs; + struct icc_path *icc_mem; + struct clk_bulk_data *clks; int num_clks; @@ -253,9 +265,51 @@ static void qcom_pcie_dw_stop_link(struct dw_pcie *pci) disable_irq(pcie_ep->perst_irq); } +static void qcom_pcie_ep_icc_update(struct qcom_pcie_ep *pcie_ep) +{ + struct dw_pcie *pci = &pcie_ep->pci; + u32 offset, status, bw; + int speed, width; + int ret; + + if (!pcie_ep->icc_mem) + return; + + offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP); + status = readw(pci->dbi_base + offset + PCI_EXP_LNKSTA); + + speed = FIELD_GET(PCI_EXP_LNKSTA_CLS, status); + width = FIELD_GET(PCI_EXP_LNKSTA_NLW, status); + + switch (speed) { + case 1: + bw = MBps_to_icc(PCIE_GEN1_BW_MBPS); + break; + case 2: + bw = MBps_to_icc(PCIE_GEN2_BW_MBPS); + break; + case 3: + bw = MBps_to_icc(PCIE_GEN3_BW_MBPS); + break; + default: + dev_warn(pci->dev, "using default GEN4 bandwidth\n"); + fallthrough; + case 4: + bw = MBps_to_icc(PCIE_GEN4_BW_MBPS); + break; + } + + ret = icc_set_bw(pcie_ep->icc_mem, 0, width * bw); + if (ret) { + dev_err(pci->dev, "failed to set interconnect bandwidth: %d\n", + ret); + } +} + static int qcom_pcie_enable_resources(struct qcom_pcie_ep *pcie_ep) { int ret; + struct dw_pcie *pci = &pcie_ep->pci; ret = clk_bulk_prepare_enable(pcie_ep->num_clks, pcie_ep->clks); if (ret) @@ -277,6 +331,20 @@ static int qcom_pcie_enable_resources(struct qcom_pcie_ep *pcie_ep) if (ret) goto err_phy_exit; + /* + * Some Qualcomm platforms require interconnect bandwidth constraints + * to be set before enabling interconnect clocks. + * + * Set an initial peak bandwidth corresponding to single-lane Gen 1 + * for the pcie-mem path. + */ + ret = icc_set_bw(pcie_ep->icc_mem, 0, MBps_to_icc(PCIE_GEN1_BW_MBPS)); + if (ret) { + dev_err(pci->dev, "failed to set interconnect bandwidth: %d\n", + ret); + goto err_phy_exit; + } + return 0; err_phy_exit: @@ -550,6 +618,10 @@ static int qcom_pcie_ep_get_resources(struct platform_device *pdev, if (IS_ERR(pcie_ep->phy)) ret = PTR_ERR(pcie_ep->phy); + pcie_ep->icc_mem = devm_of_icc_get(dev, "pcie-mem"); + if (IS_ERR(pcie_ep->icc_mem)) + ret = PTR_ERR(pcie_ep->icc_mem); + return ret; } @@ -573,6 +645,7 @@ static irqreturn_t qcom_pcie_ep_global_irq_thread(int irq, void *data) } else if (FIELD_GET(PARF_INT_ALL_BME, status)) { dev_dbg(dev, "Received BME event. Link is enabled!\n"); pcie_ep->link_status = QCOM_PCIE_EP_LINK_ENABLED; + qcom_pcie_ep_icc_update(pcie_ep); pci_epc_bme_notify(pci->ep.epc); } else if (FIELD_GET(PARF_INT_ALL_PM_TURNOFF, status)) { dev_dbg(dev, "Received PM Turn-off event! Entering L23\n");