From patchwork Mon Jun 26 13:46:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 112956 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp7500763vqr; Mon, 26 Jun 2023 06:57:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7dt+sJsblFmBwj0cYmtIZ7NZaRHADDzagGdGr4YhqCwuPA9r9nK4EFvUhcGNRZgJHtvSNl X-Received: by 2002:a05:6402:1290:b0:51d:a237:d45b with SMTP id w16-20020a056402129000b0051da237d45bmr909848edv.36.1687787868330; Mon, 26 Jun 2023 06:57:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687787868; cv=none; d=google.com; s=arc-20160816; b=wZsEDjeGAdZEH5ewLhClXTFyE3MR/YUQZ6rli9ChiGhWC2zMdkXHOWPwdIuyZlCxfb t41P5Cld3UrmCFtcMcUgCjKi+yn93Yu/63LYMx6kDyrx/Jg/zQqZ7O8dnCuJyClERNMg Yhl80baBOeNV5NYdyZAhnr3BPytKCXvKwRnu/hc8v/DeZsx0fH24zeCa0esNQhle7+Gn S0XzimSemqVUoHtfRUpo/Ptu3miit6JGeCTJqf1pW9LIogLJr20AV+dreIuxfb2siEC0 3krNxH5lXLL/PwqZS7aLG6kAilQfSGuqvNWAtSARXDtk9Vbysf5roG2+mHb10oaDP4gq Bdaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=7RchIzLEFr49hSDoEPp8rxOvgg/jdjjvX3M5T7yGIGQ=; fh=G0pLVFaeW8877iLu2apVEFjtpFRr+jSKPwzYBI8y2GA=; b=rPioEPx+O9bicduT8lCPL5/OFrILlU5mLCjUe+6M4APK1tvcz2UW1k6orjWbqSFSu1 U2NxhKwFka9No5kqmGdx57rGbk+aGPsRELHKpv7+fkpSc9vAszwnCIZJUcHdnL130KEW teK1c6j7C0rrG8IfyX7rrK8ipb0UNiD4VyGP9JOxGroYqGLG9cS6ES+Xcc7Mb1WUM2Yi 0pOfPsxaqHh/s+EievSB9gol84jlQH1uw7UXmtnw91ESjEZIKrQKXDfJ9b32eyPI3SfL 0xYAwV1yamvb4rVrdztYqnsg9VK9EUC/tyVEa9SHWtY4sycz1S3L3Jum32eyIty8RbMC K27A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Lmrlnj2T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r15-20020aa7d58f000000b0051d9f7c5eccsi650556edq.642.2023.06.26.06.57.24; Mon, 26 Jun 2023 06:57:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Lmrlnj2T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230175AbjFZNuz (ORCPT + 99 others); Mon, 26 Jun 2023 09:50:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229868AbjFZNuy (ORCPT ); Mon, 26 Jun 2023 09:50:54 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C88B4106 for ; Mon, 26 Jun 2023 06:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687787405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7RchIzLEFr49hSDoEPp8rxOvgg/jdjjvX3M5T7yGIGQ=; b=Lmrlnj2Ta/7BZUZMnCEOgZUQUmBUBKTLXd6amyHaHDb4a6olJ+qcxyKrjtxoqxjp4+jFJa T8Kfe6xWph3Z2yN7sPPKU01MVg1xiUK+Rc8WqOjdKoxZEOAKqzAG5oqSq1zxUfXL7fK0jq nuBoF05TGWeY064z8yZRuU/HRueHQ4w= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-orV3zfY9MeSG1Ih0MaMVOg-1; Mon, 26 Jun 2023 09:50:04 -0400 X-MC-Unique: orV3zfY9MeSG1Ih0MaMVOg-1 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-57000a7480bso44375797b3.0 for ; Mon, 26 Jun 2023 06:50:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687787403; x=1690379403; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7RchIzLEFr49hSDoEPp8rxOvgg/jdjjvX3M5T7yGIGQ=; b=ckbcOQCAHYlDQGXA6mD7AMrm9WJ2YQ8yHAFAJLnHGlsHowpHLh/TSd4Am72o1lvq8M ubPDXbeJHjibcTLUTJnq3O++6GuYq+CUyuf7bbCxP6pRN8IqakjkLWL7oVLN995LiTfp kvu5qX4QZmwCpPlLdoug75l/Z/45R0AZK0hwc9ilyaBkSNnZGoSheoDHayb+oHq5yTlF Gi7q25DXioQELGHKYX/6Rr+C83TQW/MBkbxd5PY6EBn+3pqxy42wl6x2TM+i3ONF3aJp suRNv9cr9cbDg+Yi1zmiSS+Ak01nCoFX6fDIIslcvvIsgJnG4m2SJkgV8Ao2o/bVjckA XTOw== X-Gm-Message-State: AC+VfDwr6tvb8r06Mvy5UXsJu3LfgQnTIvVTPykFlVRD5mKJP1G46Iy0 TB3WjdpDizvvawScehuveYPNJtkqmx6wiavfVsnj21fjpXoCFHk5UXk+1ia4N12DLqkTbi9LxK4 5G1JPoRsrLOgX/ksdIo/j8AHiQiPhPpr6+/p+NVjZS4SWw9xku1BVS89r4ZIlVD9Irwdhk47a0D HX1msCZWPH X-Received: by 2002:a0d:f187:0:b0:573:bb84:737c with SMTP id a129-20020a0df187000000b00573bb84737cmr13040319ywf.26.1687787403113; Mon, 26 Jun 2023 06:50:03 -0700 (PDT) X-Received: by 2002:a0d:f187:0:b0:573:bb84:737c with SMTP id a129-20020a0df187000000b00573bb84737cmr13040296ywf.26.1687787402730; Mon, 26 Jun 2023 06:50:02 -0700 (PDT) Received: from halaney-x13s.redhat.com ([2600:1700:1ff0:d0e0::22]) by smtp.gmail.com with ESMTPSA id p64-20020a817443000000b0056d1c26f5b0sm1290844ywc.21.2023.06.26.06.50.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 06:50:01 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: linux-pm@vger.kernel.org, sboyd@kernel.org, nm@ti.com, vireshk@kernel.org, Andrew Halaney , kernel test robot , Dan Carpenter Subject: [PATCH] OPP: Properly propagate error along when failing to get icc_path Date: Mon, 26 Jun 2023 08:46:46 -0500 Message-Id: <20230626134645.57902-1-ahalaney@redhat.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769773851921038783?= X-GMAIL-MSGID: =?utf-8?q?1769773851921038783?= fa155f4f8348 ("OPP: Use dev_err_probe() when failing to get icc_path") failed to actually use the error it was trying to log: smatch warnings: drivers/opp/of.c:516 dev_pm_opp_of_find_icc_paths() warn: passing zero to 'dev_err_probe' Make sure to use the right error and pass it along. Fixes: fa155f4f8348 ("OPP: Use dev_err_probe() when failing to get icc_path") Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202306262008.guNLgjt6-lkp@intel.com/ Signed-off-by: Andrew Halaney --- This slip up was totally my fault, apologies. I've got a "dirty" working tree (where I made this enhancement while debugging) and a clean tree for submitting patches along the way. It looks like I made a slight change in the patch that was sent in the clean tree, then rebuilt and tested the dirty tree and sent it off. Won't happen again, embarrassed to admit I sent a patch that was not properly tested but oh well. Here's a fix. Thanks, Andrew drivers/opp/of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/opp/of.c b/drivers/opp/of.c index 1f0923cc1cd9..ada4963c7cfa 100644 --- a/drivers/opp/of.c +++ b/drivers/opp/of.c @@ -513,7 +513,7 @@ int dev_pm_opp_of_find_icc_paths(struct device *dev, for (i = 0; i < num_paths; i++) { paths[i] = of_icc_get_by_index(dev, i); if (IS_ERR(paths[i])) { - ret = dev_err_probe(dev, ret, "%s: Unable to get path%d\n", __func__, i); + ret = dev_err_probe(dev, PTR_ERR(paths[i]), "%s: Unable to get path%d\n", __func__, i); goto err; } }