From patchwork Mon Jun 26 10:32:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean Delvare X-Patchwork-Id: 112848 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp7392201vqr; Mon, 26 Jun 2023 04:01:09 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ47YS8R4WFELbA/vP98hLLzY3K+5O0eCQeIPCMft7QylwHxPi5Av9ggpy9Ry1MvmcpSHXoo X-Received: by 2002:a05:6402:da:b0:518:7415:3b61 with SMTP id i26-20020a05640200da00b0051874153b61mr16065849edu.23.1687777268600; Mon, 26 Jun 2023 04:01:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687777268; cv=none; d=google.com; s=arc-20160816; b=ajlZXRu4mQPkvPVf4ckj307tiJgrwiPHgHi1KIJMVXMbNbD0A88f27FB3UwyBt3BXH f3MeIgzmwcuCmx4ZJ7YV6WoRgcMGYx6BeDjCe+wUgXgVrfJhyv1a6m2YJWy2DYB9hnjJ UURlzFRPqVUQ+EYZmxVWEywVI8gxZPktlxOEyW0z+DYnRJvGEEoWurY29wc9ZWKkYPeZ E/9UrW6bJ0NtfJtlnLeE3w7W2oO5/ISRnlyV3lAwG8BNwDh+xGcZusWbMFWVo82vmr/Y 5b4uUVmqVcCzv9Pd7w5G4ERxyQ6A4QAMrx3T8lg/VqYgLVGnfPSdmulo8YqBXADRAmZu Qgog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=z+HSLECNibzVOo7kYE3yRqNP3uGJcAQpmYEuFSJm/OI=; fh=1jTypjpGUsKe4trrIP5JxHi8HYxRxKg5wQ8OVPRT3hg=; b=xAaRUhS1SGLpszAAZI9qqX5z1WqZBhjpYuyGyjW4Uzm8FkNHpX7Xk5X+a0Oo6qUBHb EQgmqhFgx1DkTtUb1eQ1JSXL6sWv4psUtTHQg0k5BqGEbvgz2doUzImeZj5iJzv99tG2 v+Naymota4DePjs7PmlLh4UmS8NEmPV5yAwsoRvq4KjUuY7bH2uqtUNSSDO28gBnFGqW wMZAb53VXITsXZ/Gp5ma8gHINkRSbhMjewBqhnklgnzHj+/QYcHA7fwycICXZmbH6QD0 +GMx2OdAAMTgQbbmixFHzA70y8z2vZHtklelFBv0y7kcq4dTbt24yCCMEAxSyQE+w5nP QDYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=eWDLaoiI; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=bMbbCan3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n20-20020a056402061400b00519523cfe33si2454296edv.465.2023.06.26.04.00.44; Mon, 26 Jun 2023 04:01:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=eWDLaoiI; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=bMbbCan3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229848AbjFZKdd (ORCPT + 99 others); Mon, 26 Jun 2023 06:33:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbjFZKdb (ORCPT ); Mon, 26 Jun 2023 06:33:31 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97B48172A; Mon, 26 Jun 2023 03:32:55 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 237891F74B; Mon, 26 Jun 2023 10:32:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1687775574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=z+HSLECNibzVOo7kYE3yRqNP3uGJcAQpmYEuFSJm/OI=; b=eWDLaoiIC8nY2Eyf9HoiKnryKS7ZVt9r0tcTunuPJbaiAa53ryeZM0uuc0tMiA3fYq8YR3 rCi4zO0qHieNqI9B1kbnY14hPP2PfRavqTV8yhnJ+jFqCF1RwwFlE4YsqXtFz5zLqEOq8g WLb25zUXSR3mxFJjc1AEWeAllF54qN8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1687775574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=z+HSLECNibzVOo7kYE3yRqNP3uGJcAQpmYEuFSJm/OI=; b=bMbbCan38BmV4BchYOSRSYuGzmBcYrHYluBk3qG41KG/GATFQDYN7GtQx5vV2VWd6v6W1c vg2XM2ROl8rR2RBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DE9F513905; Mon, 26 Jun 2023 10:32:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id VFO4NFVpmWTYDwAAMHmgww (envelope-from ); Mon, 26 Jun 2023 10:32:53 +0000 Date: Mon, 26 Jun 2023 12:32:52 +0200 From: Jean Delvare To: Luis Chamberlain Cc: Michal Hocko , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] module: print module name on refcount error Message-ID: <20230626123252.73dbc139@endymion.delvare> Organization: SUSE Linux X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.34; x86_64-suse-linux-gnu) MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769762736911541122?= X-GMAIL-MSGID: =?utf-8?q?1769762736911541122?= If module_put() triggers a refcount error, include the culprit module name in the warning message, to easy further investigation of the issue. Signed-off-by: Jean Delvare Suggested-by: Michal Hocko Cc: Luis Chamberlain Acked-by: Michal Hocko --- kernel/module/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- linux-6.3.orig/kernel/module/main.c +++ linux-6.3/kernel/module/main.c @@ -850,7 +850,9 @@ void module_put(struct module *module) if (module) { preempt_disable(); ret = atomic_dec_if_positive(&module->refcnt); - WARN_ON(ret < 0); /* Failed to put refcount */ + WARN(ret < 0, + KERN_WARNING "Failed to put refcount for module %s\n", + module->name); trace_module_put(module, _RET_IP_); preempt_enable(); }