From patchwork Fri Jun 23 15:53:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 112229 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5884623vqr; Fri, 23 Jun 2023 09:10:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4yqGsfLm3B6MNc4Dnc+E5Z4AhC9oplp4TRGLvHhSwsWkcrV2ulTJzxWSNca3i59QPbgmC4 X-Received: by 2002:a17:903:1109:b0:1b0:3637:384e with SMTP id n9-20020a170903110900b001b03637384emr18177100plh.25.1687536622362; Fri, 23 Jun 2023 09:10:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687536622; cv=none; d=google.com; s=arc-20160816; b=AZSzGWoXhHna4Onk0Upj26dZqtfgYvDxeFJxWfVs4Qi+ETWC/YBInN6ZbNwi4RuKeP hEfqWuJZ/BH82WacOcDMCDyZWj60px3U866fL5WNA4UiuRLr4lgI+qCuUqz+xQQ4p6LU FIxJ33U1uvyoTG0d96EhRPvEF2wDRvwTD/2Y7svKOrq7KAcshEyBFw0lKLbHi/XVExjg 2XVXPmvnujVCNIiB8IUZR70YcU/FMoWMby0NE4jg3XitSadOmjLhMaL0HW5reH+Phfur Uds9cobMR9Q/qs3j12+WSEHB4UyuhJ+XxNTIVMefDFFej/o+zLika6HEujTud2FQaHaa iGGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=RqBYL4rToudmasXW3rSZav1ahfNpM2ZL3pnL4m6T3fk=; b=pTuyzFFamx0KfuwQ43RIza4e+ZvngiUgMFkKkgnhRAORFEMeTeiePCPJluYNx6qtRQ ISWldaXFFAkYaKOZuokHvgCGRepsOX3ra4gxX3sayQP6yz1uFsaWEK4Ve1EUQs50WrW5 c7jn+Gp4jYfSKqKa3UwlN54JfltmpKSYHBs6MPe1Dy8XQojKptiKscfi/rNipU7dCcVZ NXqn4aoXwBEZmPNldFCAs1703RmEWkME1EQDRsYJcsShdcz3eGW/sIGn70BpPR4eaznI fLOdRRFuXDW1VrpCOWmr8ztcAJF9epu+TSUgSpg03HA/Kvda47Eu6ZXb2LHijqdT9bF5 S/Sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XsT9irgS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u18-20020a170903125200b001b212ecbd17si10182578plh.233.2023.06.23.09.10.08; Fri, 23 Jun 2023 09:10:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XsT9irgS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232347AbjFWPym (ORCPT + 99 others); Fri, 23 Jun 2023 11:54:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231272AbjFWPyk (ORCPT ); Fri, 23 Jun 2023 11:54:40 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0838B2707 for ; Fri, 23 Jun 2023 08:53:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687535631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RqBYL4rToudmasXW3rSZav1ahfNpM2ZL3pnL4m6T3fk=; b=XsT9irgSUGoMzbP9pD2Zd4JwjtGhefQ7CMouD9HcoAZWJCCvPfLQB9zBd7CfktiJiRWLZu H7kI6GEkbvmVeNmdEto5eApEzLR9iBpwL8O/EpblAh7VQDdhwAc4gKvuwoArfH1nGdchuv eijt1qwALQAe9tpnjfszKctp+IaRHGw= Received: from mail-oa1-f71.google.com (mail-oa1-f71.google.com [209.85.160.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-478-Q5OaXB8UOoeerHr0M_sZhA-1; Fri, 23 Jun 2023 11:53:50 -0400 X-MC-Unique: Q5OaXB8UOoeerHr0M_sZhA-1 Received: by mail-oa1-f71.google.com with SMTP id 586e51a60fabf-19a78bbbe26so649728fac.3 for ; Fri, 23 Jun 2023 08:53:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687535629; x=1690127629; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RqBYL4rToudmasXW3rSZav1ahfNpM2ZL3pnL4m6T3fk=; b=BdlNbu+bNm5/u+/s5hl1cUuq7z8auA5BvjO70yCeOWNXAo+bsVQcLFC/9AuBXPp7JA SxGQvMKHEG07938t/ba+jFeSUD9N/4uJmXFvKlD7pc+YChvJszRvWNTh1zLQ6d1X/AYh wF95N170uQTcgf9+EnqBEF+ilEXOfsG+cHSgW9BCeAU0FS/HjOKNkagW9knj1g5EGAjv 144eg9KtGKSnx1iffIDXFrB6fhspke2gZptALP41ucZLleY0/qHQThET9VrI7/HLD4gQ c5Uat7L8cEZ7rW5W421IEFAajzE4LsyZA02bByvjGqggJnH4mdQB9mjoCcyIqM5EzYCB OW5g== X-Gm-Message-State: AC+VfDzHawfQ9wxbzu7yoXjX9sKatLC7p4eKj+2tq/Lt5MjqmYSv0iLK CrCopjKKl85IXm3V6HPrnZ0s696meorfx5uebDilAuHdvKtFGcBjq9oY5CIycSvSVXq1IL3Qj/u Io6vi5yerIQdkQG8/TAvGNeDarFo8hpJdlJ6Y+26QNIVE7QSufGIvUcLJdFpwCzBW0VegmWvPxQ crsKtDdFH3 X-Received: by 2002:a05:6870:7697:b0:1aa:220a:fc8 with SMTP id dx23-20020a056870769700b001aa220a0fc8mr12850290oab.19.1687535629341; Fri, 23 Jun 2023 08:53:49 -0700 (PDT) X-Received: by 2002:a05:6870:7697:b0:1aa:220a:fc8 with SMTP id dx23-20020a056870769700b001aa220a0fc8mr12850274oab.19.1687535629003; Fri, 23 Jun 2023 08:53:49 -0700 (PDT) Received: from halaney-x13s.redhat.com ([2600:1700:1ff0:d0e0::f]) by smtp.gmail.com with ESMTPSA id a5-20020a056808098500b003a0598f7d12sm1955054oic.21.2023.06.23.08.53.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 08:53:48 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: linux-pm@vger.kernel.org, sboyd@kernel.org, nm@ti.com, vireshk@kernel.org, Andrew Halaney Subject: [PATCH] OPP: Use dev_err_probe() when failing to get icc_path Date: Fri, 23 Jun 2023 10:53:38 -0500 Message-Id: <20230623155338.943655-1-ahalaney@redhat.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769510401322982030?= X-GMAIL-MSGID: =?utf-8?q?1769510401322982030?= This, in tandem with dynamic debug, can print useful information about -EPROBE_DEFFER like below, and keeps similar behavior for other errors: [ 16.561072] cpu cpu0: error -EPROBE_DEFER: dev_pm_opp_of_find_icc_paths: Unable to get path0 [ 16.575777] platform 18591000.cpufreq: deferred probe pending Signed-off-by: Andrew Halaney --- drivers/opp/of.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/opp/of.c b/drivers/opp/of.c index e6d1155d0990..1f0923cc1cd9 100644 --- a/drivers/opp/of.c +++ b/drivers/opp/of.c @@ -513,11 +513,7 @@ int dev_pm_opp_of_find_icc_paths(struct device *dev, for (i = 0; i < num_paths; i++) { paths[i] = of_icc_get_by_index(dev, i); if (IS_ERR(paths[i])) { - ret = PTR_ERR(paths[i]); - if (ret != -EPROBE_DEFER) { - dev_err(dev, "%s: Unable to get path%d: %d\n", - __func__, i, ret); - } + ret = dev_err_probe(dev, ret, "%s: Unable to get path%d\n", __func__, i); goto err; } }