From patchwork Fri Jun 23 04:44:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 111911 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5527206vqr; Thu, 22 Jun 2023 21:45:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5R9gGAbPrcck8DRFdyvlz7VGXMgf49J5n0Q+87TcZ0+CTNX4yjV3LJ7Ii7aGscUf7JPN6t X-Received: by 2002:a17:907:9628:b0:987:6ec8:aa87 with SMTP id gb40-20020a170907962800b009876ec8aa87mr18567663ejc.74.1687495536110; Thu, 22 Jun 2023 21:45:36 -0700 (PDT) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id lu15-20020a170906facf00b00988ceb28006si1059420ejb.754.2023.06.22.21.45.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 21:45:36 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=EEPCx62j; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2956038582B0 for ; Fri, 23 Jun 2023 04:45:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2956038582B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1687495523; bh=8s+zxB+y1KYuVPoVnbuq/MtYqtcKCbl+A81oJdhP5zc=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=EEPCx62jetU7ZPNT4LFSqqUB7K0oFUz2IbGFynFdIngVI7yRlDqvEuj/5clFr8JrS auPHY9qI8z/GhqK9fZsEdl8Awpc19uBP7fc7wTKfZrTphL6wvPrw/KBbvaZdjsf7oL GlboocA5zxlD8+Dx+ayXddrHX/FzT/Lv3LjbeA6A= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 1243A385800C for ; Fri, 23 Jun 2023 04:45:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1243A385800C Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35N4Va7v004832 for ; Fri, 23 Jun 2023 04:45:07 GMT Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3r93m3u9pp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:07 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 35N2ShDY007128 for ; Fri, 23 Jun 2023 04:45:06 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2042.outbound.protection.outlook.com [104.47.66.42]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3r9w18uxk7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TWcSD3P+qRkjFflsGIW7qzx9LIGaBhzKisc9sSqFBaHLErjTGDJdLOM3iInE5D6nn5NV93K2hwQdYw4wlBLwO1ZqtZClhwVpyTAcFDqGv9+PidKDahPBAzqsYPTLX2qv6vYdNkXbCIUCIscTWBT8i8S7JMBc7CqeH6vGkX7N9ay4Lqw68JfOKm1qKAaLZv81LrFzU5eyp31hddVJ5tF3eWLDhy+9z0EGjrT8SC1N7Lj/hEb5WZJYsrqxT7vuARWFU0TC+lWrYAB3my85S7HWX+B4w5kl5z2Tl55MaVcbmEE0EvfY6/Kj+jiRyefEdwCb5tTPxk2qRj1xGQzCGUJqSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8s+zxB+y1KYuVPoVnbuq/MtYqtcKCbl+A81oJdhP5zc=; b=Qsdv5ysSlwE4jrJowIrZL4cBVxnOKDpAAzy4z+p/6//iDjGHBdv3Ik7IfcszpIQKOSJt/VM3p54BctZdfILBjAUmGrTi8nZbD6zi/rH6PDMi1rBAe+AUoL3m2qelPNrmg5qf80rrpf3xdmouRB7HuNmOJ+MMj1iiIMR/oY7UIkQbATNOh5m19EDKU7xq7LpUubJUxtii4fAPQVZlFXWro15MRsiwE3j9TI5wfxfOCXHNUcoJUUqORRash6grnsCOZHzyAa8dAw73h+ng7dWCtKrkTNpebCNySSom9xl81xbRdOay53GgLBjDOIeI9TANKfawgxWWqqCyI1baPqUi9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by DM4PR10MB5966.namprd10.prod.outlook.com (2603:10b6:8:b2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Fri, 23 Jun 2023 04:44:58 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6521.026; Fri, 23 Jun 2023 04:44:58 +0000 To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH 01/10] libsframe: add library versioning Date: Thu, 22 Jun 2023 21:44:39 -0700 Message-Id: <20230623044448.2617101-2-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230623044448.2617101-1-indu.bhagat@oracle.com> References: <20230623044448.2617101-1-indu.bhagat@oracle.com> X-ClientProxiedBy: MW3PR05CA0025.namprd05.prod.outlook.com (2603:10b6:303:2b::30) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|DM4PR10MB5966:EE_ X-MS-Office365-Filtering-Correlation-Id: 88d56264-bdfe-4e86-8485-08db73a498f3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ip1txHaSl9Y4Ou4C6YsZJXyotHvwKJqK75b2cPe1u335tIZxgjJ74vqp6EJPuRbfJj5aTELTRYi4HeLGz5ubM/Zmylt34p696Wvp8aEN8BRpI/u53Cxqizbi7PnykwqTWtBzv2v/UJgFct++NQmUisj17Pmflb8d+DZyp7iYmN2g8DiV28IaLOlm3Zze/ghoT/kwytZwb1kJ5xdqgQbAffD0weaMJHnnnKEekdZxwtpJ/GCcZc8byJZSduLgimJUlQeFidSIwFOUxjjvM25Uk8xosSAjWNhhDJ7ENM0wAk0KhHPRuqiyGseze1NWHdqCFi+QFndaSwXG/z8HFy0B03Y9UNEXUGIfe1BnbTNqZhCLmDfPy3WQJIy5pv6MLynTtYF8OBMRK4BofOxsIYcKCxzScWrO1BhDWmWiLdAtLRc8tIwEoDHdXbvV4MrAEa2OCbW5ppBkXDXc2q7ZS8WFeBSM3+2tF2NmXSiLWyMYn2wzdN8XhINks7TWmK9zuLj/8ZbgDI9sw3ibgzx9e3uvYpFKkdHfVptrsUFTqVzGN9t+uTK0pejc5sZQo7CAecuE X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(346002)(366004)(39860400002)(376002)(451199021)(2906002)(478600001)(38100700002)(2616005)(36756003)(6666004)(5660300002)(6486002)(66946007)(66556008)(66476007)(83380400001)(316002)(6916009)(86362001)(41300700001)(44832011)(8936002)(8676002)(4326008)(6506007)(6512007)(1076003)(107886003)(186003)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 9jF53ipaa/h2PkANYzMSLSDdLfoloYdR0uiFuaGEIliwuGapLGqLJg6huTxti4qsBcGrAMblR57rPt4gWB10iGlpZR5ur41lSlHAlwXcKW0ZwdcIjEK1in7i/Bzuzr3m0Qv1fkbEpuO9w3+WGvCTv1BqPSeWvO/IFohvElMkpepjzH/ATjrbzQmgva/zmyRDE+VMJAYV9UXTHlsnI1fZZltoxSj4PBKSZM3Ekg2Wv1wwTT7EX+N9tFMjcV9fVh2W0BwJuQYlZhd96+949D2XbICQs4AlvqsvbUEr+UF92NusUPilQy9PDL0X9XaUvud6SI2XkzPpZwC3UFqQWko1X2srf7B7GiqzmFrSAjB9xA3BGI3D8ByM431HOEAGEAOIyFVhiXYeb0WYJF/xBpFVxHZMq+nnFjl85MheiItEKX4emlEJ8G+iGmWKZ3AsH+WC1+9WBAiUIp0wptEXf0hAL3O5LtRL7Tcw6RfYaa1opoa3rOrF52QxbfMXb/Lhi372170DALzmrrfpwW0e5i9LzQg/zt/NaoaTJTw1zvnL2rsRKO60Kx1widVejWunVwlvWTFuUyRctsv25la9giDMGfnU3vn3hVdzTprH/kSSS15NPNoYZpjzs5lTqhiCRq8xu0Ea0EZgjCUm29m/nXHwLDaL98Zl83TwhLQCIE1m6Fd8vXML+cWlxXxYKT9QOYHt/HxVz0AdET/mmf0vlXRRBIeFhWjk9AlQt8voz/4WdI50Pog2VR61rxkeiAou5e2b3l+Y0vsgevFNshZqVJ8o5dTEiXevWjiSi0inv4CffoSglvgkad5VlYmHvVnddGoF1mArrUq/0gqcfAGPLpcwblG3jbwLMqts1pLJXx4kTsUbUwAt8Ps/ErakZMrP+O/dkZGxfOm3RroT+ILLcB17VlCCWp32tYM/95bUO8mwQg8mX3LG28UABfpuIh00FejADaUQ27UU+Q6CghH/frKNeSwcGCOO5j0dv6NznG2z/rtHR9Z9BQDyXJ0mugBUgHib+Nv8auYqSjdDiaVGV/hsh0KGvFVpmbDUy+rOzSdt/Qzl/HIww/yKFPm4EMwrnxJQgyXiB+qMjAfPvr7krh2Y8woZn/Ko1IkDTJcoCQgPqhfkku6yy/NA6+L1Se1WoGMjWEQIAN5LeB97La4lpbRnmkvdN2yQoRPC0yjwGArSQi0hDbzLyEGyBVm3ILa6tQRR1KDbp/UJMhQI9yG6vSzWYkGus/KOAiuYaXh5Kt8l9giXg+4JA9iRCSkm/g/Llg0CJHHjZ0V6dSh5C0y6tw9Q2n1xEBxAbGWkO8moVOZ1t6HAlSCOZW3XYK0soi7eff+7Gf2NMa2r6daq3Km/bQEUN+PKjb0lBHMdVOE9HkvevCTTeX0eSLQq6NDZWnMv7klQkD3y8kaNVSbvLznXrnaZ6SJLkDXVsAiGzajIzpXMhvMwvZQd987WrALfyJ0HTZnzTtmdW+vniVmbp6OSAhqTSOuwckjZtdNoc4zaqrhcj+3Zk/DGOIEAtA7rBRTStNdbDBRRhy2L4CLyEXuIWwgz5YqpvNnhxZlA10kpJPWVHd8yAGqHGMPnvP3iynSIZnDx X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 206HyTdG6IZQ9D0RceD5vPf95q9wHC9U7MrIODiXXPAq8f7PmxgEdbNu7cJ4VL+4+w16CYyTL3UWPmdH9eWEHlwiPa9eznz3WFKhdnJsda8Cw371uaD4hN3Qv9dqAQlya4hMFZZoTFJYbqrAgUvyTqjy9PsMmN+QdtbsAzpbIFNk9ngE0sFPY1+QoCofn/pIEjiauSmNKx63MFKLBTNDr8LQe8RNrGJiEFAhu4ZfHBWKQzkaTRo2CbJ8vanwn++hLNoxmCBdBd8jvt04jXFn3Dmn/QJTYjqj9pttzGhMSYG3WZ9PVp6lm5Lfbd4Uoo4rVY2rpmNxT1p/1+zToS+58HGi1H9M6n5MnT/tOyqZSknQgtSrUOkrtSsF5kt1KI1JaOD1QSwSBl9a4pzomk8U3B1FIaNEgMjAeFkE7xYaM9YnQJed4DHfMtUzdGUOXCiZH07BwV+eW+lhcRNYZQKen3qOwWFA4BSC14t8atma83DOFM2xO0S6u0yeDjkfFJfPkRk8VOR09PClMpo1HU+oXTwiDm1MJccD6mT0HnUUY973geb/XtSoydeuMYZNADY6lXA50dKdZA6kKlgG6w3YRi/3qH294LDE2o1slafdmBTMrrWHN2dW0VcSpyok0TSRb+/Bx86B6cgpkwdOiNCXqpH4AMf/YqxTcsibd5skONUfc0oNOq5Jr9d5Cb/3EC8fC5guDle0bePvqwxMw7YIaP6ibwDoEMHKfFUjxoHqXIviBcdwvKJx+7HtXb1oHWGt X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88d56264-bdfe-4e86-8485-08db73a498f3 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 04:44:58.1969 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ebaZsZCTtRGHfsNOPrrdae/h5EVDpys+ifPcqLgHY4z0QtrbUg4sMwS1TSABxmO3AtUs5sFw59ncNtN5zQtR4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB5966 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-23_02,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 mlxscore=0 suspectscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306230041 X-Proofpoint-GUID: qWeXScMnKjZO7-N4QIw3dBgGG67zJIu4 X-Proofpoint-ORIG-GUID: qWeXScMnKjZO7-N4QIw3dBgGG67zJIu4 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Binutils From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769467319042184226?= X-GMAIL-MSGID: =?utf-8?q?1769467319042184226?= lisbframe was first released with Bintuils 2.40. As the library evolves, some changes will break the ABI. Add library versioning for users to manage these changes. For the next release of the library (libsframe.so.1), incompatible ABI changes are planned. These will include: - Deprecation of some APIs, like sframe_get_funcdesc_with_addr (), - Change in the contract of some APIs (e.g., return type, behavior) In libtool-version, set the current to 1 to prepare for the upcoming release. Reset revision and age to 0. Add libtool-version to EXTRA_DIST. libsframe/ * Makefile.am: Use libtool versioning. * Makefile.in: Regenerated. * libtool-version: New file. --- libsframe/Makefile.am | 5 +++++ libsframe/Makefile.in | 9 ++++++++- libsframe/libtool-version | 30 ++++++++++++++++++++++++++++++ 3 files changed, 43 insertions(+), 1 deletion(-) create mode 100644 libsframe/libtool-version diff --git a/libsframe/Makefile.am b/libsframe/Makefile.am index 2d736624208..2d1d8fff063 100644 --- a/libsframe/Makefile.am +++ b/libsframe/Makefile.am @@ -29,6 +29,7 @@ INCDIR = $(srcdir)/../include # include libctf for swap.h AM_CPPFLAGS = -I$(srcdir) -I$(srcdir)/../include -I$(srcdir)/../libctf AM_CFLAGS = @ac_libsframe_warn_cflags@ +libsframe_version_info = -version-info `grep -v '^\#' $(srcdir)/libtool-version` if INSTALL_LIBBFD lib_LTLIBRARIES = libsframe.la @@ -40,6 +41,10 @@ endif libsframe_la_SOURCES = sframe.c sframe-dump.c sframe-error.c libsframe_la_CPPFLAGS = $(AM_CPPFLAGS) +libsframe_la_LDFLAGS = $(libsframe_version_info) + +EXTRA_DIST = libtool-version +diststuff: $(EXTRA_DIST) info include doc/local.mk diff --git a/libsframe/Makefile.in b/libsframe/Makefile.in index c6a4cd56a9e..57f912caa13 100644 --- a/libsframe/Makefile.in +++ b/libsframe/Makefile.in @@ -180,6 +180,9 @@ AM_V_lt = $(am__v_lt_@AM_V@) am__v_lt_ = $(am__v_lt_@AM_DEFAULT_V@) am__v_lt_0 = --silent am__v_lt_1 = +libsframe_la_LINK = $(LIBTOOL) $(AM_V_lt) --tag=CC $(AM_LIBTOOLFLAGS) \ + $(LIBTOOLFLAGS) --mode=link $(CCLD) $(AM_CFLAGS) $(CFLAGS) \ + $(libsframe_la_LDFLAGS) $(LDFLAGS) -o $@ @INSTALL_LIBBFD_FALSE@am_libsframe_la_rpath = @INSTALL_LIBBFD_TRUE@am_libsframe_la_rpath = -rpath $(libdir) @HAVE_COMPAT_DEJAGNU_TRUE@am__EXEEXT_1 = testsuite/libsframe.decode/be-flipping$(EXEEXT) \ @@ -519,12 +522,15 @@ INCDIR = $(srcdir)/../include # include libctf for swap.h AM_CPPFLAGS = -I$(srcdir) -I$(srcdir)/../include -I$(srcdir)/../libctf AM_CFLAGS = @ac_libsframe_warn_cflags@ +libsframe_version_info = -version-info `grep -v '^\#' $(srcdir)/libtool-version` @INSTALL_LIBBFD_TRUE@lib_LTLIBRARIES = libsframe.la @INSTALL_LIBBFD_FALSE@include_HEADERS = @INSTALL_LIBBFD_TRUE@include_HEADERS = $(INCDIR)/sframe.h $(INCDIR)/sframe-api.h @INSTALL_LIBBFD_FALSE@noinst_LTLIBRARIES = libsframe.la libsframe_la_SOURCES = sframe.c sframe-dump.c sframe-error.c libsframe_la_CPPFLAGS = $(AM_CPPFLAGS) +libsframe_la_LDFLAGS = $(libsframe_version_info) +EXTRA_DIST = libtool-version @BUILD_INFO_TRUE@AM_MAKEINFOFLAGS = --no-split # Setup the testing framework @@ -654,7 +660,7 @@ clean-noinstLTLIBRARIES: } libsframe.la: $(libsframe_la_OBJECTS) $(libsframe_la_DEPENDENCIES) $(EXTRA_libsframe_la_DEPENDENCIES) - $(AM_V_CCLD)$(LINK) $(am_libsframe_la_rpath) $(libsframe_la_OBJECTS) $(libsframe_la_LIBADD) $(LIBS) + $(AM_V_CCLD)$(libsframe_la_LINK) $(am_libsframe_la_rpath) $(libsframe_la_OBJECTS) $(libsframe_la_LIBADD) $(LIBS) clean-checkPROGRAMS: @list='$(check_PROGRAMS)'; test -n "$$list" || exit 0; \ @@ -1568,6 +1574,7 @@ uninstall-am: uninstall-dvi-am uninstall-html-am \ .PRECIOUS: Makefile +diststuff: $(EXTRA_DIST) info @BUILD_INFO_TRUE@html-local: doc/sframe-spec/index.html @BUILD_INFO_TRUE@doc/sframe-spec/index.html: doc/sframe-spec.texi doc/$(am__dirstamp) diff --git a/libsframe/libtool-version b/libsframe/libtool-version new file mode 100644 index 00000000000..9dcbe48e47d --- /dev/null +++ b/libsframe/libtool-version @@ -0,0 +1,30 @@ +# This file is used to maintain libtool version info for libsframe. See +# the libtool manual to understand the meaning of the fields. This is +# a separate file so that version updates don't involve re-running +# automake. +# +# Here are a set of rules to help you update your library version +# information: +# +# 1. Start with version information of `0:0:0' for each libtool library. +# +# 2. Update the version information only immediately before a public +# release of your software. More frequent updates are unnecessary, +# and only guarantee that the current interface number gets larger +# faster. +# +# 3. If the library source code has changed at all since the last +# update, then increment revision (`c:r:a' becomes `c:r+1:a'). +# +# 4. If any interfaces have been added, removed, or changed since the +# last update, increment current, and set revision to 0. +# +# 5. Increase the age value only if the changes made to the ABI are backward +# compatible. +# a. If any interfaces have been added since the last public release, +# then increment age. +# b. If any interfaces have been removed since the last public release, +# then set age to 0. +# +# CURRENT:REVISION:AGE +1:0:0 From patchwork Fri Jun 23 04:44:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 111910 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5527120vqr; Thu, 22 Jun 2023 21:45:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6o3MohYFIpqmyARQLOBAcfslpmHDfD2Bcz+vIPeOED8jE8oa0Yvjg08C/HKu4vlynu7PGT X-Received: by 2002:a17:907:70d:b0:979:65f0:cced with SMTP id xb13-20020a170907070d00b0097965f0ccedmr16419902ejb.17.1687495520675; Thu, 22 Jun 2023 21:45:20 -0700 (PDT) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id dc26-20020a170906c7da00b009882f2a8aabsi1447654ejb.551.2023.06.22.21.45.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 21:45:20 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=G0kNwui8; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3541E3858296 for ; Fri, 23 Jun 2023 04:45:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3541E3858296 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1687495514; bh=V68GljL/2h34Nv7lzdSIqJhuxtN03Qhhk12JUoTaVac=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=G0kNwui8FeOw6uQW5nkRUGsgOAA3PxwRam4p9jX3SCj0umgkqDpzBM3QY2XFPfBom 74GNRfgHq1UsSHDxvdUG1ptyGqABkaITSf/MAoZy4QPu2/j9WRAgL23do+72Ca9nt2 TdMe8QAvzBqq34S1hBsBsGptb5H50aoec4fVckI0= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 0AFB13858280 for ; Fri, 23 Jun 2023 04:45:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0AFB13858280 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35N4W11f005661 for ; Fri, 23 Jun 2023 04:45:04 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3r93m3u9pn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:04 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 35N1e4eR005820 for ; Fri, 23 Jun 2023 04:45:03 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3r93989cgm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FzeqszsNh0KaS4Czb1e3sOr7wvG6IK9OEECb9w/4coQvSOb4qc2JvNs6VOt1WZpljTIQQ7U2ZZjtdx3NUxG5HNojVBwo+IBIBygJ2yeAQCVs2PfJwSbItP7icGxlFQRZ4UbM7bIJlrAFk5m2j3j0YIHUruEh1tMQbu9POzXjlQ5BtGjyLmfT0v+4HjmlUmMOSlgsPqHiVS8h09BQlEeGOSJH9CQ+ycFZituCCP/y4oq8jNPVblwePFYS2JOkrY2RoFwU0Q8lprJNLyB+3RHkhh+AqpGXFbXiJKVNkQX0/Ye8/JiOynDc4Nbh/uMeSgEN2clSTOCjSBGRHc9nSa7TEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V68GljL/2h34Nv7lzdSIqJhuxtN03Qhhk12JUoTaVac=; b=DO8DR/pGUkvTA7GCEuyb9dNto/zpOLub43UCdAXT9SL38ii/XzoVQkyTN8EXlHu0MFeiCu3xIA6yM1r/HNCoKoX+DXJIJb6RveBjq4T0Sq8HwnMPRhGDrNgCk4+oT8UjCduGrU6Xpn2gC2Qg7lTc3sIc+eD16LVCYy1p3XrebjsYrE6LJGVVhWOeJGWVO7Du6RvAii2GKEanZB/uGZm+sPuoKRehSZ4qXkucYbOlpTSHx7CidbNB9+W13+ln+ZH62HFrvE4MtM8JcBodRgzJZKRzGTCmtU+00PAZV4mG1SKgInvmFOUIIwkJ9LKy9LF+rHXFWWLZyNJJ71b3kFsPcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by DM4PR10MB5966.namprd10.prod.outlook.com (2603:10b6:8:b2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Fri, 23 Jun 2023 04:45:01 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6521.026; Fri, 23 Jun 2023 04:45:01 +0000 To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH 02/10] libsframe: remove sframe_get_funcdesc_with_addr API Date: Thu, 22 Jun 2023 21:44:40 -0700 Message-Id: <20230623044448.2617101-3-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230623044448.2617101-1-indu.bhagat@oracle.com> References: <20230623044448.2617101-1-indu.bhagat@oracle.com> X-ClientProxiedBy: MW4PR04CA0189.namprd04.prod.outlook.com (2603:10b6:303:86::14) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|DM4PR10MB5966:EE_ X-MS-Office365-Filtering-Correlation-Id: d3a38a78-b096-46db-3f09-08db73a49abd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uzaRher5uTTgNhKnyxr5Z1FqlkYbsMXMSrVyHd62dUdZbc/VS8AC6liuFfyrWEJkCuEhNmhsI0bkJTRiSq97ZydhS5RccMrERBEwsH7a7Xbu+T/Tkd5D4X2WV7si2oaiX36rar631cXH+krNPONmtUEiCL2a1JoKDg8pwEtNk0tJBu3LJXCDEPq18Npe339xNqmro4WiVaSrr1dc9dS6pJ5PeJ7ZQrFtdEIxIT8COUdBw7gEj+HJjuNLoWXk0dtCgSU550bMHJIl5ypsCScNeLwgDWL08rVghIT+zvLAF6FxL9m7xTY+hWjXBAO5v+YxcShBKyWzjII01aGWNemEdJQfVYiItO05rkc+S+oTVHZpjphekB4diyhf5kc7oBklDNmSX3qMbihCI6NKb5Vj4gadEIBx0R+XYu3kpXZW826VclKYNpKLfcIQBZr5q5ukbdciLe7zNJldQeaPdNBVF9Fc/CBLh2xLLdNTwoaCMCWB6dUy83qWL+KwY60i1OZHNYRpN+2rehOaThx46NEA2XczudaOa4s+xtSGSZFuuzeWx1wNao8/af12tgBHmLoI X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(346002)(366004)(39860400002)(376002)(451199021)(2906002)(478600001)(38100700002)(2616005)(36756003)(6666004)(5660300002)(6486002)(66946007)(66556008)(66476007)(83380400001)(316002)(6916009)(86362001)(41300700001)(44832011)(8936002)(8676002)(4326008)(6506007)(6512007)(1076003)(107886003)(186003)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ZkNE7sF7HYeZk3d2HW5IRSl6NVUmLB93osbxXNXoWIOVgSLjYSnfcZfTCzr70VP/koAZ2yfW38a8GxgH7Toza6S3FxgYPTfl/cwJCzeVfRpMfTgBYB+tyWqmG6uZihJXHJdNZzZFmLuSLC1cW/nbcxoppJLiHffQX4Zh2w5zSVe9jjiHA0ud4ZmrI6yT5mS7WiiWmhohOwTQXKXPi6tNzgYw7ag7PegxpRAUNCZTc8vhg9Pc6P94bVDm+/ea8f3XKx9gIn5zRbiMwLRtA5zY1vse1ThOMs33xgS12K+YRV2azJOc8QMG7+8IaIrfZ6x+I+RPOGB5PoxzVkSOUuT/WPKETKM4H7S4h2OT/OpzI+iQH77NTp5zczcCeQ3ESAMu8f06otdGdIzA1NWxLgIfJ6AqXPzLjMGMVr+1H1j4SWZgzWmG/cjhKJ9tIsvqM21mRU+kBd4HDJ3lh61m+TtlLhzVpKe2Ar0TlEe4maqefSeXe3FBF+At9OznsDwqbaFJdx4LhyG0r3+7Jjmnb9LbXGFcRRP96jVQLBxtWzhtwPVU8F88IDaNKakp4LON/i4vZiC00xnPywSofUFJvYIGcEToWVfL+UbD5JW8XRy9LkWy5VBzkLjwN3cLdEPSuv5I5J5q2Sl1INqSXSEuQJhTdwxwO9bJLaP1galhEwX70TjzVuYknZ7GgjQn7copOZkNuLVdzVY2V9SyzFjuY8omZnOEhezSa46LiXJL4YgUCpxhPn71a9VMlMh4vUZTjdM8kHqlIBG/95VLHTIZ/9GeU7Ek6P+QWNEmGyD+my4+Bmk6kfa09AQL8z1IuKGldR1RsmLFDgCZlHqvYc7MOur+DST5nmGzknki0VN8P9JHONvcK1enklJd8L8BuxnmvIBciGKKof5pqkE+ohvzo5nROoSEGOTeiRx4TQoMht2wik3xcE1e/GGCc5g9GDca6nF5f5vPjXRnI/I2WZqAgM69jz4NLczuAoZ328dObUtHAjI0GeUd0NYpyg0tPnorwa6738jn4e5wAydwVr/looONTr9iLz1YA+puYJ0baCnSjPYTrvXUMXNdq/YwxaWvtu+/9ctc9Ycc9hQr/8iUPQtTR4mnauBo08F7BC+VerCVtjWMI1Su9qKEds2PlvvYC5ewpOpstsT/WNkRrWsP7pjSYbUy+zJqtNDcxMClnsq4jIO8V+NSPRwZ7wxwkiXiB6qcjqOrRKK0GzKPXVhjkF9sKS9NK/gkDs+kfVq8ghUmWwKaHhSEU960CDlmE83cToxvSIy4wZkhWCC9ivzHZ8qw3cA90bIKEGkD794YNg2GqJLdmuSH/mLsgl8H+cS7vkLP2aFXzqOCxzUWomOIA8Yz6vUfaToiRWGIXbkmx+q4pRvgwM5TfzFfBKk6RjyhLrXubhctp1M65Krl0PEFINR81TtjVuG4RqhTwDCmXMVWg1fN4EBCdq8ucXBnSNmQljymKkyHWEqvyE8SoJS32oNCtpn3WS/QXG1pnPUFtZFQZfIYdvPK8/bNavZsMrONmIUscOQeGiVrFNTOETNYLF38ij5Ob7Lcpz3lhmdU6enZURWVSfjxp5rJSiu4jZKAKleL X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: fXEopYol+9B1yZeNR/lkL35okT83AWebCYeM70VndT9pmQH/7gZZPv6PA5Lx5G/k/TL//b3V4h5fXpsOFqepRBmfKmCIder+9ENOUakTx1MBBhfdeai/ufO2mngFWEZEypl1JfMAKA5ckCcqlrpPZI1bDkp1jcFXtHY+1REujfO1GKOjN0mg5Q0KaUmwaKOry5iNs2Wu3PlBECx9Pb5lc+Oh/dQu3p2P5bo5IJOLScc74eKDBv5nEErl9YSH81wxsBzwW2AlrBlx7vdcBkkZX7UjsIlDU+65MQ8VC68XyTcgVRDMUBFUi+SlPilauer5fsp6hjd73K4/+BX7XPrXYO+FTRr4NDnBm7t4vvslXx1QwabM79iRQtJqmZR8E4wppzZZSKGAr6odVfYZ7WLYe/f6umITwEismjUe0xYy1U7F3H+0+MUqu5kgVSSlvss82d6SkuzSsFR+zBAVb9Gida0RSU7nCh/276ntIETsjKIdzyxRYHDSdTlywj2Qfs+Wz9zKsQud9+aCmU6E80WeV6qD+NiX7E6msQayNv+DuRgH1MoqlR8Sry40iJFoX0BANmIiclpIixNQf/WGR3guPiyRu/38xZUluHEr78hEK7cZli3w0xl9IkRfXrWUfJvWTGnWFTzijAMezVLTjm3Qiri/97cXrlc7JC96ydt1dHivSnN6daDlge6K+UcfeOm1+yKu4t7N12+INeYESFp3TkuGzlR0cG6dJylJ9ocInDTLd5Zp689p9I5T8qDKIjWu X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3a38a78-b096-46db-3f09-08db73a49abd X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 04:45:01.2034 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XYHKGedcmryr4Z7QhObsuGQ1dzb4Gr4HaUfGCJ1Qy6hE3Qhu4+DrFOKRFxgd9w4cVFWrk9TnSPNP1PBa+mkp1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB5966 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-23_02,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=966 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0 phishscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306230041 X-Proofpoint-GUID: MIWMntNC7AVERUK5ETpQByxSHhrnogKl X-Proofpoint-ORIG-GUID: MIWMntNC7AVERUK5ETpQByxSHhrnogKl X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Binutils From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769467302841268277?= X-GMAIL-MSGID: =?utf-8?q?1769467302841268277?= This is an incompatible ABI change in libsframe. The interface provided by this function is not a healthy abstraction to expose: the return type sframe_func_desc_entry, which is defined in include/sframe.h (the SFrame binary format definition). This ties up the library in a undesirable way. Most importantly, this function should technically not be directly necessary for a stack tracer. A stack tracer will likely only need to do a sframe_find_fre (). Rename the API to continue to use the functionality internally in the library. bfd/linker does not use this function. Change the return type of the previous definition and make a note about its planned deprecation. include/ * sframe-api.h: Change return type of sframe_get_funcdesc_with_addr. Add comment for intention to deprecate. libsframe/ *sframe.c (sframe_get_funcdesc_with_addr): Change return type and set error code. This API is deprecated. (sframe_get_funcdesc_with_addr_internal): New definition for internal use. (sframe_find_fre): Use sframe_get_funcdesc_with_addr_internal instead. --- include/sframe-api.h | 11 +++++++---- libsframe/sframe.c | 20 ++++++++++++++++---- 2 files changed, 23 insertions(+), 8 deletions(-) diff --git a/include/sframe-api.h b/include/sframe-api.h index df1f5ccef4c..a00303a3598 100644 --- a/include/sframe-api.h +++ b/include/sframe-api.h @@ -133,10 +133,13 @@ sframe_decoder_get_fixed_fp_offset (sframe_decoder_ctx *dctx); extern int8_t sframe_decoder_get_fixed_ra_offset (sframe_decoder_ctx *dctx); -/* Find the function descriptor entry which contains the specified address. */ -extern sframe_func_desc_entry * -sframe_get_funcdesc_with_addr (sframe_decoder_ctx *dctx, - int32_t addr, int *errp); +/* Find the function descriptor entry which contains the specified address. + + Note: This function is deprecated and will be removed from future release + X+2 of the library. */ +extern void * +sframe_get_funcdesc_with_addr (sframe_decoder_ctx *dctx, int32_t addr, + int *errp); /* Find the SFrame Frame Row Entry which contains the PC. Returns SFRAME_ERR if failure. */ diff --git a/libsframe/sframe.c b/libsframe/sframe.c index 7308a45ce88..8837f878fb0 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -950,12 +950,24 @@ sframe_decoder_get_fixed_ra_offset (sframe_decoder_ctx *ctx) return dhp->sfh_cfa_fixed_ra_offset; } +/* Find the function descriptor entry which contains the specified address + ADDR. + This function is deprecated and will be removed from libsframe.so.2. */ + +void * +sframe_get_funcdesc_with_addr (sframe_decoder_ctx *ctx __attribute__ ((unused)), + int32_t addr __attribute__ ((unused)), + int *errp) +{ + return sframe_ret_set_errno (errp, SFRAME_ERR_INVAL); +} + /* Find the function descriptor entry starting which contains the specified address ADDR. */ -sframe_func_desc_entry * -sframe_get_funcdesc_with_addr (sframe_decoder_ctx *ctx, - int32_t addr, int *errp) +static sframe_func_desc_entry * +sframe_get_funcdesc_with_addr_internal (sframe_decoder_ctx *ctx, int32_t addr, + int *errp) { sframe_header *dhp; sframe_func_desc_entry *fdp; @@ -1053,7 +1065,7 @@ sframe_find_fre (sframe_decoder_ctx *ctx, int32_t pc, return sframe_set_errno (&err, SFRAME_ERR_INVAL); /* Find the FDE which contains the PC, then scan its fre entries. */ - fdep = sframe_get_funcdesc_with_addr (ctx, pc, &err); + fdep = sframe_get_funcdesc_with_addr_internal (ctx, pc, &err); if (fdep == NULL || ctx->sfd_fres == NULL) return sframe_set_errno (&err, SFRAME_ERR_DCTX_INVAL); From patchwork Fri Jun 23 04:44:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 111917 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5529007vqr; Thu, 22 Jun 2023 21:50:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6/sO/ELxx28yL6Fa0pH2R6SPzL02bvxmKJoOArZpf/WADsTBs+s1QnMxPtRVbDPNy7ApXe X-Received: by 2002:aa7:c6c5:0:b0:51a:4d98:e5ce with SMTP id b5-20020aa7c6c5000000b0051a4d98e5cemr10425763eds.36.1687495848979; Thu, 22 Jun 2023 21:50:48 -0700 (PDT) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id b17-20020aa7d491000000b0051643861867si4050683edr.226.2023.06.22.21.50.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 21:50:48 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=DWA+c7dW; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DABD8385020B for ; Fri, 23 Jun 2023 04:47:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DABD8385020B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1687495649; bh=fE2dcIM2hgvlXpIGmbS9AWkiDPHdUbp+0AuburqMn4E=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=DWA+c7dWe1kGYDaREp6CXQuSay8Ava67PPUztKtkoMql+Uw+MrfSXOpQcXAWtd8n+ 1kgauPyn/kLr6rD5gEJ7MeNYiyGaI5OF7XcOxgGDNPC7OL8H+e5KsBH8NRwqLVItKw uOIrDyuhcqEEknwQKOu+F3nV2DHaRpTGxzq/ALG4= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id A1AA23857C48 for ; Fri, 23 Jun 2023 04:45:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A1AA23857C48 Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35N4MXBg018006 for ; Fri, 23 Jun 2023 04:45:14 GMT Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3r93rbu7ry-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:14 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 35N2ASsR038671 for ; Fri, 23 Jun 2023 04:45:13 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3r9398g437-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZuFQN/3vK9iD042uDERTqAl+trwvlj/SQ2F1o9kDTyAa5LyG3Vuw9xcaRtyoLC7xVvUfrWi7kBhcEj4Jwn2cXbm8HlSLA9IHus2swPRXLbNE/dPQLaIOY0Q67l//RamGmkB6mJSMUI4gqwzAQP2gfrVDRf0E59+9zg6p06RTkBw573J9DzbDCKBwt/m+XRz509qu6M5wxHX2pFV9k6Vuzs1+jhXyVuyG3SERi/98vrOdKsP73ZNIct2IPfX+99nvOAz8QnrP//qPup+33diLcfSQvrZmgt/jANfyQdxtO9lVewbhnA4TUHnRb89e6MUpWWqeiFLtYQOjuyya+73c2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fE2dcIM2hgvlXpIGmbS9AWkiDPHdUbp+0AuburqMn4E=; b=TKd4pvWNqS/v8z7I+ZBxgSa6IVsSmIMO7B+0LftdW/bytQhsRGmfyLGz7RXZ1WH8+h80I7uWxYiUcmV/cSKewIOCEMVl16+pxsUpjWQNWZ6v5F37mqYTGs8DYbJbQaBaQRGYx0e0jZics6O8atyKqXuy6is4V1mYKAOm52+yEcgh0GcQ7UsRjmCC1JqKv+pywj3QtGT09uZYtw7MDfeMnTfcZSmqPuxveYQzAKGBZekUbcD+el9UHifQ24oBaGl0ryc1nnSZh+G3Mo7xI7wsYgTjf9V8zVtLq7gJtvBsWjTyVexJb8wpXP5xuH4BEMvMCPywc633e+ieE70I+hoc9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by DM4PR10MB5966.namprd10.prod.outlook.com (2603:10b6:8:b2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Fri, 23 Jun 2023 04:45:04 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6521.026; Fri, 23 Jun 2023 04:45:03 +0000 To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH 03/10] libsframe: add symbol versioning Date: Thu, 22 Jun 2023 21:44:41 -0700 Message-Id: <20230623044448.2617101-4-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230623044448.2617101-1-indu.bhagat@oracle.com> References: <20230623044448.2617101-1-indu.bhagat@oracle.com> X-ClientProxiedBy: MW2PR16CA0008.namprd16.prod.outlook.com (2603:10b6:907::21) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|DM4PR10MB5966:EE_ X-MS-Office365-Filtering-Correlation-Id: 6ac82a9b-fc09-47a9-adc8-08db73a49c59 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P3dX4Tp9nN2mG9GcUAJfHcSV89W6pVBisljItSysTWY/lZDq6LPJwZvtLYNY5x+0rqr6ADDzRnA27Ds/M55Ol+hp1U/uGbVhtqGT48U8sQxyf28ywOSDSAdIM9cQ9waw5raS5PkCYV8JHpC8AuN1spXbJpRxvYoGQOk644ZirWlO3YPjy/P6c8f16pNTtyQy7XWpjrmeiPizl0eH2JVTWvowcjWOUIoWNghZ+4l9/1E71BHTfN0+3hVNwdqq/GDatAW2/g6lXednuuM67ArBueJowaXVHevGBxW6XLADGxx5BK90ihBVtwVum1eEeXLeIlxk9lfPhgoIK1DWUZ0NV0+0VfckFvPEA0uETdKsIP9X80rCWmO/Tyv786xhoBEc4Q3KVi6YIoDx6K6EvfTB/T4zjkxhpSn2PVRfeXnQ7VQo84ceaKfgjw9fteR5Ls3Km/4bxj+mz7+JAxpYZEY50mpfSDv1DcnSZsbhBh5P4+u6FsQXyesfpCsANsI5Gebhzhl0yxLUDeQyvA3bO9vpogFsRNr2xWnxi4/sb/y58PVVFMOyNCCZLR3wrzdNhDUM X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(346002)(366004)(39860400002)(376002)(451199021)(2906002)(478600001)(38100700002)(2616005)(36756003)(6666004)(5660300002)(6486002)(66946007)(66556008)(66476007)(83380400001)(316002)(6916009)(86362001)(41300700001)(44832011)(8936002)(8676002)(4326008)(6506007)(6512007)(1076003)(107886003)(186003)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: bE9Mc5HIYaNxQ1oswR26EPOjJkD3NQS3bLAZhxj5PxmsPzT8rP2TVBKK4eaVzik4okcG2j0Wn6NtZSyoqa8B3tOxaiPcyjAisHGvoDp4pAbZNdM/mHN/K83Pw2V6KZeGzexLkd5ZMmAnPtaRbHKowvzk8ebMMdxDKWX/ebPsECMYAnWTyuKkwLnJgNHYfYsfDLuMx7r1tjxkQWeEGmGAMsNt86b0qH717MF88Yz7PLZJIZOD/IJ2oahV1TfdnWrtym3+h3Sp4zQvn/kqB3epJiqkd9hI2aJIJQvi/P6NtM9ddml0yFrX5cmehsVnjjVVVkJhX6E/URFxYAfGNZWOMbT7fFVuh0DcqbasBCjP1gJg/A/0iz8AFr3HHzHXyzeZpcV9gyKjNaUHFrFy+QIR3zFp+gIyIiTRexePHEW+OO3yYkza8yw//YsFc8ZC8WZ/m4g4Z+Z3DYClO6GJvDvStd2mD+SiIDTERZeH/elGYwTQYtbsifB26R2agNiCn4z9C5S+j/6Bc20GW1N5VQHmvje49nUZnkjZTzyO5mYykJVQwcqwHOcIuTpFk+X33Kq19CjxwS1wOexnoEQIU3QrdNh4E5OwuvKMrDmXcsSX6fTLGyzVqpdCRkhZXsdkyxu4nOUVAx4cN7F/rlEPUeZnMcQM/53+n/g6TceJv6Oc0rnfSIRBvR2xI/yfX1LWEiTkkOUjYf/K4YUNKy0FJZjHoo+wBn71xg1Ne71o0SrmfVCZMxW204WgesSEDrp/o1LlXtTlC8qEJCvJoc2nkUkyA/DY0QtobCIVzfceu+iF2OLp/ywBPHqmpuSwletIX/zM75kcwEazJKLY6CCC85R3MSNT/4WiP62c8etXFChWAfJAtvEl7K1iAbd38V8IK/N2IoSR3mn0UG+xhKS+vyEtXiIQv7OtQuNztiFAtiata+tSFugA3/fMWRos5kNifgLz+z/OBmzoSvKQOIs/W72Hx4Jn3D458+5nrKCunowIqosjPU0KQYuU5PQp3TlB5d77xjQy3mg0knLvgU+C/9ScBBSj+i+veerAMn99COmhtBTaQf+gsXfUdDX6CRK55ZT3mUcMR7MNBjmuHX5KkjrWR9V+qLgK6PHWtNz2PQLObM8E8e28V1rUODGAxIZ4yOccA6cc6BHfBzwSaAAdBTzReqrjiYjTKzYGC1pGjtM0f0XFRKyQbwzDj2u+gW3uQ2Y/k21GVVrajShvMtzdSroI6kfOhq7XmNFJLhaqA66C3wc8k9zH3qbZRj3nYQtXMGzrNrEOntJ8xraqFZaXPWaDXgCLAPnUOTol6v7Eb7gEk4VUyAu/IuPR36h0lrMpSqx2mvVDaqiVfB9GEpLZN6Vea7n6M5D3MUAbTW2CjiuiazGBBz6oINdX6xrmX6vaglnQ/RCIBIvj9d7OCYGjr361ncAF+dJzr6nl2sdY4iGqIrZ6nzJx4SyozMeljAsP04hhl4BdHpq5z6TbB5yKWMv6XwGYY/UneNTIrGQTVUwB0wEuJG/uzh+JUdDnHRHeDzVlqBj4W1Qh6Ylc7mXAeQnddiQghNfDF/cOdcyneeV0wVnGOFdEkl0phXxkTNnnO3Wi X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6X8AkIscGvk5tsJMYNQZ0pbaAGOuf8okbXtNpFRlQl49sH+jfJdOzVy4pJLJv/KOlHmsEqdDvdF+BCpAAz6n6lSYoi52D84U0aVFp+J7qOtKbFb7v4MHaPQ72R9gTtNtur0ykZPrVVvnpNAt+SifO4uMMQ3+2StpiRCC6lQ2vecgKCzaf/BFP5xpdO5QRVNZk5SAVxaNycx9diTv1yfzeJ6p1lOcuXc13+1tBsOz4gYtYbjdzwJD6T/fdYLB9BOOEfQ7KunqL4yJwsKiiWKyqJ28p9nTvDvYRDZeWPRnVVlYe9850l/HHzxzrDPQoWXhhkuhM2lVZ9KQtjQf9D820uG945NAU+CIo0JDd4Ev6pRZUrVABnoQUl/zvlD5uTL54rtThlj0M+smGRtV6g1OpH0rA0HCQg4FNsTqrblsIZvoPEqyJg3PvgGG47ALzkeQOSHP4+/JLZliRn2Wh73jmi/fsn4MuNc5NYLJ3VCWfOk/rbKwYEDvp59dB3HscuvHfV0VrQAR3bwro8kLO8LrBJvrVILQvwzT7C0+M36ClZG2AD6JzDiVrk8B24p7qZ/zJLaGPxotR9M0OhF6eYJwjbJeWR0RF0q3TIjfveA4buEYv75xVRlosxdr7ZCBVAkHSi+Yh4z6yOfGAySPrrguc/n6+W3w0xXD3ELw4fjTdcaOftppPur2kjveJxyE3pVzrNxCe5aQfeFZBTy0Bsg+1eDcEzBARIASLSENIyVEkRt7yHYjD2o3Ev62OmLAC/+h X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ac82a9b-fc09-47a9-adc8-08db73a49c59 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 04:45:03.9327 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jYMbV47sBuebIOE67G5y6+RwVQ5J395y8APZNbyeLnjshu9ZN2et2i22PXwGwvposDY5nh18DRbIbUz39CuP5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB5966 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-23_02,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 suspectscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306230041 X-Proofpoint-ORIG-GUID: VuAjrPKtYSEWbZ1RgmAosgt9J0Aqw-4a X-Proofpoint-GUID: VuAjrPKtYSEWbZ1RgmAosgt9J0Aqw-4a X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Binutils From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769467647533046058?= X-GMAIL-MSGID: =?utf-8?q?1769467647533046058?= Define an empty base version LIBSFRAME_0.0 and add all symbols to version LIBSFRAME_1.0. The previous release of libsframe (libsframe.so.0) did not have versioned symbols. Adding a libsframe.ver file so that future releases of the library (and its consumers) can manage the changes better. For Solaris ld, use -M mapfile command line option. libsframe does not restrict the set of exported symbols, so at this time there is no need to fall back on the libtool's -export-symbols option for platforms where some other linker (with a different command line option for symbol versioning) may be used. libsframe/ * Makefile.am: Use symbol versioning for libsframe. * Makefile.in: Regenerated. * configure: Check for Solaris ld. * configure.ac: Regenerated. * libsframe.ver: New file. --- libsframe/Makefile.am | 14 +++++++-- libsframe/Makefile.in | 9 ++++-- libsframe/configure | 63 +++++++++++++++++++++++++++++++++++++++-- libsframe/configure.ac | 28 ++++++++++++++++++ libsframe/libsframe.ver | 36 +++++++++++++++++++++++ 5 files changed, 144 insertions(+), 6 deletions(-) create mode 100644 libsframe/libsframe.ver diff --git a/libsframe/Makefile.am b/libsframe/Makefile.am index 2d1d8fff063..a660e85c2ce 100644 --- a/libsframe/Makefile.am +++ b/libsframe/Makefile.am @@ -30,6 +30,16 @@ INCDIR = $(srcdir)/../include AM_CPPFLAGS = -I$(srcdir) -I$(srcdir)/../include -I$(srcdir)/../libctf AM_CFLAGS = @ac_libsframe_warn_cflags@ libsframe_version_info = -version-info `grep -v '^\#' $(srcdir)/libtool-version` +# libsframe does not restrict the set of exported symbols. So, if linker does +# not support symbol versioning, there is no need to fall back on libtool's +# -export-symbols option. +if HAVE_LD_VERSION_SCRIPT +if HAVE_SOLARIS_LD + libsframe_version_script = -Wl,-M -Wl,$(srcdir)/libsframe.ver +else + libsframe_version_script = -Wl,--version-script=$(srcdir)/libsframe.ver +endif +endif if INSTALL_LIBBFD lib_LTLIBRARIES = libsframe.la @@ -41,9 +51,9 @@ endif libsframe_la_SOURCES = sframe.c sframe-dump.c sframe-error.c libsframe_la_CPPFLAGS = $(AM_CPPFLAGS) -libsframe_la_LDFLAGS = $(libsframe_version_info) +libsframe_la_LDFLAGS = $(libsframe_version_info) $(libsframe_version_script) -EXTRA_DIST = libtool-version +EXTRA_DIST = libtool-version libsframe.ver diststuff: $(EXTRA_DIST) info include doc/local.mk diff --git a/libsframe/Makefile.in b/libsframe/Makefile.in index 57f912caa13..08c780caa4a 100644 --- a/libsframe/Makefile.in +++ b/libsframe/Makefile.in @@ -523,14 +523,19 @@ INCDIR = $(srcdir)/../include AM_CPPFLAGS = -I$(srcdir) -I$(srcdir)/../include -I$(srcdir)/../libctf AM_CFLAGS = @ac_libsframe_warn_cflags@ libsframe_version_info = -version-info `grep -v '^\#' $(srcdir)/libtool-version` +@HAVE_LD_VERSION_SCRIPT_TRUE@@HAVE_SOLARIS_LD_FALSE@libsframe_version_script = -Wl,--version-script=$(srcdir)/libsframe.ver +# libsframe does not restrict the set of exported symbols. So, if linker does +# not support symbol versioning, there is no need to fall back on libtool's +# -export-symbols option. +@HAVE_LD_VERSION_SCRIPT_TRUE@@HAVE_SOLARIS_LD_TRUE@libsframe_version_script = -Wl,-M -Wl,$(srcdir)/libsframe.ver @INSTALL_LIBBFD_TRUE@lib_LTLIBRARIES = libsframe.la @INSTALL_LIBBFD_FALSE@include_HEADERS = @INSTALL_LIBBFD_TRUE@include_HEADERS = $(INCDIR)/sframe.h $(INCDIR)/sframe-api.h @INSTALL_LIBBFD_FALSE@noinst_LTLIBRARIES = libsframe.la libsframe_la_SOURCES = sframe.c sframe-dump.c sframe-error.c libsframe_la_CPPFLAGS = $(AM_CPPFLAGS) -libsframe_la_LDFLAGS = $(libsframe_version_info) -EXTRA_DIST = libtool-version +libsframe_la_LDFLAGS = $(libsframe_version_info) $(libsframe_version_script) +EXTRA_DIST = libtool-version libsframe.ver @BUILD_INFO_TRUE@AM_MAKEINFOFLAGS = --no-split # Setup the testing framework diff --git a/libsframe/configure b/libsframe/configure index bf4dc45b431..f7ad9c5e29a 100755 --- a/libsframe/configure +++ b/libsframe/configure @@ -643,6 +643,10 @@ INSTALL_LIBBFD_TRUE MAINT MAINTAINER_MODE_FALSE MAINTAINER_MODE_TRUE +HAVE_LD_VERSION_SCRIPT_FALSE +HAVE_LD_VERSION_SCRIPT_TRUE +HAVE_SOLARIS_LD_FALSE +HAVE_SOLARIS_LD_TRUE BUILD_INFO_FALSE BUILD_INFO_TRUE COMPAT_DEJAGNU @@ -11482,7 +11486,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 11485 "configure" +#line 11489 "configure" #include "confdefs.h" #if HAVE_DLFCN_H @@ -11588,7 +11592,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 11591 "configure" +#line 11595 "configure" #include "confdefs.h" #if HAVE_DLFCN_H @@ -12335,6 +12339,53 @@ else fi +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking if using Solaris linker" >&5 +$as_echo_n "checking if using Solaris linker... " >&6; } +SLD=`$LD --version 2>&1 | grep Solaris` +if test "$SLD"; then + have_solaris_ld=yes + { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5 +$as_echo "yes" >&6; } +else + have_solaris_ld=no + { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 +$as_echo "no" >&6; } +fi + if test "$have_solaris_ld" = "yes"; then + HAVE_SOLARIS_LD_TRUE= + HAVE_SOLARIS_LD_FALSE='#' +else + HAVE_SOLARIS_LD_TRUE='#' + HAVE_SOLARIS_LD_FALSE= +fi + + +if test "$have_solaris_ld" = "yes"; then + GLD=`$LD --help < /dev/null 2>&1 | grep 'M mapfile'` +else + GLD=`$LD --help < /dev/null 2>/dev/null | grep version-script` +fi + +if test "$GLD"; then + have_ld_version_script=yes + { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5 +$as_echo "yes" >&6; } +else + have_ld_version_script=no + { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 +$as_echo "no" >&6; } + { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: *** Versioned symbols not enabled." >&5 +$as_echo "$as_me: WARNING: *** Versioned symbols not enabled." >&2;} +fi + if test "$have_ld_version_script" = "yes"; then + HAVE_LD_VERSION_SCRIPT_TRUE= + HAVE_LD_VERSION_SCRIPT_FALSE='#' +else + HAVE_LD_VERSION_SCRIPT_TRUE='#' + HAVE_LD_VERSION_SCRIPT_FALSE= +fi + + { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether to enable maintainer-specific portions of Makefiles" >&5 $as_echo_n "checking whether to enable maintainer-specific portions of Makefiles... " >&6; } @@ -12810,6 +12861,14 @@ if test -z "${BUILD_INFO_TRUE}" && test -z "${BUILD_INFO_FALSE}"; then as_fn_error $? "conditional \"BUILD_INFO\" was never defined. Usually this means the macro was only invoked conditionally." "$LINENO" 5 fi +if test -z "${HAVE_SOLARIS_LD_TRUE}" && test -z "${HAVE_SOLARIS_LD_FALSE}"; then + as_fn_error $? "conditional \"HAVE_SOLARIS_LD\" was never defined. +Usually this means the macro was only invoked conditionally." "$LINENO" 5 +fi +if test -z "${HAVE_LD_VERSION_SCRIPT_TRUE}" && test -z "${HAVE_LD_VERSION_SCRIPT_FALSE}"; then + as_fn_error $? "conditional \"HAVE_LD_VERSION_SCRIPT\" was never defined. +Usually this means the macro was only invoked conditionally." "$LINENO" 5 +fi if test -z "${MAINTAINER_MODE_TRUE}" && test -z "${MAINTAINER_MODE_FALSE}"; then as_fn_error $? "conditional \"MAINTAINER_MODE\" was never defined. Usually this means the macro was only invoked conditionally." "$LINENO" 5 diff --git a/libsframe/configure.ac b/libsframe/configure.ac index b9ea363d00d..8189e966e1c 100644 --- a/libsframe/configure.ac +++ b/libsframe/configure.ac @@ -81,6 +81,34 @@ else fi AM_CONDITIONAL(BUILD_INFO, test "${build_info}" = yes) +dnl Determine if using Solaris linker +AC_MSG_CHECKING([if using Solaris linker]) +SLD=`$LD --version 2>&1 | grep Solaris` +if test "$SLD"; then + have_solaris_ld=yes + AC_MSG_RESULT(yes) +else + have_solaris_ld=no + AC_MSG_RESULT(no) +fi +AM_CONDITIONAL(HAVE_SOLARIS_LD, test "$have_solaris_ld" = "yes") + +if test "$have_solaris_ld" = "yes"; then + GLD=`$LD --help < /dev/null 2>&1 | grep 'M mapfile'` +else + GLD=`$LD --help < /dev/null 2>/dev/null | grep version-script` +fi + +if test "$GLD"; then + have_ld_version_script=yes + AC_MSG_RESULT(yes) +else + have_ld_version_script=no + AC_MSG_RESULT(no) + AC_MSG_WARN(*** Versioned symbols not enabled.) +fi +AM_CONDITIONAL(HAVE_LD_VERSION_SCRIPT, test "$have_ld_version_script" = "yes") + AM_MAINTAINER_MODE AM_INSTALL_LIBBFD diff --git a/libsframe/libsframe.ver b/libsframe/libsframe.ver new file mode 100644 index 00000000000..2c2081f311a --- /dev/null +++ b/libsframe/libsframe.ver @@ -0,0 +1,36 @@ +LIBSFRAME_0.0 { }; + +LIBSFRAME_1.0 { + global: + sframe_decoder_free; + sframe_fde_create_func_info; + sframe_calc_fre_type; + sframe_fre_get_base_reg_id; + sframe_fre_get_cfa_offset; + sframe_fre_get_fp_offset; + sframe_fre_get_ra_offset; + sframe_fre_get_ra_mangled_p; + sframe_decode; + sframe_decoder_get_hdr_size; + sframe_decoder_get_abi_arch; + sframe_decoder_get_fixed_fp_offset; + sframe_decoder_get_fixed_ra_offset; + sframe_get_funcdesc_with_addr; + sframe_find_fre; + sframe_decoder_get_num_fidx; + sframe_decoder_get_funcdesc; + sframe_decoder_get_fre; + sframe_encode; + sframe_encoder_free; + sframe_encoder_get_hdr_size; + sframe_encoder_get_abi_arch; + sframe_encoder_get_num_fidx; + sframe_encoder_add_fre; + sframe_encoder_add_funcdesc; + sframe_encoder_write; + dump_sframe; + sframe_errmsg; + + local: + *; +} LIBSFRAME_0.0; From patchwork Fri Jun 23 04:44:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 111913 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5528012vqr; Thu, 22 Jun 2023 21:48:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7gU3CUYoPsslhO4KUU3L8Jm3D6TYP9VPqEGgtXxcz4sp5FCamm4tLMSrgrqluFmygYJ5sV X-Received: by 2002:a17:907:1ca8:b0:973:84b0:b077 with SMTP id nb40-20020a1709071ca800b0097384b0b077mr19662337ejc.33.1687495679780; Thu, 22 Jun 2023 21:47:59 -0700 (PDT) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id j11-20020a170906474b00b00988a5cdbfa7si4397335ejs.889.2023.06.22.21.47.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 21:47:59 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=dhe5mIJf; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1333D38323FF for ; Fri, 23 Jun 2023 04:46:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1333D38323FF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1687495580; bh=1Wa0C5PMcZWx0bM17a6QcGGrSwg7A2239F45hmXPOVQ=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=dhe5mIJfJjPCI3y9AXHGSkKnGV2Il+eojzzBKIzVcQAqlZbXxiSXowTjMKYZWMmqp 1rJlBchBRPiV1AxE6TeY5bfAxQI8SJKPAR91KaDiVHsX2+lMvlZBIlcc0M3g5+pfEd TZWDs3Qe22nKQtGl1UomSVwgPLzD37y5VzKjq1do= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id D28623858017 for ; Fri, 23 Jun 2023 04:45:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D28623858017 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35N4KsKi019475 for ; Fri, 23 Jun 2023 04:45:10 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3r938du514-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:10 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 35N22jfH005923 for ; Fri, 23 Jun 2023 04:45:09 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2046.outbound.protection.outlook.com [104.47.66.46]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3r93989cmm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XL92CTFpL9eyXdfgYSwLftjDDWR9/xytJmnaZAD0goEkOdRXzuzL7yr+pabG5fWSQeaioI338hy0pI3Ub1S/WfJWBRnW5f04FbqZcD0+THybwXcZSIuHYLF6HvHZynnetaqnb4iilcCpx5BYamCIDAa2wD95S5ksyKJ+mQ1uH26NZhLgraMzdhqK7FnEsS3m2kf5icEf8npBd07fJBLeysCoI9L0nyTOi0tQqX3B7dK0X5v05YYRegBAp7UvlglvlDE0/rwwoH8wnspg8XhDkXbWnu2iqTfG4nHPJ9ZSaH7fZJF31CKRVHS8NpoFyYCTodykxw3aDj96c4+TsA9Yzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1Wa0C5PMcZWx0bM17a6QcGGrSwg7A2239F45hmXPOVQ=; b=DyY++dDswRZSBiwvWIM0c05iEC+ImnoiRaYZ7pxD3o41GTJlD0SdS2lhp/P+aZcDx/fhgBMRZqsLSn2iyH+Za356f/Y+QtuA6h8kwK3zxWls27nmAbgfVLwvgpVWHIw+2uzAJEfRHEmJlAJuMbcJiXL2diDEH9pI1L7CMDpfvn+RGRWsVBBGoxRUv+cbqCIJA1Tc5HPf573Zgk6dz1A0x25UDdA7Km7RtND69hE1N03fLvY3227IV3mbgu1o7ZWqitQXNOj4oPvLPNTTu2dYATYIesm5uk3BDbP+xH+tSaHUKSQtPKztCk7ow5CLbYXNMnjMoCb3YsGOcd2vsMiJPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by DM4PR10MB5966.namprd10.prod.outlook.com (2603:10b6:8:b2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Fri, 23 Jun 2023 04:45:07 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6521.026; Fri, 23 Jun 2023 04:45:07 +0000 To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH 04/10] libsframe: update the semantics of sframe_fre_get_ra_offset Date: Thu, 22 Jun 2023 21:44:42 -0700 Message-Id: <20230623044448.2617101-5-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230623044448.2617101-1-indu.bhagat@oracle.com> References: <20230623044448.2617101-1-indu.bhagat@oracle.com> X-ClientProxiedBy: MW4PR04CA0090.namprd04.prod.outlook.com (2603:10b6:303:6b::35) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|DM4PR10MB5966:EE_ X-MS-Office365-Filtering-Correlation-Id: 908d3ecd-1acc-4bb0-6636-08db73a49e42 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r5SILXHZhpLRbM4qZy8jxWR1eMcjYb2JUSH/UVTvwXVbgES4Iq+Jp+Zzhng8kZOJVxwmtwQB7Q87xiRZmQiXfy/mg4W5q30tRHryj5X+BWrliktSZLyhwQJ8O6/g4++GesSiiddaGclHsCePCJxdA1R1tlOlDBnVWTR1s2r7bwedQvET5OWvAfXoD55rsh+06IbZyrsb0ugiAj7XPYeB1/65izL8xbyWPlieJXwRmV8613zsxoy5Rer8jsi0g9DT4aUVeQ6LC/JEwo+9CNOi9YwRSTh8naYUQzOXfJwl2Mhgpau5uWpFaJI0NYIBNtKQRAX372zaeaTAWQ8FI6OGA3boI6d6gkhZYRbHzpiJsgsbR/NIxajDCQ6v8jNbuaUuTpKRvtBD1uibKYFKM5zArkvuVUzWJSOIF4vqcE2AT5rHxoX3aljgJv2qYRzXSoIpQOJ+40EHuUSFdAOoSG5E7szWrdp0+1gKrbG0lwZUueimzRqIvyw+ZFfsKO69b+BEL4iKMbBe1mWTiuVEyK3HBtD2XgvFUny1d4VVvLcOkXR5WLsCkW5XhduNaCHRRLKg X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(346002)(366004)(39860400002)(376002)(451199021)(2906002)(478600001)(38100700002)(2616005)(36756003)(6666004)(5660300002)(6486002)(66946007)(66556008)(66476007)(83380400001)(316002)(6916009)(86362001)(41300700001)(44832011)(8936002)(8676002)(4326008)(6506007)(6512007)(1076003)(107886003)(186003)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5vGN43g8CzDWcmbhBwQrMkIFbtPUs7NS7qRAEoT8VXkFWyNvNVbkerrpVUJvlP0/HwVQtKbsNwi2Ed32028IiKN6yRqnOU0fa98DskcdiPYQUTteFfr2n6ubyfRIlOjy9vldv0g1HiOARf7haSsq3N/ZvC2jdTRxTWCd6xmgPuz6jt+rFfELNl2p9I3zDWZcf4YH2Li0vIGfBE7twyc+7h89Bhkv7R7PvQu6U+yt1oW065QROuphXD+rfEGhY0Vg83zfxzaNu8TsPNk+BAoVLzAbFu+GWduf9kwI7+PnJRXaYfoWLGPT1cQ2c88P1DwrXdPeDdoSXK8yW075MUUDjLD/snYfZsFUqgoUMqdh576sTe2gJWQS4AxwXBEP6zz+YoaiEqdbyG52yjwforBw6Ei6UdleqWN72683fa9sp/c5uCUA5qoI4GmwS+N+mHVRCwLyiFVeXxrKHnFwAxOImETcwXDueQVy+aiL4Kz0d/9rNr/wnlPiwL6CUzVkMH93tAthKjY5qWiigN794iVCXJl/UZuNEQNHThXNu63rkBOCinSWKl258tGvxkZ9PFWwCrzxoJ1oBz+8uh4EpMsaPj3oymUojVzER9HNZ1pnIxoSra3tLmYg9VVe3458TB2GQIqbFSNIeDqBlL+GLEQfx+r8PlWtPb0nFqPsiY+QzVLCLcFmq/8ODjLtd4K97l7OcAQro/BbzlgnCu5249fqi494lKXm/bQZpgeTamTUH//VQmvZir3ZHNlfYkGgNn/NP5Qy0ZJwF+JfhBewp6apbldRXwZ79MTVuVEYz3i0suNTlIk0NUk4Ph0Tb5fXlpsv3q0Ldjv5SMJb1cPoaAcRqBhp4T50isZhLNi3nJ3LPlBXtQXg0mlRJObaV8tSE1DzIePXDtR/QWVLhr/8FkmQ3eewJMHTEcoZpGE/9qKFJkMwgCzn8kVkqxbDqjtFIiC7yrZ/cVJFuqLJKq8X9btO62WSktdz0RXdyOvDAthMQC5Uxs7giudHd0qRQVy1+/sxjWgsMtLyCEYUaH0KCN1AJOqqnXzLPxlTVIix7dPoNNtr5Fj+Va+8hNaYBaPC/EQlOvACgNfgEJFlYNeqReRntgdPZ5Ro7GT18T8r89kWZV9v2OHJegR4uJ8TDz/ysBgv/HprUaqm4uRBWpr7ILBeAGVaSiA2L0jDEWvwzwHz0QYB7nTYHDCJDHnHrWVXK7UMmIf/2NcuHTP0iQA6UWsnjd3kneNUjaSi1NQZGkeTh3o4c+8AE7qRBgBpUdoBQo2XBml1onljP5U9pLncsIrY4sCq9lk0rFPgN25GZsIsv31x7p4xA/6Vh1GqQyWr9vWJoJ2rPZzuR0FfSDvbRuPA40ycjp/nVZ5UW6E52UtIXWs+DEXR1eSsl6HN4AMOs/CKWNWt03PCuoFMXSIYzpp4S7hNa3Zio6RAVdNSpTdPPYshF+xZ0ejkOULeUVogcHrN6+H7UTR6fXCTvKItGQMcmy82OOVgIPLSt7mBGoehNmApxu8fZ6TZ84zTjZ/KrrzaiRqJv11v2DzzkOoFsBBIGrg/o0c7w5Fdn4fv4rASXGTvwzhXdJ8UGeduLUbEzsw2 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: EdA/UV6QkCiZK7SGQrHkgqdsAzVhd6dsRU/WNKlW2qcZJNIFYTE862T6f52KSeCwTyVl6LwNpuaR4S3qR1VfXscBHVjtoGZKSqNv9n18nBYhzFnC6Qc4aZfLX1JepZnkPspWlBqif+GavLdLEAbL0/gB+tuDL+/U//qCJHFVOaJ1MjDUoEpeo93flnlQD3tN00g4yGHJXWbl96qnG5WTFTb5f72bRU2ZW45m0qHb00LWUWXG6STbvcKCEJsc3bPSFbbKtGawp82aFiZ712pgt+uBVuGSXeAdddOAc9d+dq5/VDsd3v3QVHZ/ArNH3QpmOr6rY2OKCW1lQTtOuu9rPAOZ7wZ2jY6lciskDl5rzg19MczOjjHru0fhsA8DnaC+MqKVlAGLLte53pClQGWetJsB8w+vnRqjsXJkqjthN4HQPWM2ZUlEE0YGVLP5syiBt5UUbqNvFEB7akfc2nggtQBWhtFAcUguZiAQ9OtBlwcYFFTwDfV2X/lue9VWwNAR3kL3q65wZ5i+3l4L4lkMLsIXH1XDbxs37JVpB1BuvlEQiNDsie53hyDUE1qzIu89HBOT8FUVBNZtVc65ubG/z/IItLiPd1wAHhOB209LJFQg2FckOGcXsO/h9Ju0bBCClhp/lS/23OhvPlIjunWmNfIcD0afE4sqs1uhHj0gzROoLKNGlWk6CUgTc4akVZoT9pBZS/Q4I8Pc7Z1tsD2Xh/nKBLzWxftrq6f1ZnWqLF1tRP78NkBRo4rNFsNd6wt7 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 908d3ecd-1acc-4bb0-6636-08db73a49e42 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 04:45:07.1153 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Dy7lXEk4oZouQ/njgRzKk3moY6BDkYM52S4PmWyzmaDFbO41+LKOKycw9TTxn0glRfC5ukuNlQkjQ48kPAsgxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB5966 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-23_02,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=853 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0 phishscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306230041 X-Proofpoint-GUID: doq-_xw8mrhW_VKLdVOABJhFMZF7QCxu X-Proofpoint-ORIG-GUID: doq-_xw8mrhW_VKLdVOABJhFMZF7QCxu X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Binutils From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769467470057909452?= X-GMAIL-MSGID: =?utf-8?q?1769467470057909452?= Until now, sframe_fre_get_ra_offset () would return SFRAME_ERR_FREOFFSET_NOPRESENT if the ABI uses fixed RA offset (e.g., AMD64). A stack tracer, then, will call an explicit sframe_decoder_get_fixed_ra_offset () to get the RA offset. On second look, it appears to make sense to hide these details of whether the RA offset is fixed or not from the consumer. Now, with the changed semantics, the call to sframe_fre_get_ra_offset () will fetch the fixed RA offset if applicable, or get the RA offset from FRE when there is no fixed RA offset. Adjustments need to be made to ensure the textual dump remains the same as preivous. Currently, e.g., if RA is not being tracked per FRE, following is seen with objdump --sframe: STARTPC CFA FP RA 000000000000NNNN sp+X u u This patch changes the behavior of sframe_fre_get_ra_offset: it turns an error into non-error. This change will be included with the next release of libsframe, where all exposed symbols will be versioned for the first time. libsframe/ * sframe.c (sframe_fre_get_ra_offset): Return the fixed offset, if applicable. Else return the RA offset from the FRE. * sframe-dump.c (dump_sframe_func_with_fres): Make adjustments to keep the textual dump same as previous. --- libsframe/sframe-dump.c | 12 ++++++++---- libsframe/sframe.c | 14 +++++++++----- 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/libsframe/sframe-dump.c b/libsframe/sframe-dump.c index 6d266392cd7..2491b4391f3 100644 --- a/libsframe/sframe-dump.c +++ b/libsframe/sframe-dump.c @@ -164,11 +164,15 @@ dump_sframe_func_with_fres (sframe_decoder_ctx *sfd_ctx, strcpy (temp, "u"); printf ("%-10s", temp); - /* Dump RA info. */ - if (err[2] == 0) - sprintf (temp, "c%+d", ra_offset); - else + /* Dump RA info. + If an ABI does not track RA offset, e.g., AMD64, display a 'u', + else display the offset d as 'c+-d'. */ + if (sframe_decoder_get_fixed_ra_offset(sfd_ctx) + != SFRAME_CFA_FIXED_RA_INVALID) strcpy (temp, "u"); + else if (err[2] == 0) + sprintf (temp, "c%+d", ra_offset); + /* Mark SFrame FRE's RA information with "[s]" if the RA is mangled with signature bits. */ const char *ra_mangled_p_str diff --git a/libsframe/sframe.c b/libsframe/sframe.c index 8837f878fb0..3d1b5575f0b 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -665,11 +665,15 @@ int32_t sframe_fre_get_ra_offset (sframe_decoder_ctx *dctx, sframe_frame_row_entry *fre, int *errp) { - sframe_header *dhp = sframe_decoder_get_header (dctx); - /* If the RA offset was not being tracked, return an error code so the caller - can gather the fixed RA offset from the SFrame header. */ - if (dhp->sfh_cfa_fixed_ra_offset != SFRAME_CFA_FIXED_RA_INVALID) - return sframe_set_errno (errp, SFRAME_ERR_FREOFFSET_NOPRESENT); + int8_t ra_offset = sframe_decoder_get_fixed_ra_offset (dctx); + /* If the RA offset was not being tracked, return the fixed RA offset + from the SFrame header. */ + if (ra_offset != SFRAME_CFA_FIXED_RA_INVALID) + { + if (errp) + *errp = 0; + return ra_offset; + } /* Otherwise, get the RA offset from the FRE. */ return sframe_get_fre_offset (fre, SFRAME_FRE_RA_OFFSET_IDX, errp); From patchwork Fri Jun 23 04:44:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 111912 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5527276vqr; Thu, 22 Jun 2023 21:45:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5cIghVdmfO7guKQgMuvLY8ZMgADg2gYhza2D427r+St7m9hFZ9DxkJYRxYLTvcsHE9bTch X-Received: by 2002:a17:907:72c7:b0:98c:e72c:6b8a with SMTP id du7-20020a17090772c700b0098ce72c6b8amr4892156ejc.10.1687495549202; Thu, 22 Jun 2023 21:45:49 -0700 (PDT) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id x4-20020a170906298400b00988c552332fsi4042919eje.300.2023.06.22.21.45.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 21:45:49 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=uZ00h8k2; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C73853856DCD for ; Fri, 23 Jun 2023 04:45:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C73853856DCD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1687495528; bh=LQJPIpdJNsH5MBq43bNzCMQ7f8cRt+30xCqaktLOazI=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=uZ00h8k2yNJDiQI5sj/RlSj2T3lfN2F0CwFcI4IYFP31D1bMVRA9u+LuJ82n4oRsR zpF+gfL1PYm98aoDMq7DB2L1vjIuQAg87poSfhSGMloNGeBjc7F/0eVFKZqrE0XFHf cNKIDMfKaweESoLlMUW+hvlgyE1yqXejptBfYPM8= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id D04543858433 for ; Fri, 23 Jun 2023 04:45:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D04543858433 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35N4dKgN028127 for ; Fri, 23 Jun 2023 04:45:15 GMT Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3r94qab17u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:14 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 35N2ASsS038671 for ; Fri, 23 Jun 2023 04:45:13 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3r9398g437-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yud45leSuDUC1q3L5ezsRg532lhV1aS60OI8zWuJ43s8HXbdplifGVsQf5JA23YRzwVt+BUnsJNhGDVOEZ/fx2QVC9LpwwgTU/33bWsWEpBeaVxvOWxokDSTg90LLFW3ieuLJW0lAOJ60Y6w6hdaPJgBzOxWuVkqsJcayMmeIUZRMRo3UgVxgN1YCX6VsgXiAz7ffpBqv4HYOPPikl2gKOjbuy/4nvdntuRwQXcsqWqkVYLvgtKyLP+2Nfr4SK4inE0FRVdP1vE2L1hwMG3PihuP95Xg3gbALU6fuSmv6Kw227eWmK3zSKtxHLpP7MGQL25P4cU7WfJqyoVnZS4ouw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LQJPIpdJNsH5MBq43bNzCMQ7f8cRt+30xCqaktLOazI=; b=ERGzsvH6kv3EwtIcFn4cBwI24vTokbc31CG1JCPXi8N9hZLUYaH8R/0YCtzGaKmgcggxADzoCqaDVrvJj/pBrjpR83IVWh4wgWRbMGB8hCchHQUWiMO+Bm2gAO77THJyE8EQCUw66hhok9Q/AbAo1LiLztm8wRKk2FDzN1qofc6CSemzNVSW0nMeRRhu5NZm98dwYZvAAwXuqRlJ0ITMDEGrKKtRVJ4NcCd/jYG+hCGfUF8b4XOIO74Z1s87vgYFxpVgqzEreNZBl/8ey76W8NyZ489lDKK6uBh6LHrcQuKXDDsMXgD5LxbAnJZlhx8zyU6IKH4550fL5Ha17F/c0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by DM4PR10MB5966.namprd10.prod.outlook.com (2603:10b6:8:b2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Fri, 23 Jun 2023 04:45:10 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6521.026; Fri, 23 Jun 2023 04:45:10 +0000 To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH 05/10] libsframe: update the semantics of sframe_fre_get_fp_offset Date: Thu, 22 Jun 2023 21:44:43 -0700 Message-Id: <20230623044448.2617101-6-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230623044448.2617101-1-indu.bhagat@oracle.com> References: <20230623044448.2617101-1-indu.bhagat@oracle.com> X-ClientProxiedBy: MW4PR04CA0093.namprd04.prod.outlook.com (2603:10b6:303:83::8) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|DM4PR10MB5966:EE_ X-MS-Office365-Filtering-Correlation-Id: 1cbda64f-5664-4a52-f7d3-08db73a4a023 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Se0Kf2JjIXT5gpwX69N50R6lz2LmxK1qSSOAtep0wh14vKP7ngChs46iLQfz9tc8jRfo9IvrAePM60EvJdY/ohvM2UfK4SqlUoPo/YM8Uzb1ux54mjMWos+Z3raBp8fjSX3amohce5ys+lojwBPB0dmx8dvsOzE+PU9Yha3uV85IFgW2dwdEOKF2HNhFKEk3c3YvXt2WG42ww2d096nKhZk4s+gdOlxlHGda1OVntdkvTtTUoHXeBnEefzkaZya25WHDyZ8Ihtt29PWQ0SGMnZo9Tev9+9aWJAFeVL7OVwBY4c4NGdj44ax12ld36ai0RA63t1A/ZDdiIqsinbNl2yBVvxKHt065AQgRwWFqbAufJIGhsittVqkWu8+1CGPjMllkDVUQE3Y3zk32OUGxQtnMWMrYJBVh6N0eXsKs7JD2aojNl+pgLDjPzHRvxjGJQZ8E/YSIT2dl78CIGcTSToqOMbvtPbIZJp0yqSu2Ue4YknslcBGFBG4YOWPe56B7+d10K5MrVu6lFzlRjAH9Nl2XU2mQysIRUVXSKzThmXNIvKs+802HEzhnbbYm2ok8 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(346002)(366004)(39860400002)(376002)(451199021)(2906002)(478600001)(38100700002)(2616005)(36756003)(6666004)(5660300002)(6486002)(66946007)(66556008)(66476007)(83380400001)(316002)(6916009)(86362001)(41300700001)(44832011)(8936002)(8676002)(4326008)(6506007)(6512007)(1076003)(107886003)(186003)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ByE/ZNrLuSCjVJ1JUxcSOv10U7IpTBVZxIEoY0hQBRT2xssLzirOX3PNikKNCceiuHvlf4arwA1wNVYa2qVCnMNdyQneOVPb2xy6vNB68wRxONl+A0iDx3vSCA6202jdPvrRlwKPNBEr+qKS/PVzrwDhuFwKXfdfv1MAZl5HjeFhTTwbS6sHvxXHpJif3p+5X4os2iVGLeRGAoP7vCy/KpoGZY2qseyfoSde1WpZztw8YQCfnhPRFlwkapd5WyLvVJM4uMt1++SW6JfwhYTbIL1ge6cveC8m9kzg0XRMh7T4opT4fImUlR5ON1RCvc54urBSS3GSKgSRbx8IPoxFPL3sguhPm32awyBKSx8DU83YEQQxpJaqKbFBDbac6E6Xf5O7R4+La3EYwvgtJQH5CS/EtUKRN7r+lSUbEKJwwd/1a58GHqrerXTJSK6kHFgW3jQGyZq/n5C8aSsNRhPrqHhdmetwrD24JRGWXWqfsO+CTjtAEnvfahpXYZ+g5QdbkHR23WPB+PhNXeR9f0jNXMQ6kkF/CoNkpprueHEgp4V8YjSTCOv8TTTMf9aXWWnbxr4+ji3FBFaXfSaGwvn1/PV0zwfvDKPZRj5c+v1mv7jfEcf2fcQidBA3FjPHvwOUFOuH8Pq/fvsRhXSF1RB5zKttYJ1vkwXUAKzxiXSmbfOlfSAD3S+uk0rW+xIg0SKFDLCSQqL0v8go5dTLNeCFjfmt302MuSpgP5rQdfiQP0i96k1i2JmM1YMPg7VyvC+kvpIvOQWyq+7O+EcfnFCblly6K+948OvfbhLEzr0NEinSqQlA3eVQPA5UGiu0mBUh1LNPrBnUASco39xyj9SoswgEz83xVuvt0E9xmBAyh5JadvHj9PaAl2CT3ogKiOMwpHuH6Af1o0K9yrQ8R7vkDEI+uxn3EmMQeI96FSmJnxLJPrRaXI3f6P1pGiqzSEWaVPE4hEvmWx8pa0CUL1Dlpm5aonlkqiflmQiu5UA2bBnQHJooyy6hBPD/TcGy30CHBUAy7QxHClcyNza29rkm9DpSQ3lXdSoJksiKOIcjuZSKvdiLIuLEu3FrUwRVuyOcIS4Ji5bE7C2NlXKarQBijO2I5nkP2CvfHS86rZG9fPsfYXlre2O3ffWAmE2J8LKTz5YXdEjcbQjSuo4/W8fHfclFVNfj5mQcnukUIHIEdQCO3vhc7GS3XVzVX3fT20m/AYYx/vsDLF/9zn/o2tN4oI2quMWFhCrlSRgyn4rCq1ljc9BHut13yh4RVXGGobDwMXf/OCVm4Q942pifkFuG51YZoCoGZcf7TPxGtwTb1SNee3iRnGLufvjm4tSkTIw3o0kJN8of6Cpn/RJrU6s4FUjkEVu09Q+EIhhwTMWt96prKpiT5Yp9Fg89dYmdCeTHxODHhoYKpZ91716HH+2Y2MHYRfvQK7uc/bT/bLVGc7vUsU2WcNxlzOBr3gY2z3GBpBwOpD6YNYChKPGhzxJdraWM/joujqnB5fT2rmZHo7+KCWUvAtY2yezdqdwU+94SOKkd+rJoInYGEIi1WTDsLqjnrQlRkIFPMyPNw+ax8NlYxJ03lom8ExkzmGdxh4mt X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LGfY1w5qlU3BlKSoIyPkDrrKu8jsWgr/7FsJ4Q3zHuyuJCjP65jDSDR4YkxbgMPvB+BgxK0IJ0U2hRTwAi7mQe8ILOMfTDY5uiG0BWMH7AmioJjylo9NWEQH23oghgfxExyOY1hSpw3a7sSS3nN2RnUBAAAGURiTQyh4MG1s+EMjjLAJjNS7Y89Ew8fHIvAwLpa94CzaNsSmADIuIh0b4dSr08gtqLwbBzmTSTwnImFPwEYAWn2SZ6Cj2u6JKejBPI9ftoYEAVigtqNfjg8dNk/mup3FGpZkFsaADsJUE1jRaKic74n/fbWxUWtSTR2YDORpSxb9xWU0TpPCIJnV1xRUknzP8dmjQAR60anAM6X8PB8DSj+wTQdxVM33Jh+H+cQLRHK9IE2ahgTlAWbKYBxQoGC8p8kS2Mu2cks9r/aFV6qn8jfTW9C4/9NSyidB5a41cb3Q5FlniQP4wUOSQTGKD53uqq+ciJ8B7WG2lmK9A73Yy7nsF5HEn1O/Gmu/7IDFmLFgD7VfnxS2po0zOecoSVItf6h9jt+Ew3f3JHOHTUBfOPwM+ayQfeMi1prj0Gkw4kGMQJVX8wXi7Nnp56jZDVPukGsZFkf4XN1/14EYVuYScXh3MqAdJOwgOehR7Bweseu3+VqMBhOM0ReEw6FU0uBRL1uoxsmSXZ7nA/j562GJMBaFgilxWRQYAwrqcqz5Rc63lXXbpydlBazQkXQQ0UjZ1qKlspv0CFSAM1gDFxRjZvreNKhYcWm6dLKd X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1cbda64f-5664-4a52-f7d3-08db73a4a023 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 04:45:10.8098 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cnpxvV6KiEg43aNqo+qnAvzv14wwgOIQDa9dkyGbqaDF0ZULrJywA/CfxUTdw6JtU1xKhQi+Bp0ZgLidr1gXVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB5966 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-23_02,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 suspectscore=0 adultscore=0 mlxscore=0 mlxlogscore=815 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306230041 X-Proofpoint-GUID: eEK7LA4jjCUIeZt2vOd2JAXoH2dwEzRj X-Proofpoint-ORIG-GUID: eEK7LA4jjCUIeZt2vOd2JAXoH2dwEzRj X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Binutils From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769467332738255756?= X-GMAIL-MSGID: =?utf-8?q?1769467332738255756?= Until now, sframe_fre_get_fp_offset () would return SFRAME_ERR_FREOFFSET_NOPRESENT if the ABI uses fixed FP offset. A stack tracer, then, would call an explicit sframe_decoder_get_fixed_fp_offset () to get the FP offset. On second look, it appears to make sense to hide these details of whether the FP offset is fixed or not in an ABI from the consumer. Now, with the changed semantics, the call to sframe_fre_get_fp_offset () will fetch the fixed FP offset if applicable, or get the FP offset from FRE when there is no fixed FP offset. This patch changes the behavior of sframe_fre_get_fp_offset (): it turns an error into non-error. This change will be included with the next release of libsframe, where all the exposed symbols will be versioned with version node LIBSFRAME_1.0 for the first time. libsframe/ * sframe.c (sframe_fre_get_fp_offset): Return the fixed offset, if applicable. Else return the FP offset from the FRE. --- libsframe/sframe.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/libsframe/sframe.c b/libsframe/sframe.c index 3d1b5575f0b..912d34352a1 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -644,16 +644,21 @@ sframe_fre_get_fp_offset (sframe_decoder_ctx *dctx, sframe_frame_row_entry *fre, int *errp) { uint32_t fp_offset_idx = 0; - sframe_header *dhp = sframe_decoder_get_header (dctx); - /* If the FP offset is not being tracked, return an error code so the caller - can gather the fixed FP offset from the SFrame header. */ - if (dhp->sfh_cfa_fixed_fp_offset != SFRAME_CFA_FIXED_FP_INVALID) - return sframe_set_errno (errp, SFRAME_ERR_FREOFFSET_NOPRESENT); + int8_t fp_offset = sframe_decoder_get_fixed_fp_offset (dctx); + /* If the FP offset is not being tracked, return the fixed FP offset + from the SFrame header. */ + if (fp_offset != SFRAME_CFA_FIXED_FP_INVALID) + { + if (errp) + *errp = 0; + return fp_offset; + } /* In some ABIs, the stack offset to recover RA (using the CFA) from is fixed (like AMD64). In such cases, the stack offset to recover FP will appear at the second index. */ - fp_offset_idx = ((dhp->sfh_cfa_fixed_ra_offset != SFRAME_CFA_FIXED_RA_INVALID) + fp_offset_idx = ((sframe_decoder_get_fixed_ra_offset (dctx) + != SFRAME_CFA_FIXED_RA_INVALID) ? SFRAME_FRE_RA_OFFSET_IDX : SFRAME_FRE_FP_OFFSET_IDX); return sframe_get_fre_offset (fre, fp_offset_idx, errp); From patchwork Fri Jun 23 04:44:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 111916 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5528219vqr; Thu, 22 Jun 2023 21:48:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7n+nKJ4Ld1JN+GA52YSEsHeSefI/Vx80lV1/vRTb5Th+qqzdk17KPopl8H2zx2L3Gckktg X-Received: by 2002:a05:6402:5112:b0:514:387c:930 with SMTP id m18-20020a056402511200b00514387c0930mr25725444edd.5.1687495712076; Thu, 22 Jun 2023 21:48:32 -0700 (PDT) Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id g5-20020a056402114500b0051bf85a01f7si298475edw.427.2023.06.22.21.48.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 21:48:32 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=PkNcdwEO; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E155E3882014 for ; Fri, 23 Jun 2023 04:46:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E155E3882014 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1687495592; bh=BtwrkKeyk0PWl2Moo7mD7AATSesSy7I93jFtSzGbf/o=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=PkNcdwEOmijxki4/KOmLHLgXAZE3sATmo+f2IkXxkvStO+SsC9RrrYpAniOgtR8wa dUhnEo1jZaiKNZpIWtCcfIiETaQr4gYckDLCkwg1znmVrw+bKfeUiU1IWIzBlb39CZ nkeT2NHVbIDgEvhtQTexCsI9lNrfrCst30cPDtAg= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id CDC383857703 for ; Fri, 23 Jun 2023 04:45:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CDC383857703 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35N0p3Gs015102 for ; Fri, 23 Jun 2023 04:45:16 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3r938du515-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:16 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 35N38rvG028809 for ; Fri, 23 Jun 2023 04:45:15 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2044.outbound.protection.outlook.com [104.47.56.44]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3r939egtd0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mpr6nHlnpQwJVvs9OFWS9xr3aBClXe0xyvRjE4a4t9KbaPI/80ymXhYWCregAF9PwVBKG1RJIu2EkAK3zx+wYsvOz54qwJo64VoVh5sGtw6U3X4o35cLui89YF87qLu1QTJL8Ed6NtMAFqvqvXPT02Y9BhoSsASNS44W8zyC51O3PBciI/9e57dLL/5lA3Jf7DAo/ULcjc3sUUyJ10gzKtSKU1Tlohx9rLzCFcD+319iVorJKH3kLNWHUE2t1eBAAXX6TIAEtGmRn11jheRTwpJ+a5YSi0M5hUN9ij4pCjv9nisxk2PCXoaDBybmeEdQQaPUoqh5jypLY0NhlZHHow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BtwrkKeyk0PWl2Moo7mD7AATSesSy7I93jFtSzGbf/o=; b=Me15g4b//gkDWUn4sL+Flr5Picl85HD9Zi0EK0m82SqT2hhU/OMAOxpbZQKKIwn1Js4USYiZceHkvZ7Z9CgZNknYYDGISRXqCkQB43LFUy81/YHUK9ayvhEGsuuT/1l7xgj76HSxQDT/JK+xs+2uu4jM3jtW/eO2Y4kJVfeD5C6I21SI+2h/zBzDPP3QTtRZsOBrIhCjtQ7e00+sAJkxT8RqOJzaA6+k8LwLgYhT34TUtFVWvZ17PjHlGP19/nSZptdG+3UHKUcrD5d4P3jw0wP5BpDAdi/z4Q+Zsgz13dkZcEeusnHWEtTxudXHVkSqy68FvkQu+qh1jHSiKGtpvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by DM4PR10MB5966.namprd10.prod.outlook.com (2603:10b6:8:b2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Fri, 23 Jun 2023 04:45:13 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6521.026; Fri, 23 Jun 2023 04:45:13 +0000 To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH 06/10] libsframe: use uint32_t for fre_type and fde_type function args Date: Thu, 22 Jun 2023 21:44:44 -0700 Message-Id: <20230623044448.2617101-7-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230623044448.2617101-1-indu.bhagat@oracle.com> References: <20230623044448.2617101-1-indu.bhagat@oracle.com> X-ClientProxiedBy: MW4PR04CA0128.namprd04.prod.outlook.com (2603:10b6:303:84::13) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|DM4PR10MB5966:EE_ X-MS-Office365-Filtering-Correlation-Id: 4018ec01-734d-4b6a-9dcd-08db73a4a1f9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x8d3jZOkW41OO9nqqqdLn+VfuXvovedU8PuQdveEaq6bHN/y7cqvU3JqkS5Eo3fGtvW+xwgJ0mYhV3V9rbChXDCQNG26qD+J8kSVFKYHULgbW8VBXUTrAZYQ2bpbi+Xgk7mxRw+anAq/54oj7D2sBG3Ndq167JoEmkH+r8Lh9X4OCZVoV/DYDT9OZj/U06GB27/Fk7uf20B/AOBD1JHbWJAdhvzYkK+QDOAd/ju2etYFQtb5/bomxUwYl8sVlrZ7g24ejwm+xTzT2dp1KhcTL6vO9sedwlr3aaJInXF8mGpDYn94z+4M7a5nq7RDqsR1cAKb4v6tSSO79lEQwj5LvQnjIMeEl4ul5BzJZ24JKGbmA07tTGHlRAyly6dWw7C/GV4HkKONotH1CCjokfX+VKtBD/Mtfo4/TxGSBtxdE70rOehpBX4ydMZWRuiojwYF23PmaO9pg5OUceKP9LiUmzlIpnqyE6QDX6APNEikesJ/dnL67b7DuhlPxxFQnh6dJxPPZwoq+kOsDGA9Vgg4ZHdnC2BwQOlgeOSuOwJlLNQXVutiPAL0mAEWCN+qyEvo X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(346002)(366004)(39860400002)(376002)(451199021)(2906002)(478600001)(38100700002)(2616005)(36756003)(6666004)(5660300002)(6486002)(66946007)(66556008)(66476007)(83380400001)(316002)(6916009)(86362001)(41300700001)(44832011)(8936002)(8676002)(4326008)(6506007)(6512007)(1076003)(107886003)(186003)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: c/xXkriAOAjwoVCg95xL46WhguNpka6gtFhF0Yeo+jLgD/ZikC2HoLbxYDzhqlkvIhy9GZAV0IS/qsJQwfZ65vdntZFakhMtdlOh0ON7ttaTt1XPnZlRT1mLD9w/DkWqfGlun43/83ETVkRXmj9wOvqfQeeFhd8XYyqzF+2IzKJpijNIHHFbV+BuyWGjVVVxOGg7b6C/NzqorLRvaFsIWZfatygUpEpjgqwgOgp/2ASHU++ePoc5m+oVzNkSEgFKlR848Sj9CmXL+mfY2rEJULCN380OZWEOGPD28vFBblw5GUK3c09uU+UeBc+gR9uyljNa55ofVzFno9WCIZH+YUmvFBm2i07rlPnBWI34FY2XkVrxWMUa61AqjexaW6WLhRfQWeL7e8f6N+ltbbFsORvtsV+DspuRxbPkXhq+g/0cPnOhZ3MMiOV85omgASlj6VGtubD3MXjsY2W6ttm8PmjLG7FTHx5Rg9v/pvhMF8J78Z6w5urqVEAsso9y0lINxKtxbr77ylNE+Fq7o/jyjR/RjUpN2U2Ec7h3K58UKaPpupm/QBDwdmedm7zExwIpcBxcjAyyrwO6esHJbq4VKhWaSl7E0GT79g1kqHkpegt/+DjUU3fklHAwsLpSWoZ5LWxWa3gtU5CcrbdjVG9ijkRYJEd9ZS/LKxCdtxx8JlAHm9bgavqFWyJYnTp0kJKDglCHVOjffJSazlVYZY6R896DNbATCrb28WkntM7gEbe2CQsHQrHe0E8Z/YpMK0n6L4oIl3PiebEgWDE8gR1c0k3xHk/ib7gj9XAwKUjJ0wKhxxUJBWRqmGcog7Lzo37yWyuw43fi2jZTuOxMrFh3s4AO830x1DTKGbKP7GHJz6NInIAD5Tb6R++WR6IhM/YhKF98pnC5c9PzE+Lbw6GTp5OX4jfB6PiarzWgq1dSdPeQp2mdMW9JmNGB/TrOdTC3uP5V3yEoSlMdSHq2W2XoxuFZeqNTf+JA81+o0ABy3pE3z7nQvsgOZIe5TRYBjde/kviuZ8ft51Wyjr+Cr0FvPQx7GhO9fwcbNORxG174td+m2VXZkuWf3pSGwJ/PLiQY1XFBpqkN+8TAYOUaTiF1dLPuwYa3dAuUfO2bY3sTQim8oYy1ffFgvXkKbSFW1kgZiYp/MxPO8SlSdwnISHzAYgA5o9dvlgufmfEioISyFGPDgVHh+gCSxOCBt2pi9kz749hGiQ5FgHHEwReuO2ptvJNhZ0J8RMdj0gN0UnzqUsOSdkbPdE5c+bs0C6PDGCqcG06O6UQhEKCk9Oyx21VWhtQZOP6FNf79ejlfb5cI+ulgc4Z1BxipXpr2rUMAirsFA2C8D6NCzJ9mvPMgGMmQZ8Wd9Daooj9aRobYPX6lDj8DetxR9nWJDMCScnVFdt+f9CsE0mbW8xAxgkB0wrOeytDBqCzYtCV/7/PwySAGn1hTwJTnuNSuwLEkJmTawYKtUebZQbG9jY1ICQvoKROKeOfunoP/AjBrfTMAYCrWj+JHCGqM0/3oU4JAlBIHJUisc8hHD8sQ2sVepo/1QDGkcnECQXLZr2ToHE5vx07S6ZOwdj4S/T37pWtEsECpBTu0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: cwf7yxHeMMggOoITsTpm4macYaahdseiIJ9jkAbIZga3+RAF/zmY2iD/PqVZ3j9nwzJXJY+1psydMKCpCNNOTd7DVYF9xZ2ciZoyrMPfymrO+DDBXo+IN6TmTv6w/TSRkd8q+fKjmJtNha3gWBejhNAy1psL5KeMpN2RUr+znmv+MO21EAB1+VyoLziBvJOFTiSO1iBOWHVUVl83xq6WbWAd6v9PI2SkUCtUonfYhDtIrB/S9zvhAI0WcScikWaxtHLo0CVGmXjXMI6jVnV+ceU9+hjw3y18KjPP7FpEeodfpcKNNV2b7fuChn0F28RUEXE9gvpmPpfT162dW/Pk7xQUszXxC1UwjLSBy4T46+M1c/rxlObFcFrnzoLYa0CEi5FQq1F8AdnBsqdqxVQA8d7gMPQAQe6nIWcGXoEiVi937AS5AqHbGSq6jAPVBK+LSw1umDXhBeiqMGtrl9sYHA9tnvco4X+7cItWHgEPRlT0uSrCGON3Dm1jz8qswBJtfEly/tpt6BNgnQFgVln/60EHz9Vm6orV07fqbGAp+CVqtNG85EBeoOwcI1Um35SzZP1JJK3/LiFc0xt6k+2hOTFSy0gp9K+3LCKcjVwbUCuPnOnZmY6iv+02RuiO7f5Gpt+qVKfLrcw6yUncQhOZbVAMXgljuG9/+LY/zdU5PdQ0bSP80L4fUFZVUXrkiSzlHczgAyxep7r1YOOsaiyZjL2YXMGEf4wPj/I1OtYyk0NDbPsFgqbfKz4UpfWz+rQL X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4018ec01-734d-4b6a-9dcd-08db73a4a1f9 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 04:45:13.3349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v/9eZPNdXFI1mTbOvU8zEgJ2+el3371NR5LH1fDBMW23n+QnBk/lf/tr+UkRQCV8uef+healAQ+GcuSyCwCKFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB5966 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-23_02,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 spamscore=0 adultscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306230041 X-Proofpoint-GUID: P7XR0EGCcnP0_UArKn6tzVrhHPOHlZMA X-Proofpoint-ORIG-GUID: P7XR0EGCcnP0_UArKn6tzVrhHPOHlZMA X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Binutils From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769467503443030366?= X-GMAIL-MSGID: =?utf-8?q?1769467503443030366?= The API sframe_fde_create_func_info is provided by libsframe. Current users are the bfd linker. Adjust the argument type for the variables carrying the SFrame FRE type and SFrame FDE type to consistenly use uint32_t type alias. include/ * sframe-api.h (sframe_fde_create_func_info): Use uint32_t instead of unsigned int. libsframe/ * sframe.c (sframe_get_fre_type): Likewise. (sframe_get_fde_type): Likewise. (flip_fre_start_address): Likewise. (sframe_fre_start_addr_size): Likewise. (sframe_fre_entry_size): Likewise. (flip_fre): Likewise. (flip_sframe): Likewise. (sframe_fde_create_func_info): Likewise. (sframe_calc_fre_type): Likewise. (sframe_decode_fre_start_address): Likewise. (sframe_decode_fre): Likewise. (sframe_find_fre): Likewise. (sframe_decoder_get_fre): Likewise. (sframe_encoder_add_fre): Likewise. (sframe_encoder_write_fre_start_addr): Likewise. (sframe_encoder_write_fre): Likewise. (sframe_encoder_write_sframe): Likewise. --- include/sframe-api.h | 2 +- libsframe/sframe.c | 42 +++++++++++++++++++++--------------------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/include/sframe-api.h b/include/sframe-api.h index a00303a3598..d04ebe85d11 100644 --- a/include/sframe-api.h +++ b/include/sframe-api.h @@ -94,7 +94,7 @@ sframe_errmsg (int error); /* Create an FDE function info bye given an FRE_TYPE and an FDE_TYPE. */ extern unsigned char -sframe_fde_create_func_info (unsigned int fre_type, unsigned int fde_type); +sframe_fde_create_func_info (uint32_t fre_type, uint32_t fde_type); /* Gather the FRE type given the function size. */ diff --git a/libsframe/sframe.c b/libsframe/sframe.c index 912d34352a1..7391df0d3b5 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -132,19 +132,19 @@ sframe_get_fre_ra_mangled_p (uint8_t fre_info) /* Access functions for info from function descriptor entry. */ -static unsigned int +static uint32_t sframe_get_fre_type (sframe_func_desc_entry *fdep) { - unsigned int fre_type = 0; + uint32_t fre_type = 0; if (fdep) fre_type = SFRAME_V1_FUNC_FRE_TYPE (fdep->sfde_func_info); return fre_type; } -static unsigned int +static uint32_t sframe_get_fde_type (sframe_func_desc_entry *fdep) { - unsigned int fde_type = 0; + uint32_t fde_type = 0; if (fdep) fde_type = SFRAME_V1_FUNC_FDE_TYPE (fdep->sfde_func_info); return fde_type; @@ -221,7 +221,7 @@ sframe_header_sanity_check_p (sframe_header *hp) /* Flip the start address pointed to by FP. */ static void -flip_fre_start_address (char *addr, unsigned int fre_type) +flip_fre_start_address (char *addr, uint32_t fre_type) { if (fre_type == SFRAME_FRE_TYPE_ADDR2) { @@ -257,7 +257,7 @@ flip_fre_stack_offsets (char *offsets, uint8_t offset_size, uint8_t offset_cnt) /* Get the FRE start address size, given the FRE_TYPE. */ static size_t -sframe_fre_start_addr_size (unsigned int fre_type) +sframe_fre_start_addr_size (uint32_t fre_type) { size_t addr_size = 0; switch (fre_type) @@ -329,7 +329,7 @@ sframe_fre_offset_bytes_size (uint8_t fre_info) includes the starting address, FRE info, and all the offsets. */ static size_t -sframe_fre_entry_size (sframe_frame_row_entry *frep, unsigned int fre_type) +sframe_fre_entry_size (sframe_frame_row_entry *frep, uint32_t fre_type) { if (frep == NULL) return 0; @@ -363,7 +363,7 @@ sframe_decoder_get_funcdesc_at_index (sframe_decoder_ctx *ctx, } static int -flip_fre (char *fp, unsigned int fre_type, size_t *fre_size) +flip_fre (char *fp, uint32_t fre_type, size_t *fre_size) { uint8_t fre_info; uint8_t offset_size, offset_cnt; @@ -416,7 +416,7 @@ flip_sframe (char *frame_buf, size_t buf_size, uint32_t to_foreign) sframe_func_desc_entry *fdep; unsigned int num_fdes = 0; unsigned int num_fres = 0; - unsigned int fre_type = 0; + uint32_t fre_type = 0; uint32_t fre_offset = 0; size_t esz = 0; size_t hdrsz = 0; @@ -585,8 +585,8 @@ sframe_decoder_free (sframe_decoder_ctx **dctxp) /* FIXME API for linker. Revisit if its better placed somewhere else? */ unsigned char -sframe_fde_create_func_info (unsigned int fre_type, - unsigned int fde_type) +sframe_fde_create_func_info (uint32_t fre_type, + uint32_t fde_type) { unsigned char func_info; sframe_assert (fre_type == SFRAME_FRE_TYPE_ADDR1 @@ -604,7 +604,7 @@ sframe_fde_create_func_info (unsigned int fre_type, unsigned int sframe_calc_fre_type (size_t func_size) { - unsigned int fre_type = 0; + uint32_t fre_type = 0; if (func_size < SFRAME_FRE_TYPE_ADDR1_LIMIT) fre_type = SFRAME_FRE_TYPE_ADDR1; else if (func_size < SFRAME_FRE_TYPE_ADDR2_LIMIT) @@ -717,7 +717,7 @@ sframe_frame_row_entry_copy (sframe_frame_row_entry *dst, static int sframe_decode_fre_start_address (const char *fre_buf, uint32_t *fre_start_addr, - unsigned int fre_type) + uint32_t fre_type) { uint32_t saddr = 0; int err = 0; @@ -762,7 +762,7 @@ sframe_decode_fre_start_address (const char *fre_buf, static int sframe_decode_fre (const char *fre_buf, sframe_frame_row_entry *fre, - unsigned int fre_type, size_t *esz) + uint32_t fre_type, size_t *esz) { int err = 0; const char *stack_offsets = NULL; @@ -1056,7 +1056,7 @@ sframe_find_fre (sframe_decoder_ctx *ctx, int32_t pc, { sframe_frame_row_entry cur_fre; sframe_func_desc_entry *fdep; - unsigned int fre_type, fde_type; + uint32_t fre_type, fde_type; uint32_t end_ip_offset, i; int32_t start_ip, end_ip; int32_t func_start_addr; @@ -1178,7 +1178,7 @@ sframe_decoder_get_fre (sframe_decoder_ctx *ctx, sframe_frame_row_entry ifre; const char *fres; uint32_t i; - unsigned int fre_type; + uint32_t fre_type; size_t esz = 0; int err = 0; @@ -1359,7 +1359,7 @@ sframe_encoder_add_fre (sframe_encoder_ctx *encoder, sframe_func_desc_entry *fdep; sframe_frame_row_entry *ectx_frep; size_t offsets_sz, esz; - unsigned int fre_type; + uint32_t fre_type; size_t fre_tbl_sz; int err = 0; @@ -1505,7 +1505,7 @@ sframe_encoder_add_funcdesc (sframe_encoder_ctx *encoder, = encoder->sfe_fre_nbytes; #if 0 // Linker optimization test code cleanup later ibhagat TODO FIXME - unsigned int fre_type = sframe_calc_fre_type (func_size); + uint32_t fre_type = sframe_calc_fre_type (func_size); fd_info->entry[fd_info->count].sfde_func_info = sframe_fde_func_info (fre_type); @@ -1549,7 +1549,7 @@ sframe_sort_funcdesc (sframe_encoder_ctx *encoder) static int sframe_encoder_write_fre_start_addr (char *contents, uint32_t fre_start_addr, - unsigned int fre_type, + uint32_t fre_type, size_t fre_start_addr_sz) { int err = 0; @@ -1584,7 +1584,7 @@ sframe_encoder_write_fre_start_addr (char *contents, static int sframe_encoder_write_fre (char *contents, sframe_frame_row_entry *frep, - unsigned int fre_type, size_t *esz) + uint32_t fre_type, size_t *esz) { size_t fre_sz; size_t fre_start_addr_sz; @@ -1644,7 +1644,7 @@ sframe_encoder_write_sframe (sframe_encoder_ctx *encoder) sframe_func_desc_entry *fdep; sframe_frame_row_entry *frep; - unsigned int fre_type; + uint32_t fre_type; int err = 0; contents = encoder->sfe_data; From patchwork Fri Jun 23 04:44:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 111919 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5529064vqr; Thu, 22 Jun 2023 21:50:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Mk5MFOfLmLfiw8Lbyrqo0tj9SO/is4LFxjO6iJcSAYxjk0zU4USDAtVoYoBnReDJ1KoHR X-Received: by 2002:a17:907:9623:b0:988:9a65:eae6 with SMTP id gb35-20020a170907962300b009889a65eae6mr12937633ejc.38.1687495857496; Thu, 22 Jun 2023 21:50:57 -0700 (PDT) Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id rp28-20020a170906d97c00b0097885e7bc15si4663462ejb.71.2023.06.22.21.50.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 21:50:57 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=vEgy4h7I; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 44A3B3889E3B for ; Fri, 23 Jun 2023 04:47:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 44A3B3889E3B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1687495655; bh=4LtHC6w92TZl60m6T3Xf/2RTKiQhT7NNMd80/6sxO2s=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=vEgy4h7IHIqhna0wdM/TRyOx5wAek6mDSM4ll/Ahchx7z/U2syPWBlTINsq4VfHl0 cbyjD4BRSJCumKjxHCYQPhB+pGaWS/RUnOldZC9pxypP3t7YrnXM0SqsVNCwYseQZV zJxSB45xyKml9XvBtVM/Oe9yUPQBfvjhFSzLRP/8= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id F33E5385802F for ; Fri, 23 Jun 2023 04:45:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F33E5385802F Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35N4KsKj019475 for ; Fri, 23 Jun 2023 04:45:19 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3r938du517-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:19 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 35N3CGxr005858 for ; Fri, 23 Jun 2023 04:45:18 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2040.outbound.protection.outlook.com [104.47.56.40]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3r93989ct8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WBzt3s5xQVOWssgnSVbIU80a1I9HSE9hUQCIf/ue8sRiVhA2FTmTdKS7Un84XSKRXYGJPDktNL4xLTpcJ9x2N5rjWBw5i8Y/JrjDdPJK6hJbPifMpfKiozTFp+J8P5fSIkuJxqdqqZOQifMKuwzMmzydZtYO41vvYoVFfClPKqxiLOV3lY80666GyZj73K406USiPU40la5z2TFvanLRGTltmFfKFUxBNcS1iGTe+ECZOy30jA0Wwz7/+1eYHDQBc0PFWmruMTuziQ+ZymP5z+TP+cj2BVCrbco1BqmAi0z4+I93d1DXwurAx9SCzfAtAlbikOEfbI19e+Y7dkP7Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4LtHC6w92TZl60m6T3Xf/2RTKiQhT7NNMd80/6sxO2s=; b=Svji46PbycutsPQWk1wmnG0BpoN9nA9gQAjU7dAOIZPOagZrcLU03aDFyhqbVmk0P4y7rIMGJCb0IdSVOc6lknLL4/wfeElvyq2KLrCwZOnC09VhYIu49hjMExA3nmtHdvkmKEObwpZPvgHMm7QCLqB6tZQbxt40ohlUXAVrqRfwDLXL1HXBHEafir5/ZAEEeLKOdNAYmU2+nlZ/q70Siwj0vmwpGnr8grXdlM1EYrZKIJ3ZSXxbsy8FN6PSGgY/DCMdqFUK535xyhuSb0ETtfMoxmD9Brr72pZlDHDX55306AYUPMlBeFnhMdMVfiBiFojoacsDLCem9oaMxVEfcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by DM4PR10MB5966.namprd10.prod.outlook.com (2603:10b6:8:b2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Fri, 23 Jun 2023 04:45:16 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6521.026; Fri, 23 Jun 2023 04:45:16 +0000 To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH 07/10] bfd: libsframe: use uint32_t for return type of sframe_calc_fre_type Date: Thu, 22 Jun 2023 21:44:45 -0700 Message-Id: <20230623044448.2617101-8-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230623044448.2617101-1-indu.bhagat@oracle.com> References: <20230623044448.2617101-1-indu.bhagat@oracle.com> X-ClientProxiedBy: MW4PR04CA0284.namprd04.prod.outlook.com (2603:10b6:303:89::19) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|DM4PR10MB5966:EE_ X-MS-Office365-Filtering-Correlation-Id: f9cb019d-1c35-4745-0487-08db73a4a412 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4vwozXD6umRt0C9dvefA6650fOBkd5SOe/EHpmIS3l5898FR8L1Km7g3HktDLgoOfRRylcid/2pHvNoXC9NC/fVdEFermDBiBnyYG5om8Q+tNtbcqzAR/km8YPmTE3Ch1geJsU9RCa9wg/OElA1LQRzOtyEfIXPxZHk2Ig7fFEA3A7G/2jAJg0xQlOCeS5ZsQRHTeC4NrAaT/O4cpYj0jtlYCH07oO0FCnCAbXO6blKHOMZ9R8yNplc7dSqk4N+at5hKe11Ap3ckiMpvGNcVu4CBkSSTvRQG6Dlzbd4NgWDZilLd/Arlj5ZCl82eGIxeZHzxViR4veK6aWjBjqGOVg/na+qcKm00xf6QLrY6bXPRXBOhhHcRA9xau47kHhRfWZbAFLKvIXsf5+8NOzT8Z7edrMtFzT57r9mAjR3udZTB2P8acbebi3SYTmVicn+ko8rXMi8p64o4WUuRcdbSK14Pgw+jRJWxCIpRchCzQmFxE1aRybrwV1bGw5r57BAA+jPTOf0BY6N8jkddyyBf8NrwgMIu+q5loSI1NvvzBEQbtnu/YRwY5G2Tfb821CQe X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(346002)(366004)(39860400002)(376002)(451199021)(2906002)(478600001)(38100700002)(2616005)(36756003)(6666004)(5660300002)(6486002)(66946007)(66556008)(66476007)(83380400001)(316002)(6916009)(86362001)(41300700001)(44832011)(8936002)(8676002)(4326008)(6506007)(6512007)(1076003)(107886003)(186003)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 8Uy9lNZ6LvmUv5WY13SxkL2L8yny9OTezUgemRJeVX8UPlNoxOiOuH9Pt7F3DaxmYu40VH1QraUMltY8rw5PNE03sl2dvBYQBLaZr9TfFADsDvgHrsd1DV5xO+AZM1ZbMiXf18YWsAkMyFvOI42xwKwQw8Wd5RSB+ycjVJjiMaj/eT8OWE4CyaUjzBRibnG1UU7Jb/X9YoIMPaovpFEbJLOnR/YrNFjqDMRoB4zVHtnaZO/VO7SLhUIg5LR9oUrIzeP1wAV1CEfDhtt35LQB+hsBmj+NytBf6/iVBqcwZ0gcDiK2NYVBNZu80S8BpWaG4KoyxoCwfmA+Gtgyy1zJaiDe7jEoEvjcaZr9ZhZjg3W3Jw6JAslsfvBH4pOjxkkKo/mLJaXjnX9K3xG8VX7JimcyicfEwTDmYr5QR6sZW68SfZCWrr44l5aqoyCXccYreKJhDK3yBbnckuwg6p6Vc8sNmDleFnzyzMsiyvySpK71h/vVR1mxuvJ8iBtQnWe49CUcv/5u0vxQHRBdcziSb4FCRUu34jFXORsN8ouQhrrzEriQna/MNEaLYwWtder/dYlXwwXh1twbkTJezksM/Clpq5O6JToARxxsdtxsbufVC6RLoP1Ejao+gigSVQC18Ioda8MFBqwEI3R3+w9V9JdBayD7oPWxBwyPYEN9gWnWPoAW6Fk98thJJWti9dVEyEVDiJnHsxUUHAPvCiNCrtIBPhhrsHhNCVGpnsFdZlWzNdz8me4yaRzbFJ+PiDzEwG+1afdEd2LuYoJU6GTEOQcZ1rI4+YbXWmlv7fQB0nj8wnQ3muXvpVJbfWPmSWdOIGYvZo27qgvVdzDaqY3gdGWdRjd5cjqrYMDGAyhNhcScLA2Vd7WceLgH0sBDKeJ0MdQIrfDqu/mJgARtJdAYoxc+TYvMWAZrjzusv0td4N2QHvWjSUpvMsP+FcrBkIxP/u1eC6/JhV5KFOTIRUk/GU2N69tlE/YnzLSWZIYIbAdGyNbR9FtyiRP4+MY/axB/HGfAfuQqmPHEGVSrr0q7QZrTonbOPWIzyxY83aytEGjVI7rJNguPia9D94Ha6JBE0tcF06/uVWPCVnLA3kaUugcSiqCV6hMBi96gWLZiTW0SetxvUpLcc0ngApsuToGQ+W1DdzbZ9wnA+eREKjepAIeCzS0QUai/hwYDXHt7DP1DQwlg4hmK8YaVtgOU/2tqxvyNn0hETs8CS9TGSPL4hP8q01xWRstRuoH+Zoqw5GFV9w75AT66nZZp1jSu4dUH0o70ueEE7n91hs3z7VCqmm2S20fI9PypF0RohcuGvfZqLJhOr//WmBhYCMTK1h63Cw/isngl9Srlt+YBWrZpUfVi3bGeMdCfI0wcesvVP3lPO9SOhrG3a2q5KK3rmr0Hd1ExSMEiC0DMvaiGqIC42GzA7r7J+bJYFX1C/qrE7VUIcabz4sNRb82stLva5f8fC0zAv3TdYGlgAeHW8k84jUgPP63XSPh/H9L57SDsyn+ugldxlUpyU1dabul9jkswQLAknL9eDn4DVIKazSts/nqzZDbmfbnz5iaEs09meKMiUOl7h8CUUSHhV6BTGFi5 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1zFDuVQfs2r3/QZeX/+ig8TwLzpgZT6qJHuX8VZ6tkcJYawBatfOik/a+tTrjhhTH4mu5nTWl9k0gaY8zVx+brzazhkcxUCH+Y6kk+wU8SvAoymXBRMxhw51PAHKE16g6a/DPUEvsR0fxWjmjuj0yDCUnLQjfSAn+aH/Z+smfUB3gZru0h5As/4d3oYwtxcpcRMSgNcOgxzBT+vz5qfU5ZSn8v6A3FTiOk+x/Inu4llNhFlc/PxPEmT3fkXJCqR589Wk6oPtdohyRU2/9hFJYemKaKz2BMeowa5FhnIlPS3Db7C4WRNhiQhVK5CzHUa4z9t14jEdlHu2UPIl0iJtbWl7yzpi+Ddu1UIH++eFL9HR6I1H1vZ9Gn3BDC18vu8nxSVgt7qQg+icCOY7BtyAEr2hRcosbyezIFhPQCi82oV1yjV0luIbHR9zLMDA7TmYWyw0XaUfze1RUyDvPnDko2CDxB+JOYShV2TrQz/eYSqCXMhV96iYlXLCPz19LtLQ3n3nyZYySPSThgXhw8xp4mHTIW0SSu4OFdy4Nvepslg6QNaBATd2Lb8OG/ESAXaEKuaLFNX7w4T8NIHu7XZJjN0T2PuKTcfRVzZxsGFFqAJ9FvpJpjJ1wXRmeASaPWdL40d9PlM6FQWyeMnhhZQZiy0ujXI2CCJDack6IU8MwgQnGemfYnXUzYYCLpAl00pClqdTvqYxKPpuaisUPGPa0e0fatwsCnGsobErtFLBwP/o9qAVUB79jWTOdxR79uj/ X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9cb019d-1c35-4745-0487-08db73a4a412 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 04:45:16.8257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bNHXTQPW0owt/8hUlBTJSY/F+Lq9QeZCEVYwEW7+4Y3yO7yHmrsFUrxeAk0n4bOEgJAnR1igyZbR9mN4Z+IFxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB5966 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-23_02,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0 phishscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306230041 X-Proofpoint-GUID: iaruY9lANMkHe9AFPacF0apUYdGcBXFy X-Proofpoint-ORIG-GUID: iaruY9lANMkHe9AFPacF0apUYdGcBXFy X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Binutils From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769467656305689928?= X-GMAIL-MSGID: =?utf-8?q?1769467656305689928?= Use uint32_t type alias consistently for all APIs in libsframe. bfd/ * elfxx-x86.c (_bfd_x86_elf_create_sframe_plt): Adjust for the changed return type. libsframe/ * sframe.c (sframe_calc_fre_type): Use uint32_t for return type. include/ * sframe-api.h (sframe_calc_fre_type): Likewise. --- bfd/elfxx-x86.c | 2 +- include/sframe-api.h | 2 +- libsframe/sframe.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bfd/elfxx-x86.c b/bfd/elfxx-x86.c index 8e13a92e7f9..ffd02f137d1 100644 --- a/bfd/elfxx-x86.c +++ b/bfd/elfxx-x86.c @@ -1832,7 +1832,7 @@ _bfd_x86_elf_create_sframe_plt (bfd *output_bfd, bool plt0_generated_p; unsigned int plt0_entry_size; unsigned char func_info; - unsigned int fre_type; + uint32_t fre_type; /* The dynamic plt section for which .sframe stack trace information is being created. */ asection *dpltsec; diff --git a/include/sframe-api.h b/include/sframe-api.h index d04ebe85d11..70829ec87cb 100644 --- a/include/sframe-api.h +++ b/include/sframe-api.h @@ -98,7 +98,7 @@ sframe_fde_create_func_info (uint32_t fre_type, uint32_t fde_type); /* Gather the FRE type given the function size. */ -extern unsigned int +extern uint32_t sframe_calc_fre_type (size_t func_size); /* The SFrame Decoder. */ diff --git a/libsframe/sframe.c b/libsframe/sframe.c index 7391df0d3b5..8e9dc0a9d2c 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -601,7 +601,7 @@ sframe_fde_create_func_info (uint32_t fre_type, /* Get the FRE type given the function size. */ /* FIXME API for linker. Revisit if its better placed somewhere else? */ -unsigned int +uint32_t sframe_calc_fre_type (size_t func_size) { uint32_t fre_type = 0; From patchwork Fri Jun 23 04:44:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 111914 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5528058vqr; Thu, 22 Jun 2023 21:48:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5yp/fwL7mvrttUxbjEFJ5GVRppjmVTY8ygmzB14bG/GOF//fWTeYDUlB5TspG4/lC6onm1 X-Received: by 2002:aa7:d9c2:0:b0:51b:fa2d:c3a5 with SMTP id v2-20020aa7d9c2000000b0051bfa2dc3a5mr104573eds.8.1687495687945; Thu, 22 Jun 2023 21:48:07 -0700 (PDT) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id k5-20020aa7d8c5000000b005149bc2c0b1si427506eds.67.2023.06.22.21.48.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 21:48:07 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=EPevpOEp; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 12DCC38319CA for ; Fri, 23 Jun 2023 04:46:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 12DCC38319CA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1687495583; bh=c8diH4bvLBfjv72vdFH1w1stwzYrQlf2DkhGLEaOmTI=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=EPevpOEpRbOfcZXujDkdYlkcQnKGZD8suX7g4ZGQEruQat5z5aCIOTBCzOCRSXd6Z wECacblnM2LvpmwoCjpZ9eMw75ffgIWd0gKh1MKSZWtPpu6GZwXI4szyPHZTA3jpQs R1E933em5JpNiIvvcZbobVAshj2wP2gRlVlqLhLo= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id A9DB73857354 for ; Fri, 23 Jun 2023 04:45:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A9DB73857354 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35N4Va7w004832 for ; Fri, 23 Jun 2023 04:45:23 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3r93m3u9pw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:23 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 35N3ZiS0005841 for ; Fri, 23 Jun 2023 04:45:22 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2044.outbound.protection.outlook.com [104.47.66.44]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3r93989cva-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Se9I71/4goCFBwZsb0CszmA784nXVabMrIptIe3S4HoMguEFKm4Wktxn+t6OAfGK5f0xeEBnomFKS0JVsMel7Cf+CqHhubIHiYwdCwX00KsBsQw0XF2/4IC1zotSlbkuq+y3nwsuk4lyvymDOSJ+B/U6+tuFHzkkg8LkA11+q57AzX+P/B46ZwHBKwdknW1dr6iKmGj32iK1Tp4tK5aw+/UMhaie2Q0mjltc1AjhH0Yo/a9oFFc9xUquM0mEd7Ac3R3RQdykdxht0T3PDlNAIGHxXSO35WuNbhwSCbK9pl+3MIDlRyp38Cps/6hjGMURYQ7OUepqcjgWTRYW5/vFAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c8diH4bvLBfjv72vdFH1w1stwzYrQlf2DkhGLEaOmTI=; b=famNjW5QMju4+hJ7+1KYFeh+9zlGbfZTw9dxX5NtbNgeSPBbbXZRYHiQ79ZOliOb3nHL+we/o6H4O0SbhfHRaDZ1pUE4gFQ/MmYclHQqJjEvspjnTU7c8dgl+xaJfErhig6WgG1TpQO0Xb5T/6nDt9iLcqYEZkdTZAqDJNq4sEHecXwJSNBpvsmaA0EN3FbmNzrsNM+A9JwynB8eojhbDY1Z8uTy/rZMeKby9Rof6emumd/cDrUzmmV+TSYeSmKs7CHyqQAE1bU6VUps90MkTnz/lymQw0K3TsuMAw3mEDONvguyJQ3p4GAdHVQF4OQ0Pccv5uIMD7i5tttKkd2kVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by DM4PR10MB5966.namprd10.prod.outlook.com (2603:10b6:8:b2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Fri, 23 Jun 2023 04:45:20 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6521.026; Fri, 23 Jun 2023 04:45:20 +0000 To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH 08/10] libsframe: use uint8_t instead of unsigned char for abi_arch Date: Thu, 22 Jun 2023 21:44:46 -0700 Message-Id: <20230623044448.2617101-9-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230623044448.2617101-1-indu.bhagat@oracle.com> References: <20230623044448.2617101-1-indu.bhagat@oracle.com> X-ClientProxiedBy: MW4PR04CA0125.namprd04.prod.outlook.com (2603:10b6:303:84::10) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|DM4PR10MB5966:EE_ X-MS-Office365-Filtering-Correlation-Id: 29e71ae2-c961-48cb-d176-08db73a4a5ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H4xx/AHDLCuSldvIzCWxQ2vyKwgvZfKfv8O+Z5A5drJPi2oo6HUsc8T8RzBMWv6X8+sPrOQYMbAknlBE906zJr9NLNmxHwSpYj7UOHYM77gkRdzTYbGtuOp7o60Uui6lnh7iDd2DcxCI+GxFShkaMyjrlRtcS2n2v4N5Vcxxi2CDG+f8Ageml1ISawoP/PdDhh1uXXRSQH8B3isbvdEq1mV17SwH0P4cVunrtLe7wKFRao4M/wW8byzWF/U8AV/zZfvHQb8Qj5Q3v+fbiezeojCgNY30NPT/rIz7RS6qQpYAOLp60h9QisTZ+pXjJWQ1jJxoHjifYo736E4fbJShypN762feqjeqRYDqlIeqIZRat6cC3incJJBrcGehUhXbBWBz/1hdWQnaKTQIDpVcaVhmfl+8SYROEujtrIfmzPbz3r9SciGbTql61FLZ+vg2Ga9FIDCondwNodMyzovkloM87fxhWtJO/LJjBHOTM3SzpUMXdNEcR1j6ZWM9gPyx926sNFvFfyOqWrNz2HDcEgzwh0orC1D9cZkolm2+nRHvLBi5V0nW4ehJM8ipvHhG X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(346002)(366004)(39860400002)(376002)(451199021)(2906002)(478600001)(38100700002)(2616005)(36756003)(6666004)(5660300002)(6486002)(66946007)(66556008)(66476007)(83380400001)(316002)(6916009)(86362001)(41300700001)(44832011)(8936002)(8676002)(4326008)(6506007)(6512007)(1076003)(107886003)(186003)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JhQynSYGuQf2K5cOs6X0ydbMJ+ZynquoO9Abfb1G0xZVpgdQYqKHdf6JsiiYssSJRhDPnbnYLCxA6JZ8AolsyUNkjuWJSxqw+YPMZkuateeuCoLrpyNCfAIlpm8teZVIOeLhKs+s6cjXOu7fHsM3TJSUCACEih2x38UyJUpb/8Tv3mtXKYP3t5wA9Q6E7g7kn3dw/GygnEPZ4RdT+T6T6iDDUcP6h2GjgGmtS0qVUdmiM68RAnbsQldl1w8PPOkbm4tWZ8eVg7PFhk+Shxb7C3jNYIsMzd/Uanftsj4Q8l7QJrzumQsB2hOB3iEiFmPBBi4P5p5Yzp9RcX9j9aWhl/ydcMf0wzzxkZORaMXeJo1PY+QzD0p1qLE6fR56fbil7vN2U58JuRN22L1t31edEUV5rDvH9hX214XU6SQ48lUoddQ2vVZXxYcv61wG05JOdC9M5vjXSePcUgvNAay9vtTjy/cChSpURg4YZRlx4uf+AiVXI1aiY63wtRJljRqYatbM8EeErcFPv2/b9rmaoNQpipzfQIvdX9h7/weOO6xS2pHESdsu85K7mkZ+IINvgWp93JD7TnvzufZmS5d1HRo5l5UZyuOsgZVcGrjFgccdram3/nmyTLmmi/j0Ar4lEIij18QzsrCoR64pMBrAPcqJa+VbjxC5fy4IWRNZ8jmA0La9xkxIbnkCDe3ER+WzEgR4jneBxyf5cDbBt0I51LkLOiLSrBLVVImyPPURzJOpRVmg2fIZuRi4znUEji4HOgPBPUqCtdqTfpCGKtGbvgQkE0uW0/8uAU2dZK/J/3vFrGIwZNLMN6tEBQR3RrqeCYuKH87cKJ3ohrgro6vcM0Djfvl94Z8/y7IIg6PThP1VTQpEMX+Oz6hRSZmdolqtO9oo3WvBdaYegS24j/Zy2t+CZP2VDYuCfnPTBcD8jSAJ79Hi6+OQCKZdxH5cmk9pUKCxFVadZp0uf1GquW13V5Uop2cIeHE8EzhmfnK3TJOb4I72EpftMMwryhyzdShOVJcIlF9qA0ZUVa2Nt23O3pn6jHLzXbAP0eXsU/0ewRFOQyQZOi3t/rauqWFu+JyG/KRcCSI6KzQtb/gN7Y65HmdaJ975bg/wC0pWzaYHL4VZAoEN9PSfLMwz0dUcYnBRZA9HwQuYc6H/UXP9Ns2P1YcdcslFDPnlguwIOesfRXA6bTvExUWsW2xpEDPO5Unb/FVtiE8pAIm81PGUVkrFcXwVXIt8EG44lNgMhTsRGFQN5l845xATVdkTgAujEBOxebZ+ecqlX8xM8LWfuMx5KnmaH9mNGIMrWHyZF7j2nHFtY+B6PuZk4JpomL6LdoLpbjt69FLC6DArQdIjxlHld2LcKNOSniehSVoYli+OlTRYDwhgArVMKr3NMQ8tS9NEQ0Y+s1k4aSDTi3mTf40OuCpyjlIyxFO1Xdw7flhtWhb7q12OL8ZtPn6KH4pD09YZktmVqqWc/zMeAoswJlFA9yDg3pFddB8mEFM+NV3v67MG/iWiFU+PM6xIalyGUZfiE6+z194EbpH3yO6WANq2HeMOOYn1xdu0FbhJlIWasUuPK//WZX1tInnlez8BsBx7 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Nso12DtsdPmY9xqZZN17DyO3Vo/ZVI/b53Br25Qu2+nWppaBNqQLO7amUgBgQRjrz/So0+dbye12D1P+0xQYbWpSg2coe8Zaja3iK6UlkstUzWLfEUMr2IJNjT6l0JE7XPqh5BZkAspsPBfyfsbuFECohGvQr5L/AUpCEvtpyNEilgyXWSrdkG+t9HmbeLWBoqdgVLpu41MBB5gI2KJTK7amgcBQPF7iHIHuN0Ns6FSRdfnsdAeRqO9qpGDffv7k8TMK10hCpUVpInxXMEsrQJDyhn6HE9HmXZdTHaYA5X+cevrNMdwtqFtLWPkxnpiUFQtdamm25p82xWS75FykPVrLcAFRRs1m5amxxRyNNcH6Qi9Q2vKWq2tKGWXcUxOKoBQUJKuCIrJ3S2pakbD0pQxSU//j+Pip9HqIuT3wE3kELRCOenoBXqigQqktasY39gBhC41+764GU7UW5U+o2nTqdGiCNHegcZ2ce3Y1ZS5RC5sK81y/VfTBi/grwZkyF8Hp50utkuPyLbX1v2vM9oD/sfECQOrR3ujYsDryB3Dyuj9T64CHaSHBLd9PUGplHXVYrtmMkp3Wo1PPcmRkCe4iiKkbMUaZ2VTgbvvAXznBxSHeFLk4bZDX/4KEWDCrrh+VdmVTJdmy9h6ZZoVLZ6xEi+ISb0EGiMPlOzmxJezjfsA4TsdsU28jprvxeEZZ3D9sTNN71iFhmlTOwl0NgS4DRjEw8NjZO+PdEta+X6uqaXSXUwOFO3xBrZtr39e2 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29e71ae2-c961-48cb-d176-08db73a4a5ee X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 04:45:19.9714 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CEszBD3fXiUiwUVJuea+HOAMUZAl5+VRNLcKSXz0+OoMp7BeYjEGeI2Im8ReoOBhrRiZc/JT3JQcNRcz57HROw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB5966 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-23_02,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0 phishscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306230041 X-Proofpoint-GUID: nKlo93IG7E2jWQm0bBEFQEH-1-0RTSpB X-Proofpoint-ORIG-GUID: nKlo93IG7E2jWQm0bBEFQEH-1-0RTSpB X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Binutils From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769467478612204128?= X-GMAIL-MSGID: =?utf-8?q?1769467478612204128?= Use uint8_t consistently for identifying ABI/arch in SFrame format. bfd/ * elf-sframe.c (_bfd_elf_merge_section_sframe): libsframe/ * sframe-dump.c (is_sframe_abi_arch_aarch64): Use uint8_t for local variable. * sframe.c (sframe_decoder_get_abi_arch): Update return type to uint8_t. (sframe_encoder_get_abi_arch): Likewise. include/ * sframe-api.h (sframe_decoder_get_abi_arch): Likewise. (sframe_encoder_get_abi_arch): Likewise. --- bfd/elf-sframe.c | 2 +- include/sframe-api.h | 4 ++-- libsframe/sframe-dump.c | 6 +++--- libsframe/sframe.c | 6 +++--- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/bfd/elf-sframe.c b/bfd/elf-sframe.c index 57d67989bf9..069f7564fb4 100644 --- a/bfd/elf-sframe.c +++ b/bfd/elf-sframe.c @@ -325,7 +325,7 @@ _bfd_elf_merge_section_sframe (bfd *abfd, struct sframe_enc_info *sfe_info; sframe_decoder_ctx *sfd_ctx; sframe_encoder_ctx *sfe_ctx; - unsigned char sfd_ctx_abi_arch; + uint8_t sfd_ctx_abi_arch; int8_t sfd_ctx_fixed_fp_offset; int8_t sfd_ctx_fixed_ra_offset; int encerr = 0; diff --git a/include/sframe-api.h b/include/sframe-api.h index 70829ec87cb..e62a7a38285 100644 --- a/include/sframe-api.h +++ b/include/sframe-api.h @@ -117,7 +117,7 @@ extern unsigned int sframe_decoder_get_hdr_size (sframe_decoder_ctx *dctx); /* Get the SFrame's abi/arch info. */ -extern unsigned char +extern uint8_t sframe_decoder_get_abi_arch (sframe_decoder_ctx *dctx); /* Return the number of function descriptor entries in the SFrame decoder @@ -214,7 +214,7 @@ extern unsigned int sframe_encoder_get_hdr_size (sframe_encoder_ctx *encoder); /* Get the abi/arch info from the SFrame encoder context CTX. */ -extern unsigned char +extern uint8_t sframe_encoder_get_abi_arch (sframe_encoder_ctx *encoder); /* Return the number of function descriptor entries in the SFrame encoder diff --git a/libsframe/sframe-dump.c b/libsframe/sframe-dump.c index 2491b4391f3..37ce9d70eb3 100644 --- a/libsframe/sframe-dump.c +++ b/libsframe/sframe-dump.c @@ -32,9 +32,9 @@ is_sframe_abi_arch_aarch64 (sframe_decoder_ctx *sfd_ctx) { bool aarch64_p = false; - unsigned char abi_arch = sframe_decoder_get_abi_arch (sfd_ctx); - if ((abi_arch == SFRAME_ABI_AARCH64_ENDIAN_BIG) - || (abi_arch == SFRAME_ABI_AARCH64_ENDIAN_LITTLE)) + uint8_t abi_arch = sframe_decoder_get_abi_arch (sfd_ctx); + if (abi_arch == SFRAME_ABI_AARCH64_ENDIAN_BIG + || abi_arch == SFRAME_ABI_AARCH64_ENDIAN_LITTLE) aarch64_p = true; return aarch64_p; diff --git a/libsframe/sframe.c b/libsframe/sframe.c index 8e9dc0a9d2c..7bb8c647c19 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -933,7 +933,7 @@ sframe_decoder_get_hdr_size (sframe_decoder_ctx *ctx) /* Get the SFrame's abi/arch info given the decoder context CTX. */ -unsigned char +uint8_t sframe_decoder_get_abi_arch (sframe_decoder_ctx *ctx) { sframe_header *sframe_header; @@ -1322,10 +1322,10 @@ sframe_encoder_get_hdr_size (sframe_encoder_ctx *encoder) /* Get the abi/arch info from the SFrame encoder context ENCODER. */ -unsigned char +uint8_t sframe_encoder_get_abi_arch (sframe_encoder_ctx *encoder) { - unsigned char abi_arch = 0; + uint8_t abi_arch = 0; sframe_header *ehp; ehp = sframe_encoder_get_header (encoder); if (ehp) From patchwork Fri Jun 23 04:44:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 111915 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5528153vqr; Thu, 22 Jun 2023 21:48:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5+N74UbJbOiVburKid4G474YfXwNYACHeecZ9If4AVxNq9W0MS2CDb530g5sjcLr8pKOgG X-Received: by 2002:a17:907:1608:b0:98d:470d:9331 with SMTP id hb8-20020a170907160800b0098d470d9331mr2820333ejc.1.1687495701111; Thu, 22 Jun 2023 21:48:21 -0700 (PDT) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id z5-20020aa7c645000000b0051be8a615cbsi1622727edr.305.2023.06.22.21.48.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 21:48:21 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=wAUyDOKD; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8DF03385559E for ; Fri, 23 Jun 2023 04:46:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8DF03385559E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1687495588; bh=546o4pLTkvar4ucpJ/OgkEYzZJ4XND1u/0k8jjbqkug=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=wAUyDOKD/lmwvH/u1aDVPi52MnQnfh8NEQzqvccBNUcN7VRrTLONvaQEqE1dF6gPS +ovWto2w3hjb4l56OAyRjuBWYy6LPdE09WnjpfIn5VpziXVdZmTrgAUCQOqHwrawz0 uW4U9qOjVaPoz49faRuzzzFn1WLQk1O2O9OcVXSc= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id E1B2B3857027 for ; Fri, 23 Jun 2023 04:45:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E1B2B3857027 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35N4cUov027243 for ; Fri, 23 Jun 2023 04:45:26 GMT Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3r94qab17y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:25 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 35N2lI3g008538 for ; Fri, 23 Jun 2023 04:45:25 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2045.outbound.protection.outlook.com [104.47.66.45]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3r9398s69s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ri8oCZHaIbJGFT0LM0OhQqBtOHj1CeR08Rbx4P7N3rkrqERljlydGxivCMf8RP5KriST+9WHtYFZg6VLBT4sqGZDU1d8LxHknaqrwJxlWVqjm9k+VxpYYsM+20dtyVzQYZXEd6IkUFROMSmWF/kQmaImJlRF8qsoXN/CabaQPyUpVUkda8mZQgAn5UPDqGMJmfdpyKzKhvIdfpCP2UVP8rfm/T/ImN4ojvM4ebp4DhoDPbaaBlg6ETHBc6S5IWfnvwkfWgHaQv3fGEffmBvpTcz3UkRCtMG1H73hza798kcX+7CSM1lRYk8sw0lh9PTk3/2DCw4QQVetjwDfa2ce9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=546o4pLTkvar4ucpJ/OgkEYzZJ4XND1u/0k8jjbqkug=; b=Azp/p2jvRsjyWVY/3RHL2hCBV8pa9raM/IZqAM+bPl3bIjcFgbPT9rhVjfMhrPpqJTdYjSrdrfH3NE4XiqQCm8l9A8yLwZzDLS7oks+JXhtpTWlI+xoSFuYQ92m3HkQ6gUuXxvfzpx5Vo1QXEDNlokJ1wqFdc/AHMvKcJ83Vo5GXMnhH8lNyRZgA+sYcLw5RCoapwrJQHg0LwmhLI1Fan+iTZ6xj/g909b3AltskRSq80YZraHRuYPO8WMVdHbE5IwSdcqp+3yDNoLARKYjKgs/0T9fPOVEBgZXBN1Q0e8fBV3tibhWBVM1SS22jifz9pGicD5i+/ooy0UA4ftuR4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by DM4PR10MB5966.namprd10.prod.outlook.com (2603:10b6:8:b2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Fri, 23 Jun 2023 04:45:23 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6521.026; Fri, 23 Jun 2023 04:45:22 +0000 To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH 09/10] libsframe: use uint8_t for return type of sframe_fre_get_base_reg_id Date: Thu, 22 Jun 2023 21:44:47 -0700 Message-Id: <20230623044448.2617101-10-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230623044448.2617101-1-indu.bhagat@oracle.com> References: <20230623044448.2617101-1-indu.bhagat@oracle.com> X-ClientProxiedBy: MW4PR03CA0067.namprd03.prod.outlook.com (2603:10b6:303:b6::12) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|DM4PR10MB5966:EE_ X-MS-Office365-Filtering-Correlation-Id: 818ef08d-300a-43e4-6501-08db73a4a7b1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vr5KxfwMJPMlPdilpuOdTHsHZA5EEDynrFAdjmAn/YiIBUKFpYo5hCpwIBvXUa8ykvAnL55qqEJFk46OZ2RdyYZrR0Ec7w39MHITm3Q9BMmcROjEzNI1ZB0G/+2kggNoc3xE5gqveHnsz55UU9sILZ+fmkA8x9US4EiA+lBEKEWcSIuC6hRmLr5S4L5GD/bHXcVgH0xxvBjcBGUkl4i1Al++AgfV0WcPy+BNKTPGyC6cnPhmyKXEXyQ5hDwOj7Hf9WWd7Fr5Yj0RKz8Ac3mjRHOxPuG3n/3iraL6ymxhrO4VOJRp2ZJ8c3MjrIATA7vn4o87sI2aaY9DZxe1Jk1Y8LNrSTfOZpV5CFvQWIdyErYFoS5pEwwAN1juB5NFf91E7dIr9W3TBhlPYY+NxP5zeTcQbs9IPPNfOtZnCNbSL/nBOfgqVlCj0c0CeZBCtDEvCCXkBFtNlYQUp6NFXCLqXPev/YoapImHTpdXIZ3HySVoV4OXFHqKjGUzR8r0uKjQQTsay68Ue164GCIuKG3SyUsR2cKqGrgrqpNNjUlcBy/Ic/6k++nlaDjGjUcYk57g X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(346002)(366004)(39860400002)(376002)(451199021)(2906002)(478600001)(38100700002)(2616005)(36756003)(6666004)(5660300002)(6486002)(66946007)(66556008)(66476007)(83380400001)(316002)(6916009)(86362001)(41300700001)(44832011)(8936002)(8676002)(4326008)(6506007)(6512007)(1076003)(107886003)(186003)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: UONmAq71um9rjg3GHUmN7VuKIYZPnsTqBuYv63PEc7px19jZ3OP0Q3JtBNi0OybQCou9DtG36FTvLMI7ud2NomxBwZYNVYaUuN4q7wCmrL8B+d+s0eh9Ph4wi9CkPti1jRfWn9v6aehRtNrnYduJywkDAbtPA7i+kPMI9Ztd6nZCUVthvA+RedJenv4Ae/SgltHFQrYlzgmcw2NHbfx6eq7CW3w8245uY//Mlss+pPoF6uw0UbL2jmY56Itp93BznH3fx+9HmgD+Opkf1ipawobwzTT1nBArHFvYjTm95KS0sOLrlJaqUTqkVCi2i98qTM2WLV89s7XsUaUZDoibUK75V8UqJVFcGg5CBfSPnofTaiwzpyXJ4whLwWr1qzBlmqn8v+36w/hYXTnscgfen0Q3YFuGjJxMoc8ySCw2KEw0FcIUyVsMlFkrq0kpV/O1CCiE2S5tZf4uT9osq46nBcbkcv/5OjpT+VOXs9fnxCP+xozKUOCGu1kFw7sFkYIQv5S4ZfHdjm/OpMxRCFOfe2vBMXZ1yD0Qm7cQiNSx/dOauAXPkbEImfyaAaH7Q9CYpjIsba2eZOJD4SKC9PkdDFvecLmoUpQsX5ptxPJCyk2Qajjy+Qrl1s/qBXobH92egWCh1G5b/2e7naLBgNZab5zEKIdX/c6xzYwRogtbFl6hkoK0uZo2s5Dnqe/6FTmIowGlj3HnLIDFUPOSWQ6Fa+VL6KA6f53BvTmnAnysExM/QMv96+sQ8wV1xDP2gB0WMy/pPy/3V10ngrEADEzZK7b7c2h2AutRS5qVWcY1aDtBxOp+lS8Yv6eHCJnORhSD4QSWn3Kbb1Iqdq0Xw1dNMfA4kAPm3iNsA7DsKS0uizd8zT/CBEY7YfSoGuEdxgjpTRl4iMVYTRjScP5ZvfC9SYGNvHU0C17UC3GxamTWY35e3cO1Yxn/2zdT2rPyvhbdKRH+zcGKODpQDvvQdf36xcLjN+IXShXhdgCQWWziJ/D3A2XR5Q3ZiHWIjqzRdhu+XUTT9Ts64rwJ7iQzIsp1FEPrA/qfX/atk+Roud5800qAuvwGeNlqAAHZeTVLum3CLylmKNa5Cw9BIFUCJpDGjjhJAvB0PVdxyf+19VUfXPAi8g7RGy2ubojM2Nln2ySDZvVbAPqsDEIDPY0LA1EngtfbwuWXvdpBT8jRUdZieUrUSwFbLR/cVhzx3GpW9CbrAoqbiN9Cl/l947TipxJ6tZO7QWhu9nYc0Sd2IKrTKmGGkAhTfHXSavcHkiQbJnndLRqz1JFOpxWuL74siNkW3OkVSoSJDejwtOUyqeepPX61mo2RZCNlk2gDtXxEp2n39lSRy/w1UKABa9iPIBwcj+TREIfOmfS3m6PM3klc/VInwS6NRtJDEeLvABa1a+lnbUTFj2DxxLHpgz/wwY6u3ms/AiRneCHaObRYUcge2TIGZfxm3f6h4ykxb9iXiexCkh3O0HYDfBtH6Day7hzKr6WoPbrQ9fQLM5umnKW72KU34+ceMkJ3FhIYMWk/2D19jxTuLYkmPSw3tyKlOwj/oDRcipKIH2wg6+Z/9Qa4d86rO9DQY5i9K2RFxJ2TSml8 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: vdDH0hfjxLDwAdEKE4Js4VFYSyAgEmCTaUcK68/lPiPnWUmCojeaERigCGSGKSUDnu5Q2xsz1wc9oTm6LnkDNF12h4Ul5hcAxap4TDONfQBMKAjxgX9+QYTbiDFgKSZO3GhhaVPB74jWNnjsQNGeqtWEfvcN08ZgZaBI1/VgQW8ZV7kXOaRItNyvRjgaHSLkJXZAK2qIhKGAxmG4SGO01+Thp4EEzhLxLVl1Rrny3/DptOYOKgkO6ckiqkaqtEeau2Uar0uyBSCp2MRDpx73fx3zxt8OgRNwpuyfUTpeLk3uQrnXLzazBhsDumAl38simEJS6gZqHGJi8C7FuSOFWhfv2Ynb6wxlTiyZXam28iVNioJ6DtN0tDoP5ut/X9x6C+MMTUaRleQVcXKf1Y/4Svb48vazwj29xrWsAKiH0UhYSBxadEo37x5iw7xBB/Wj311Rt0LzblQExlOyIDv57p3+FgZaJP1p/4Bh74ndpmI5o8Bk4w+eNYrB/WPurv5PSRZebozS+F6dBhMw4YR104Ew3EYqyXAYVaHKF6VZcq1ilk02GuDtFghC16FwLAin8NVaqcXK/Eqxz3tO93CiCzV0vAfn08RHzonzbJ7c2jmIFCjex9318Jvw74qR7XQ8c6i6q1KdVx0zMyu2KT3lacZ4r03SiQ+TsC6deMlcytVfJD0zrNB/BcTX07Edfk5h3VBLpKaeapg7BHj7qlX+De64Tpp7ErkoZKQ/8noFyjoNDBbCzNQjvxZnZOg7xLax X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 818ef08d-300a-43e4-6501-08db73a4a7b1 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 04:45:22.9065 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vs4HyQCXI3iGAhER/ONulbZWK1fWv+SgMp2WbYJ7h1yaEU4wSwiLlepZWydkxmOk3aNaiA9B3jhSRMP5eVZ1KA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB5966 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-23_02,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306230041 X-Proofpoint-GUID: Gr67CqSGdxk3bvMMmaYRHMeKtD1ZXnUZ X-Proofpoint-ORIG-GUID: Gr67CqSGdxk3bvMMmaYRHMeKtD1ZXnUZ X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Binutils From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769467492249044446?= X-GMAIL-MSGID: =?utf-8?q?1769467492249044446?= Use a more appropriate data type. include/ * sframe-api.h (sframe_fre_get_base_reg_id): Use uint8_t as return type. libsframe/ * sframe-dump.c (dump_sframe_func_with_fres): Use uint8_t type for base reg id. * sframe.c (sframe_fre_get_base_reg_id): Use uin8_t as return type. --- include/sframe-api.h | 2 +- libsframe/sframe-dump.c | 2 +- libsframe/sframe.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/sframe-api.h b/include/sframe-api.h index e62a7a38285..46614925c68 100644 --- a/include/sframe-api.h +++ b/include/sframe-api.h @@ -173,7 +173,7 @@ extern void dump_sframe (sframe_decoder_ctx *decoder, uint64_t addr); /* Get the base reg id from the FRE info. Sets errp if fails. */ -extern unsigned int +extern uint8_t sframe_fre_get_base_reg_id (sframe_frame_row_entry *fre, int *errp); /* Get the CFA offset from the FRE. If the offset is invalid, sets errp. */ diff --git a/libsframe/sframe-dump.c b/libsframe/sframe-dump.c index 37ce9d70eb3..4799652f727 100644 --- a/libsframe/sframe-dump.c +++ b/libsframe/sframe-dump.c @@ -105,7 +105,7 @@ dump_sframe_func_with_fres (sframe_decoder_ctx *sfd_ctx, int32_t cfa_offset = 0; int32_t fp_offset = 0; int32_t ra_offset = 0; - unsigned int base_reg_id = 0; + uint8_t base_reg_id = 0; int err[3] = {0, 0, 0}; sframe_frame_row_entry fre; diff --git a/libsframe/sframe.c b/libsframe/sframe.c index 7bb8c647c19..170b2d830b8 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -618,7 +618,7 @@ sframe_calc_fre_type (size_t func_size) /* Get the base reg id from the FRE info. Set errp if failure. */ -unsigned int +uint8_t sframe_fre_get_base_reg_id (sframe_frame_row_entry *fre, int *errp) { if (fre == NULL) From patchwork Fri Jun 23 04:44:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 111918 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5529010vqr; Thu, 22 Jun 2023 21:50:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5d5tuioWszlEx7J0kCuz+oufe/JNEV1h18hPRS7MiquwbhYYSPezl3u5jcKOVZtKSLkDKE X-Received: by 2002:a17:907:d0b:b0:974:55ea:1ad8 with SMTP id gn11-20020a1709070d0b00b0097455ea1ad8mr21936907ejc.63.1687495849297; Thu, 22 Jun 2023 21:50:49 -0700 (PDT) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id a18-20020a1709064a5200b00982b1c24b2asi4185217ejv.337.2023.06.22.21.50.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 21:50:49 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=DlDAkLSz; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2794A3853D1B for ; Fri, 23 Jun 2023 04:47:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2794A3853D1B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1687495650; bh=j1I9zdc8XOvtqbNb1cA8GkiWfIcMwhCVx81vJg7tqDk=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=DlDAkLSzY824JKpbzmBFvToYhx5rQKZNbs5d9dgz6PTBlZObtx28j2wbRgUylV6nZ zc4/hB6DEpMSsrZkbLGtLw04eLGDwYuOAcBDcIBhmVPd79uPTPYiltYa365wLlCCQi 0ymrfgoyfL1qsiO+QzdogiB322NjVomNh3skC5FI= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 85DFB3857714 for ; Fri, 23 Jun 2023 04:45:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 85DFB3857714 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35N35krP020934 for ; Fri, 23 Jun 2023 04:45:28 GMT Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3r93e1k731-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:28 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 35N4AgmN032924 for ; Fri, 23 Jun 2023 04:45:27 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2049.outbound.protection.outlook.com [104.47.66.49]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3r9399ew23-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Jun 2023 04:45:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=coKQXmKLNvT+xN2l2SCKnEYBdY+mqhS1w5fms8FtBNuCOsmqGuN2vtz43iDHTvDbxMwsNCSsgnix+smlDZEd68r3xHL8HE3etFSCTLRE8DGmoe9Mc+iOcCTMX9ZdV4u98lI4QcCceYpASe9Zku3r/lH3Cq/Vk1PtKwGNxtqQG8jHIG9h+hx/JqEdxoLv9I6ePuDKYNLxM0eI8TwPnHZ/PHfx0AmzhKquddziBAPCvZ68/DFqF6W7C8M1oSJmxIPrLTlSosaMcAm8kYuUJl6tAh2khAxf/OMfMQ8pM5gO4FaRDM6bH0CBT/caQsx4lpmQZ8YLHA6I5Tb29kIHjDUvqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j1I9zdc8XOvtqbNb1cA8GkiWfIcMwhCVx81vJg7tqDk=; b=TdqC7h1G7lUwBw8XRcFXpbol0rv6OZbTaS7rdDkI7PokgXkkfRqm3HYlZmZaCHEuqcobj8lKkBkWVkzjSq1s0/XUv2iwwtN3g4CM4zXuUGpKAH+wCEcflfEGaVu0kIc80Dc+mjhDLjKDuDsqO/qxVBBIJ55uQd8KTcNawwqKfdEFLiFLc6Bj6ITD6WQNosUQh/X7ryqvlTniqKc7oYVv+F7lC9dMogFAS5YB/wMuiw/k5dloLJCMAEmLEaSuSNOHHRS3l9lHtnQwFjSF37g6W66LR/rYiulAKrAHIlxaxPoWS/5nwuoPIhbvcZzKhoC3JN0lwQzKGsIOhGcYq7vUmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by DM4PR10MB5966.namprd10.prod.outlook.com (2603:10b6:8:b2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Fri, 23 Jun 2023 04:45:26 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6521.026; Fri, 23 Jun 2023 04:45:25 +0000 To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH 10/10] binutils/NEWS: add note about upcoming libsframe changes Date: Thu, 22 Jun 2023 21:44:48 -0700 Message-Id: <20230623044448.2617101-11-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230623044448.2617101-1-indu.bhagat@oracle.com> References: <20230623044448.2617101-1-indu.bhagat@oracle.com> X-ClientProxiedBy: MW4PR04CA0233.namprd04.prod.outlook.com (2603:10b6:303:87::28) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|DM4PR10MB5966:EE_ X-MS-Office365-Filtering-Correlation-Id: c99e69fd-fac3-4192-e41e-08db73a4a97f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WVrfICrJLoeH7siWks6gvYhVy8kUgEAW18PhS0Qd0xhq7aAZDFUffSwqhca4LIEGemrZK0P9s7uQyqJilTqoRiFr+mtR6J1L7LJvxlFLy2yLNpY1TA80H+yBbJG/96MFeKpgxFrnI7KvgRdfishNFVFiefzVqPeqenSnCdby2g3RvaaN3W4dO+OoUsoZ5tTaYBvWYPrrQEP9C6lGUzQadZmqlwPmLnprcnQF9q9j8Q+i6pMcBSIf1M7eSBVGapFg83mp0p8B6kcPmDIXJECdTos1WM1o+i6Sgk87NhFXuKK2GHA0/kv1vjjUpFJLsEkN+c/OEAoouxl80HKfx944W0OT1GjsD5m08oN7bg2AgQfnirnMOO1kJUULyRbRS+sP+ePjjnPi0nfUBSRMgW/ehoB+TOe5Sr0RFHbjiDdGq8wDS7lYX57060g8sYQ1KyYuPoWv2f+SgNeK07+QzDIwDxpbPnrAOMRwzM3MjsjWP16+8Og/wDEozpFyQPYwfGMtr0ZoLXC2AV0sFmDBnxSTmEqqgRL90DZ20F0PjmNmxocoebJNa+xwiJmRVEaG4F+p X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(346002)(366004)(39860400002)(376002)(451199021)(4744005)(2906002)(478600001)(38100700002)(2616005)(36756003)(6666004)(5660300002)(6486002)(66946007)(66556008)(66476007)(83380400001)(316002)(6916009)(86362001)(41300700001)(44832011)(8936002)(8676002)(4326008)(6506007)(6512007)(1076003)(107886003)(186003)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: oNG5i/z+c0uXpQNJgcceUqttiqO7Vqu1C3Qgm4nwdoD8N7DnUcfgEAi2u+ffJoqh/reF2eDBivmqti3xqPdUjd5ieTEMClqffJVorLHi77uLbAhP+N4u2yLwngow3RypQmPyXV1fJK3CQVy+57yr9YEqpb0xt4StYVBQlaBb1mcObTBoBViW8+IoJ4fKr3cjdPSVn9YZ674dLWGrRvzXNyt8bg5nrWnpWgETloAlRYrkZ0fbTX3J9QoxXgp9cuP89q4sW+qlrXR50qjQSRnxdtOlDR7gMhJn7kl4sqL+K9sJEovbOiTKRXOBB8vCkbPZh3/qZraTw3E11QW7XT7dLYdvT48cCtD5rkMiTmwCKinhoD3KC50SFXB1g6HoE6J6OGAxATqYhSM7oMNU6H5+GMvBfc5xXpAljwC/g2uHe0WOYQuZY3giIRnuXuEyWeydZadkeEgapF/1wcycGLlS6vytiGMoZKVafzWKKSQZOefuBQBWr4nLIk+4kQuCUMpOnX3ko62JfRTPbDQgSoO5xuvs/djp+dDUd9nJIA8AOYneoyc/zC89J+GZlk63uYDPvtpHVafosV560Lscg7AYsP6dEvBwUGV+iC5JEnSwour9sGNuHvEjdLB/zjHbL1PKooUpKnrQYH400Vh51+0TfVIbHMuHZRPMK6a/RGg1d7c8k2GWf2HOqh/NfHHZZdJWl4yS6niTXg2EmCcJQShaN9V6OzKHyDBPlqbkVO39wcBp4tw/xCwVwibiiYoAEimq8fnM7OqO4tqrRTTVjvjrVS6PFoU+HlQ4AtxRobzVY0Ft3+PP54V7lbPGf0Sh8a4cokg/9t7ndwPWHpmWtc48oPiZ+xUQeLZk5XEybqwwsggmh7WS4PBH+Yfd7bS+qfk/ZAThdJvcnA0lWpqfGsEJBa74pysA8PF86GZDSkK0LowmFyuTRm5ebaYo4l3OYxT/fT7at5dcjmENGpmQ/vbusTz8bp7SOX5Y5FnDGMAZ/fyMZrOf0H8lGKv+NyUQBnreV0HAuANJV0g18Q8vMBmxgIM1keEXecsWyz8O0V2ZfJNizYwkkB0yUCcqGKccFy3+4RUqYPe7NACfrLQGbT5NSgIlyqWckTKqzoL4qFZH7j9zEb3zjXSHZ9EH4QlZDHZPJawkzoD0EULkUQAe4umjsSqGq9igPi15JPwzZhgc9FsxUeoGxgljHn+OI4JjLQDXMvK6gpc0yTb7KZ8IoX8FTKJviJ/DobteeQRub79NbZ8AKdy2w2wwAWM3xjaKy4M09bNvG2szOghr+45O0Tu+4219eTr1jXtR5exzcOQyaD3TjMkmILMItrv+9Rm6bOgUr10QI1aMywI9ZG0GUScvsfPv0rtHGpQZZoodZws0kMV4yvD4NJt3Anu1ndf935D5NLGGqq8lkw4e1jX7UfIou/4kxTQ0q4v5HItxT/rfJmcB/z8RS9Yfu9A5/nYnBfBIZSS/qS8HBqMrvgwOKEtE40VSwJCtcMVMJGHMoijhrMBWRJqVkYRDzDbRiPI8zFBqyO9X0YFJ4qZbYGy7qGpQTWYZpESFnb8QmPb8DVP+nAbprE/dJW7EouJLRvRAeZcH X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 5cWEkx3PS2b8TLl9nCqST3/Bi2e/X8ZsqhhObrnaKpP53ztoAOERKmweco3SOixyl5MOuUnoI8S8NOdZoRmizcDK11RMdE2OE1g/O1ON1qcXc2zm4nIu/y1Sbuf0RQgJLLYVb3i63kzRYWEScOeuQaIpzU44sKVujGO8r/0hEI0w/9BNiBFo/sq+BCkV2PteO6m0Vq5od+06UpREL85glGaxqFyaY8m0tuxSsOMfPH1R438o4oJnVqHMH2WKt100F2m/Sw/eA8lAey9FK9o0n+aMRmHpvP8E1S5Kj2OP7cu5yGmq5HHoymQCW2ZPTkQhMJ4MToS1v1o6ahLrUSH2+0vSVj+cK5kOuroTfP4FgnnezK+U8CbFSxzo30Jbd1LBk/RXe4ONBRJyem0j0hWxOQb81X1M61fwwSnsx9waTSvY5NaCrdrRIHbPG/safjZNmZnwL+C02Ba1LPH7evWj43cqBxC/QSU/J6Zxp7OZzMhZYgvKHUiYp+BUXQJK3mpx7f4sigQf2abVfdIXCo123M5IWj2EFcUeXqVSDMU/TOljjlgQvZlN+k5/4EtUxMNPFCE/JvXH3f2zGJVI9/rL8Zk99w2oPqbe0PtpGSverOW9lM8ywDONmBj2O6NfDX6oS3zn9k9OXIm9Fu5cbfr633bXIhAop9qx8HBs/SRbLHcylDqOsZUhAtA+GQ0RHGGn+4wMstAcBPtvfOIwsvQFegrTTR6t0ZMGt8KOrro3dSNn1FILTLhb3l/Qg9mYS6hQ X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c99e69fd-fac3-4192-e41e-08db73a4a97f X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 04:45:25.9273 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q6NFiiOnJWFA1hNK3wxZayVRjCXpWPw848HBXdk3WPJFsynk2To7ozJcCAlmvuLQpHxQ6o9qE5G95BlCvF4Wjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB5966 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-23_02,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=758 phishscore=0 bulkscore=0 suspectscore=0 mlxscore=0 spamscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306230041 X-Proofpoint-GUID: ArT-BYefl1kG__K-BbAg43vZj33TTt8A X-Proofpoint-ORIG-GUID: ArT-BYefl1kG__K-BbAg43vZj33TTt8A X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Binutils From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769467647336942867?= X-GMAIL-MSGID: =?utf-8?q?1769467647336942867?= Some of these changes update the ABI in an incompatible way. --- binutils/NEWS | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/binutils/NEWS b/binutils/NEWS index 8e1b1ee63e9..00ef7c43610 100644 --- a/binutils/NEWS +++ b/binutils/NEWS @@ -7,6 +7,12 @@ * Objdump's --private option can now be used on PE format files to display the fields in the file header and section headers. + +* New versioned release of libsframe: libsframe.so.1. This release introduces + versioned symbols with version node name LIBSFRAME_1.0. This release also + updates the ABI in an incompatible way: this includes removal of + sframe_get_funcdesc_with_addr API, change in the behavior of + sframe_fre_get_ra_offset and sframe_fre_get_fp_offset APIs. Changes in 2.40: