From patchwork Thu Jun 22 12:37:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giulio Benetti X-Patchwork-Id: 111660 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5061393vqr; Thu, 22 Jun 2023 06:17:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ43qFI9EUTjbKd3rjdjzRofgWHjfyI+KygIOfQV+lo3J4Vv7lU6YiZct3RMENG/1zx4USbU X-Received: by 2002:a17:902:ea8a:b0:1b2:5ade:9ebb with SMTP id x10-20020a170902ea8a00b001b25ade9ebbmr11906510plb.2.1687439829923; Thu, 22 Jun 2023 06:17:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687439829; cv=none; d=google.com; s=arc-20160816; b=t20QuFO7/Frvvxx719kekm8Ei+p+e0sZkoihgbfz2kpAkIFayzT0p2iQ1LjEhuHi6B o8J9yb0gDtt1qcnq5gE3b6MzvLLqsZ4V8YKMiLS5SNxV0pEoMOMZRAgunVwmS9gvgIRe V1kCn7z3Eq6aV5dn+0zS8o805RAOsakhOr2TQiGtZcMtlt/qBYNmZvo40zac+Mm9MSBg ukIdHBQdLcZw+E/xdWIrfnoFi5UIB28kIsgIPyn3iG1ZeVvht1os0cI8UWKt8rBagF13 N4p0sXY8vyAkj3Tr6X/YpY2OV3LLG2pAHDiAAJ8QBVoGSz/S+ebm6OdLIRvFwLSJLtEg MwYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ultaEadOhUEc02QWUIGC5Xmq0QHyYFtK++iRB0qq28Y=; b=bL6cyg0NoZcAL1f69ymji8ut7DE30HHqs7FL4R05+PdfR1mNqQw+w+oN2h2Nq5xtjY 4TEVXy+DcCKTixNonV02mAUBygyNJeg7qLV2tNGnfgVfgIeiEa5mEH7q7JLdAXDWyhbU 25To4DHC3oIHyMgwfAuJDiYwO0RLGNmLc6Nu0lGKtmpZ+HOs6azYrfFlAbPJKZc8kkLG b2xwOZWH6uFJNic/aBW64Cimucr/+XXhuuA+t3fABcvGx7uNb4CB+hsqE8kelzYCxmz+ 0Smwwb8FOz/ViPt218aYCnFSfMdwF9kp0VgVYrJJQRi01ISz24a9LvAwApGrolozCpBB HqhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@aruba.it header.s=a1 header.b=eNW2RDBr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q17-20020a170902f79100b001a8096ef2bfsi2313557pln.34.2023.06.22.06.16.56; Thu, 22 Jun 2023 06:17:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@aruba.it header.s=a1 header.b=eNW2RDBr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229990AbjFVMis (ORCPT + 99 others); Thu, 22 Jun 2023 08:38:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230305AbjFVMiq (ORCPT ); Thu, 22 Jun 2023 08:38:46 -0400 X-Greylist: delayed 60 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 22 Jun 2023 05:38:44 PDT Received: from smtpdh20-1.aruba.it (smtpdh20-1.aruba.it [62.149.155.164]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88C8210C1 for ; Thu, 22 Jun 2023 05:38:44 -0700 (PDT) Received: from localhost.localdomain ([151.79.164.54]) by Aruba Outgoing Smtp with ESMTPSA id CJZEqf8KC1xz6CJZEqE7my; Thu, 22 Jun 2023 14:37:42 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1687437462; bh=g03OJMjrBbsiPap55M8C8/eh3feEmOWxGVwXp3EGFpY=; h=From:To:Subject:Date:MIME-Version; b=eNW2RDBrrahovjFeZYjyVuvgwITFcUflLImIHBwPRNH9Upd1xJu5xag4yMSbQ829i WJyFarH57K33ffFtTxfWtKM+2+kbHF80bwpkm5qCLSzYHQSxiB5bHkrd89X4sInQGH JVTqE1ldzEuaMJHYXEtL5CYqbNfVQ7oJw29ibNza8id1sqgudEY4pAFS6VueATpOya 84cBolwYe4KjcdyW7tlzvHFVls31tFfn+g8dyGw3gN4crIpV0v1zMCmpQHHxlCMSeD 0tQHyTH9kQW5aTMkmf1FNwhve2NB45L+DzH0rl7mQ+7THBwC87/psqaZ/UoxbbGeoC IhsLzFppiKoNA== From: Giulio Benetti To: Florian Fainelli Cc: Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Giulio Benetti Subject: [PATCH] net: phy: broadcom: drop brcm_phy_setbits() and use phy_set_bits() instead Date: Thu, 22 Jun 2023 14:37:37 +0200 Message-Id: <20230622123737.8649-1-giulio.benetti@benettiengineering.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CMAE-Envelope: MS4xfHJyd/ZEh28BATS8DEkFR2WqXze3wFY5EaNI9gpZ4M9ewFj4saI/IPlanEGmVHTBGnqhO9SLMg0TvAzgIQ1Pf2nsrjngHOJXlr3LVID+EEgwyss0ApMi QzwxBMw7JexINdQp6yqOLGLh1f4MrMLEsMuL1dTQPicgScYCZsOd+01Ncma+tdvkjvab2lSdLNMS31/nsW6c1AYgZLR/u9DsE592KZ5bdYurNIByQUy14J2k Fi/NbH/YAu0Cl61EJvHNsy7+C7zboB38KW7JuDHGl2LQP0s+4ZcZEL/EAR7taZ654Mtpgn6TfuxY6twCjkBIoLHnoRhPEdm1GfIcsZyECMqI06NTBVJ9/ZI3 jqREXWN8zBxD5CJdbufGIf9zC4bdxxPJZ3XwRe/KBTc12kPhSVKUsWovzWJ/j9AJSSter4tt3UG7EJezXG3TWHSwl9VB5gYCwdr1LjeiqnyHUIOTyTjozSuk OqhrNCaPSbIasDz8iUs+u4EfcVOYLp6awLV7wye4d9vOckgbJlZWXTHzQOZrcH6jH3pIm/BExN8A4gbeg8IX2MP7kCcgeueJyHZsTKMdJK26avUNx1dbyeos t7PTdiCUDoQXjimyxd2fGxt2 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769408043990109293?= X-GMAIL-MSGID: =?utf-8?q?1769408906755043412?= Linux provides phy_set_bits() helper so let's drop brcm_phy_setbits() and use phy_set_bits() in its place. Signed-off-by: Giulio Benetti --- drivers/net/phy/broadcom.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c index ad71c88c87e7..d684c5be529a 100644 --- a/drivers/net/phy/broadcom.c +++ b/drivers/net/phy/broadcom.c @@ -608,17 +608,6 @@ static int bcm54616s_read_status(struct phy_device *phydev) return err; } -static int brcm_phy_setbits(struct phy_device *phydev, int reg, int set) -{ - int val; - - val = phy_read(phydev, reg); - if (val < 0) - return val; - - return phy_write(phydev, reg, val | set); -} - static int brcm_fet_config_init(struct phy_device *phydev) { int reg, err, err2, brcmtest; @@ -689,14 +678,14 @@ static int brcm_fet_config_init(struct phy_device *phydev) goto done; /* Enable auto MDIX */ - err = brcm_phy_setbits(phydev, MII_BRCM_FET_SHDW_MISCCTRL, + err = phy_set_bits(phydev, MII_BRCM_FET_SHDW_MISCCTRL, MII_BRCM_FET_SHDW_MC_FAME); if (err < 0) goto done; if (phydev->dev_flags & PHY_BRCM_AUTO_PWRDWN_ENABLE) { /* Enable auto power down */ - err = brcm_phy_setbits(phydev, MII_BRCM_FET_SHDW_AUXSTAT2, + err = phy_set_bits(phydev, MII_BRCM_FET_SHDW_AUXSTAT2, MII_BRCM_FET_SHDW_AS2_APDE); }