From patchwork Thu Jun 22 07:51:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 111480 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp4901998vqr; Thu, 22 Jun 2023 01:09:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Bb87pyYNd/jAVaGUHQIfuCCMhlYrC4DmcjFCd+WEYNc99ywKlOagzS7DI2UYHtB3eO/kG X-Received: by 2002:a17:902:e848:b0:1b5:49fc:e336 with SMTP id t8-20020a170902e84800b001b549fce336mr10757620plg.42.1687421340080; Thu, 22 Jun 2023 01:09:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687421340; cv=none; d=google.com; s=arc-20160816; b=KoBwdgHpYiDHhkzdiJf3cXuyP3GKOLC4WrKsLjCm3JcWQOs/9agrsHn+Vvx+3QCn1I 1AynIVYEj3iVADeqNQQgoWiMjcqqEa3/qvLrm+fxRfQNvRkMck4qy/7DIObbDEIlBBeI LB8VjHOKByfr4VqPE+NKusEo+QmyT62aNfMFONGHS2j5q2hI19aVAWQ+zA0qbDidWKji V0tpLOmnbuaL3ATpIDG8yj4ScUBadEY2L/XrktacYMDCyWvHAVfCjYWJg2y4naWD2xrA 4vY6lGf8/tY8pc+5JBpS06X24yrBOWDj+CXNlvxCZuDX03hIziTYzPOlTw9m82Hhe/Xq P0dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=sNhh/FwCc/lCNYCHw8CtkNpEVnx/1RmSCV5RoIhW2Sg=; b=HWOxsXaCH5KNd697NKvQBHsE2TJVN5o27JTo7Ox0A/pvLo4NZXkQSStlcSp7pER7I7 9/gW6BDn/IlsLtFedOWifZhOTTihBr4qcrnmSFQXM5G4PHpPtJIHvSfdPv9LQWi2YRaR jsk1yWOYVitMs+t4Qv5N+kIJ2MCduDhSc5bfMDUGjewiTjKHIBdFuMtb25Pabxul1UE3 Tg04Fgt77xhD9I+MkdD4rDeehZpNIhfRcw4MKonb8pYo0BrgMow0RTaLZTaQ0NVKz13s WQGKndyfQN74W75Sqs4DuHOd7NORMAgFU0SViJCO4Ywg5FHJoDXHKro9cLDsYxt2cobG b2Lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kqihgs3p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a7-20020a170902ecc700b001b3af7e375fsi6368111plh.559.2023.06.22.01.08.41; Thu, 22 Jun 2023 01:09:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kqihgs3p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230262AbjFVHwj (ORCPT + 99 others); Thu, 22 Jun 2023 03:52:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230272AbjFVHwg (ORCPT ); Thu, 22 Jun 2023 03:52:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 102C1210E; Thu, 22 Jun 2023 00:52:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3C1EC61787; Thu, 22 Jun 2023 07:52:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96C66C433C0; Thu, 22 Jun 2023 07:52:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687420343; bh=e9NKgW3oClf65wHR4jFOmp3+UsGr7YxDei5mvCWN0/Q=; h=From:To:Cc:Subject:Date:From; b=kqihgs3ppcJWf2G4dcgyCAVIslHMHejpAq+er43v44mJ58HvXOd/87MuZrMNRSIaJ dzZkx9G3J2fMFjvm6JKXjxzR9VSlh894TP6vVMrS0iuxJ6FgejbN1tAOzPbceGORyM TQXU33JRziUcUIooDdCkQcCvRRPqpqAIljhsgY0Fmxtaw6qEZk8dMBtIdAHQWsABfL Sg1DaKrhV17anw+wcLRzrwC3GIfqaA1+OWXRCQQug5TSP5UDryUi9+1/pSgyTRQ6NI Gj4/oyqpS+xezpgHVtaa0SiydAky/D/Q0mRHfSOU0EFH+RR9hSQ1kZ+YB1TrZEITss 1A67IYbfo2hDA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1qCF7F-0000Ev-07; Thu, 22 Jun 2023 09:52:29 +0200 From: Johan Hovold To: Sean Wang , Vinod Koul Cc: Matthias Brugger , AngeloGioacchino Del Regno , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH] dmaengine: mediatek: drop bogus pm_runtime_set_active() Date: Thu, 22 Jun 2023 09:51:50 +0200 Message-Id: <20230622075150.885-1-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769389518725259506?= X-GMAIL-MSGID: =?utf-8?q?1769389518725259506?= The runtime PM state must be updated while runtime PM is disabled for the change to take effect. Drop the bogus pm_runtime_set_active() which left the PM state set to suspended (as it should be or the clock would not be enabled when the device is resumed). Signed-off-by: Johan Hovold --- drivers/dma/mediatek/mtk-uart-apdma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/mediatek/mtk-uart-apdma.c b/drivers/dma/mediatek/mtk-uart-apdma.c index a1517ef1f4a0..92864c9371a3 100644 --- a/drivers/dma/mediatek/mtk-uart-apdma.c +++ b/drivers/dma/mediatek/mtk-uart-apdma.c @@ -551,7 +551,6 @@ static int mtk_uart_apdma_probe(struct platform_device *pdev) } pm_runtime_enable(&pdev->dev); - pm_runtime_set_active(&pdev->dev); rc = dma_async_device_register(&mtkd->ddev); if (rc)