From patchwork Wed Jun 21 14:00:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 111051 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp4410886vqr; Wed, 21 Jun 2023 07:34:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7jROVVeH4xfpp0CaUudYmV1iyHWfOA1cro/brnCj1r+0GieLnFWPUHCxCHtsdKNE6SP1DA X-Received: by 2002:a05:6a20:d90b:b0:10f:9bea:5a61 with SMTP id jd11-20020a056a20d90b00b0010f9bea5a61mr17592852pzb.2.1687358087971; Wed, 21 Jun 2023 07:34:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687358087; cv=none; d=google.com; s=arc-20160816; b=b9EemijqwakXcizgEv+v9cnoAiqE21yXRwSTTwtR4SMLmgCQzxx1MVQBBOzjZK/pKB 87A095iwae6DEFyytcnmHyjrhiV1MSbaaabdwL9EUPaUtslIKMe5mMG3ZHhFFZx9x0AR GZFOalb8c8Vglju0HLLjlDZ7QlEt6oozPc8b2stPm/yVXNwKPu+M3hBI4nWinG5ShNSq 2Jsrqop1UFc6DHkaH4+Qfi3fCuZVb9DuslLFHHmZlp+1n40miP+dfZf7yqdEWdjT4aGX 5pWooTAMN1JqDK58V5Tb689U1z9XRf655UY/3n8VMBLKMB+2UKr9RXgCTYp6aLr67EyZ JBPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=e0TQPSS7a9Jk8gsZ9aLEqJ9x+mgzVCzVi1FpIGNdrBw=; b=wOJGtdHoDRJm0lQPTXyeoks/K/nwN737IPzH8FQab+ZKUio5+ucE9oS9Rd9cIBUkag FORhuTWZaPXPDEAkp1TfD2LfTE5MM3sv+5/KFUHgX0dFYT3zLLfoPDcc4NNW7LBr9z4b Kpu0WchhN61mhrSAYuiS8BXV49SjeGgZdO+UIk6t3he5LTUPcLUITDjqq5HRNGRsMwbT 2fED/7vYJV4TZgMmNik+12O5hWRRCBmzXORNyeMqMnxFP7PH4aBZCYARY1+ODKJ0F5I2 rZxTC8r8K1QOjcdyRv/jF/1YGyL5yyToOChlrdidTTfoPW6owedO8e7oAZWxm2cp+u5S UB9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=ZY+A+AK+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d4-20020a633604000000b0054fe7642adesi4040840pga.790.2023.06.21.07.34.11; Wed, 21 Jun 2023 07:34:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=ZY+A+AK+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232602AbjFUOBa (ORCPT + 99 others); Wed, 21 Jun 2023 10:01:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232476AbjFUOBD (ORCPT ); Wed, 21 Jun 2023 10:01:03 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B38561BF1; Wed, 21 Jun 2023 07:00:58 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3f8fe9dc27aso45838415e9.3; Wed, 21 Jun 2023 07:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687356057; x=1689948057; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=e0TQPSS7a9Jk8gsZ9aLEqJ9x+mgzVCzVi1FpIGNdrBw=; b=ZY+A+AK+0hrEqCQD5smhWHxGBgM513DkVqUqEYh8CTkbDkfBqlijxtada3pe1oO6RU qAnRJTWbOw7A82AmMVkjSnGgvX4adfXs8QGiXJrf6X7elEipSkUouVQM6KxJnfJaRw+8 vdbu4y6FXWx7It3diymV26tO8gGqKRoKSSoMTKckwFi82e0p3wvuaMs8aGQchu5XJApv QkZrVCkbKpxYOjOFUwzBkcJUPPHlM8kE7qx8DZKyA5a6EVkt5cdvnNqjMdW4F9A2c0YB cR94RYWH0IbE/c70GB4u4tsRVhXZX3L3HbV4cX8rncCg6FMQcXkp4KO/kfrnykD+lcBw f4pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687356057; x=1689948057; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e0TQPSS7a9Jk8gsZ9aLEqJ9x+mgzVCzVi1FpIGNdrBw=; b=EMLmnNOykIzH40j0JFdOmpmPlrnVyMp1JddyM1zX0xCXrJ/A+T84PO+OnDPkD3Svpk n/u2C/2ARy95f2AGPm5A9bvRqGVG0MjFfMRYPb5yN+oafB/0IJzLTm8IfHaRgXzhjL7t 6lMrf5++Jn1SzPAyd/YZ6kIWbxt/yMgIIVDvVMoBfFcJqjEsHm1pYhI9HfCoI5qFfTdJ U1dHqir0jK5G7fRAtO/gfeJcaHBdObiIi/QruGAN6imk+rcvXH34lUwxGYbAqo+Xwzr7 5lFESThKITTGHpXXQCFsoUBqci85KUqHW2fCumR/yhzEMcC0LNEVDp2jZalDkGZHzdxm Gdnw== X-Gm-Message-State: AC+VfDyg2vKw1f1UVE+EVRc7VK7ZLI2FfLqv67IMjuhtVwQ1cJYLrsJA v6JqjSml5dIfAJFIX1oDOA95RrTb8tS4ZQ== X-Received: by 2002:a05:600c:2158:b0:3f9:aaa:37e7 with SMTP id v24-20020a05600c215800b003f90aaa37e7mr7285270wml.0.1687356056879; Wed, 21 Jun 2023 07:00:56 -0700 (PDT) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id u15-20020a05600c210f00b003f18b942338sm5118938wml.3.2023.06.21.07.00.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jun 2023 07:00:56 -0700 (PDT) From: Colin Ian King To: Mikulas Patocka Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] hpfs: remove redundant variable r Date: Wed, 21 Jun 2023 15:00:55 +0100 Message-Id: <20230621140055.2679143-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769323194466006435?= X-GMAIL-MSGID: =?utf-8?q?1769323194466006435?= Variable r is being assigned a value that is not being read, the assignment and the variable are redundant and can be removed. It is also useful to remove r as it's a confusing shadow of another variable r declared in a higher scope. Cleans up clang scan build warning: fs/hpfs/namei.c:560:8: warning: Although the value stored to 'r' is used in the enclosing expression, the value is never actually read from 'r' [deadcode.DeadStores] Signed-off-by: Colin Ian King --- fs/hpfs/namei.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/hpfs/namei.c b/fs/hpfs/namei.c index 69fb40b2c99a..d892a6f74431 100644 --- a/fs/hpfs/namei.c +++ b/fs/hpfs/namei.c @@ -556,8 +556,7 @@ static int hpfs_rename(struct mnt_idmap *idmap, struct inode *old_dir, de.hidden = new_name[0] == '.'; if (new_inode) { - int r; - if ((r = hpfs_remove_dirent(old_dir, dno, dep, &qbh, 1)) != 2) { + if (hpfs_remove_dirent(old_dir, dno, dep, &qbh, 1) != 2) { if ((nde = map_dirent(new_dir, hpfs_i(new_dir)->i_dno, new_name, new_len, NULL, &qbh1))) { clear_nlink(new_inode); copy_de(nde, &de);