From patchwork Tue Jun 20 15:55:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Jihong X-Patchwork-Id: 110602 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3788713vqr; Tue, 20 Jun 2023 09:29:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5jIoAJHR17aOm9CEJ01Qa0B6bjLrbuhwptQdrR8FR6tC8beSU9pZHfmuXEs8R8em7ue85e X-Received: by 2002:a17:903:22c4:b0:1b2:1d98:2511 with SMTP id y4-20020a17090322c400b001b21d982511mr8902842plg.50.1687278555236; Tue, 20 Jun 2023 09:29:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687278555; cv=none; d=google.com; s=arc-20160816; b=IPgpuKyZpR6dOZfsOszkxb4BbBzPxit1bgoabuA5OZkD6K3UliDz2rL5zZcr9PC98w 0jLqQJcmRiOeBZ16h98WYQMma2M1MkDc/fXVRg4U1EObHYMP9Ae/mFQDv1pXQROuDEHj UsilXMacBCaYHeAdbuobmxVjyP9okYLueKyXl2hVA8fcSJcdq5omWDyNgUOH6zsEL6ME AQD9zL37oCpXDfEcEyngGfFYxzxNjsaLkddiqgOehi7U+cqvMDXcphGGpzLn5RlwaUaE ooQcM+qnZB/zJKbfKQ9MflJMLkOqkLGTxrl8/cBIpy21gWxdtZoLdyj4PubrNy7Mm1/0 Ye+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=i8Y07Lgw9S5l94RnvEzd1Bc9ZnXIvHcIlmgDwT/9m3o=; b=Y6n4NvEHtwYojJM1fEF0y6vqpTZNpNEsABlDarGejS7Xc8aqor580WpQNM/FeD+XzV MbM3LxVAyxUkUA9h6hYeyVQLhGQzUGtObQtB7Y962jzgKN/q5uu5PsVBjmMZzZb4r8ij vm9QtPQx7gHgkQNKIJM6r3Qtw2vthkuIP0Kc85x/B1baVcKZ8bOcBj3nyJdyRRXHcK2z JOCc+HuT5f7lmdIWlU80Q0ZRja+ULqPfXFycIV5qQtDWoWmdX0dwP2t+wYh3PDHYccMq Bg7fZKhQAVZMWOJCSx4e7Jnooj9bI/63K+5IR5lfnWuEs0LfiSpfMYSuQU+TyURZi9/u yZVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q4-20020a170902dac400b001b043fb4083si2509336plx.16.2023.06.20.09.28.59; Tue, 20 Jun 2023 09:29:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232873AbjFTP5N (ORCPT + 99 others); Tue, 20 Jun 2023 11:57:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231945AbjFTP5K (ORCPT ); Tue, 20 Jun 2023 11:57:10 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40E54B6; Tue, 20 Jun 2023 08:57:08 -0700 (PDT) Received: from kwepemm600003.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QlrqH4vKLz1FDds; Tue, 20 Jun 2023 23:56:59 +0800 (CST) Received: from localhost.localdomain (10.67.174.95) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 20 Jun 2023 23:57:05 +0800 From: Yang Jihong To: , , , , , , , , , , CC: Subject: [PATCH 1/2] perf/core: perf_iterate_sb_cpu() supports to receive side-band events for all oneline cpus Date: Tue, 20 Jun 2023 15:55:14 +0000 Message-ID: <20230620155515.101222-2-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT In-Reply-To: <20230620155515.101222-1-yangjihong1@huawei.com> References: <20230620155515.101222-1-yangjihong1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.174.95] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769239798704808406?= X-GMAIL-MSGID: =?utf-8?q?1769239798704808406?= Add a bool parameter `system_wide` to perf_iterate_sb_cpu() to output side-band events to events on all online cpus. No functional change. Signed-off-by: Yang Jihong --- kernel/events/core.c | 58 +++++++++++++++++++++++++++++++------------- 1 file changed, 41 insertions(+), 17 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index db016e418931..66dbca1ba577 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -7886,9 +7886,9 @@ perf_iterate_ctx(struct perf_event_context *ctx, } } -static void perf_iterate_sb_cpu(perf_iterate_f output, void *data) +static void perf_iterate_sb_pel(perf_iterate_f output, void *data, + struct pmu_event_list *pel, bool system_wide) { - struct pmu_event_list *pel = this_cpu_ptr(&pmu_sb_events); struct perf_event *event; list_for_each_entry_rcu(event, &pel->list, sb_list) { @@ -7902,12 +7902,30 @@ static void perf_iterate_sb_cpu(perf_iterate_f output, void *data) if (event->state < PERF_EVENT_STATE_INACTIVE) continue; - if (!event_filter_match(event)) + if (!system_wide && !event_filter_match(event)) continue; output(event, data); } } +static void perf_iterate_sb_cpu(perf_iterate_f output, void *data, + bool system_wide) +{ + unsigned int i; + + if (system_wide) { + for_each_online_cpu(i) { + perf_iterate_sb_pel(output, data, + per_cpu_ptr(&pmu_sb_events, i), + system_wide); + } + } else { + perf_iterate_sb_pel(output, data, + this_cpu_ptr(&pmu_sb_events), + system_wide); + } +} + /* * Iterate all events that need to receive side-band events. * @@ -7916,7 +7934,8 @@ static void perf_iterate_sb_cpu(perf_iterate_f output, void *data) */ static void perf_iterate_sb(perf_iterate_f output, void *data, - struct perf_event_context *task_ctx) + struct perf_event_context *task_ctx, + bool system_wide) { struct perf_event_context *ctx; @@ -7933,7 +7952,7 @@ perf_iterate_sb(perf_iterate_f output, void *data, goto done; } - perf_iterate_sb_cpu(output, data); + perf_iterate_sb_cpu(output, data, system_wide); ctx = rcu_dereference(current->perf_event_ctxp); if (ctx) @@ -8174,8 +8193,9 @@ static void perf_event_task(struct task_struct *task, }; perf_iterate_sb(perf_event_task_output, - &task_event, - task_ctx); + &task_event, + task_ctx, + false); } void perf_event_fork(struct task_struct *task) @@ -8254,8 +8274,9 @@ static void perf_event_comm_event(struct perf_comm_event *comm_event) comm_event->event_id.header.size = sizeof(comm_event->event_id) + size; perf_iterate_sb(perf_event_comm_output, - comm_event, - NULL); + comm_event, + NULL, + false); } void perf_event_comm(struct task_struct *task, bool exec) @@ -8410,7 +8431,8 @@ void perf_event_namespaces(struct task_struct *task) perf_iterate_sb(perf_event_namespaces_output, &namespaces_event, - NULL); + NULL, + false); } /* @@ -8505,7 +8527,8 @@ static void perf_event_cgroup(struct cgroup *cgrp) perf_iterate_sb(perf_event_cgroup_output, &cgroup_event, - NULL); + NULL, + false); kfree(pathname); } @@ -8730,8 +8753,9 @@ static void perf_event_mmap_event(struct perf_mmap_event *mmap_event) build_id_parse(vma, mmap_event->build_id, &mmap_event->build_id_size); perf_iterate_sb(perf_event_mmap_output, - mmap_event, - NULL); + mmap_event, + NULL, + false); kfree(buf); } @@ -9020,7 +9044,7 @@ static void perf_event_switch(struct task_struct *task, PERF_RECORD_MISC_SWITCH_OUT_PREEMPT; } - perf_iterate_sb(perf_event_switch_output, &switch_event, NULL); + perf_iterate_sb(perf_event_switch_output, &switch_event, NULL, false); } /* @@ -9149,7 +9173,7 @@ void perf_event_ksymbol(u16 ksym_type, u64 addr, u32 len, bool unregister, }, }; - perf_iterate_sb(perf_event_ksymbol_output, &ksymbol_event, NULL); + perf_iterate_sb(perf_event_ksymbol_output, &ksymbol_event, NULL, false); return; err: WARN_ONCE(1, "%s: Invalid KSYMBOL type 0x%x\n", __func__, ksym_type); @@ -9261,7 +9285,7 @@ void perf_event_bpf_event(struct bpf_prog *prog, BUILD_BUG_ON(BPF_TAG_SIZE % sizeof(u64)); memcpy(bpf_event.event_id.tag, prog->tag, BPF_TAG_SIZE); - perf_iterate_sb(perf_event_bpf_output, &bpf_event, NULL); + perf_iterate_sb(perf_event_bpf_output, &bpf_event, NULL, false); } struct perf_text_poke_event { @@ -9345,7 +9369,7 @@ void perf_event_text_poke(const void *addr, const void *old_bytes, }, }; - perf_iterate_sb(perf_event_text_poke_output, &text_poke_event, NULL); + perf_iterate_sb(perf_event_text_poke_output, &text_poke_event, NULL, false); } void perf_event_itrace_started(struct perf_event *event) From patchwork Tue Jun 20 15:55:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Jihong X-Patchwork-Id: 110600 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3786532vqr; Tue, 20 Jun 2023 09:25:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4kFxIaXlTArJSYF/3xjHow0fZdHEl/sT9mEVc9qk71SOQVK5iWvaGq5voqi6RRXijXEQ6r X-Received: by 2002:a17:90a:ab0d:b0:25e:bd1d:4f0c with SMTP id m13-20020a17090aab0d00b0025ebd1d4f0cmr11157553pjq.10.1687278331318; Tue, 20 Jun 2023 09:25:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687278331; cv=none; d=google.com; s=arc-20160816; b=tPYcv4LC2gOwe/5UzkJgmHrEupPtF6C9+2xLdW870kgOaRzd/1h/q9uj9YKSEsh2I7 2NRHo63tqCaLYq0XWwkOTg1ZY4X1+LJAKLCg+C1MCDyq7J523H8FIVtf26rgzzWO4VR6 BVhrN47zj8AHeeQQtme4LtdUdnUd0hNzXqDpPAxlaGN3b7ETiI1/QrEHl6P8+Eo8QECv Lz+MiojC1Dxtm036nQLWP8BzF8Gi4U43xiDyPYGNZfLnwvoTurwlJG++GtEQ3LLggNuC jUWgUAN+Cc+ifjvaLzjeNNz4lf7zsca1p6xle8LagMlttzbHtOLV6LR1i4QLnb4ZnFoz 2dNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=lnCsoCnCh39b0s6m/fUfMAc2IwZb70n89X4sVjn81Co=; b=Achs83B0bCO+Ywu0Q9hAYDNsRP1771FqSjPW4RBStAIBRoX38WF3Bsq5BjVbzHtaFD mbzgxMYD1RCeeFt1RevBmLfUIEJ2knst9Ejktl5bmHVt4BDuEIdDogJyUSNSaArE773l tG9HZjGDCoCpwmTkOpyQMhKG0Jo6vsohZGEYWKlnxyP1r/4VA881AwA+5F4cYuCuTO9m NMmn+t8kZDsFTWt4YOsXYYq3GH8WSz0Kqy05eC9/d6eKCBWzJsY+kfq0epi6pSznQhyT GIXrFgpMqDv0BTfePMhpy/B8bPvBhLZexVnJ5yWW0lXWzPgemdj4/6aV+JQJlr2LMetO V1EA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kw11-20020a170902f90b00b001ac937171d7si2069009plb.278.2023.06.20.09.25.15; Tue, 20 Jun 2023 09:25:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232951AbjFTP5Q (ORCPT + 99 others); Tue, 20 Jun 2023 11:57:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229954AbjFTP5K (ORCPT ); Tue, 20 Jun 2023 11:57:10 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4052AB4; Tue, 20 Jun 2023 08:57:08 -0700 (PDT) Received: from kwepemm600003.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QlrqJ0mmXz1FDf8; Tue, 20 Jun 2023 23:57:00 +0800 (CST) Received: from localhost.localdomain (10.67.174.95) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 20 Jun 2023 23:57:05 +0800 From: Yang Jihong To: , , , , , , , , , , CC: Subject: [PATCH 2/2] perf/core: deliver PERF_RECORD_COMM and PERF_RECORD_MMAP side-band events to all online cpus Date: Tue, 20 Jun 2023 15:55:15 +0000 Message-ID: <20230620155515.101222-3-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT In-Reply-To: <20230620155515.101222-1-yangjihong1@huawei.com> References: <20230620155515.101222-1-yangjihong1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.174.95] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769239563183337952?= X-GMAIL-MSGID: =?utf-8?q?1769239563183337952?= Tasks are migrated between cores due to scheduling. If perf samples specified CPUs, PERF_RECORD_COMM and PERF_RECORD_MMAP events need be deliver to all cores to avoids the problem that the comm and symbols cannot be parsed due to task migration to the target core. The specific scenarios are as follows: CPU0 CPU1 perf record -C 0 start taskA starts to be created and executed -> PERF_RECORD_COMM and PERF_RECORD_MMAP events only deliver to CPU1 ...... | migrate to CPU0 | Running on CPU0 <----------/ ... perf record -C 0 stop Now perf samples the PC of taskA. However, perf does not record the PERF_RECORD_COMM and PERF_RECORD_COMM events of taskA. Therefore, the comm and symbols of taskA cannot be parsed. Signed-off-by: Yang Jihong --- kernel/events/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 66dbca1ba577..a014b2063af1 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -8276,7 +8276,7 @@ static void perf_event_comm_event(struct perf_comm_event *comm_event) perf_iterate_sb(perf_event_comm_output, comm_event, NULL, - false); + true); } void perf_event_comm(struct task_struct *task, bool exec) @@ -8755,7 +8755,7 @@ static void perf_event_mmap_event(struct perf_mmap_event *mmap_event) perf_iterate_sb(perf_event_mmap_output, mmap_event, NULL, - false); + true); kfree(buf); }