From patchwork Tue Jun 20 10:39:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 110414 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3575511vqr; Tue, 20 Jun 2023 03:58:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4GBQE8QY89z9p2JcFqkAlCmlKm8K0nW+Setd0ua6bN+OzdevP3pwuBNZyDxpDVe5Ha4eJe X-Received: by 2002:a67:ce19:0:b0:43b:4950:66e0 with SMTP id s25-20020a67ce19000000b0043b495066e0mr4655559vsl.11.1687258728300; Tue, 20 Jun 2023 03:58:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687258728; cv=none; d=google.com; s=arc-20160816; b=GguoA0L5VfscbsHdetB1O55L8x23piAyECLQ3MW/O3TtdTvUHn4Sl56YG87yOwTi5+ HdzfnJ2KAvZvHpDlt+vxHCVDnF5aniuLD5V9/KKnKzNp5cbveyHA3II1DZl0D+SdWajQ iFxL2k/BG6qjcSw/f4kgXN4PK0AsBPY28/iHX3LQo+G6p6X+srbsvJVPS617/u00Ysa+ qCE85flPO0Yg36EHOv/gPHwqGsONsBCo1x5LH3AlkdSmFEkipLm5+xqSRQtx5mmQmnBf IQBzv8U/rNorots8P/5gDMRAq1bXx3a8RV91GqCRujJenS3aGwYgkmiKcwODRxNzxOS2 Y5FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YMXPKF0W4ViSBsuPEBbrJJ9nCBUUcWf3miOoXNmR9QE=; b=o1Zm4PtLBUye5fqMgmiwIIRpmHoZK7nbCiJ7xJtRrHzVbxEk5YrEtrxifww4Px94nr IaVxrAabmpp9JC/RGFdfHSnyG/XDyaRWchzC3Tbtr0jJYa79biE55X/mQHLyOkH7zscp d9T3jKrCPB/faN0VtOYDNUOoJTIkphS9yfLBH/guCOwaH7TLVkZl1oIJ062iUIZ8vpSK OYEQljteKZ7gt0QP61gH43So3T4rF+1k8DhXqC03a8GJkVleWMVYTCxS7L3wgeC20Wyp dWriCnGvkRqXpoPcSJrrwNVcuMa91H1mmBtkVeUmxxnU4r1BAzVkkt4iza0T5aaG/xkZ 44ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=Gd4lSC1t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x3-20020a63b203000000b0054fe7b18671si1397574pge.809.2023.06.20.03.58.35; Tue, 20 Jun 2023 03:58:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=Gd4lSC1t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232195AbjFTKjj (ORCPT + 99 others); Tue, 20 Jun 2023 06:39:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231962AbjFTKje (ORCPT ); Tue, 20 Jun 2023 06:39:34 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F667E41 for ; Tue, 20 Jun 2023 03:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=U7fCOQZbJkzRS/ SUBlBnZh9gq2QKuIUDy7rdPxvWssY=; b=Gd4lSC1t8xeXhR+F/xeSwHMULeoibe ox4jbcvK4a0GGV3dQcPvnDLoChC06Ynb6GxgJEMM0dnpyHhfQnVUjFx67Jt+1+qL DaOfzJqkGGrvO2dvO6j+t5yi2m4qZXDKusQBqaVzv5y/dstRP0mnYe1cuVyYaIrz Pdhdyurrs5TM4= Received: (qmail 601049 invoked from network); 20 Jun 2023 12:39:25 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 20 Jun 2023 12:39:25 +0200 X-UD-Smtp-Session: l3s3148p1@Eq3VQ43+qoxehhtC From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Johan Hovold , Wolfram Sang , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org Subject: [RFC PATCH v2 1/3] gnss: ubx: use new helper to remove open coded regulator handling Date: Tue, 20 Jun 2023 12:39:06 +0200 Message-Id: <20230620103909.37582-2-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230620103909.37582-1-wsa+renesas@sang-engineering.com> References: <20230620103909.37582-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769219008096767075?= X-GMAIL-MSGID: =?utf-8?q?1769219008096767075?= v_bckp shall always be enabled as long as the device exists. We now have a regulator helper for that, use it. Signed-off-by: Wolfram Sang --- Changes since RFC v1: * rebased because of patches dropped drivers/gnss/ubx.c | 26 ++++---------------------- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/drivers/gnss/ubx.c b/drivers/gnss/ubx.c index c951be202ca2..9b76b101ba5e 100644 --- a/drivers/gnss/ubx.c +++ b/drivers/gnss/ubx.c @@ -17,7 +17,6 @@ #include "serial.h" struct ubx_data { - struct regulator *v_bckp; struct regulator *vcc; }; @@ -87,30 +86,16 @@ static int ubx_probe(struct serdev_device *serdev) goto err_free_gserial; } - data->v_bckp = devm_regulator_get_optional(&serdev->dev, "v-bckp"); - if (IS_ERR(data->v_bckp)) { - ret = PTR_ERR(data->v_bckp); - if (ret == -ENODEV) - data->v_bckp = NULL; - else - goto err_free_gserial; - } - - if (data->v_bckp) { - ret = regulator_enable(data->v_bckp); - if (ret) - goto err_free_gserial; - } + ret = devm_regulator_get_enable_optional(&serdev->dev, "v-bckp"); + if (ret < 0 && ret != -ENODEV) + goto err_free_gserial; ret = gnss_serial_register(gserial); if (ret) - goto err_disable_v_bckp; + goto err_free_gserial; return 0; -err_disable_v_bckp: - if (data->v_bckp) - regulator_disable(data->v_bckp); err_free_gserial: gnss_serial_free(gserial); @@ -120,11 +105,8 @@ static int ubx_probe(struct serdev_device *serdev) static void ubx_remove(struct serdev_device *serdev) { struct gnss_serial *gserial = serdev_device_get_drvdata(serdev); - struct ubx_data *data = gnss_serial_get_drvdata(gserial); gnss_serial_deregister(gserial); - if (data->v_bckp) - regulator_disable(data->v_bckp); gnss_serial_free(gserial); } From patchwork Tue Jun 20 10:39:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 110415 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3576825vqr; Tue, 20 Jun 2023 04:01:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7gAho65eCLY3zXA7Lqe5Yh5wTFCgwUHV6eM+prZ3+GiIqaBUiSntOlPvpBYNSX6x+Fc4Uw X-Received: by 2002:a05:6870:2c2:b0:1a6:945d:516e with SMTP id r2-20020a05687002c200b001a6945d516emr5200139oaf.24.1687258868061; Tue, 20 Jun 2023 04:01:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687258868; cv=none; d=google.com; s=arc-20160816; b=ThpWJOGiRxSk4FWAtyN284YrmKMA5bpRxpHeTHkvUTe7S8PHeBoaRdto46ESL9Yytu e8BPwEgN7nI1+ergqpm3dHPJbykS55+czRo06YWIxM6PFtM9OadnqQnJ9L42qEMQPpKL uNloiDz3RXm5kg3pLEHMKO1NTI7gkMQY5IUk+e3tBUolPFi2pH01QGxLy8BwZPVGpkUn KuoJoWc3EAKbHSTlH39KOsLHdOePmG2j5IQiIT4wwwFoimw1E6iVQJt4cTXCgzcpNU1P oE0iSqoszBUc9gfmZIOZEYRGbd72i4S7guTV3UOjG4BzpEAxsvUjEXGVwDJX4EnjHx76 kDWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=OugQ5brUfT/MtGSFKqv8VnGtKaKmSqeAy26INeSV3mQ=; b=09oX2rvF/mda+0RG30wVp1ZReByUhgoOZZm5vM9qODqO/IvmWnBMZ2pBcIBg5f03US hbjhX72/oLdYs7UB5Bm1JZN1LQmPkD9g+z8HD22YCOD+21zaJXOc/Spt5C/m7yWP+Yf1 YJ05h8QDT8TgpM74AG/asfcCySytNzuPhalsxHvcVG9o0gARXOONUofUZSZqUSNRJ1Vi DLshBf2DCYhZQ1I2FcYxXDETpc5zP3ewdRECbrJRRK2lRuNJ/4dUPoq7myVgJ25PTbRI LIrS60xnCGj8S204BAzXDYfI6VvmNEq37uvcrxoQw+3DJensomcv5jj3fz2b01/TTW/s d3Gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=OqV+R8q+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v1-20020a63b941000000b00540ca2b00c6si1471439pgo.733.2023.06.20.04.00.53; Tue, 20 Jun 2023 04:01:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=OqV+R8q+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231962AbjFTKjn (ORCPT + 99 others); Tue, 20 Jun 2023 06:39:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232177AbjFTKjf (ORCPT ); Tue, 20 Jun 2023 06:39:35 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EE8210F8 for ; Tue, 20 Jun 2023 03:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=2BsJbCMG4/ENDD xROROqsb+IvXX19wdVnpIz1CwK0nE=; b=OqV+R8q+gfa60VfPGLstKbBoyp3OCH nTHQUQOdqCslu/jTAqqE2Y/vwRAsIgjR+HEzqeUuWatCdK7+qHDasbS1YouNHLW4 9nQxkOTgWZCtbXzhvomN0mwxZk0bOLuh2WdGGtpFG8+i0bYPqKxi5XmwPLlJxmU3 Urxw8OFF7x1C8= Received: (qmail 601086 invoked from network); 20 Jun 2023 12:39:26 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 20 Jun 2023 12:39:26 +0200 X-UD-Smtp-Session: l3s3148p1@nQjfQ43+uoxehhtC From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Johan Hovold , Wolfram Sang , linux-kernel@vger.kernel.org Subject: [RFC PATCH v2 2/3] gnss: ubx: add support for the reset gpio Date: Tue, 20 Jun 2023 12:39:07 +0200 Message-Id: <20230620103909.37582-3-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230620103909.37582-1-wsa+renesas@sang-engineering.com> References: <20230620103909.37582-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769219154963164893?= X-GMAIL-MSGID: =?utf-8?q?1769219154963164893?= Tested with a Renesas KingFisher board. Because my GNSS device is hooked up via UART and I2C simultaneously, I could verify functionality by opening/closing the GNSS device using UART and see if the corresponding I2C device was visible on the bus. Signed-off-by: Wolfram Sang --- Changes since RFC v1: * rebased because of patches dropped * bail out correctly when requesting GPIO fails (Thanks, Dan!) drivers/gnss/ubx.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gnss/ubx.c b/drivers/gnss/ubx.c index 9b76b101ba5e..cb0612100644 100644 --- a/drivers/gnss/ubx.c +++ b/drivers/gnss/ubx.c @@ -7,6 +7,7 @@ #include #include +#include #include #include #include @@ -18,6 +19,7 @@ struct ubx_data { struct regulator *vcc; + struct gpio_desc *reset_gpio; }; static int ubx_set_active(struct gnss_serial *gserial) @@ -29,6 +31,8 @@ static int ubx_set_active(struct gnss_serial *gserial) if (ret) return ret; + gpiod_set_value_cansleep(data->reset_gpio, 0); + return 0; } @@ -41,6 +45,8 @@ static int ubx_set_standby(struct gnss_serial *gserial) if (ret) return ret; + gpiod_set_value_cansleep(data->reset_gpio, 1); + return 0; } @@ -90,6 +96,13 @@ static int ubx_probe(struct serdev_device *serdev) if (ret < 0 && ret != -ENODEV) goto err_free_gserial; + /* Start with reset asserted (GPIO must be active low!) */ + data->reset_gpio = devm_gpiod_get_optional(&serdev->dev, "reset", GPIOD_OUT_HIGH); + if (IS_ERR(data->reset_gpio)) { + ret = PTR_ERR(data->reset_gpio); + goto err_free_gserial; + } + ret = gnss_serial_register(gserial); if (ret) goto err_free_gserial; From patchwork Tue Jun 20 10:39:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 110411 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3572408vqr; Tue, 20 Jun 2023 03:51:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7QzQUZKGDNJDS24299IfNTWntk2OhuyeQi2MC8qCU2swdBsbDswCuCnZhXwrIAJndMuBL1 X-Received: by 2002:a05:6a21:32a0:b0:120:80ba:3df0 with SMTP id yt32-20020a056a2132a000b0012080ba3df0mr2982793pzb.27.1687258262291; Tue, 20 Jun 2023 03:51:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687258262; cv=none; d=google.com; s=arc-20160816; b=UKN4y6MJ0a+/yC07womo5gLp20ltLYOqbhQS6+ZR719WMbhxrJTQQPqbot74oZgC9Y ljAEJiOOvEXPB3TVqMYbVE5kIaWfpP3AXKSkHU3rMeseQCyra/aBDz6sJQoqn2l6ExI9 p1tZDkk6J2Z0pNmPe1ae4tCuSRi2q9dUyfiG2IIP/sgCelxBhTx1WfvIAjUJsMxds/LU A/oQkPIADab0ipXLrBjSLfI9+rQ+U1QofR/Hit0bBtcNjYIE5ZiJwlctI60DPByJ4qmQ uOL6TdnRm86KPIhp4Jy+VmQK87cfBk+Q52Li8Xy3tOMtWjiooxERYuoP3GZcl7Ee7uyJ apaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=egKlPUE8ZVyOHmsx92MkRbLbqEdbExGpazWJ/AEagwY=; b=eYBv/tKNsLZR4rnMbe3RklKhAArH+GkXHs0voLGeM1Id4bKlpJ/rQ2eumThxNwJepP UvdsZS/wM8Kp2IC5VMplaVrDh0PS/fGXFA28jA9nAg2kHE914NLo0TMMhE5zFpoeHwZz vYlevt3oU/I0jRG2elnbDXCwtuXkuRI4zYTz4aNFy5USR5VTt2JDvowATb/40mkRIP3s gXqW7HuFNL45uUqpkFgo3IELghKBC67L65p5qln1/KNXi8gOUb8YNVZcGJs/2rOazuDe zGSi/k+z5nGfgqHj7EJpSsrEfOhXFqNw1581oMyZurSI/h6mGGvW6EvRZm/YSV2ERlZL 5RlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=aX0RyTv4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u64-20020a638543000000b00553ce42135csi1442444pgd.812.2023.06.20.03.50.49; Tue, 20 Jun 2023 03:51:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=aX0RyTv4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232281AbjFTKjx (ORCPT + 99 others); Tue, 20 Jun 2023 06:39:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232196AbjFTKjj (ORCPT ); Tue, 20 Jun 2023 06:39:39 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8D9C10D0 for ; Tue, 20 Jun 2023 03:39:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=tQR0dWwr8w4Ycm Bt80qqUYFnqdWmFqmB5wVjdVTNQGI=; b=aX0RyTv49uKNK1StgC86X7o4GVifF5 L1mkoGXFqymtcBtohUJjjWCnnlZPBNgNnsRLpzdc10oWI5GQ2cri41QRyBQPGjmP k01F1OCQs90sV/YH9oKq+J1R7LC2UYulzv/Lqnt6h6MzXnm9ikbax6IyCldyG7SA sRo+apN62cWow= Received: (qmail 601116 invoked from network); 20 Jun 2023 12:39:27 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 20 Jun 2023 12:39:27 +0200 X-UD-Smtp-Session: l3s3148p1@QoLpQ43+vIxehhtC From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Johan Hovold , Wolfram Sang , Geert Uytterhoeven , Magnus Damm , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v2 3/3] arm64: dts: renesas: ulcb-kf: add node for GPS Date: Tue, 20 Jun 2023 12:39:08 +0200 Message-Id: <20230620103909.37582-4-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230620103909.37582-1-wsa+renesas@sang-engineering.com> References: <20230620103909.37582-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769218519728978346?= X-GMAIL-MSGID: =?utf-8?q?1769218519728978346?= From: Wolfram Sang Add the node for the GPS receiver and its VCC supply. Signed-off-by: Wolfram Sang --- Changes since RFC v1: * rebased because of patches dropped and refactored * added static vcc-suplly @Geert: Not sure if we need so many fixed 3v3 regulators. Most of the other ones more or less directly derive from d_3v3. Or do you prefer it this way? arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi index e62f5359f64b..dd1ffc31c874 100644 --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi @@ -39,6 +39,13 @@ accel_3v3: regulator-acc-3v3 { regulator-max-microvolt = <3300000>; }; + d_3v3: regulator-d-3v3 { + compatible = "regulator-fixed"; + regulator-name = "d-3v3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + }; + hdmi_1v8: regulator-hdmi-1v8 { compatible = "regulator-fixed"; regulator-name = "hdmi-1v8"; @@ -434,6 +441,13 @@ &scif1 { pinctrl-names = "default"; status = "okay"; + + gnss { + compatible = "u-blox,neo-m8"; + reset-gpios = <&gpio_exp_75 6 GPIO_ACTIVE_LOW>; + vcc-supply = <&d_3v3>; + current-speed = <9600>; + }; }; &sdhi3 {