From patchwork Tue Jun 20 08:26:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamlesh Gurudasani X-Patchwork-Id: 110351 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3519429vqr; Tue, 20 Jun 2023 01:52:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7T/9Yuh2Wz4J4GuMiHLCzvYGMnjHtl9rp5Kz2RGTZsXg4DPf9KKSsCmJRTJp/rdvEnFb14 X-Received: by 2002:a17:902:cec4:b0:1b6:6fd5:4a91 with SMTP id d4-20020a170902cec400b001b66fd54a91mr3146325plg.57.1687251127647; Tue, 20 Jun 2023 01:52:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687251127; cv=none; d=google.com; s=arc-20160816; b=jQDObyw0HApEgRg8HX2Tkmy47dVfAxTfgrqJ2vELk8hoDcf6s4UBTFRttoLFTFzq6W R5Lm3LFGoOZyJMg1OZMAJ2/LAL8HlqSP10qt6M8BEMzkcjU4fL3QG8DUTxITK6hTmAS+ 6blIpLic6BQUmxnKgPD59PFfGf42RfTw1ttESk7W7Gn62xbh5vV8nMmog+Kd2HBofRhz wQX5IMl7mN0Ekt7GvCVtjXagtt0NUEySQeA1iTP47A2R4lU7cLS5Rh72VWxMAR+cvm+l wtJo/KM3W/2EgXmhrBGSCr2ll49QCjuv8duNdJ+uG5qSwOKV04Lf2NKEqIPgtdFknj92 KqFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=suCPQPrzzGFfP4KenDy/T5byFv935u0r7FkdI3FxBb8=; b=lyHls/2oNXbnOlaXmGN8u1suril5lusqMRJ/WA1YHfAM2vbKcFTjqgadl81F92i+UG 3d6cXqPzTBnQqDtIhFIrvoNuMdbG0YvsN4Dt2a1UmrOQoFBrAmWwvJahkZZzP8uRUonb uPYU9L5jDMYXqaxKvq7voGibcxYN959eMuGttvz/URwHQIewHQky/TuglLv0vQ/KXi2r I4eIYuav+vemAv/yu9aJNtkuW+CV0pACzAhdlpUdo0DNC9z9EKReyIWo7BLIzJ24RsM6 ZgInjc2Fzw7tS9Z1GaqKM2mJ/1IvTBZRlKAvZuxa4j11u+UdiPggKiGKgagOE36g2CKQ txYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Ak0WeTnA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k15-20020a170902c40f00b001b6819b6238si984130plk.195.2023.06.20.01.51.54; Tue, 20 Jun 2023 01:52:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Ak0WeTnA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231919AbjFTI2b (ORCPT + 99 others); Tue, 20 Jun 2023 04:28:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231909AbjFTI2a (ORCPT ); Tue, 20 Jun 2023 04:28:30 -0400 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDC17130; Tue, 20 Jun 2023 01:28:25 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 35K8SIHg131019; Tue, 20 Jun 2023 03:28:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1687249698; bh=suCPQPrzzGFfP4KenDy/T5byFv935u0r7FkdI3FxBb8=; h=From:Date:Subject:References:In-Reply-To:To:CC; b=Ak0WeTnAy3ZxPjUz74Z60HqtjFXrMaLEDaQ8yMLB6QwaeO8JQhddUzqkVVudnbBuU AHg41gN8gHjdHJwyjGRbbvuz2bgA8FAkOxsfxj/MkvcUN5HxWYCB76dlZx29ZwiatA pXIm9xxtb7DDnxbgCA18vm43v8BnQs/IuXBEjXL4= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 35K8SIjQ022384 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 20 Jun 2023 03:28:18 -0500 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 20 Jun 2023 03:28:18 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 20 Jun 2023 03:28:18 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 35K8SHdC065731; Tue, 20 Jun 2023 03:28:18 -0500 From: Kamlesh Gurudasani Date: Tue, 20 Jun 2023 13:56:59 +0530 Subject: [PATCH v4 1/2] dt-bindings: crypto: ti,sa2ul: make power-domains conditional MIME-Version: 1.0 Message-ID: <20230614-sa3ul-v4-1-7c969f626796@ti.com> References: <20230614-sa3ul-v4-0-7c969f626796@ti.com> In-Reply-To: <20230614-sa3ul-v4-0-7c969f626796@ti.com> To: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jayesh Choudhary CC: , , , Kamlesh Gurudasani , Conor Dooley X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1687249695; l=1420; i=kamlesh@ti.com; s=20230614; h=from:subject:message-id; bh=9fFLiJzU0nj0ThkjDNPisO+/050gLX2S2toEaa+3810=; b=hZIGO2szRT25GerYQmO4Jq6Qssaj4zGAijghN1ci5tJLrgsDoC+CK2vJXXAhhaIwiyLeWR7JA UwgCauj2rEjCN9MIWQxyV3LWcvWYP0BkPaTnG3VTQbCoNRXS+hDc9SS X-Developer-Key: i=kamlesh@ti.com; a=ed25519; pk=db9XKPVWDGJVqj2jDqgnPQd6uQf3GZ3oaQa4bq1odGo= X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769211038247925734?= X-GMAIL-MSGID: =?utf-8?q?1769211038247925734?= Devices specific to compatible ti,am62-sa3ul don't have control over power of SA3UL from main domain. "power-domains" property in crypto node tries to access the SA3UL power, for which it gets NACK and hence, driver doesn't probe properly for those particular devices. Make "power-domains" property as false for devices with compatible ti,am62-sa3ul. Fixes: 2ce9a7299bf6 ("dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation") Reviewed-by: Conor Dooley Signed-off-by: Kamlesh Gurudasani --- Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml index 77ec8bc70bf7..f0ef7685550a 100644 --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml @@ -66,10 +66,22 @@ patternProperties: required: - compatible - reg - - power-domains - dmas - dma-names +allOf: + - if: + properties: + compatible: + contains: + const: ti,am62-sa3ul + then: + properties: + power-domains: false + else: + required: + - power-domains + additionalProperties: false examples: From patchwork Tue Jun 20 08:27:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamlesh Gurudasani X-Patchwork-Id: 110349 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3519119vqr; Tue, 20 Jun 2023 01:51:19 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6MPsr/3pRWqC2ra0cm7GWTb1uw+MjT+TroQsJTJ0DYCZcXHoDTiNmDHxV9UNqXW5ixGJFU X-Received: by 2002:a05:6214:21ea:b0:630:21a6:bb5e with SMTP id p10-20020a05621421ea00b0063021a6bb5emr3868608qvj.30.1687251078814; Tue, 20 Jun 2023 01:51:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687251078; cv=none; d=google.com; s=arc-20160816; b=og350aB32nGCJJyvw/eRp/DTc/4g8NrbB1nykvEOJfX+S1jOJ+YTCNYquhXvAsuT2X V5IaDDjXCj51LHBC2xrwRmJjv9pmNCLiuwdENKdUXC9Co5GIHujO2963iPZyq7J30Zyo fr6fn/5jEBTQ/I2rJprEkHikqRumFW+LYI/ZHlkcSnF3TW/RHWW91pHFdHWytVJx7GJS F1CfhSoWJLIJpu1n2qMjDS/05/U9AEc3LewBCuhrKSSla20Szcz0E7DSJWm+s4xxC7fD HQXkP0Xh/D3eG48x+JPPq+X3mNi9yA7Q9/Tw4pxLIM1AxyceU+g2YDiv1ydptdekUBcl RuhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=mKtCUPgaud8pjCzNSvAn4kZizjOxNjiafARqukJWj+8=; b=y9fXq7cuT24Oq6Ycfkf1Vop7ZGwZAUbE48UbXrvWuSOBKcca6cD2PVUdU4K4NdeAkq DyZLDay/0WRpoHtnOO8+NCqNfVonZVkfefEppRN2ySwUtq+3+khYii6dsS8ojl0jDlnD aMSd+yiui+55CN9Sb2E4OdxoDVU1p3fnmA8jv9+b5L83GgZTw7AKwQGj0UGGIXeJy6Mw klM9+7o6xlsv4lIbBUVZojLhlzjTZ8gUDGPfesxHfFoh6KvnCg4oK9NnrBMVkaLqX/ZW oCacOdInQQHYs4ty49AbdkPkgRrRzjQOcYv2+4ReQ6XLKKLlTTmr2uerjk641UnIUa8f V30g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=h2EEn6uY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e10-20020a63690a000000b0051f7686dfb7si1283713pgc.189.2023.06.20.01.51.04; Tue, 20 Jun 2023 01:51:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=h2EEn6uY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231573AbjFTI2e (ORCPT + 99 others); Tue, 20 Jun 2023 04:28:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231911AbjFTI2a (ORCPT ); Tue, 20 Jun 2023 04:28:30 -0400 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDD91132; Tue, 20 Jun 2023 01:28:25 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 35K8SKWq131024; Tue, 20 Jun 2023 03:28:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1687249700; bh=mKtCUPgaud8pjCzNSvAn4kZizjOxNjiafARqukJWj+8=; h=From:Date:Subject:References:In-Reply-To:To:CC; b=h2EEn6uY2RoBnI1oT1TfviGf+MRBU2R/DzBpna36nkXQua/s2JSW/UF9SfyHwsWlh wM9RAmXTrVsT0eQKLfEDsUsatvgnUx2NxyiAoRapOt5hVBmeMBrOhjLo256FqLvWlj GPpTg1v+JllHNViI3c70QpfT6i53aljGm9JnA/0E= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 35K8SKmR005164 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 20 Jun 2023 03:28:20 -0500 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 20 Jun 2023 03:28:19 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 20 Jun 2023 03:28:19 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 35K8SJdb010857; Tue, 20 Jun 2023 03:28:19 -0500 From: Kamlesh Gurudasani Date: Tue, 20 Jun 2023 13:57:00 +0530 Subject: [PATCH v4 2/2] arm64: dts: ti: k3-am62-main: Remove power-domains from crypto node MIME-Version: 1.0 Message-ID: <20230614-sa3ul-v4-2-7c969f626796@ti.com> References: <20230614-sa3ul-v4-0-7c969f626796@ti.com> In-Reply-To: <20230614-sa3ul-v4-0-7c969f626796@ti.com> To: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jayesh Choudhary CC: , , , Kamlesh Gurudasani X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1687249695; l=1080; i=kamlesh@ti.com; s=20230614; h=from:subject:message-id; bh=twkydDeRPS5AYQfyYZRmDOCh79DoQ65SqFyXWQK4qeQ=; b=PWS4JU8LX+bhAAPFR2oK0F1v7ZN3UN+EkLVNzavYEs9wBVqkaZD+O6BX9A1jRo1BCrfQjx2zn X82SXIz/6mwBnv60B1UpApxJUTiCHxk5s3EZDNqnn+qtb0+4pJRT1SV X-Developer-Key: i=kamlesh@ti.com; a=ed25519; pk=db9XKPVWDGJVqj2jDqgnPQd6uQf3GZ3oaQa4bq1odGo= X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,TVD_SUBJ_WIPE_DEBT,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769210987057676305?= X-GMAIL-MSGID: =?utf-8?q?1769210987057676305?= Only SYSFW has control of SA3UL power. From SYSFW 08.04.00.002, for security reasons, device ID for power management of SA3UL has been removed. "power-domains" property in crypto node tries to access the SA3UL, for which it gets NACK and hence, SA3UL driver doesn't probe properly. Fixes: 8af893654c02 ("arm64: dts: ti: k3-am62-main: Enable crypto accelerator") Signed-off-by: Kamlesh Gurudasani --- arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi index b3e4857bbbe4..18a6e9ffaf58 100644 --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi @@ -174,7 +174,6 @@ k3_reset: reset-controller { crypto: crypto@40900000 { compatible = "ti,am62-sa3ul"; reg = <0x00 0x40900000 0x00 0x1200>; - power-domains = <&k3_pds 70 TI_SCI_PD_SHARED>; #address-cells = <2>; #size-cells = <2>; ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;