From patchwork Tue Jun 20 06:50:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugh Dickins X-Patchwork-Id: 110269 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3482294vqr; Tue, 20 Jun 2023 00:15:47 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7aGLlVb8xBwCbdzMAEgW4i0yfZS4BLfLvFM6t9aTyCOGi3lX/4KNHCucLYsiz58FThx78+ X-Received: by 2002:a05:6a20:a110:b0:10e:e58d:ce85 with SMTP id q16-20020a056a20a11000b0010ee58dce85mr16579581pzk.10.1687245347514; Tue, 20 Jun 2023 00:15:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687245347; cv=none; d=google.com; s=arc-20160816; b=sSN0h1qze8h0FORE5bfWuwLum22aLYZ2XXSKNxMqTZedMSyKbWNp/C+N15AFlxHOtT 5Qx3KzJQsxDcYnSKeeS0qxwQmTwJyb0YNvlbjFEdXtDA2T4N7wHAja8iYxviZdhuECGj XrRC3m2YT/zqjW6hoX265EjW0f57aCpofu7Dwun+PnOwws4fbynpURaLCIJYIJnOGVpe YhN5GRJrC9LUEJcrRwhq8TSOSQ6Gxr4+Kux871+f1NA336csOLI2VfZXtbtyWg3iDQO1 f2hwqfAwyq17JNgRKNI5sF15dtdtPh3hQD2ho7uQyWdJKeFcXB+SvgI0vaG6wNEHv2wy 82eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:message-id:in-reply-to :subject:cc:to:from:date:dkim-signature; bh=I/bRJJ7HKAxHd08pJcszqvVk2aL6jH9Ld13vowySjkQ=; b=dcJgIiEx1K5N7ZvysGWjmPr0lPSfzIlKMYIF9PM/qKttPzZnSWh0/ifAd/VCpl0KB6 EM6CCLyZ/kfMVY5WKgJuuk8PKrUaXZ4lEmBMYgdMZC2oOdICoacvuccnT6OHOdr5F0P0 SGrfUxbr9MRVg2xqB6YrnylyxeE8Z1I8sfvxhCW2odVinY1bFk/ddYEPx4YTUrFfrBaf Nzm4X35XCWdVXUwKbQT2YoRmoB/caXVwgOjxODBx1u+1ugdPEybdd/XGFze5akFJcEVJ DcEHKcgzbksHUzNCKAPaZM3lspXRP7kKNpSk0Nq3W2i5ktLiuTosxnzfajj7H4ZE6yRz RErQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=Vz0vexlm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q11-20020aa7842b000000b006686fe3fe4bsi1131454pfn.154.2023.06.20.00.15.35; Tue, 20 Jun 2023 00:15:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=Vz0vexlm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229995AbjFTGuQ (ORCPT + 99 others); Tue, 20 Jun 2023 02:50:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229651AbjFTGuO (ORCPT ); Tue, 20 Jun 2023 02:50:14 -0400 Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CABD5B1 for ; Mon, 19 Jun 2023 23:50:13 -0700 (PDT) Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-57083a06b71so35803397b3.1 for ; Mon, 19 Jun 2023 23:50:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687243813; x=1689835813; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=I/bRJJ7HKAxHd08pJcszqvVk2aL6jH9Ld13vowySjkQ=; b=Vz0vexlm8Fi1kRWWLKFH0afGyZbpoHfUCJFGK5u6d1yfX9pcmaTaF8B9KhDWYwm1jW Z3OHmDGoXUe3JhXcUAbF965Onew9srRDivZSbN3wndiTA6j7qLe46+c7OONnoi1awyTP PxuAvKUdhV9NZgbHaRPq9uuToBYnY7B3RKXHUc3DgHDN4+2mhVMJWHieVVS5XvM7nsua 94bKAJ2uPjOf+d8ibOrtydWioDkIQYoSfFcweFsuWKU+f3lbQACGTY8l9iGBLIH2Kqz6 q1zwm0178oZv/vq0nCnIzWVviStyiAH7Q6JscZHrNhFJ3utksGPBC2KEKTxPj80uNjMh YJOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687243813; x=1689835813; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I/bRJJ7HKAxHd08pJcszqvVk2aL6jH9Ld13vowySjkQ=; b=jgRpP0eRYcwv67MHXXt+nhBc4MMmClldGBOK5kO0TNgYrwiBc+Hmlj/LGP9lEsKoJt xhFxT0zTniCotLriBs2GkJ3nifdw+61OAi7+f1lL/PHHXpaKkhyDT7EUJUkL/M5FkTZQ aDIPnWzaorJX4b1PErKeLxZFPmz9B7NleGCsp1o0axv74bKfBV5LCIjbs0gr4gMscwDe RY3KKlbYeuQhPAQ2WQon1wWfeLyKM0molfLZE+/KQyhf97ETAjXtsBO4KdLU9NwCSBrB EfNPgadF78h9AEBXVL7SndSSZwWrSTN11YGAWbAdCbAG/7pRP9RtmxFFWwPt/aChvX22 tK1Q== X-Gm-Message-State: AC+VfDxqM012fqSK3m3/UB54OziMHK5twEP5zop3uS40O1j+FwJfy6Uw SgNvQRF+V1IDUzwgQoIN1f779Q== X-Received: by 2002:a0d:d412:0:b0:56d:3402:b9a0 with SMTP id w18-20020a0dd412000000b0056d3402b9a0mr11226869ywd.14.1687243812830; Mon, 19 Jun 2023 23:50:12 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id w1-20020a818601000000b0057328423a05sm356123ywf.80.2023.06.19.23.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jun 2023 23:50:12 -0700 (PDT) Date: Mon, 19 Jun 2023 23:50:00 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Andrew Morton cc: Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Lorenzo Stoakes , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH] mm/swapfile: delete outdated pte_offset_map() comment In-Reply-To: Message-ID: <9022632b-ba9d-8cb0-c25-4be9786481b5@google.com> References: MIME-Version: 1.0 X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769204977482731709?= X-GMAIL-MSGID: =?utf-8?q?1769204977482731709?= Delete a triply out-of-date comment from add_swap_count_continuation(): 1. vmalloc_to_page() changed from pte_offset_map() to pte_offset_kernel() 2. pte_offset_map() changed from using kmap_atomic() to kmap_local_page() 3. kmap_atomic() changed from using fixed FIX_KMAP addresses in 2.6.37. Signed-off-by: Hugh Dickins --- Here's a late "33/32" to the series just moved to mm-stable - thank you! mm/swapfile.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mm/swapfile.c b/mm/swapfile.c index 12d204e6dae2..0a17d85b50cb 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -3470,11 +3470,6 @@ int add_swap_count_continuation(swp_entry_t entry, gfp_t gfp_mask) goto out; } - /* - * We are fortunate that although vmalloc_to_page uses pte_offset_map, - * no architecture is using highmem pages for kernel page tables: so it - * will not corrupt the GFP_ATOMIC caller's atomic page table kmaps. - */ head = vmalloc_to_page(si->swap_map + offset); offset &= ~PAGE_MASK;