From patchwork Mon Jun 19 14:17:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yogesh Hegde X-Patchwork-Id: 110046 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3063176vqr; Mon, 19 Jun 2023 08:00:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Mfa4mG/e/wA3auJGcwXDXAR/YN6Kfl9eqU4V15p59k7DdDCnq68Y0KteSwYva8LCIZdLi X-Received: by 2002:a17:90a:74c4:b0:25b:dff1:ae2 with SMTP id p4-20020a17090a74c400b0025bdff10ae2mr5536486pjl.12.1687186845309; Mon, 19 Jun 2023 08:00:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687186845; cv=none; d=google.com; s=arc-20160816; b=LjiQ59D9TuN7RXu7k/gA0PvFwXqAmAABpcs0/tUOb0r5V+xCmISyKrVdsQuC/NEXPN dV/YKa0h9u5UxQ2Ail1Oz+bRD4SqZZbYtnfU0RzMNcvxWqB8idKoxU1Y5i5/dyigx2Ta FzcthV5qFJpdXT8PzQWISQurkS1sifL+zFOdPo8B87bM9fndzbWFUBeDZJw+L810QyXU pfwGHrUKonCvho+9hhCWMS4tc6zW9X1B0j46bz/lv9ERQMrLJ8L1w06DhZW+az3nhVb1 rtOmugovXhsBBM6/R3wsn1frOOJDp7b0qMvXE57Bvd3+IFsl4owwr3F4fsPG3nJkxer/ eAiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=z2lE7a2e73x78sHkw8HLnq0fUJFGsUNME76JPhx8NgU=; b=zhpGu+3O22Ken0UYg3T6qc4vN9V2jYqepFkf/tMb/n4KL+s5byCpDSTPHyEynMhVaG 12XHNPPZ1m9dpITPt/QIRqKNn5rDLwPdMxdbN47ySFPTc8PUGfdKmuqr3Pm9HG44Tk8l x4qItHE99XzwuMRP3bYUmDfMZ4pwraERAciuJvguZPta7Qu2mYQx5O8oMVKImOrfTmSJ bRMjhatIWw+NS9/oNcxi+5IDHge5ZXXuZbmtg2ftt5ett9dvg6XEXn1V1mXSUvQMG4Wy IijAnh/wWbPTK6Vw/wdi95e3hRr85/IJX4mZQEU7VQ3M2O4OX6oU2UUkjWo9sH/qRYlb 24Kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=NHpLwEgb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mp14-20020a17090b190e00b0025bf0c44970si7595769pjb.8.2023.06.19.08.00.31; Mon, 19 Jun 2023 08:00:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=NHpLwEgb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231911AbjFSORy (ORCPT + 99 others); Mon, 19 Jun 2023 10:17:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbjFSORw (ORCPT ); Mon, 19 Jun 2023 10:17:52 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 639B6E7 for ; Mon, 19 Jun 2023 07:17:51 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-666e916b880so1187407b3a.2 for ; Mon, 19 Jun 2023 07:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687184271; x=1689776271; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=z2lE7a2e73x78sHkw8HLnq0fUJFGsUNME76JPhx8NgU=; b=NHpLwEgbAllkTYZVBSWJFhrO127G4EAGk+PObZwauMv29q3xq9Ph+MbO26c4+j2cpA MyCtGuYnHvcRP4YpAbZtZn+fBwsIeIStGioI/TNjNeVurN+ead6ZGjqRMnEvB/zEBCGp 3JllhG70x/GQD23zisSEKQBKLlaA0rkPyK0hKhbjNHWlcpJyB7btvhR2inltVM5YS4+l 0Xe8q5oCZoMx3PoPKpWeRfcRFLipYEiC3XaSDWaLM/lQGHgl702/BmR0298xXd/T+REJ fDgzro9JD229vzbd9XdBIZ32rFH1iB5D3l7UPU/UH/nQWHt6LzeGMmkx3b6bfZ6rNBQf AuCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687184271; x=1689776271; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=z2lE7a2e73x78sHkw8HLnq0fUJFGsUNME76JPhx8NgU=; b=WvKqkuB4WsTwFQN59qPvbFaq+LR91sRyDarlrrgqh9HfRhzK9L1UCyf+iGW1RVOdug EuGN8jzLhH8yrHlVU22z2yIyOPfiM6uDcVUYgQlhDrkkQ4xwA5dA8bDeIiUXLGKF5Fv5 fdOaWhyi10YYcfSlSEkC7vuDeeqI6oeZnEkOlEoS0qaj63jGQx1SIAftc1pYHn0Wo2lP Avptx2+J/dZMfVJUCQFLAJigpEcE5F1KekzXcwFycJKDOCHoQyNzjrUN/cTxlz59fcip yXTSk8wzfupvL4sujikNJFgNEtph+dVko6c9VNRQpdHAFxr+E4L/egZPxy5o3nvjjkgX JcNg== X-Gm-Message-State: AC+VfDyp3bG4zRG7C++gIxlTBHIzc7HaYBHWe+N6gn8FuABn+YWWDN4R hkn+0nSaGwD2dGRN3kigc+I= X-Received: by 2002:a05:6a20:9187:b0:11a:c012:4fdb with SMTP id v7-20020a056a20918700b0011ac0124fdbmr938782pzd.34.1687184270774; Mon, 19 Jun 2023 07:17:50 -0700 (PDT) Received: from zephyrusG14 ([103.251.210.211]) by smtp.gmail.com with ESMTPSA id x1-20020a056a00270100b005a8173829d5sm12177962pfv.66.2023.06.19.07.17.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jun 2023 07:17:50 -0700 (PDT) Date: Mon, 19 Jun 2023 19:47:46 +0530 From: Yogesh Hegde To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: dan.carpenter@linaro.org, philipp.g.hortmann@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, ivan.orlov0322@gmail.com Subject: [PATCH v4 1/4] staging: rtl8192e: Rename variable SetWirelessMode Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769143633720471919?= X-GMAIL-MSGID: =?utf-8?q?1769143633720471919?= Rename variable SetWirelessMode to set_wireless_mode to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde --- v4: Rebase to latest staging-testing branch as suggested by Greg Kroah-Hartman . v3: Revert back to v1 of the patch as suggested by Greg Kroah-Hartman . v2: Removed the variable and called the function directly instead of just renaming the variable as suggested by Greg Kroah-Hartman . --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_softmac.c | 12 ++++++------ 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 9cb4ae9ba970..51748166eecc 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -716,7 +716,7 @@ static void _rtl92e_init_priv_handler(struct net_device *dev) priv->rtllib->check_nic_enough_desc = _rtl92e_check_nic_enough_desc; priv->rtllib->handle_assoc_response = _rtl92e_handle_assoc_response; priv->rtllib->handle_beacon = _rtl92e_handle_beacon; - priv->rtllib->SetWirelessMode = rtl92e_set_wireless_mode; + priv->rtllib->set_wireless_mode = rtl92e_set_wireless_mode; priv->rtllib->LeisurePSLeave = rtl92e_leisure_ps_leave; priv->rtllib->SetBWModeHandler = rtl92e_set_bw_mode; priv->rf_set_chan = rtl92e_set_channel; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index cdd167de127f..581d568476ce 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1690,7 +1690,7 @@ struct rtllib_device { enum ht_channel_width bandwidth, enum ht_extchnl_offset Offset); bool (*GetNmodeSupportBySecCfg)(struct net_device *dev); - void (*SetWirelessMode)(struct net_device *dev, u8 wireless_mode); + void (*set_wireless_mode)(struct net_device *dev, u8 wireless_mode); bool (*GetHalfNmodeSupportByAPsHandler)(struct net_device *dev); u8 (*rtllib_ap_sec_type)(struct rtllib_device *ieee); void (*InitialGainHandler)(struct net_device *dev, u8 Operation); diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c index 7494c7e6fff6..0eaff91d92bd 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac.c +++ b/drivers/staging/rtl8192e/rtllib_softmac.c @@ -1470,7 +1470,7 @@ static void rtllib_associate_complete_wq(void *data) netdev_info(ieee->dev, "Using G rates:%d\n", ieee->rate); } else { ieee->rate = 22; - ieee->SetWirelessMode(ieee->dev, WIRELESS_MODE_B); + ieee->set_wireless_mode(ieee->dev, WIRELESS_MODE_B); netdev_info(ieee->dev, "Using B rates:%d\n", ieee->rate); } if (ieee->ht_info->bCurrentHTSupport && ieee->ht_info->enable_ht) { @@ -1654,12 +1654,12 @@ inline void rtllib_softmac_new_net(struct rtllib_device *ieee, (ieee->modulation & RTLLIB_OFDM_MODULATION)) { ieee->rate = 108; - ieee->SetWirelessMode(ieee->dev, WIRELESS_MODE_G); + ieee->set_wireless_mode(ieee->dev, WIRELESS_MODE_G); netdev_info(ieee->dev, "Using G rates\n"); } else { ieee->rate = 22; - ieee->SetWirelessMode(ieee->dev, WIRELESS_MODE_B); + ieee->set_wireless_mode(ieee->dev, WIRELESS_MODE_B); netdev_info(ieee->dev, "Using B rates\n"); } @@ -2233,11 +2233,11 @@ static void rtllib_rx_auth_resp(struct rtllib_device *ieee, struct sk_buff *skb) } /* Dummy wirless mode setting to avoid encryption issue */ if (bSupportNmode) { - ieee->SetWirelessMode(ieee->dev, + ieee->set_wireless_mode(ieee->dev, ieee->current_network.mode); } else { /*TODO*/ - ieee->SetWirelessMode(ieee->dev, WIRELESS_MODE_G); + ieee->set_wireless_mode(ieee->dev, WIRELESS_MODE_G); } if ((ieee->current_network.mode == WIRELESS_MODE_N_24G) && @@ -2566,7 +2566,7 @@ static void rtllib_start_ibss_wq(void *data) } ieee->current_network.qos_data.supported = 0; - ieee->SetWirelessMode(ieee->dev, WIRELESS_MODE_G); + ieee->set_wireless_mode(ieee->dev, WIRELESS_MODE_G); ieee->current_network.mode = ieee->mode; ieee->current_network.atim_window = 0; ieee->current_network.capability = WLAN_CAPABILITY_IBSS; From patchwork Mon Jun 19 14:18:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yogesh Hegde X-Patchwork-Id: 110042 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3062175vqr; Mon, 19 Jun 2023 07:59:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Rlb0EJDf+MNljXt2OnkBV87xUD/+RV2NjPqRXOWlxhgfUXVpefAsDgUNDz5ZTgBOsGKf/ X-Received: by 2002:a05:6a21:32a0:b0:120:80ba:3df0 with SMTP id yt32-20020a056a2132a000b0012080ba3df0mr1039763pzb.27.1687186767072; Mon, 19 Jun 2023 07:59:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687186767; cv=none; d=google.com; s=arc-20160816; b=Wb8TFBfuYkh1U3B8+ESvSsok0juW6jeuB2soekVn3yeHzS8CwQ2JDbclbDlYsZeZHC RUxVk3w4B5dS1ZTivtEp/yAJR77IG89zU97zFIxmxHKpywI6UvuUS1E7T6e4kx/v3E7/ FkPEN7Bglwi9wAO0NGyeLovExtiKoHTApGltXDN0+6MyXWuhmeTbxKQ8viAX3g07HBtc Kg2+dGvExkop07AEj42h9p2QlaqemrDBBw+V2Zh1xjmYiDJzUNLKRo9hYEhqIESGJBgI r+vHjv8wajpb3/EDFZ6giILWJmLqpVC+jeVQBgf2KuMvykA+uE7SDu2xcUd0Uc3CS6sE qWiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JQy84gQUtEAMC5sEhanysB2VGHkEqPs0ft2DSQHuBlk=; b=MH4oqjod9b6ZeeDhuyAoHBHsz8L5+UQ/dkOhcXnL5HuK5a8JHkENJI5Ef6yXe9z0m2 U7Ii/TutAI82dkDYxAiPn2fnxhbPcYbkmhZyRNoiZYY5xqeQLtbQ92rKD7xaU970Xr4j mUZUAQxKYz28C7xljMAchq75KGRtK7r9GIq8YaKmKHN3j43b0um53dy+PELzlvHrRH/M XwMjXvkrtzmnWQwrIQ4Ru1zhquFhuwKs3AtNTNZJQLZkkBUowbS/HDey2spuCgWk+LWm O22B0StPVLTYj3e1tqLgyy8gKLmz9dzB6gLQTPZXSvnzVVmaSXNE8YG1LzF9McVJQOUX /Aiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=TF9Ir8Ar; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l8-20020a170902f68800b001b526e9bb43si8375459plg.249.2023.06.19.07.59.14; Mon, 19 Jun 2023 07:59:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=TF9Ir8Ar; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232147AbjFSOS0 (ORCPT + 99 others); Mon, 19 Jun 2023 10:18:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232160AbjFSOSV (ORCPT ); Mon, 19 Jun 2023 10:18:21 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5DC1186 for ; Mon, 19 Jun 2023 07:18:20 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1b5251e5774so14469255ad.1 for ; Mon, 19 Jun 2023 07:18:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687184300; x=1689776300; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JQy84gQUtEAMC5sEhanysB2VGHkEqPs0ft2DSQHuBlk=; b=TF9Ir8ArfA1ZmdS3lhs/0saMshbLdrbX3GKiqC6IrUHGC5nf306M71GvRX5jM6GN1L WKsR2pilm46hyNOSHC3PfRaCZmyE610r9Z7Cndj+hdmPwsQ1NbsEDtel3g5Dp6Ge4vQo C3gbgNk+j1HH+F4VW6EicBFXyp5kBWyTLoyCU9rZF7qe2LeNF9C+97HN3i4RatIlz3o4 z2j6gyuJ3wXqCNOFDR6khZTT7hV5sivUVE7trMGAaStGvNAWzOIt4uU5k4J0AtsdtGDw ZJQA1fPQXXuC5nU3+Wt1HnAySOQmUVeUmbE4StTeOtkcTglcOMJ9V7axs8lq4D/UcWP4 xOOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687184300; x=1689776300; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JQy84gQUtEAMC5sEhanysB2VGHkEqPs0ft2DSQHuBlk=; b=Np+bDVsa5ilZMTDlCGKLYxlbDg8064L7B5ZOc/iJDJYrjPtbB3NzC7IK8yidwO0yFy T+pOeVZRBGkp58sfsfjj97G283rPe1iB7Stuvvu/egm5ckyvlYT49t5zNWAFtsep81mu PZ1tJ9757QDHiktCvV5US19ifgiI7TCCmgZb7dL+ZPv7p1vfdliQVh/6SB4LYZLuLlre 6z941DYfK4TlQjT9eyqedJA8JQPIBbaJLIJ0d6jZeieIgJwduomoFad+fuKZSmMc+nlt 2JgsXioLpJHWgEGmYU8IgJmUbpM5twH+8ve6yZ6HdGkkxUHpfE4ALKBjrmSMfwKynWjH 102A== X-Gm-Message-State: AC+VfDyVUu69JRZoVvEqHjvpH2I6y1JX/bBNvwC061kboKC+sB8G8NYz FNqBrCHa6DcRapcX/I9Pg4U= X-Received: by 2002:a17:902:d2cb:b0:1a9:40d5:b0ae with SMTP id n11-20020a170902d2cb00b001a940d5b0aemr1060217plc.12.1687184300199; Mon, 19 Jun 2023 07:18:20 -0700 (PDT) Received: from zephyrusG14 ([103.251.210.211]) by smtp.gmail.com with ESMTPSA id b9-20020a170902d88900b001b55fe1b471sm2589127plz.302.2023.06.19.07.18.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jun 2023 07:18:19 -0700 (PDT) Date: Mon, 19 Jun 2023 19:48:15 +0530 From: Yogesh Hegde To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: dan.carpenter@linaro.org, philipp.g.hortmann@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, ivan.orlov0322@gmail.com Subject: [PATCH v4 2/4] staging: rtl8192e: Rename variable SetBWModeHandler Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769143551563429240?= X-GMAIL-MSGID: =?utf-8?q?1769143551563429240?= Rename variable SetBWModeHandler to set_bw_mode_handler to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde --- v4: Rebase to latest staging-testing branch as suggested by Greg Kroah-Hartman . v3: Revert back to v1 of the patch as suggested by Greg Kroah-Hartman . v2: Removed the variable and called the function directly instead of just renaming the variable as suggested by Greg Kroah-Hartman . --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib.h | 6 +++--- drivers/staging/rtl8192e/rtllib_softmac_wx.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 51748166eecc..a06d1c4e778a 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -718,7 +718,7 @@ static void _rtl92e_init_priv_handler(struct net_device *dev) priv->rtllib->handle_beacon = _rtl92e_handle_beacon; priv->rtllib->set_wireless_mode = rtl92e_set_wireless_mode; priv->rtllib->LeisurePSLeave = rtl92e_leisure_ps_leave; - priv->rtllib->SetBWModeHandler = rtl92e_set_bw_mode; + priv->rtllib->set_bw_mode_handler = rtl92e_set_bw_mode; priv->rf_set_chan = rtl92e_set_channel; priv->rtllib->start_send_beacons = rtl92e_start_beacon; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index 7ee3cb846ca1..f9fa3f2bb728 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -833,11 +833,11 @@ static void HTSetConnectBwModeCallback(struct rtllib_device *ieee) ieee->set_chan(ieee->dev, ieee->current_network.channel); - ieee->SetBWModeHandler(ieee->dev, HT_CHANNEL_WIDTH_20_40, + ieee->set_bw_mode_handler(ieee->dev, HT_CHANNEL_WIDTH_20_40, ht_info->CurSTAExtChnlOffset); } else { ieee->set_chan(ieee->dev, ieee->current_network.channel); - ieee->SetBWModeHandler(ieee->dev, HT_CHANNEL_WIDTH_20, + ieee->set_bw_mode_handler(ieee->dev, HT_CHANNEL_WIDTH_20, HT_EXTCHNL_OFFSET_NO_EXT); } diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 581d568476ce..b3d6699b31ed 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1686,9 +1686,9 @@ struct rtllib_device { /* check whether Tx hw resource available */ short (*check_nic_enough_desc)(struct net_device *dev, int queue_index); - void (*SetBWModeHandler)(struct net_device *dev, - enum ht_channel_width bandwidth, - enum ht_extchnl_offset Offset); + void (*set_bw_mode_handler)(struct net_device *dev, + enum ht_channel_width bandwidth, + enum ht_extchnl_offset Offset); bool (*GetNmodeSupportBySecCfg)(struct net_device *dev); void (*set_wireless_mode)(struct net_device *dev, u8 wireless_mode); bool (*GetHalfNmodeSupportByAPsHandler)(struct net_device *dev); diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c index be82f0a655e8..d8c7b7377132 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c @@ -335,7 +335,7 @@ void rtllib_wx_sync_scan_wq(void *data) b40M = 1; chan_offset = ieee->ht_info->CurSTAExtChnlOffset; bandwidth = (enum ht_channel_width)ieee->ht_info->bCurBW40MHz; - ieee->SetBWModeHandler(ieee->dev, HT_CHANNEL_WIDTH_20, + ieee->set_bw_mode_handler(ieee->dev, HT_CHANNEL_WIDTH_20, HT_EXTCHNL_OFFSET_NO_EXT); } @@ -348,7 +348,7 @@ void rtllib_wx_sync_scan_wq(void *data) ieee->set_chan(ieee->dev, chan - 2); else ieee->set_chan(ieee->dev, chan); - ieee->SetBWModeHandler(ieee->dev, bandwidth, chan_offset); + ieee->set_bw_mode_handler(ieee->dev, bandwidth, chan_offset); } else { ieee->set_chan(ieee->dev, chan); } From patchwork Mon Jun 19 14:18:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yogesh Hegde X-Patchwork-Id: 110041 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3062015vqr; Mon, 19 Jun 2023 07:59:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7AFQXLUJLY2EOgDp8x9rbGFKb31PFiQ0pNKEOCRj41BTevf8M10SLiX/HWVBe/SiMzeLy7 X-Received: by 2002:a05:6870:7688:b0:19e:7696:2fc with SMTP id dx8-20020a056870768800b0019e769602fcmr5962986oab.9.1687186748220; Mon, 19 Jun 2023 07:59:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687186748; cv=none; d=google.com; s=arc-20160816; b=0iH8u/A5CiHJ4TDp6LCzw3pHnlnSyyRVrINAL85t6vJ0rZQJydJ+GS9SKzLdWJD7Yo iuKgsnduRsbOsyGbtDnN0wgyeZsnD+98ImZqVVArWXpL4MQxVqDhVxkkq6+o9q1weH5m ygl2n3x87fL9gEo3MHmChQ3ALPeVEX7fEvS8BydJOWdNW3pyiMQR/gKz0Q/O5SCvg1qr RPvVhOiuxjxP0Rflc3wuEO0vsiRwMKvnVvfta4NNPe3IhkbJZ8nLCGD39uHKWoD34kVV Aq26peRqEVNsB7rMb0nP0IcCV1ypjimkXG8FID1ycjo1MUXq511mqfZJYR5gM0FRVuSP rkIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=BmCAzAWDqWS9Ad0kyeEiBkiBoZ6up2YMzFBEN+N0Ip8=; b=h9qm4XJADK/fEp5SiqXMmV3aKMGIjeCQDTm4GCOKFL+Ymhv7A1N221IEbZf+R2QIZR P9V7eYnkemLD/323cEPYfPoM6jYkimT6lX+ENzks1XtZ/XCG4t1FSUXnjAALVykz8WE0 L/cLrGqtmCyxPKxTEkVWDKtXmtK4KIz/xQPDutVAZrOldQzC1KhoaASnKOQE+fiT85iB VP4xMPhedy2219mzkzZd8Woip4W4rRHVj5e7tb9Jxv9MZnshSZLulsrGE9Eeea4PqZXA Y0KTn/dbi4KFvWaHGG9xNcs5u1N+tYuiUzfNzMo4ZNHZfX/1BdueiWgEu7mQEVBbYk9F 9gtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=B6WVAJqD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k64-20020a638443000000b0055338653beesi8370553pgd.271.2023.06.19.07.58.51; Mon, 19 Jun 2023 07:59:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=B6WVAJqD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231368AbjFSOS5 (ORCPT + 99 others); Mon, 19 Jun 2023 10:18:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230220AbjFSOSw (ORCPT ); Mon, 19 Jun 2023 10:18:52 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D6E0E66 for ; Mon, 19 Jun 2023 07:18:41 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-543c6a2aa07so1788474a12.0 for ; Mon, 19 Jun 2023 07:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687184321; x=1689776321; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BmCAzAWDqWS9Ad0kyeEiBkiBoZ6up2YMzFBEN+N0Ip8=; b=B6WVAJqDiJLAXG9b4ZGy2XIQ6HiOn9GqBMho/mof+muGY9bmLwcprdE2HEkGOuOPyN XixtGDPtJuERtpjsx61nxjcEd4lhmTYbGIj6PVeSy+66t/wVTxelZZZLGBqo1lGC9nof zmMi+YxGcvXTFfJKU9M70asligvSN8duXvlEHhsn47UHI5sVmHiSyo3XvEK3yaSzxNO8 qkp5U0k4sUHQE9NaJbm4Wu8e5CVMHX638sn1Ud+n58qr/any+eAskGGjSR0pD44b3xQz n+NmyXPFcQzRmO7Aby1NhzACk6Come91GOKeppfkHG8G+mh8j0HQ8Ge47zcAO51JVg/A DeIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687184321; x=1689776321; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BmCAzAWDqWS9Ad0kyeEiBkiBoZ6up2YMzFBEN+N0Ip8=; b=lvxDo81UGNAz03lp2E41XSkXrCvfYesvWQWVfVEtfxLOwsEwYKZ/pmrZQafENOhuGm od8kMGUNsBI0ZqL8PFKDmaTeBE4zfsfGCSIrU/nUCGtCF+TP02D6q7qzDZN7e/T2wtqc 6fI69eKOTldP0W/qn7PK79n7H5GoBQHqJwk8M2dU6QS27ABYkQc/TE38yph23yF+48jN /IxFrZyhXevmp1voHGf19jP4zHQ/uMT6gPTlR2dLEMFnCBcDs2Ti2n71petybSZAT7U7 3VT8AUaAoDKj6Jc/7IQKeWQoF5RRytTNdK6RgelzMP+WIEC9zBXkH8FXYxBKBIdVECXq cihQ== X-Gm-Message-State: AC+VfDyxTaXt3JDjUrlnPQchxljGbKxWVs5vAsPj9ezf/YO5jZrsEMQL 3RZlTmn4JstdMgg0VF24LkY= X-Received: by 2002:a17:902:ab17:b0:1b4:65c3:ca68 with SMTP id ik23-20020a170902ab1700b001b465c3ca68mr6448951plb.66.1687184320743; Mon, 19 Jun 2023 07:18:40 -0700 (PDT) Received: from zephyrusG14 ([103.251.210.211]) by smtp.gmail.com with ESMTPSA id d4-20020a170903230400b001a67759f9f8sm18819812plh.106.2023.06.19.07.18.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jun 2023 07:18:40 -0700 (PDT) Date: Mon, 19 Jun 2023 19:48:36 +0530 From: Yogesh Hegde To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: dan.carpenter@linaro.org, philipp.g.hortmann@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, ivan.orlov0322@gmail.com Subject: [PATCH v4 3/4] staging: rtl8192e: Rename variable LeisurePSLeave Message-ID: <3c63f4d750b7365f233c35c676325c5e4ca54a4c.1687183827.git.yogi.kernel@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769143531752657805?= X-GMAIL-MSGID: =?utf-8?q?1769143531752657805?= Rename variable LeisurePSLeave to leisure_ps_leave to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde --- v4: Rebase to latest staging-testing branch as suggested by Greg Kroah-Hartman . v3: Revert back to v1 of the patch as suggested by Greg Kroah-Hartman . v2: Removed the variable and called the function directly instead of just renaming the variable as suggested by Greg Kroah-Hartman . --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 2 +- drivers/staging/rtl8192e/rtllib_softmac_wx.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index a06d1c4e778a..631cbe016ea9 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -717,7 +717,7 @@ static void _rtl92e_init_priv_handler(struct net_device *dev) priv->rtllib->handle_assoc_response = _rtl92e_handle_assoc_response; priv->rtllib->handle_beacon = _rtl92e_handle_beacon; priv->rtllib->set_wireless_mode = rtl92e_set_wireless_mode; - priv->rtllib->LeisurePSLeave = rtl92e_leisure_ps_leave; + priv->rtllib->leisure_ps_leave = rtl92e_leisure_ps_leave; priv->rtllib->set_bw_mode_handler = rtl92e_set_bw_mode; priv->rf_set_chan = rtl92e_set_channel; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index b3d6699b31ed..37e6fcd4b1ec 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1703,7 +1703,7 @@ struct rtllib_device { void (*rtllib_ips_leave_wq)(struct net_device *dev); void (*rtllib_ips_leave)(struct net_device *dev); - void (*LeisurePSLeave)(struct net_device *dev); + void (*leisure_ps_leave)(struct net_device *dev); /* This must be the last item so that it points to the data * allocated beyond this structure by alloc_rtllib diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c index 78d13ff1f14e..91dd3c373aef 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1200,7 +1200,7 @@ static void rtllib_rx_check_leave_lps(struct rtllib_device *ieee, u8 unicast, if (((ieee->link_detect_info.NumRxUnicastOkInPeriod + ieee->link_detect_info.NumTxOkInPeriod) > 8) || (ieee->link_detect_info.NumRxUnicastOkInPeriod > 2)) { - ieee->LeisurePSLeave(ieee->dev); + ieee->leisure_ps_leave(ieee->dev); } } } diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c index d8c7b7377132..de3db873f305 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c @@ -316,7 +316,7 @@ void rtllib_wx_sync_scan_wq(void *data) chan = ieee->current_network.channel; - ieee->LeisurePSLeave(ieee->dev); + ieee->leisure_ps_leave(ieee->dev); /* notify AP to be in PS mode */ rtllib_sta_ps_send_null_frame(ieee, 1); rtllib_sta_ps_send_null_frame(ieee, 1); From patchwork Mon Jun 19 14:18:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yogesh Hegde X-Patchwork-Id: 110044 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3062834vqr; Mon, 19 Jun 2023 08:00:23 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6byO/f//kJxvae3k3VFQpE1DqbilBJoQvQW9h2B3ciCy8RZSN5bJ438va+jpZrFWSesyl8 X-Received: by 2002:a05:6a20:728a:b0:115:2b4d:1fce with SMTP id o10-20020a056a20728a00b001152b4d1fcemr13378091pzk.12.1687186822470; Mon, 19 Jun 2023 08:00:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687186822; cv=none; d=google.com; s=arc-20160816; b=deuSz9X2oSSwMpYJFRmtz2j8DMqiS71+0+eo1Pm0SX9V6T0hDQjcMpy8xTTvvRft52 MelEQfiGeNveQfm5zba4aIwYbZVJs6dCdUVcSooJGjOJf7/tHfy2lIc515ZLvwf20Q01 A8n3RR1KHqcW5BACQGaPUcC/VQ5wO+/4hggWjTh2a1dX4wMulEq1Nf079xnEwR0SxGYu zqrjf2IaX4aie9KZGtl+2Dj/sBK+pCibyyySyk1uaC7h2YrFDZovR4w+XqWAML5i+k57 t1kofugtKR3BZ7JdBxKFm50waRTZv5pHxqhRVBN5KtmF0G40J09h2h1HSGSCsj5kxHOt lb7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=j3rO86JQ5SHM0eemJ/VqPbGFU0io6tHVoiFzDxr8Og0=; b=h4OvYOfJyPMdPTPkb1e2tyEp+qmKS9cTBGHM0N2U8Jmpd47nr5uUT2Q/B+pNbz+P51 f4pY2QmklRmWZIz68qP7r1wtIFMRIrX28zhvxaK8eDqoNXUxbRRBaoz5KfxgNFyw4RoM snTAocyEDSFWNORMwvFbxzLqKL7ZICfyJ2WGiTdhlNikiAAX4ifQ/XsnDf2WSiBUQZSX VHU94uarmcqWLiW91CdcTe5ucD91OOs2m9MaAYrPS4VpI3zzL+0KvU8jUWAlVy6MJ5Sl +DFvSi9fmjEJ3q4nM3JyszIdg9kspq/0VWAhhko570ITEjI1eoI6kU8nrCsMkNURXSJ+ eC/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=elw+cl1r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x2-20020a170902ec8200b001adbfba9c29si17895568plg.409.2023.06.19.08.00.09; Mon, 19 Jun 2023 08:00:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=elw+cl1r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232171AbjFSOTF (ORCPT + 99 others); Mon, 19 Jun 2023 10:19:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232184AbjFSOTD (ORCPT ); Mon, 19 Jun 2023 10:19:03 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87A3AE64 for ; Mon, 19 Jun 2023 07:19:02 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1b51780c1b3so28157205ad.1 for ; Mon, 19 Jun 2023 07:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687184342; x=1689776342; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=j3rO86JQ5SHM0eemJ/VqPbGFU0io6tHVoiFzDxr8Og0=; b=elw+cl1rlqwKShs5z+o3pnWcbAKateNwHR4iLX+c7aQT3ymfwK7pTPJmAqbKBxIozO Lx4k7TRunfRXhNXl8RIKNItivmqVNgaTu3/iHzhaEun4j7XVlXTGM9WlHNsSlLpJ7J8P LtTNTtA6k20Z5mdVQw5I2d78vKjQYtNjj5nfpDZcnu4UYWvq+F5ptFxuunsK+si2sezK HjiKyVQPFRSSMfXFFkaocvXyLgN2LS+ReyHAeQ2q1B5MD59+AyYHdaQTEdOp0RFiLMmD JFlVjKoupWnaF1c/Q2Vatgs4MmsmOZWTolXHU3SHmCjLsgm36LUoztHhpt4k8rn6OMO/ tnSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687184342; x=1689776342; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j3rO86JQ5SHM0eemJ/VqPbGFU0io6tHVoiFzDxr8Og0=; b=d7UADQcAWHD60mWp0fHBewLgwVWAciH7ueuZAwZHP77cDG68ljL4f0hnAtcShR88nf XDPGMFrV1i2zkPxxkBylKCmY7z1FljL3mAcK+gcUg3zQpm6t5uSQHaKtq2Kar0QxVApC YtJEkwmDq9ghPM50VbodNGn0ztqSln2Fq+c9WpH2D0pF6lpMX32XfUmqQzVcvu3mGWCX vzq5El1AxM6cAZqqStN8/VfsX4UBE6Rgb0FLjMp8RXSfdA1wWk0oxRDVBnIWVcJOW+4Q kXLidaylS9wyQEXruMVh2KNs/IaZx/s7hPY8wVYHnzHQrXHL1iEzzhMV+SfdbpWbPMYc 984g== X-Gm-Message-State: AC+VfDxVQYRofRDsCcAZT307IYbNSCzceLHIib5pjoSKxfYvCE6QtFrE ov2geRKRf9iOnX5d9UfFk3c= X-Received: by 2002:a17:902:d485:b0:1b6:79fe:3832 with SMTP id c5-20020a170902d48500b001b679fe3832mr281315plg.69.1687184342004; Mon, 19 Jun 2023 07:19:02 -0700 (PDT) Received: from zephyrusG14 ([103.251.210.211]) by smtp.gmail.com with ESMTPSA id u3-20020a17090341c300b001aaecc15d66sm20560820ple.289.2023.06.19.07.18.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jun 2023 07:19:01 -0700 (PDT) Date: Mon, 19 Jun 2023 19:48:57 +0530 From: Yogesh Hegde To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: dan.carpenter@linaro.org, philipp.g.hortmann@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, ivan.orlov0322@gmail.com Subject: [PATCH v4 4/4] staging: rtl8192e: Rename variable InitialGainHandler Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769143609604972166?= X-GMAIL-MSGID: =?utf-8?q?1769143609604972166?= Rename variable InitialGainHandler to init_gain_handler to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde --- v4: Rebase to latest staging-testing branch as suggested by Greg Kroah-Hartman . v3: Revert back to v1 of the patch as suggested by Greg Kroah-Hartman . v2: Removed the variable and called the function directly instead of just renaming the variable as suggested by Greg Kroah-Hartman . --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 4 ++-- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c index 7b0da55fa7aa..267fc6f8800e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -1109,11 +1109,11 @@ void rtl92e_scan_op_backup(struct net_device *dev, u8 Operation) if (priv->up) { switch (Operation) { case SCAN_OPT_BACKUP: - priv->rtllib->InitialGainHandler(dev, IG_Backup); + priv->rtllib->init_gain_handler(dev, IG_Backup); break; case SCAN_OPT_RESTORE: - priv->rtllib->InitialGainHandler(dev, IG_Restore); + priv->rtllib->init_gain_handler(dev, IG_Restore); break; } } diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 631cbe016ea9..4447489a16ea 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -734,7 +734,7 @@ static void _rtl92e_init_priv_handler(struct net_device *dev) priv->rtllib->SetHwRegHandler = rtl92e_set_reg; priv->rtllib->AllowAllDestAddrHandler = rtl92e_set_monitor_mode; - priv->rtllib->InitialGainHandler = rtl92e_init_gain; + priv->rtllib->init_gain_handler = rtl92e_init_gain; priv->rtllib->rtllib_ips_leave_wq = rtl92e_rtllib_ips_leave_wq; priv->rtllib->rtllib_ips_leave = rtl92e_rtllib_ips_leave; priv->rtllib->ScanOperationBackupHandler = rtl92e_scan_op_backup; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 37e6fcd4b1ec..dbf78b60dd78 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1693,7 +1693,7 @@ struct rtllib_device { void (*set_wireless_mode)(struct net_device *dev, u8 wireless_mode); bool (*GetHalfNmodeSupportByAPsHandler)(struct net_device *dev); u8 (*rtllib_ap_sec_type)(struct rtllib_device *ieee); - void (*InitialGainHandler)(struct net_device *dev, u8 Operation); + void (*init_gain_handler)(struct net_device *dev, u8 Operation); void (*ScanOperationBackupHandler)(struct net_device *dev, u8 Operation); void (*SetHwRegHandler)(struct net_device *dev, u8 variable, u8 *val);