From patchwork Mon Jun 19 13:28:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamlesh Gurudasani X-Patchwork-Id: 110032 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3036383vqr; Mon, 19 Jun 2023 07:13:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5vpb48UtlwiAQo5dlhPDKYEx5LWHZ+D5X2ThfEYgEQS6ravyJ7kA3vCHnM7KBwrBBOp1ML X-Received: by 2002:a17:90b:3881:b0:25e:f133:41cb with SMTP id mu1-20020a17090b388100b0025ef13341cbmr5021655pjb.21.1687184026233; Mon, 19 Jun 2023 07:13:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687184026; cv=none; d=google.com; s=arc-20160816; b=UEBFMwz99zc8JE9bxTdxIPw6W8Oexmmu442NviYN84hhz3tio21CUladB294s57pjG icoQrp3c7hWSG9yrIPLr0pDbIKm5e9bPWnGyJeSoK+LrNGSC58OV6ddTo7Xy7H+uDZdy kaehE3L2yWcG0uTmnqz9zlH2XBFyd5x4O2j0FHB8JCb2RTkW3T7lqrLupI1SRyMBP4az DcDXHDQk1BrVpaxrKX0x8b6zwypLxr0idwVkGz8DRUQ3sWxy9MB48FJLZhl2Kql178sA 8MjeoFqyE44pVOZP9rvNfarxAljDzp+gHAyTiXe+WpYlbTlTnVEU/5WxdO3M/QACkYfv q5Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=rJduMobeRC/tMg1rZKpZ/oOwoM1dMAtCWKvjPlh0XDs=; b=1CVriHlRzGyzguD51jj9T5hqI9GrGJJjs08x00jPEYLwoiCqxToehSd2VbbepW7lw6 GJU+CfQdn366kFovapqLP1OLsYg3WKV97NDEjdRoJ2bcgjgdTH2cmQZVVvkWmsh1bldR tfI+hS1cIHjQaN7Wu9+ffL/UWyDQs9hzskSlkXyu7iXislwkYCX54Ux3tIiOkhR/C5cY xdRhljbRaRaf4K/ot9+W+SPM/ytA17xtDcCG0RQKEneUeoXkiiv2G4Y/5jE2YnQ8jVvS s7uWZLHwTc5KzLU03T04Y7y6VNxCuPwrbWzikhh9unUp7NEHkj/UdavuSp2RJP3wEN6c 8x6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=ZthdKPMF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kk5-20020a17090b4a0500b002591ceedfd9si8522640pjb.72.2023.06.19.07.13.30; Mon, 19 Jun 2023 07:13:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=ZthdKPMF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231951AbjFSN3Z (ORCPT + 99 others); Mon, 19 Jun 2023 09:29:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229824AbjFSN3V (ORCPT ); Mon, 19 Jun 2023 09:29:21 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1194018D; Mon, 19 Jun 2023 06:29:20 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 35JDTE0E071572; Mon, 19 Jun 2023 08:29:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1687181354; bh=rJduMobeRC/tMg1rZKpZ/oOwoM1dMAtCWKvjPlh0XDs=; h=From:Date:Subject:References:In-Reply-To:To:CC; b=ZthdKPMF4jYqaI2JeOB827Hq4VcAmSArfCpE+GTwB8X41b2UC6/zseeQhpEq8obQf ekT1ySOaoWZwxGSBOfKlVDxsIWVnp5e2Czxv6h56QbAVOITiKSHF41Ayp192B1AlKt C0quJKi1WkdFpSAoI51rOntZFMph5gKJpeUSMgb0= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 35JDTEPP082914 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 19 Jun 2023 08:29:14 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 19 Jun 2023 08:29:14 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 19 Jun 2023 08:29:14 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 35JDTDOV008680; Mon, 19 Jun 2023 08:29:14 -0500 From: Kamlesh Gurudasani Date: Mon, 19 Jun 2023 18:58:47 +0530 Subject: [PATCH v3 1/2] dt-bindings: crypto: ti,sa2ul: make power-domains conditional MIME-Version: 1.0 Message-ID: <20230614-sa3ul-v3-1-2eeb810327a1@ti.com> References: <20230614-sa3ul-v3-0-2eeb810327a1@ti.com> In-Reply-To: <20230614-sa3ul-v3-0-2eeb810327a1@ti.com> To: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jayesh Choudhary CC: , , , Kamlesh Gurudasani X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1687181351; l=1267; i=kamlesh@ti.com; s=20230614; h=from:subject:message-id; bh=M3s6KmpyVsIj0WkuttZ1UlVMKN1GIG2n/jJbvX2d0qY=; b=/lo7nroG7Wz+d4nNjPuVF7Dnhwp5ArMxd4f5+IjIcq1VsvXr0AQCe+ameXJuk3FSEuRF1djRs ljYirhyeQaRAYiaC0D4e+MYx24TnU9o81nTlH0Zy8k/F0I0bqlqPHcK X-Developer-Key: i=kamlesh@ti.com; a=ed25519; pk=db9XKPVWDGJVqj2jDqgnPQd6uQf3GZ3oaQa4bq1odGo= X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769140677559754679?= X-GMAIL-MSGID: =?utf-8?q?1769140677559754679?= Devices specific to compatible ti,am62-sa3ul don't have control over power of SA3UL from main domain. "power-domains" property in crypto node tries to access the SA3UL power, for which it gets NACK and hence, driver doesn't probe properly for those particular devices. Make "power-domains" property as false for devices with compatible ti,am62-sa3ul. Signed-off-by: Kamlesh Gurudasani Reviewed-by: Conor Dooley --- Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml index 77ec8bc70bf7..88c8ee8821d4 100644 --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml @@ -66,10 +66,22 @@ patternProperties: required: - compatible - reg - - power-domains - dmas - dma-names +allOf: + - if: + properties: + compatible: + items: + const: ti,am62-sa3ul + then: + properties: + power-domains: false + else: + required: + - power-domains + additionalProperties: false examples: From patchwork Mon Jun 19 13:28:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamlesh Gurudasani X-Patchwork-Id: 110031 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3034132vqr; Mon, 19 Jun 2023 07:10:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6wsDvURgWHCBxQdluEwFZ91ekrFPxC0T+T7e67qnC+b20mLbfk6JozObBDYqOjnU8D5vN6 X-Received: by 2002:a05:6808:1287:b0:39e:ffc5:c450 with SMTP id a7-20020a056808128700b0039effc5c450mr1933356oiw.47.1687183831149; Mon, 19 Jun 2023 07:10:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687183831; cv=none; d=google.com; s=arc-20160816; b=ItLAVZ9EdcI/jaPaYoEgyxq1Mx7vZ5KPQ/dnAOTA3FVXu8hKM3RYduDgXwIEiM6pkc aR6TrS2faRicg97wPs3YqyBTvtorCPu8vk8qfmt01MPbmne9BDO3XoSc8wTu05MIZTCH nQFWYwhVLjtWJv6Ek4k2EJqpKjO3Oyp7PiKoO91JR8O7OgYXCDwl8njaS7/eyBXwBOMm MWUWKDzV+VDdMJzDyBRPX1ldYZjdFQnik6refDQZ/HzAdUonUDyKQhTAxO7ZYiZ5+f/2 ttfKEAKYJEd8Sw/i4piw4K+bAMIJsSUVwvexzSVuQCneWZHeTkKv7rL2CdCEIx5zJNJn FPXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=mKtCUPgaud8pjCzNSvAn4kZizjOxNjiafARqukJWj+8=; b=UVtBwkWMi18XNHQHFJm5EOoSw1yL9bRQDfaghCYw3rXaxYlXg0JuCkJTBgCIFUJT7J VKphFr9dAx9e3UEhlajEzSlamzkE0y/RXaVFQTkmu34yWY6MU4QL909xSPkMMTD0TEr9 sPs40cS3ifZta6mCO7f9aicaOklz9/b7WsxzGEuKM9SwpdrdHwWa6w60W29PTritYn5x YwCkaJ5tH5BzgVZ2Ywz74i9Q7MAT7DBodjRVSqq0taWyzaC0cKU9TbwhVcNEwAl7SNa2 CUGmPQq0mQQHs+YcHfzBhwf8NOscu1hKKanwLufgUxD3Y+IsFl1jJ/lIbSwlmnM/HxZg b7NA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=V+b9K+xv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l76-20020a633e4f000000b0054ff7740abfsi9406291pga.482.2023.06.19.07.10.15; Mon, 19 Jun 2023 07:10:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=V+b9K+xv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231952AbjFSN31 (ORCPT + 99 others); Mon, 19 Jun 2023 09:29:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231940AbjFSN3W (ORCPT ); Mon, 19 Jun 2023 09:29:22 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26C6A1A4; Mon, 19 Jun 2023 06:29:21 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 35JDTGbI071578; Mon, 19 Jun 2023 08:29:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1687181356; bh=mKtCUPgaud8pjCzNSvAn4kZizjOxNjiafARqukJWj+8=; h=From:Date:Subject:References:In-Reply-To:To:CC; b=V+b9K+xvUUF70qdi/PV5XUFkmpGQ2EiF12920RLpXXuDUNk9qj+GaqlT9Azk1GJfJ UuUCHtfJa25JOSJA1jNI1VHp6dd7AXqeHLwEtLGmdVJYfviPgT5lsfT46BwpuxTj5t 0LV2pbxzmG6TnEJR/3yjMGYWk0ChfRIpvKS449z0= Received: from DLEE106.ent.ti.com (dlee106.ent.ti.com [157.170.170.36]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 35JDTGJ3003911 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 19 Jun 2023 08:29:16 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 19 Jun 2023 08:29:16 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 19 Jun 2023 08:29:15 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 35JDTFiL018616; Mon, 19 Jun 2023 08:29:15 -0500 From: Kamlesh Gurudasani Date: Mon, 19 Jun 2023 18:58:48 +0530 Subject: [PATCH v3 2/2] arm64: dts: ti: k3-am62-main: Remove power-domains from crypto node MIME-Version: 1.0 Message-ID: <20230614-sa3ul-v3-2-2eeb810327a1@ti.com> References: <20230614-sa3ul-v3-0-2eeb810327a1@ti.com> In-Reply-To: <20230614-sa3ul-v3-0-2eeb810327a1@ti.com> To: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jayesh Choudhary CC: , , , Kamlesh Gurudasani X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1687181351; l=1080; i=kamlesh@ti.com; s=20230614; h=from:subject:message-id; bh=twkydDeRPS5AYQfyYZRmDOCh79DoQ65SqFyXWQK4qeQ=; b=fTTOzyH/3cHonGFh5X4ldYk/YdbNR3J9XVIPra2qMgLI9uyMihaRaHca2JCqsmIfgJ1Rv+7Yr Fnz/2HJu3vsCNr5Cq0c2vPnlDNb7J/5hNx5j0Bs+mKJjxMhCzankxC8 X-Developer-Key: i=kamlesh@ti.com; a=ed25519; pk=db9XKPVWDGJVqj2jDqgnPQd6uQf3GZ3oaQa4bq1odGo= X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS,TVD_SUBJ_WIPE_DEBT,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769140472859917589?= X-GMAIL-MSGID: =?utf-8?q?1769140472859917589?= Only SYSFW has control of SA3UL power. From SYSFW 08.04.00.002, for security reasons, device ID for power management of SA3UL has been removed. "power-domains" property in crypto node tries to access the SA3UL, for which it gets NACK and hence, SA3UL driver doesn't probe properly. Fixes: 8af893654c02 ("arm64: dts: ti: k3-am62-main: Enable crypto accelerator") Signed-off-by: Kamlesh Gurudasani --- arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi index b3e4857bbbe4..18a6e9ffaf58 100644 --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi @@ -174,7 +174,6 @@ k3_reset: reset-controller { crypto: crypto@40900000 { compatible = "ti,am62-sa3ul"; reg = <0x00 0x40900000 0x00 0x1200>; - power-domains = <&k3_pds 70 TI_SCI_PD_SHARED>; #address-cells = <2>; #size-cells = <2>; ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;