From patchwork Mon Jun 19 11:27:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 109934 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2939833vqr; Mon, 19 Jun 2023 04:31:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4CpSXlA8+SFpSDBMWC5IrU0kBbF72oz8UTwMU6jFlZuguCpGutZLr62+eVQ1xFHJscHYRq X-Received: by 2002:a05:6830:1491:b0:6b4:6945:867d with SMTP id s17-20020a056830149100b006b46945867dmr2591212otq.9.1687174315960; Mon, 19 Jun 2023 04:31:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687174315; cv=none; d=google.com; s=arc-20160816; b=jhg6TkhLoJmrRn7CI3gPc1ULB37G2NbUlXCAkq9yNL8RoUFgbgsDnTqAYwlH9RCUGl 1oCQ2si/N2BhjHhR2fAF+ozLOWGXbQCDjD0oAQPm0oJcURGoJi/pmn+unxY22CY+R349 fhGZkeweEylEwwmGAt/yhUmmj67YlmgCfzLL+TrDw7BDpAuh0MtBa+p0sY+Jjug8hcPV jFEyHN7nE7VvFZT8ZZ2oGnVkB5njV19XpRtRCmlDytsFgdlUdCME6Cgpm1Pg0k0qzeva izXgnyzcDpyN7ul7K7EOu/fTo1Dqol6fbTPWMuMqm4F/eu8tURP2yRWuVd3OV/NnHrGR GbzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=QGoV+p2U2JjfptTIQsLM0IarNYs008kHFSeefDMzwiA=; b=tKWovT51r4esSwEbA9NebK7fF4OSE/ytFBWaeS0jithm0sia0/ckh6iRT3KqrmSj2m Cfw/Hrj6+PAvuu71KlTyXY2+ssAGE6PclaHPC73y9jxWb3/r8FRR7a0to6QyZbdjJION hbPwRExVx1hbfpKPtxDDAisX6lmG+T8eBBQzP9zoC+2OesjqbMly/vi9NWCxmI+kttGK MQ64TkWwUxRd0ioNHHdi1+MkBq4ixZ5AoiycrWBRx7Y7/osYFTPEiZnJwkihhPw3ZIq9 eFas+Zxp2XYodwShVep4Tfw/BkHYbK7GeLNuSV6nF+1p2mDlsrGbxVPFs1pAkokw8euv lx+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=ZF1xhfol; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j63-20020a638b42000000b0054fd642ae84si11657558pge.561.2023.06.19.04.31.43; Mon, 19 Jun 2023 04:31:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=ZF1xhfol; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231500AbjFSL1a (ORCPT + 99 others); Mon, 19 Jun 2023 07:27:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230293AbjFSL11 (ORCPT ); Mon, 19 Jun 2023 07:27:27 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ACD810F; Mon, 19 Jun 2023 04:27:25 -0700 (PDT) Received: from desky.lan (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3D59AFB; Mon, 19 Jun 2023 13:26:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1687174009; bh=SKZE2foAuEiJpM0lv3kNXoNAKjM6FsyDumDBcf61Xvs=; h=From:To:Cc:Subject:Date:From; b=ZF1xhfol2ETOAkBHuhR8/KeNPrD0+8aql8U32pZdWdmLtitmvbN4/Ts/ld3X49toj bsV/UKVz4R3t7OB11GHOwHoZYDQntwySGsdDPALi8WSBW0tjWr1OCMpePzXtZi/Kj2 W1ddrcCS0M/mRKUHjd8D2tehqnxQneYVwKyOu+tY= From: Tomi Valkeinen To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Sakari Ailus , Laurent Pinchart , Jacopo Mondi Cc: Tomi Valkeinen Subject: [PATCH 1/3] media: subdev: Drop implicit zeroing of stream field Date: Mon, 19 Jun 2023 14:27:05 +0300 Message-Id: <20230619112707.239565-1-tomi.valkeinen@ideasonboard.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769130495480769146?= X-GMAIL-MSGID: =?utf-8?q?1769130495480769146?= Now that the kernel drivers have been fixed to initialize the stream field, and we have the client capability which the userspace uses to say it has initialized the stream field, we can drop the implicit zeroing of the stream field in the various check functions. Signed-off-by: Tomi Valkeinen Reviewed-by: Jacopo Mondi --- drivers/media/v4l2-core/v4l2-subdev.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c index 2ec179cd1264..c1ac6d7a63d2 100644 --- a/drivers/media/v4l2-core/v4l2-subdev.c +++ b/drivers/media/v4l2-core/v4l2-subdev.c @@ -200,9 +200,6 @@ static inline int check_format(struct v4l2_subdev *sd, if (!format) return -EINVAL; - if (!(sd->flags & V4L2_SUBDEV_FL_STREAMS)) - format->stream = 0; - return check_which(format->which) ? : check_pad(sd, format->pad) ? : check_state(sd, state, format->which, format->pad, format->stream); } @@ -230,9 +227,6 @@ static int call_enum_mbus_code(struct v4l2_subdev *sd, if (!code) return -EINVAL; - if (!(sd->flags & V4L2_SUBDEV_FL_STREAMS)) - code->stream = 0; - return check_which(code->which) ? : check_pad(sd, code->pad) ? : check_state(sd, state, code->which, code->pad, code->stream) ? : sd->ops->pad->enum_mbus_code(sd, state, code); @@ -245,9 +239,6 @@ static int call_enum_frame_size(struct v4l2_subdev *sd, if (!fse) return -EINVAL; - if (!(sd->flags & V4L2_SUBDEV_FL_STREAMS)) - fse->stream = 0; - return check_which(fse->which) ? : check_pad(sd, fse->pad) ? : check_state(sd, state, fse->which, fse->pad, fse->stream) ? : sd->ops->pad->enum_frame_size(sd, state, fse); @@ -283,9 +274,6 @@ static int call_enum_frame_interval(struct v4l2_subdev *sd, if (!fie) return -EINVAL; - if (!(sd->flags & V4L2_SUBDEV_FL_STREAMS)) - fie->stream = 0; - return check_which(fie->which) ? : check_pad(sd, fie->pad) ? : check_state(sd, state, fie->which, fie->pad, fie->stream) ? : sd->ops->pad->enum_frame_interval(sd, state, fie); @@ -298,9 +286,6 @@ static inline int check_selection(struct v4l2_subdev *sd, if (!sel) return -EINVAL; - if (!(sd->flags & V4L2_SUBDEV_FL_STREAMS)) - sel->stream = 0; - return check_which(sel->which) ? : check_pad(sd, sel->pad) ? : check_state(sd, state, sel->which, sel->pad, sel->stream); } From patchwork Mon Jun 19 11:27:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 109933 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2939828vqr; Mon, 19 Jun 2023 04:31:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6gsM/HRY5ZFeUFAjvdtVWOhsSJDM2SbyTvloW3+SKVV/jYcVHGFdS+48IOPBaGcwl2aoVY X-Received: by 2002:a17:902:da88:b0:1ae:10b3:61e9 with SMTP id j8-20020a170902da8800b001ae10b361e9mr10947820plx.65.1687174315566; Mon, 19 Jun 2023 04:31:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687174315; cv=none; d=google.com; s=arc-20160816; b=MOgaGlHpvBzQ+8a+DDC5A5SHsJF5A6n8weEotz/8Sino4Z5ah5zK1oxjWSp7ycqbpN 4EzaIntaN18t8XBV6nhLyXxfj5ckNzbTlIkWPjVvSItDfIWx4JM0a5SsxEJYRMczrshe UEenD1GPtjHNdOaJBBYbmcXFTkkdf2PhacBwh4aJbHAH5KIPye9SZUDncQfSDPaDlLCq Ok/ZBwJOlXWXu/ilQG89ncVj+rVwa75hvODHD+DkKr/gn2lwQRmnbTRkAZiBcsLCVYS2 YXEKsZeyx0N6K8smo6ya+pts6UgRZXMyrt3INiBtH33Q7+xD6dlzMYFJI+qprpVyC51a 1g2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=jNCedfe5Gs6pVhqoMwDYfT+70a/2/m9qT+TaJ6E7FMw=; b=fedqC6zv1wY4s4Wd9EEfbqfdwkzP28SK3Svi99RmTUGi8/9JxfU11kDYbhKiNOxiwE TR5YKBWTmzFohJn4zdQpQUb8eyESD6jBXUSdyD5BAkalPlFKFu24XqZTmLCoFP2adV4D /RBTj8gupXJ5VW2m2/I0FBRk7icOJEiJn42CT9IejXifnBYNBS9YaZwsJgGL/IQ4zHYC OiIGa5WjTUrhVdx9S79YHhf2izvSMRfduDCHC5FZrMEqx5fjxbVMXrHwGxEYePEQDAiH FQYDszqIkpRBZbVM3MrvZPjKg47pvY86nYP9ktohB6ngN21GrEsjREKyRizw6zc2Mryv pzbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=HjZjo4QG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q11-20020a170902dacb00b001b0113e102dsi7261720plx.365.2023.06.19.04.31.41; Mon, 19 Jun 2023 04:31:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=HjZjo4QG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231393AbjFSL12 (ORCPT + 99 others); Mon, 19 Jun 2023 07:27:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230311AbjFSL11 (ORCPT ); Mon, 19 Jun 2023 07:27:27 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E68B4113; Mon, 19 Jun 2023 04:27:25 -0700 (PDT) Received: from desky.lan (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 19B36547; Mon, 19 Jun 2023 13:26:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1687174010; bh=vKoVEh8/BVZ6bIy/hlGDIh7J4gLuFZr4qI4O6tce2iI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HjZjo4QG3nRjoqquQPe5bfdbkA0Xmvxu7yuKfqGthGc3bq6IA8xHcAzqdb9rOWX+e AhmLPyGjc1Tu/c/1dRXsXfp8LzsA7T377g5X2dANXTsCondZTP0Z7g4XK7kQ+WxYjd RZ8vcIA1cloPOrcC34vqnWeB0bWj0YXnNsZAWPrQ= From: Tomi Valkeinen To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Sakari Ailus , Laurent Pinchart , Jacopo Mondi Cc: Tomi Valkeinen Subject: [PATCH 2/3] media: subdev: Constify v4l2_subdev_set_routing_with_fmt() param Date: Mon, 19 Jun 2023 14:27:06 +0300 Message-Id: <20230619112707.239565-2-tomi.valkeinen@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230619112707.239565-1-tomi.valkeinen@ideasonboard.com> References: <20230619112707.239565-1-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769130495298396017?= X-GMAIL-MSGID: =?utf-8?q?1769130495298396017?= The routing parameter of v4l2_subdev_set_routing_with_fmt() is missing 'const'. Add it. Signed-off-by: Tomi Valkeinen Reviewed-by: Jacopo Mondi --- drivers/media/v4l2-core/v4l2-subdev.c | 2 +- include/media/v4l2-subdev.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c index c1ac6d7a63d2..73f716a42569 100644 --- a/drivers/media/v4l2-core/v4l2-subdev.c +++ b/drivers/media/v4l2-core/v4l2-subdev.c @@ -1590,7 +1590,7 @@ EXPORT_SYMBOL_GPL(__v4l2_subdev_next_active_route); int v4l2_subdev_set_routing_with_fmt(struct v4l2_subdev *sd, struct v4l2_subdev_state *state, - struct v4l2_subdev_krouting *routing, + const struct v4l2_subdev_krouting *routing, const struct v4l2_mbus_framefmt *fmt) { struct v4l2_subdev_stream_configs *stream_configs; diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h index b325df0d54d6..ca0bacb88537 100644 --- a/include/media/v4l2-subdev.h +++ b/include/media/v4l2-subdev.h @@ -1532,7 +1532,7 @@ __v4l2_subdev_next_active_route(const struct v4l2_subdev_krouting *routing, */ int v4l2_subdev_set_routing_with_fmt(struct v4l2_subdev *sd, struct v4l2_subdev_state *state, - struct v4l2_subdev_krouting *routing, + const struct v4l2_subdev_krouting *routing, const struct v4l2_mbus_framefmt *fmt); /** From patchwork Mon Jun 19 11:27:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 109935 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2939954vqr; Mon, 19 Jun 2023 04:32:04 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ynRLsXVZ16TOoYv9mo36c/Yw4VIAKF0/F3AA0GyxMwT5v8SMsdoXtuRQJIkNldlxV3k8E X-Received: by 2002:a05:6358:cc22:b0:130:ef29:70be with SMTP id gx34-20020a056358cc2200b00130ef2970bemr1058559rwb.32.1687174323693; Mon, 19 Jun 2023 04:32:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687174323; cv=none; d=google.com; s=arc-20160816; b=wj9eoPrRC9KFMdED4LO4ExZnNhp9AJ2K6JeQw/+DYvnBtJQ/0sWg0t6bg8KqDV6KPI 9jD1SQ6y0QdVXwLEngkFKJqU2SUPXtGxqh+TrjoSi0u+VamjdMCsCtJLv80cpJLZePnb hamLZP52pexux6KfagySxsbAJi28aKgF0BfgWAdI4SDqjf507IxKi1ZEdOIIdSEjXSE3 vZvDgb7pOz2XXCv/BwDheVtwcgL/Y/WX5Lr3cgnu3yp1JAKyumvnfM3/7H75bGHoWogo eZPUINnCMJH82kvyOLOKcFnoYIUeBy+joFaS/AumkKP0s8ndkwKwTA4PEhtcvBfZzlVt SxxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Q4Or4P1j8T0NevxsxUtl11eVgTqyt2M4dL8NTcFJ+pA=; b=s/zF4gqQ3wHLPk3cZVs+tkmM6UeOa3+YYluQRbas9qaM7l08M8qMV2ibn+3IRixD4K wTZt38Tuv73+BbLjzhtYvTYPBCfBZ5hWgG6ZZhUOz37fOVIaY1j0s8WeaVlIQMxZhLHZ caWIwqzv8DhBjk00WaVz/zc5ng0OnbbWeEBlqCwHxA024QzTZjz9Yfje9hupQQyYWdnZ L1dTb1XEb/5sK7n5dhJ4tPVCFTlzMcbJfe8EYL/QrdYx0oFLs48/3Kknc9O1/f0S2RQB 35fLDwhFB+wF34BmhM5e+soLypiImo/Su114sbG3Ti2naFE4gA4YfbLPMdRTvHFQrvvK IXmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=ZNHpJMwz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d132-20020a63368a000000b00542ad648fbasi16713942pga.188.2023.06.19.04.31.51; Mon, 19 Jun 2023 04:32:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=ZNHpJMwz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231610AbjFSL1c (ORCPT + 99 others); Mon, 19 Jun 2023 07:27:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229932AbjFSL13 (ORCPT ); Mon, 19 Jun 2023 07:27:29 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CC9F100; Mon, 19 Jun 2023 04:27:28 -0700 (PDT) Received: from desky.lan (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DB887800; Mon, 19 Jun 2023 13:26:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1687174011; bh=Ua5NcitkYLYSqBnLZDqy7P/dMOR9PahCDNt3nwt7wFM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZNHpJMwzDW3Z/m/Niqez8UbbEjXIXS1IOOiQTnROmHWVPt55Owh09Fnz6j/ytirh8 ePGHkqMzS3byVpgXkvJF6NcpS3kxhtDEknarMnldYRYtA6LqlZuLwWOGB3sFlhaJcb WE0zJE+/WWHvQMbci4olFIHpTO3mrfKBxzj16AFM= From: Tomi Valkeinen To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Sakari Ailus , Laurent Pinchart , Jacopo Mondi Cc: Tomi Valkeinen Subject: [PATCH 3/3] media: subdev: Add debug prints to enable/disable_streams Date: Mon, 19 Jun 2023 14:27:07 +0300 Message-Id: <20230619112707.239565-3-tomi.valkeinen@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230619112707.239565-1-tomi.valkeinen@ideasonboard.com> References: <20230619112707.239565-1-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769130503207694633?= X-GMAIL-MSGID: =?utf-8?q?1769130503207694633?= It is often useful to see when streaming for a device is being enabled or disabled. Add debug prints for this to v4l2_subdev_enable_streams() and v4l2_subdev_disable_streams(). Signed-off-by: Tomi Valkeinen Reviewed-by: Jacopo Mondi --- drivers/media/v4l2-core/v4l2-subdev.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c index 73f716a42569..0f86a165b202 100644 --- a/drivers/media/v4l2-core/v4l2-subdev.c +++ b/drivers/media/v4l2-core/v4l2-subdev.c @@ -1977,11 +1977,16 @@ int v4l2_subdev_enable_streams(struct v4l2_subdev *sd, u32 pad, goto done; } + dev_dbg(dev, "enable streams %u:%#llx\n", pad, streams_mask); + /* Call the .enable_streams() operation. */ ret = v4l2_subdev_call(sd, pad, enable_streams, state, pad, streams_mask); - if (ret) + if (ret) { + dev_dbg(dev, "enable streams %u:%#llx failed: %d\n", pad, + streams_mask, ret); goto done; + } /* Mark the streams as enabled. */ for (i = 0; i < state->stream_configs.num_configs; ++i) { @@ -2089,11 +2094,16 @@ int v4l2_subdev_disable_streams(struct v4l2_subdev *sd, u32 pad, goto done; } + dev_dbg(dev, "disable streams %u:%#llx\n", pad, streams_mask); + /* Call the .disable_streams() operation. */ ret = v4l2_subdev_call(sd, pad, disable_streams, state, pad, streams_mask); - if (ret) + if (ret) { + dev_dbg(dev, "disable streams %u:%#llx failed: %d\n", pad, + streams_mask, ret); goto done; + } /* Mark the streams as disabled. */ for (i = 0; i < state->stream_configs.num_configs; ++i) {