From patchwork Sun Jun 18 20:49:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 109680 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2641871vqr; Sun, 18 Jun 2023 14:13:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4TDh3ojL+Z6PS+DmXgIZyw4p0D4WL6g6SMwX0VnJjvPCFPIAiKiHKJDgUZBDqDLb4/5GZw X-Received: by 2002:a05:6a20:1606:b0:11a:8b75:64ec with SMTP id l6-20020a056a20160600b0011a8b7564ecmr5213151pzj.23.1687122790695; Sun, 18 Jun 2023 14:13:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687122790; cv=none; d=google.com; s=arc-20160816; b=F77//A8xicqILBwxXMH20IyXg5U09WTuBS/uBEmgvAJzfMQIj0DLqsHdCnZowK4Cqe rrNNcF4w7YiOuFzgKhbod7asYcNGqA0eafZXx5c98MrqJCteu4iKu9BX7QPPDDZVNGPY 89FqwiqOVQh448bMkLTMXdvxALdy7S58HFchRchyW2YezrMEkQmJ8CPeKXeJQDF3Py5Z tjS4PQpknyiy5s682xQgAqI9ZLO3V+qIw5HmSxqkzbY2bzxL5D+juqP3/8FXiMsnYhkS hy054xCT7mfRxaN4b/DQz12rYs2TmkB9t+WGBUEraldn2gBv5bPX48AjrX5dYVD12mh9 7n+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=3Lnd9I9JfpsOWa3rbGS3GEORYWctuXHXCskeUPz4dt4=; b=SAt36XQAZ5qAtYc+6OtVgnt6OogX46ZjBtklWwnA6vazks3VC8LWz4cB/ku42C4bCP AziwNLXpIVBOGshr4+mTSKGcn5y+btK2KveFmQERC1oHSSjZx7RbIExSXwo50m9mGzaS FoK4yTts5dXU7RrBaWVNnjTOe7vox7vqBbWZTyLBGAQyQzzAPDYKb12K+lnA+TIb6+v6 DWLvuP1P99a492SeMuA3ngwiViJBUppgHJfSAfYpReN9MsadWW8FkLpuYcs5fnhr3Xvu AFWu8HYWWLAv9xK+l231wsXba/oZfj5nXnjN8a0EHTdxbJEh4XxsN/YIorGVZy1H7qFv G6CQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=pB+wX3XZ; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=81sDHcJz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d5-20020a170902854500b001b34159f341si14841949plo.596.2023.06.18.14.12.57; Sun, 18 Jun 2023 14:13:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=pB+wX3XZ; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=81sDHcJz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229706AbjFRUuS (ORCPT + 99 others); Sun, 18 Jun 2023 16:50:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbjFRUuA (ORCPT ); Sun, 18 Jun 2023 16:50:00 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A154DE49; Sun, 18 Jun 2023 13:49:59 -0700 (PDT) Date: Sun, 18 Jun 2023 20:49:57 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1687121398; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Lnd9I9JfpsOWa3rbGS3GEORYWctuXHXCskeUPz4dt4=; b=pB+wX3XZ7u2kTBcj5MVUMuPzoX4CPj6yZgjKjn08nGE9egrPczBOmA4UPxOMbXPQnaf17F 1+QdqHbz3ORU6G+mDOcqNtA4IqLvYf8gl2Jk/iFzE96L7YcKxNFrbH4zctfxwWTM5Qw5cu ln1BXj3rnHQ17dNe8O2QEKjiN+4qev0eC4TRt5BO4MxJT/rVV4BS/h9bWSQV8+iHirDqGg pk6ikPavP6zlrclX9cd5XQ9FQJCW9rDRUN+tIDa7M7zlfLiJ25qCDbCPRYZcwTsX+OAPQE oSBQtLnc/5iXAYshPGL+V7eLvs1LcyjPEGz0LOgeIkzJ5OMQ3HFH4/RJ8406TA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1687121398; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Lnd9I9JfpsOWa3rbGS3GEORYWctuXHXCskeUPz4dt4=; b=81sDHcJz3P01qXX5WcukSc1bK/BSJiVyptYU+amtqGxd1wE3x8x6fgcQgSRHYBuXjDdkvA ocCUMcVITeaEW+Cg== From: "tip-bot2 for Thomas Gleixner" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: timers/core] posix-timers: Clarify posix_timer_rearm() comment Cc: Thomas Gleixner , Frederic Weisbecker , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230425183313.724863461@linutronix.de> References: <20230425183313.724863461@linutronix.de> MIME-Version: 1.0 Message-ID: <168712139782.404.12860532912277348450.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764176023816231112?= X-GMAIL-MSGID: =?utf-8?q?1769076467510464512?= The following commit has been merged into the timers/core branch of tip: Commit-ID: 02972d7955341b711d4c392f14faa9f9cd69d551 Gitweb: https://git.kernel.org/tip/02972d7955341b711d4c392f14faa9f9cd69d551 Author: Thomas Gleixner AuthorDate: Tue, 25 Apr 2023 20:49:22 +02:00 Committer: Thomas Gleixner CommitterDate: Sun, 18 Jun 2023 22:41:52 +02:00 posix-timers: Clarify posix_timer_rearm() comment Yet another incomprehensible piece of art. Signed-off-by: Thomas Gleixner Reviewed-by: Frederic Weisbecker Link: https://lore.kernel.org/r/20230425183313.724863461@linutronix.de --- kernel/time/posix-timers.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c index c8b0f52..d8d2169 100644 --- a/kernel/time/posix-timers.c +++ b/kernel/time/posix-timers.c @@ -275,15 +275,9 @@ static void common_hrtimer_rearm(struct k_itimer *timr) } /* - * This function is exported for use by the signal deliver code. It is - * called just prior to the info block being released and passes that - * block to us. It's function is to update the overrun entry AND to - * restart the timer. It should only be called if the timer is to be - * restarted (i.e. we have flagged this in the sys_private entry of the - * info block). - * - * To protect against the timer going away while the interrupt is queued, - * we require that the it_requeue_pending flag be set. + * This function is called from the signal delivery code if + * info->si_sys_private is not zero, which indicates that the timer has to + * be rearmed. Restart the timer and update info::si_overrun. */ void posixtimer_rearm(struct kernel_siginfo *info) {