From patchwork Sun Jun 18 20:50:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 109672 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2636466vqr; Sun, 18 Jun 2023 13:58:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5CqGZn2zX6ZOxzCET1i0bLo/TDvImljEHDHXDROpWIRoM+3fAfsxWwE5C1hDALqOzDNSBQ X-Received: by 2002:a05:6e02:102:b0:341:d9e7:9d88 with SMTP id t2-20020a056e02010200b00341d9e79d88mr6532661ilm.11.1687121907454; Sun, 18 Jun 2023 13:58:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687121907; cv=none; d=google.com; s=arc-20160816; b=y87pYEgsKincZiv6b9DRQCT+SpthbP27Q1c3WFIfcuUND+wk8z0pkcJt1PM8XP9f+O Z1zBH8IjB5ZPIITQUtCQxpU75eXSYGv+08CNppc6sw67zSSleHXr5LmiqEKcFbHt8nlD 8EHucLbWX9c92YE2BEiKIIvCcpNThMhrjlzq1D9oDcko4raG/XrRRs3zMDyd/k9G0h+M Ksi2OQqX7rL5eKowjxib+JBbY9ek+f9pnKBL3t8Mf/nLg03AehNkfs5Rixm9gJpTwmH9 mY6DnWi2ZLYeTQG2rLpZFCUQfhKNcmqWx7I56MI+O4IHTDOSwLwIkpq1tn/slOw2Ii4z UGjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=5+A7Bi/X2n8XHhjnVYrS8ebBzftUu/YIL7YEonpKXCY=; b=tv8oFxdZhi91UDfCIxSZdt9kumU7x7NSOYSpi9VaVH2vVQapIMLgzjrXF8gNQyjpk7 6jzbb+bLQHJCi3EXRKR+dCskQfyTCapaisD9QVFHE2aqXVpHDdL+xoeYLoapnSf221D1 wcGxPgzVboKr9Hayn79M1yX7ixLen/tUc7Qs8jO9afjfjOIZOdrAZlcQdl6bCIcNmT1N J0A2hpfRK6zeEZU5I+ehw6jwDR3Oms0j9oEppJOO7hixgJjeCLw14SQ2Cl4uovlXEGLL CgkKDZNdOrndtpcZeKmwSkBUrhziTFqIQSDzrvmDlIx57Y+/E2Tyae+ErSZtbrbKYsa9 iXgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=L1Uw9LA8; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=mrPnrVPA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j16-20020a170902759000b001b5553bf6aesi2273331pll.78.2023.06.18.13.58.15; Sun, 18 Jun 2023 13:58:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=L1Uw9LA8; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=mrPnrVPA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229802AbjFRUux (ORCPT + 99 others); Sun, 18 Jun 2023 16:50:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229631AbjFRUuI (ORCPT ); Sun, 18 Jun 2023 16:50:08 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D4BEE5A; Sun, 18 Jun 2023 13:50:06 -0700 (PDT) Date: Sun, 18 Jun 2023 20:50:04 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1687121404; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5+A7Bi/X2n8XHhjnVYrS8ebBzftUu/YIL7YEonpKXCY=; b=L1Uw9LA8kg+l3i0VbY1Psw+zipWiLXEZcUPuE0qvrCysLyPdjlk9ZFNNnXscICsZ1HcDKY ojfjKsdNFUjlZYRYvjSxBdWs+LRvBBXdp/kPX5baL7BJDFIdrkH7iYhyE4p7011YAfzqFA T3oPyioT2qATp2DgLB+ZFndO5xcx7/Scsvy9yMs0GGe3hhboywQSoVcLTJA4Aq7RnmO/Fl hKEVH0RWEsqPVzVelV4J54Ine20xtiGS+78W/1KkoS797Mgomdz3wVeFlB0cbOfOSoWz30 SEohsn2NLm3LScj2DwPPJBQoSW0pvOCPxbTHwXXZlh+wLIkeDN8hAtAhQDsT1w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1687121404; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5+A7Bi/X2n8XHhjnVYrS8ebBzftUu/YIL7YEonpKXCY=; b=mrPnrVPAqHepILe+NjTTk1iQKQzlRR0FKbytVtA2nSUQF2kSbTsOhrnf46tbgMDwtYEswe Vyjy/W8GenOyw+Cw== From: "tip-bot2 for Thomas Gleixner" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: timers/core] posix-timers: Remove pointless irqsafe from hash_lock Cc: Thomas Gleixner , Frederic Weisbecker , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230425183313.249063953@linutronix.de> References: <20230425183313.249063953@linutronix.de> MIME-Version: 1.0 Message-ID: <168712140425.404.12496348784303071442.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764176018549232911?= X-GMAIL-MSGID: =?utf-8?q?1769075541379191350?= The following commit has been merged into the timers/core branch of tip: Commit-ID: 11fbe6cd41210c7b5173257158a22e11e225622d Gitweb: https://git.kernel.org/tip/11fbe6cd41210c7b5173257158a22e11e225622d Author: Thomas Gleixner AuthorDate: Tue, 25 Apr 2023 20:49:08 +02:00 Committer: Thomas Gleixner CommitterDate: Sun, 18 Jun 2023 22:41:49 +02:00 posix-timers: Remove pointless irqsafe from hash_lock All usage of hash_lock is in thread context. No point in using spin_lock_irqsave()/irqrestore() for a single usage site. Signed-off-by: Thomas Gleixner Reviewed-by: Frederic Weisbecker Link: https://lore.kernel.org/r/20230425183313.249063953@linutronix.de --- kernel/time/posix-timers.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c index c1b77c5..ed7d260 100644 --- a/kernel/time/posix-timers.c +++ b/kernel/time/posix-timers.c @@ -471,10 +471,9 @@ static void k_itimer_rcu_free(struct rcu_head *head) static void release_posix_timer(struct k_itimer *tmr, int it_id_set) { if (it_id_set) { - unsigned long flags; - spin_lock_irqsave(&hash_lock, flags); + spin_lock(&hash_lock, flags); hlist_del_rcu(&tmr->t_hash); - spin_unlock_irqrestore(&hash_lock, flags); + spin_unlock(&hash_lock, flags); } put_pid(tmr->it_pid); sigqueue_free(tmr->sigq);