From patchwork Fri Jun 16 10:31:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 109034 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1256434vqr; Fri, 16 Jun 2023 04:06:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7rpN3GVwc2xjqfjNja4qYkheMTJMfqtFM6yK5IhOUklGI7uokTOnOCmVNmUVJc/wjXvvp3 X-Received: by 2002:a05:6a20:2d25:b0:10c:5745:3f44 with SMTP id g37-20020a056a202d2500b0010c57453f44mr1654523pzl.61.1686913600051; Fri, 16 Jun 2023 04:06:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686913600; cv=none; d=google.com; s=arc-20160816; b=qtFgoYLv+S3W4jeaPPBjFnavrIzUOwZ85tX1HcEwkXpH2rmybOGzfiZcZb9UiNg6Yx zN1/5ZIWn+KoGjbP44m8+w1xThf/zJeY0Fx/urSW2YvuSRhzlKkxIWvKnrA0lbLcv+9F GPmjA0FhskgDJFzQMznqPIqKKT0KPf/iu1MbY0Y+0c+sYdhjU5cGPG0bob42HxNYpHii OtE/SG72UaNkaufK7v5kXmJUh+KnRiqSCKqyqe1xDiRGL3lHj09UZzehQaS1ro+R2Dyc 6LRZRW0ZtXRy/cB7jGK8CAEQMQaRO1MASMXdBNLFU+jGMgLA2ha7JK7uVURqg55X6lG1 OvOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=l7UUUCEiDOQDFLQBmgYOU/VRB87rfpeTkrh78SXewlQ=; b=nwVtIU7XjxaxvI9fQQQREAsauXmoR2uxCoRpqRGqvUtbdI2Ttj8K/UByN1lx38sSiC JsHarOw3rySHqQSLUGFdv6C2DixlK5sluANKbZl+c/rGVUF+j8Ew0hqU6rNchY1VFXiM BZZ36GB6WVIfm9S501FCBRBKjfVRWqWIFMjH7i7+LhCJ5dlf8wTXNLQEySb4EAS0Fqui AqEMUa54c0+tj/mTQgM8y+0LsIbvM0+VnHIhgBYRrNF8QAHCuBT++3GB89pCapl6ahj9 +cLD7gYrZ9t0j8LWQCA3JgnPg3mdjWx/L2Kg2iBcsg/48HD9um43iRUDK4lBJNIpH9Dl /4Jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="d/HoqkPN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n14-20020a170902e54e00b001a51c26f601si15281980plf.627.2023.06.16.04.06.24; Fri, 16 Jun 2023 04:06:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="d/HoqkPN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344942AbjFPKve (ORCPT + 99 others); Fri, 16 Jun 2023 06:51:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344895AbjFPKvS (ORCPT ); Fri, 16 Jun 2023 06:51:18 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BE9A5B86 for ; Fri, 16 Jun 2023 03:43:14 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-31122c346f4so270166f8f.3 for ; Fri, 16 Jun 2023 03:43:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686912174; x=1689504174; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=l7UUUCEiDOQDFLQBmgYOU/VRB87rfpeTkrh78SXewlQ=; b=d/HoqkPNJhmfrZK92gGm3XCSxr3gRxMKmYS1pBA3mH4DonHRJxzkoCjrNHzbFM3Xkh 4r+gd1AQ4E4rtecdZB56qSPEKlSoUAAbD4Zpv0SAQM7DLOp/AuulZmQJjWW3mFqBIL+M 8AD0YD/y4kzGuuT2UG6nWYMn3CFlHQKkW/nw/qMoritzMdZK9LxLM3ON7OSP5s0sCtTJ QOYWzIfYFk3xavNfKs5z3NoWeep1RoeML6N6+PLwGZjg1X9yFBv22Y2LeBeegHvYpMT8 ltQv1plpsh5ZqungEDhdA1vRxgdPQWGAtUv+ZlprMp1jIHGRVMbiG06t4Y6MEQuwbLU6 JIEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686912174; x=1689504174; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l7UUUCEiDOQDFLQBmgYOU/VRB87rfpeTkrh78SXewlQ=; b=bHOMWgLESvvkM4JjbGmlkFMXu6bpLaKBuNHyISXVlxD3uQ64scFOq5wpcJ/sctCIZC VuzYwYVIWUDS6Oq5qFf7mpr/Ib9a3MI8xcNer0CEs81U2A0HKtSkrr2pMjf8EOSBJdwz xGCE5bGENH1Ns5C8A5p4EqLqhL9JhAUo5bMzO+vTvIpaO6tvBdpDxqufPCQQF2rVExiB Zff/7nlulXZtdKRfakGanqNl/R78E3EbcKgijrBf9Pievvt57HED+BTddCTlg8VaJ6bF ylQPo7inlN33UVmq2VbdJ/GovzlhgWCf0MMtnL7ReAprakgOouVY1zQj1TLldEWo4oOl d22w== X-Gm-Message-State: AC+VfDxby7TLv2Lehn0nKeOyoRQQzNQWnOB/PTtOvCC7aBYTwodbSIc7 shQWhmPta5xJNm8PiVktApbl+FfqyTiwMwzFh8M= X-Received: by 2002:a17:906:da8a:b0:96f:e45f:92e9 with SMTP id xh10-20020a170906da8a00b0096fe45f92e9mr1493906ejb.16.1686911495167; Fri, 16 Jun 2023 03:31:35 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id s20-20020a170906961400b009829d2e892csm2251098ejx.15.2023.06.16.03.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jun 2023 03:31:34 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 1/2] stmmac: dwmac-loongson: drop useless check for compatible fallback Date: Fri, 16 Jun 2023 12:31:26 +0200 Message-Id: <20230616103127.285608-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768857115045811352?= X-GMAIL-MSGID: =?utf-8?q?1768857115045811352?= Device binds to proper PCI ID (LOONGSON, 0x7a03), already listed in DTS, so checking for some other compatible does not make sense. It cannot be bound to unsupported platform. Drop useless, incorrect (space in between) and undocumented compatible. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Conor Dooley Acked-by: Jiaxun Yang --- drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c index a25c187d3185..900972521b59 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c @@ -59,11 +59,6 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id return -ENODEV; } - if (!of_device_is_compatible(np, "loongson, pci-gmac")) { - pr_info("dwmac_loongson_pci: Incompatible OF node\n"); - return -ENODEV; - } - plat = devm_kzalloc(&pdev->dev, sizeof(*plat), GFP_KERNEL); if (!plat) return -ENOMEM; From patchwork Fri Jun 16 10:31:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 109032 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1243167vqr; Fri, 16 Jun 2023 03:46:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ41OZ0Z7AQHWsn0Oggc6GR6UTYNf45+kpy1aPPGZp6QWu91HAUc19/QZqMBEVc8HmHqUNuF X-Received: by 2002:a05:6a00:3926:b0:664:9579:d31c with SMTP id fh38-20020a056a00392600b006649579d31cmr2188330pfb.8.1686912396047; Fri, 16 Jun 2023 03:46:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686912396; cv=none; d=google.com; s=arc-20160816; b=Xf4PhnUEA58gZt14PWazrnRYw4wWslR9sgTV6WViU52R4+IjxU/weu5d5sJxfs4LgO +cYYP9qoinv8c9X3vUjeogH/HYtBvscsadUMka//D+jqfAGWIF/flPp6IixFJDKkT8de IBj9GDtHol0QRWs9KkIaxPU79ST4sqrP4GnNk3ScGg08jAqX3xEYF7+V6xMvXQsshbdc bDiDJys6pZiJ8fsc2JXpf+5Q1hNjIbxpygHFTLXRqGaZImZw77Ab4VP0lCKYwDnJevox 827jaR134RcEiBzbimbfieZTwBZDvDoMsGFUEhW1ufNwKxlXKTDvCiYJgDljbksET3eT IA1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kaBTG2zxwhnxmGeWEEvsgJ1P9b9NURsoufZiPInkKEc=; b=ZBUgVWpGlKyFMRpECOq2S+XVfApu/uM175nUt0YvfdCJ+Sd4wFxmJqLrCgeP+ZKaEb TdQjffhP0yB1c92C4BX5Nq4DEB9DU7/X7//2E6GK0p2xOooV7OWQA3vrgExlqthvd8tk aEmzFFwH+pjfutQkU68lJsVrJMP6INkihjgIGSpJe9BTtF6keLE+HaQMSYRz6h/tPoCq kJA1AALw++nLlPyevk/8f57GMztVZHUyo6wlL1QmRP7XUlEdCMfoC3yfGNWM6AwQhTeD bIodPNT5ZaXrFhCtuVdIvoQWFdU64ZHW+DsQBQu7i41oh8j6+kd7vaRElf8026u4gDfk Yiag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=h9v9BsnM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b3-20020a62cf03000000b0064354230c2asi686282pfg.367.2023.06.16.03.46.23; Fri, 16 Jun 2023 03:46:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=h9v9BsnM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345373AbjFPKlQ (ORCPT + 99 others); Fri, 16 Jun 2023 06:41:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345932AbjFPKks (ORCPT ); Fri, 16 Jun 2023 06:40:48 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF5DC4237 for ; Fri, 16 Jun 2023 03:32:46 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5149c76f4dbso712159a12.1 for ; Fri, 16 Jun 2023 03:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686911498; x=1689503498; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kaBTG2zxwhnxmGeWEEvsgJ1P9b9NURsoufZiPInkKEc=; b=h9v9BsnMb8Bf3tOsibIfWu1YRF7sqKDKvcliKPiGOhQm9d+yURo0wcCeqd+DmQDhKt HQxtH4w/UDkNR6lgDkzs6RpPodbxsGvG8XQItKw1Mgb2BcNW4BaV6fqdWsS6SGYURdCw KCN8VsLvFKkiBuea1lWMUMpFFkdOyzYqJ0nWTvNBytpmZ6IFN9/WVZqW3V68LdJK4/zM RguwkU1YaZdt+C9D5w0L27ABoizLpwuHYr8gk4JXNooSpONL5bmv5y86Q1x4G82NSJUm ZqBCrP4sRfEIx/ELuTZtkaK3hZr2nWpTGQVO/4ooNGnI5KSbsK7aMWN0NedI3iV46wow O08w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686911498; x=1689503498; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kaBTG2zxwhnxmGeWEEvsgJ1P9b9NURsoufZiPInkKEc=; b=ffKHFBfEnEeZ664P7wLb+KoX4PelAH+NtPh3obkk7xaaiCwohmhjblwRv/rT8Lfsnr 9XcSj4QrCeSMRPVpB3+fKQ3KXI/WrsoYzSnXbjTEeHyOdmtyB5+Rsvnu5074AgAPMA3l UuQXTWOhwuRF8LX4Sbu4SnN2FpR3CQyj8e0IZClbysS5dheEU4m0tAcD65lZfqCHCvRG GTYDONYnzQMYGjuYvvwTBS8R4T634rcnEXOg1sua6l3T7nvHCFzt8MTVQQQF3TqYli1W cYYW8lPI/5t613+4g6lwDkwvZ0ydhuGfu8ZWIUYNg3tMXw61DyAYt90lTi82fPyOglvf NkYg== X-Gm-Message-State: AC+VfDxS/GVHb39yc6oECXxOaGAG7CqtFNLLCh1LjrYZZa3f+84N+Ev5 1Bqou+9mI27wTBzNlHokD8h5eA== X-Received: by 2002:a17:907:6ea4:b0:978:94b1:25ac with SMTP id sh36-20020a1709076ea400b0097894b125acmr1625268ejc.40.1686911498060; Fri, 16 Jun 2023 03:31:38 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id s20-20020a170906961400b009829d2e892csm2251098ejx.15.2023.06.16.03.31.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jun 2023 03:31:37 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 2/2] MIPS: dts: loongson: drop incorrect dwmac fallback compatible Date: Fri, 16 Jun 2023 12:31:27 +0200 Message-Id: <20230616103127.285608-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230616103127.285608-1-krzysztof.kozlowski@linaro.org> References: <20230616103127.285608-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768855852466933639?= X-GMAIL-MSGID: =?utf-8?q?1768855852466933639?= Device binds to proper PCI ID (LOONGSON, 0x7a03), already listed in DTS, so checking for some other compatible does not make sense. It cannot be bound to unsupported platform. Drop useless, incorrect (space in between) and undocumented compatible. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Conor Dooley --- This patch depends on driver change, thus it should be accepted a release after the driver is merged. --- arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 3 +-- arch/mips/boot/dts/loongson/ls7a-pch.dtsi | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi index 8143a61111e3..c16b521308cb 100644 --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi @@ -123,8 +123,7 @@ gmac@3,0 { compatible = "pci0014,7a03.0", "pci0014,7a03", "pciclass0c0320", - "pciclass0c03", - "loongson, pci-gmac"; + "pciclass0c03"; reg = <0x1800 0x0 0x0 0x0 0x0>; interrupts = <12 IRQ_TYPE_LEVEL_LOW>, diff --git a/arch/mips/boot/dts/loongson/ls7a-pch.dtsi b/arch/mips/boot/dts/loongson/ls7a-pch.dtsi index 2f45fce2cdc4..ed99ee316feb 100644 --- a/arch/mips/boot/dts/loongson/ls7a-pch.dtsi +++ b/arch/mips/boot/dts/loongson/ls7a-pch.dtsi @@ -186,8 +186,7 @@ gmac@3,0 { compatible = "pci0014,7a03.0", "pci0014,7a03", "pciclass020000", - "pciclass0200", - "loongson, pci-gmac"; + "pciclass0200"; reg = <0x1800 0x0 0x0 0x0 0x0>; interrupts = <12 IRQ_TYPE_LEVEL_HIGH>,