From patchwork Fri Jun 16 09:09:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 108963 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1194585vqr; Fri, 16 Jun 2023 02:24:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4kbOYNiD3Kr3aC7xn+ESEjNGaBOYIAU5T3ispv+47Zf59lzihRlSDozgjQx5KBEtTIXZZt X-Received: by 2002:a05:6214:1303:b0:626:2bf5:d532 with SMTP id pn3-20020a056214130300b006262bf5d532mr2295221qvb.14.1686907446484; Fri, 16 Jun 2023 02:24:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686907446; cv=none; d=google.com; s=arc-20160816; b=qD//lVa/H3zUmkos3pqOwaC/JOZiw/QaraRP5B/QRg9HZKJob2e/uEf/YPhW6rql5N PMWQ/+Gt9UJTPe7GeCllNurCBvKu2e6kNWHV+C55Z1zSoE9ZgwJASV1oit75WLjxbhdK r0Y/BOoyPU44fVQ/UyH3DEGgJinm93ZCaOAMHd9LAALPfsbQfrjEylIgf/9kHsfBr/Nm SO4O/CBz8zSk4nOvDbzVrM3hYQSrl1UtQXH0kNFldOTVXTF5tNMsWsI5+8z+mUnTFqib 0jFD20wdmf2b3ueqvw1mGqWrxoZVuYcrjHCZ+AiAbZb9o+3suAul6aQECgOPbj2MO8QE OjzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=C7Z20wFC8tO2EjyBMWHNoOemFqXs3fItEOhxthc/0uk=; b=FGMkOI3lqj411v6U6MMtuadr7lcaNlCLH95ufxYuME6MkgqbJPR/7wx8kicutHapf2 eQ7hjEdvmekuU8DdsgrzAGQ5lBQolhUr+n6LbeazkRZECS3wZExKdkWqpZCj68sCuCSX fAJGOPoNPkSrjgaUKbLbshZh0b+w3Sj60K4lFs5av91ykRmw88oxFHtqqv/UlQaQP2AS VG18wJg5uuEJ1lPKOr19ntTt5+ln+3ipy2xtq+fmMDmc86WMp0KM03QcWtKQpfhIxYPr LTPDA2Sw6CIc+B5/VypTWHcaGe/UKkvmyZa88C/CZTUxmK9EVrNMwU7iA9R68EoYpUu9 fvQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YYX3cJ4i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x12-20020a63b34c000000b005428e6564e2si11984760pgt.245.2023.06.16.02.23.52; Fri, 16 Jun 2023 02:24:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YYX3cJ4i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230149AbjFPJLg (ORCPT + 99 others); Fri, 16 Jun 2023 05:11:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344095AbjFPJLN (ORCPT ); Fri, 16 Jun 2023 05:11:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F2AF35AA for ; Fri, 16 Jun 2023 02:09:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 157BD61199 for ; Fri, 16 Jun 2023 09:09:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2457C433C9; Fri, 16 Jun 2023 09:09:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686906578; bh=2YXvEte0tHvF2Un7MoBdoKftmOVsekrDTNUHt5cOEDI=; h=From:To:Cc:Subject:Date:From; b=YYX3cJ4ianisLazJgdikgP155Wib9XYqSbKA2QwXMR7ujm8QXtx7Favmp76BalGzh up411kYjoZn7deAEgja1U0Q80VurO5KBOm433islAMN8gbElUJbxwlTDMo4Ah3Hovz KHsVggBR5LThQvatMUAVD0FUCQOSaUsqwJt1qfmsvbkVCjFG/WKlx9MiKo4kDOJnI5 4wouy+SJgmpM3u54ID5lTz+I6w+DjHOGQLszNQFdPCQOGy0IAKN7MuAujk9kxJzOcm TgyqxIwvIpwpk1zSh0hEKRl5M60EuRlZdSaEhP7IJ4xrVtCKjtzxLAEMHFFPdZ3f7H XNYGbDcwfG8kQ== From: Arnd Bergmann To: Vinod Koul , Bard Liao , =?utf-8?q?P=C3=A9ter_Ujfalusi?= , Ranjani Sridharan , Pierre-Louis Bossart Cc: Arnd Bergmann , Sanyog Kale , Vijendar Mukunda , Rander Wang , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] soundwire: intel_ace2x: fix SND_SOC_SOF_HDA_MLINK dependency Date: Fri, 16 Jun 2023 11:09:24 +0200 Message-Id: <20230616090932.2714714-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768850662402545314?= X-GMAIL-MSGID: =?utf-8?q?1768850662402545314?= From: Arnd Bergmann The ace2x driver can be build with or without mlink support, but when SND_SOC_SOF_HDA_MLINK is set to =m and soundwire is built-in, it fails with a link error: ld.lld: error: undefined symbol: hdac_bus_eml_sdw_wait_syncpu_unlocked >>> referenced by intel_ace2x.c >>> drivers/soundwire/intel_ace2x.o:(intel_link_power_up) in archive vmlinux.a ld.lld: error: undefined symbol: hdac_bus_eml_sdw_sync_arm_unlocked >>> referenced by intel_ace2x.c >>> drivers/soundwire/intel_ace2x.o:(intel_sync_arm) in archive vmlinux.a Add a Kconfig dependency that prevents that broken configuration but still allows soundwire to be a loadable module instead. Fixes: 4d1e2464a1104 ("soundwire: intel_ace2x: add sync_arm/sync_go helpers") Signed-off-by: Arnd Bergmann --- drivers/soundwire/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig index fa71c9a36df7a..4d8f3b7024ae5 100644 --- a/drivers/soundwire/Kconfig +++ b/drivers/soundwire/Kconfig @@ -37,6 +37,7 @@ config SOUNDWIRE_INTEL select SOUNDWIRE_GENERIC_ALLOCATION select AUXILIARY_BUS depends on ACPI && SND_SOC + depends on SND_SOC_SOF_HDA_MLINK || !SND_SOC_SOF_HDA_MLINK help SoundWire Intel Master driver. If you have an Intel platform which has a SoundWire Master then