From patchwork Fri Jun 16 08:55:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mahapatra, Amit Kumar" X-Patchwork-Id: 108947 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1184717vqr; Fri, 16 Jun 2023 02:02:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ71zajs+uG1be6xnNSOCQs9Tp13fiEAVrMSVA/bhjEWo/q7XqxDny1Gc5nvWbCsZFdt3kjx X-Received: by 2002:a05:6359:282:b0:12b:c8d5:f10b with SMTP id ek2-20020a056359028200b0012bc8d5f10bmr818919rwb.29.1686906135015; Fri, 16 Jun 2023 02:02:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1686906134; cv=pass; d=google.com; s=arc-20160816; b=aHTYyafW7KlyjdZOuLf92HJjLd1KBrcWoNxJho6XacnW/K6ezUUwOmtcisXe/p5sEh Xu1GM1avWjCfJbX06mLBKE0BgNbVrFuBeXcRDRgIwgPOrxndRWJ0IvzYT5JGpVeKI+Pr /KonU7dlKNCg7RH2tWaeleB/YLCBJehImO9TmS9g9iklIC0Ktg/wretJ9vRqSkBaQEXk +gww4aI0XQo/q5ix28JEiw8KMiS1T8aU2tX6XMgJ8jsY5ByKqgDv/x4yzRzmLuweKBVO oxH2b40Pfz91NBzKCBkI0NLg88wrsHkFliT806UYpBkgg8TCUmhZIG9b9xJLIfz49feA 2hOw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=eTR6TjeDspJmp5Fo9pYiiKi+3nOC4nkqCcykXGpJGp8=; b=UxQPcwtsWcpS7fOxEAwkVsut5ceyKr2BajpfORpYdjR+PgwtkF/VBb4dJlB221vQqv /YNjmcv351VPHQNQUVd3gtZWQM6L3KNdsgNNf22NW/RiUct7QIGg6FwCqUaExeNZPEft ZtFg+WpnehVBxTWnHVC1jlyFNNvpIUF0phVZXIRT3jVpSxCHheDMiuaPpkesBcpWEkQo wQJtI57vj+3b2uevwstd+T4PQbqr+sW5jsJ+DrcXwdTpZX1zrbBMXvCSZYvklaq0rZBo UXucsIKmX4mBf+Seju0jnWPWIPK2/vjOQbIZKby0OZLn8WAh7Xbe+toY5OKccG90ecwG HvLQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=q39AeUUm; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c5-20020a6566c5000000b0052cb473f95esi14395886pgw.214.2023.06.16.02.02.01; Fri, 16 Jun 2023 02:02:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=q39AeUUm; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244069AbjFPIzv (ORCPT + 99 others); Fri, 16 Jun 2023 04:55:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244839AbjFPIzd (ORCPT ); Fri, 16 Jun 2023 04:55:33 -0400 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2069.outbound.protection.outlook.com [40.107.93.69]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CEB830E5; Fri, 16 Jun 2023 01:55:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d9th9zGJp0pah9OMCdRs43cJmrwR4q4U296q/6pD2pihXrFs1a3xH/0qrOD3IjyH2uJ8+Tjvrj+qaQ8GrS66+FrIYndO1WblTtMRepSjVsI2Z9RW0B3gWDczOEixq68oL+YfT1lxeNZt1rH0HlDuX6ilW9Vk+/WmBzolPCTHW4Re9reOiK5+IxX/YzaTtkrJ7Mj2t75lBeYGqkesFfsAadnuYAzH3Q3k30L9C8RN/Bp7Z5aZq5c/EkJTDAz/me+e74yXhj4EWowY6yZEow6uBusGpgZbelrmEwlL/rjW9tOlPoysYSyHBdZA89MPrrcGHvJX8Qk2a1+UpVleyyil0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eTR6TjeDspJmp5Fo9pYiiKi+3nOC4nkqCcykXGpJGp8=; b=WN7frlfvDPsovDsWXYw+e5L81gwWJbWU4mw5KYxSCNNiB7kBB43senLKGsnxPpKFj+RQKtf2hDW8nYDM9Gm/gLH9KcOilwKbCYIJx34OEGIZsW72fncJW7xjxqe+GjOT2d64IYaw5agHARXpp2nf6KiPQKr4kZtEFzD17p7g/qXoBbgknntpe19MxC81NKZPRJRigJTtforq4/KfQ2zdY6EVHhAx960qnrSAI3Grayvv9GsPnb9zwtosIHlsjznThwZgRD1tqPDduBm3s6hP9qJvz/mas3sPgMiwdiNhrtJ1Q65ITApstHL72w2xxrDDe5nx+8JieM5x553s+n03WQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eTR6TjeDspJmp5Fo9pYiiKi+3nOC4nkqCcykXGpJGp8=; b=q39AeUUmZdIoXniJCZihSYuz13sypSYybUqVISIqBxTCaqcq7ba0dmBRgEPzBeEQa0reDhZ+ZFdqafSJUg+158rNzR/SflN775gqedQgj3BFdOJtOu9ltCgBrluSNXY4mbJUpV54usjTbssK6VzJ7PijTwJishpROlrE2eiqiAA= Received: from DS7PR05CA0062.namprd05.prod.outlook.com (2603:10b6:8:57::8) by DS7PR12MB8229.namprd12.prod.outlook.com (2603:10b6:8:ea::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.29; Fri, 16 Jun 2023 08:55:29 +0000 Received: from CY4PEPF0000EDD6.namprd03.prod.outlook.com (2603:10b6:8:57:cafe::a8) by DS7PR05CA0062.outlook.office365.com (2603:10b6:8:57::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.12 via Frontend Transport; Fri, 16 Jun 2023 08:55:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000EDD6.mail.protection.outlook.com (10.167.241.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6500.22 via Frontend Transport; Fri, 16 Jun 2023 08:55:29 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 16 Jun 2023 03:55:24 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 16 Jun 2023 03:55:23 -0500 Received: from xhdakumarma40u.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Fri, 16 Jun 2023 03:55:19 -0500 From: Amit Kumar Mahapatra To: , , , , , , , CC: , , , , , , Amit Kumar Mahapatra Subject: [PATCH v2 1/2] dt-bindings: mtd: jedec, spi-nor: Add DT property to avoid setting SRWD bit in status register Date: Fri, 16 Jun 2023 14:25:12 +0530 Message-ID: <20230616085513.17632-2-amit.kumar-mahapatra@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230616085513.17632-1-amit.kumar-mahapatra@amd.com> References: <20230616085513.17632-1-amit.kumar-mahapatra@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD6:EE_|DS7PR12MB8229:EE_ X-MS-Office365-Filtering-Correlation-Id: 815ed521-7859-49f6-0371-08db6e476f6d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kR4E7+pN9e2u7nWFPksyWaE368X/cXebXm8HFDwKOzZWQGSgHFzaRHQAdpY+JxotX6h+PaUMNR8Yns0MtQdXkfDQOXHN3U9SD4meWdbowFt97NOOJe5sJcuyq8fVRy7ConMznn0pN+Xm16SVLngusrJHNkinEC0OBcVFcPjdXKr2bVi3oAPvhdzD3i1vBakNwlrxUgL4D8E2EEgOObMDdfLaB/7EE3fZoJOEhqh4Um0vahzt1ppFxqObOhho8cuLK1GWdyQ5oUumldqUz7tLMJ5TnUAOSMt7OLpawMtwEiPIwwlBahBWDhE4T84Ge92IbHJCqKSLeRKBgbYXoOjV0pV0Pw6IRlfievn2s8mt5YvqIt8rQlc9jBrmyMsuSKLBbhP7hz896S5tzwmeGf0NzwsLJsZOUlZRI1Qu4d90ClItW5/6DyEWqVv2FfbURLDHaQ1wyPO6jJae7GBhYw9V9aLyF7gYle8xwhJ0YbPGcQeQXaSJ4dvtw9A6BFFTnbJuYxDyQgP9kraO2nVuDL96sbrbV4v8hysUjuZQzbvn6oEeJ5/joVfdkbm8kFSlnVeU0ZO+36otGrF7j+U/s8I5BuGsOBn6TTYWImxWoL36lFhNOip+RpILr9N9cMIXUDXB6pESjiaMcTqgI86Fqil2BOK0s0KeATD9DdoKr9Xi/YK12UPUPhC2fiHdTBoDt3DGrZlOshqk7Wmqv9b2CWGDyzy5Y5VX2KbsZWIND9K+YWJjBW95siYDHdzxOIdjZaaJAVPFyX97LBAWOzN52ojVZw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199021)(46966006)(40470700004)(36840700001)(1076003)(26005)(4326008)(316002)(70206006)(70586007)(36860700001)(426003)(2616005)(47076005)(336012)(186003)(6666004)(356005)(81166007)(40460700003)(110136005)(478600001)(54906003)(82740400003)(40480700001)(7416002)(8676002)(8936002)(5660300002)(86362001)(82310400005)(41300700001)(2906002)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 08:55:29.3112 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 815ed521-7859-49f6-0371-08db6e476f6d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8229 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768849286961742350?= X-GMAIL-MSGID: =?utf-8?q?1768849286961742350?= If the WP signal of the flash device is not connected and the software sets the status register write disable (SRWD) bit in the status register then thestatus register permanently becomes read-only. To avoid this added a new boolean DT property "broken-wp". If WP signal is not connected, then this property should be set in the DT to avoid setting the SRWD during status register write operation. Signed-off-by: Amit Kumar Mahapatra Reviewed-by: Conor Dooley --- .../devicetree/bindings/mtd/jedec,spi-nor.yaml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml index 89959e5c47ba..10a6df752f6f 100644 --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml @@ -70,6 +70,21 @@ properties: be used on such systems, to denote the absence of a reliable reset mechanism. + broken-wp: + type: boolean + description: + The status register write disable (SRWD) bit in status register, combined + with the WP signal, provides hardware data protection for the device. When + the SRWD bit is set to 1, and the WP signal is either driven LOW or hard + strapped to LOW, the status register nonvolatile bits become read-only and + the WRITE STATUS REGISTER operation will not execute. The only way to exit + this hardware-protected mode is to drive WP HIGH. If the WP signal of the + flash device is not connected then status register permanently becomes + read-only as the SRWD bit cannot be reset. This boolean flag can be used + on systems in which WP signal is not connected, to avoid setting the SRWD + bit while writing the status register. If the WP signal is hard strapped + to LOW then it is not broken as it can be a valid use case. + reset-gpios: description: A GPIO line connected to the RESET (active low) signal of the device. From patchwork Fri Jun 16 08:55:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mahapatra, Amit Kumar" X-Patchwork-Id: 108942 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1183826vqr; Fri, 16 Jun 2023 02:00:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7leACKLPlfSDX2SSZ6RZXS17eBu9R2JmKdFW7pAXj7ctKiY1SmIcGQrlPEmlX/faRRVm4E X-Received: by 2002:a05:6a00:1789:b0:652:7b99:df30 with SMTP id s9-20020a056a00178900b006527b99df30mr1755486pfg.25.1686906053113; Fri, 16 Jun 2023 02:00:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1686906053; cv=pass; d=google.com; s=arc-20160816; b=Ke+pO3hrxc9CEtt8cV2rMTzt4e31Erc+OZfV1jBSw3/L43ZvZMOWWVRUwoh9oZH4kw atX6NUUs64XkAQDL8RWVP6bGczU0TbVHdyZ1gGRMOBqO+sx7M/wQ6KtCkfM0++bFdzBJ vgxIu+XT7og6FPAfQJE2z+gjHmVk5TH8GMz1bDbfxSwIxzKzysBKn51zjZuZPmsyYLTk I4EPEmw5F4BVRyRhFt1esABXCvjk0cA7iHQtHqCIubzwXsPGiPkxBoqAU8lLwY6wOM0B W6c9dXwDKMrmIELzfKDzpoFTqJRv4k04U+Gd4uwCOryB117NbbtF1UDi7bSzVPASfvOb GsHA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=LUcwvPSeNEP61TNBLUnxBRn3FCI9LfPRUN4FULDF3MA=; b=gLwJssRvEJwPxfA93KHQ8naCNfrP+TPJE6rCftO5pDkp2dg4QLHNjAUvBWCUt6neRN H+Ea2bU6q9A+0yF6XZpbJl/jlnH43Ni0lHriQZaZZdHF8+wNI5kndSNEE0JhBZQl7Gcn 6kQOxGYMqA1TWJr44G4MQRhQ7IAjd6N4akC+B9W1aUO0/s5wmPnyHVeOQK8q7nCbUKwP Xl/KqgeoKKGOFa0u0hAQc2pXIo4Pw6VglrdF+586crIPDCcTa0/bWVD14ORwujn5H2Tf Aru6kcuecKYayXA9feyqaUU0JwwC6LDU7uKZ+OG1TNifvNgaPzAvPelXjjv0w25R8Ejf HHtA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=KphZIN8S; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s6-20020a625e06000000b006626454ef63si14575653pfb.364.2023.06.16.02.00.38; Fri, 16 Jun 2023 02:00:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=KphZIN8S; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241496AbjFPIzp (ORCPT + 99 others); Fri, 16 Jun 2023 04:55:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244917AbjFPIze (ORCPT ); Fri, 16 Jun 2023 04:55:34 -0400 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2040.outbound.protection.outlook.com [40.107.237.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6136C30F4; Fri, 16 Jun 2023 01:55:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ElxdEKjMXuGKZ6umIkL9h3f+uqny6POgRMJzVCGlZ0cAMhsiid7+5zt64qCDjyQhMPEfiTDgH0ry2zQfdXVGlXBy1GoBRwPcfvylurj6+waqaxtL7m5DANZtvRXym1kwHoxq7g0DeFxzDNCR6HcLr170THbw8m3BhQjLm5tGPamm0rBReBnUN+vYK+58wccIZnczuFIGrdG36JhKvoImcdKW01zP1QjkQ//Vvb+LOweQgTvrqYYu83LO7psSLzeuC7MgZ+df4w4NUKqyZB3mKyTe+bxKCeQqiBYRupLozeKu2jcbl8jG5OfAqptDdrbHemY6PQTw32Hjs83RX7nswg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LUcwvPSeNEP61TNBLUnxBRn3FCI9LfPRUN4FULDF3MA=; b=WqkcyQyuCr78KI8s8kr3z5reJoHLKy9+akE2W9WQ5dEhGymHA/ukd57Yjq5Y1rQLsEbwJAw6QLLI/11Oj8I4vdI8VCXLVzyN2mIRyGqZTVLFmA0D4CJL60h8/o9RvM3tUUVaKtCn8BybOTALjn41mYQCtUcqz09uFt844RmjJRxBWe4eENzAmIaetBYa68jisBj/vdwtwNaHtP+0017pt6b/KLKXI3/15bOvbGYv0iM9GKCBi5BsP8gUPwcmrd8GhAwyCcX1XQstcc6kPWUsNuSEQ+lwc4z5fz9KQWYUTbsWEX4cJSfBe8/NHD2xsYIAHlGXxf9oXLURDcEzQU6I7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LUcwvPSeNEP61TNBLUnxBRn3FCI9LfPRUN4FULDF3MA=; b=KphZIN8SgWZTY00n6oQaWFIqdFassKMleuXn7VMSz32BfyBqixz2rWEqH8LLfOk+RZ1P3bEikLuej+egb6JK3knAJmWOV0KXTF3y0KNsNQt/UbilNVCCe2DJtKRN2BsQh/ApdHlZYGiWjZo23X2Lx1Fc6l0EKOiGPGuJcfH4pTo= Received: from DM6PR13CA0016.namprd13.prod.outlook.com (2603:10b6:5:bc::29) by LV8PR12MB9262.namprd12.prod.outlook.com (2603:10b6:408:1e7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.25; Fri, 16 Jun 2023 08:55:30 +0000 Received: from CY4PEPF0000EDD4.namprd03.prod.outlook.com (2603:10b6:5:bc:cafe::d2) by DM6PR13CA0016.outlook.office365.com (2603:10b6:5:bc::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.11 via Frontend Transport; Fri, 16 Jun 2023 08:55:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000EDD4.mail.protection.outlook.com (10.167.241.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6500.27 via Frontend Transport; Fri, 16 Jun 2023 08:55:29 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 16 Jun 2023 03:55:28 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 16 Jun 2023 03:55:28 -0500 Received: from xhdakumarma40u.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Fri, 16 Jun 2023 03:55:24 -0500 From: Amit Kumar Mahapatra To: , , , , , , , CC: , , , , , , Amit Kumar Mahapatra Subject: [PATCH v2 2/2] mtd: spi-nor: Avoid setting SRWD bit in SR if WP signal not connected Date: Fri, 16 Jun 2023 14:25:13 +0530 Message-ID: <20230616085513.17632-3-amit.kumar-mahapatra@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230616085513.17632-1-amit.kumar-mahapatra@amd.com> References: <20230616085513.17632-1-amit.kumar-mahapatra@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD4:EE_|LV8PR12MB9262:EE_ X-MS-Office365-Filtering-Correlation-Id: 21fd9a29-cb37-47a8-3d8e-08db6e476fc6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h2xxJWOOph0QicVAa+eJDJzXkUp/JG/R27St2wuCyhY+sbKEqjMz8/R7jC4YhmXU2KtLqa+dmzV4KX/268zL6oC0BJ8LTPdfzUyHsu3jrgX0EzDlkRAadBmHY6hY3ysbZxOFkV0ntyIpqFH0c9gGAvaRgz000mU6KMg3vz0GPa+tQym1aK2Td37XNQuITJrXttz7axDAK5wM0p75Gg+Ss9Gh8jUaawL3xxVm7h/Tt54lmRoX/pbVfjp4tDNd+dMQFaqQ013ok8CywyNu7wPQof9DP9effFj+nRJwt5aA/0naElCzR05WH22VUSZPfZVrZiXCiNtYD83TOEpz53PdxTw6E/1ZBXFAovvQc0pH19agmjxFJUnUdC9VXihcyS7Fxx5r2tTK6IDGD5TTq6Ze9dJmQOU9nkKVvnVHxXlcAOMX20i9YTiuaxv8BDaN6PsXvI3m5X5IFaMnVVrAT3Fe9yasjTejWKqkSvxCzbShrDl+Lc07KbOZEhhaqp2syS87YTbLnOtGJo+B6A+HOS2kqBk6njBB3HFEMsUzqkRFvTHzFYXn9LiQSakSJFWgCAILR5LfGWX/JCuZoum7+YMw8XL8b75atK8+DpXrhkkaoAMFXo21ak/hh+pLIRLjknLkB8LOUKyPd8Z/bYRvw9xGC+UqjG4qlDY9lgwX2gUPwHkSz4T+0RVvWs0iXB1gDOfHnmuqetmHRfv9CbN7sV1E9KDkpKjCPMmnjATKiC66ngPzmn3UUZwkEeeWgWnerwfuBghzWzI2+Vxr+1QvinCwQg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199021)(46966006)(40470700004)(36840700001)(40460700003)(82740400003)(5660300002)(81166007)(356005)(336012)(2616005)(83380400001)(1076003)(426003)(186003)(2906002)(36860700001)(7416002)(47076005)(26005)(478600001)(40480700001)(70206006)(6666004)(8936002)(316002)(8676002)(41300700001)(86362001)(82310400005)(36756003)(4326008)(70586007)(54906003)(110136005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 08:55:29.8959 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 21fd9a29-cb37-47a8-3d8e-08db6e476fc6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD4.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9262 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768849201422697051?= X-GMAIL-MSGID: =?utf-8?q?1768849201422697051?= Setting the status register write disable (SRWD) bit in the status register (SR) with WP signal of the flash not connected will configure the SR permanently as read-only. If WP signal is not connected, avoid setting SRWD bit while writing the SR during flash protection. Signed-off-by: Amit Kumar Mahapatra --- drivers/mtd/spi-nor/core.c | 3 +++ drivers/mtd/spi-nor/core.h | 1 + drivers/mtd/spi-nor/swp.c | 9 +++++++-- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index 0bb0ad14a2fc..81b57c51f41c 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -2864,6 +2864,9 @@ static void spi_nor_init_flags(struct spi_nor *nor) if (flags & NO_CHIP_ERASE) nor->flags |= SNOR_F_NO_OP_CHIP_ERASE; + if (of_property_read_bool(np, "broken-wp")) + nor->flags |= SNOR_F_BROKEN_WP; + if (flags & SPI_NOR_RWW && nor->info->n_banks > 1 && !nor->controller_ops) nor->flags |= SNOR_F_RWW; diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h index 4fb5ff09c63a..6ac932eba913 100644 --- a/drivers/mtd/spi-nor/core.h +++ b/drivers/mtd/spi-nor/core.h @@ -132,6 +132,7 @@ enum spi_nor_option_flags { SNOR_F_SWP_IS_VOLATILE = BIT(13), SNOR_F_RWW = BIT(14), SNOR_F_ECC = BIT(15), + SNOR_F_BROKEN_WP = BIT(16), }; struct spi_nor_read_command { diff --git a/drivers/mtd/spi-nor/swp.c b/drivers/mtd/spi-nor/swp.c index 0ba716e84377..5d91f152c2cc 100644 --- a/drivers/mtd/spi-nor/swp.c +++ b/drivers/mtd/spi-nor/swp.c @@ -214,8 +214,13 @@ static int spi_nor_sr_lock(struct spi_nor *nor, loff_t ofs, uint64_t len) status_new = (status_old & ~mask & ~tb_mask) | val; - /* Disallow further writes if WP pin is asserted */ - status_new |= SR_SRWD; + /* + * Disallow further writes if WP pin is not broken. WP pin is + * considered broken only if the WP signal of the flash device + * is not connected. + */ + if (!(nor->flags & SNOR_F_BROKEN_WP)) + status_new |= SR_SRWD; if (!use_top) status_new |= tb_mask;