From patchwork Thu Jun 15 11:16:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mahapatra, Amit Kumar" X-Patchwork-Id: 108453 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp573594vqr; Thu, 15 Jun 2023 04:56:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6YAQDYsDG4StkNUVF1dK//v7G2Y1TQoUDDZbvs3cXLoPaDuc3Rtlwrtw4OxTF1+qqxKJ1E X-Received: by 2002:a17:90a:7e94:b0:25b:ba0c:ab7c with SMTP id j20-20020a17090a7e9400b0025bba0cab7cmr3635827pjl.27.1686830170389; Thu, 15 Jun 2023 04:56:10 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1686830170; cv=pass; d=google.com; s=arc-20160816; b=OCD1dd4DXa7TQdOIf3ESuklI4UoLdEz1QiWRC0GiLYDc5qyBs6u3ZyQiaV5V6C9kgm biERmwwR0nhj0YyL2UxqtFKWRO0kjWai5cAOIyRtbhCxrYbpHU8AC6Ais4Kq/DH/A9vj MvWsNbdcU1R6sKBW5qqEk5ljxlJnjgOXp2MASHuZMDt3FUo+NUsZpCCUuzJiD8MHB4KE 5ksGEjo0+Ajed9dqQtSzOOAc2gNxxqe/G0gZEbnFoOdIkf+EK6pj9pBk23Vgb5nBN/Vt XgqdOIG/A2+BMaWBu1G3c0YmsFG70HleAA7UhoOSSvFS8djQg2qI4OuNSGRsz9hboAZ+ qw5Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=NwLpsJxkcH49sLPYetklM7Y60KSjKNFkRmtNfEo/TBI=; b=KVZPjh/xsjxxWzPlkXNN3w7+LdLtcmO/Kxgxw1TaAEwkN2uPOKpOyaWU6vcz5SR3+J vTGArUSNxTQr64elCYAKpDNtJJVqUUblpwcjrBUoSjsgnoK7pi0JSkJWRIlLPH3o0jwi Q5NNhKFcv/CNKYBFQ+z1bQ7yvpiuBzvCJhXtBAdqjRoeAQhX6ciFJqGqxLeRLd/3CL2d O8PdbHttQhtfYkmM750odGIT9Vqz6CYCoz9+7IO2sxRWHEB7NMEIn1+jyjh2rSIB6uQR ZYxFYLqeCFRDlyDC7qLGB9+Ot4fIB7zGIWGCmvuh7E9uRI/74XZD6PP6UeP1mk+CrPFF c6+w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=heFT9ydZ; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rj3-20020a17090b3e8300b0024e4ace1a41si13377760pjb.183.2023.06.15.04.55.56; Thu, 15 Jun 2023 04:56:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=heFT9ydZ; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343644AbjFOLRM (ORCPT + 99 others); Thu, 15 Jun 2023 07:17:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343746AbjFOLRH (ORCPT ); Thu, 15 Jun 2023 07:17:07 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2089.outbound.protection.outlook.com [40.107.223.89]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEE45271F; Thu, 15 Jun 2023 04:17:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aRNy4O6IhztfAWU+SPWEDeLtZN396dmE5r/cbh5SRApIh4CAWKIO8oUB3S69parplWQiF4eXZXSFyXEMxVjTzMVuKPyncbpwjztYSXXCYGglBEzTYgS+aWM4mxRExhhFTh4FZiomoMYlUqJsGwEIrwinBj0pKaLHo+NP8sp5lxvVvi2sv0tduGZZem77rxj9KD8nCmnzW/P0SYgaiRtjYzM2iYGAvICNdwd/ozSjTIh1oDSGWh4bcaJEzI90l+UYxd/kK61RMQEJa87UXzgxd0GBm3nbNr1uKsB9SpLX8q4M3fBBOJwQVYVPilcPbBw62RDVpsKC2EI/pSW8W0Frhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NwLpsJxkcH49sLPYetklM7Y60KSjKNFkRmtNfEo/TBI=; b=CA/Ylz96Yx0AvZ52RdaBLgAppg7jm1hQfjdHM6NDvts554roB4TUA9y143lhQ0pVeh3SDg/hWEJhZekP9WhjExfi/YUCR3D7b7AlEHZ4OD1lAfwO0lcylIDbFvabIfeeO+/EpdX/s3J1IJegNtaYemWwaEy23/m5CzdLrXsf336vXHLPEXzSlBjO5xA1xfSNYb0VRfM5EZnhM0teV5wBAThqqUYavS8ncaaqJGPN9lO9mi3OBFMxZ1ycz7SuSt9XIkpkXZxAH1gBpgd64QDuyLDngUzBe0mKU/JzfcSoFyeCJw22D+gUxnV4qoH7SqzIBVjQf80cltXtLbBso8wvnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NwLpsJxkcH49sLPYetklM7Y60KSjKNFkRmtNfEo/TBI=; b=heFT9ydZ2we9TViikrt71Re611OPsiJgcJL+IlEIuAspcDv2BWwo7HdK+ZO2tCPClekQWijbmedv0WSBDpAYyw95aZVetq+2tXjHTtgjE+uyACQi3fFGowHo6DO+AVLSX01U+nlpINVCyI7D3l1mvgXikr7iUkyAIzMisBE+Xf8= Received: from SJ0PR05CA0169.namprd05.prod.outlook.com (2603:10b6:a03:339::24) by MN2PR12MB4568.namprd12.prod.outlook.com (2603:10b6:208:260::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.27; Thu, 15 Jun 2023 11:17:01 +0000 Received: from DM6NAM11FT054.eop-nam11.prod.protection.outlook.com (2603:10b6:a03:339:cafe::d7) by SJ0PR05CA0169.outlook.office365.com (2603:10b6:a03:339::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.12 via Frontend Transport; Thu, 15 Jun 2023 11:17:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT054.mail.protection.outlook.com (10.13.173.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6500.27 via Frontend Transport; Thu, 15 Jun 2023 11:17:00 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 15 Jun 2023 06:16:59 -0500 Received: from xhdakumarma40u.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Thu, 15 Jun 2023 06:16:55 -0500 From: Amit Kumar Mahapatra To: , , , , , , , CC: , , , , , , Amit Kumar Mahapatra Subject: [PATCH 1/2] dt-bindings: mtd: jedec, spi-nor: Add DT property to avoid setting SRWD bit in status register Date: Thu, 15 Jun 2023 16:46:48 +0530 Message-ID: <20230615111649.36344-2-amit.kumar-mahapatra@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230615111649.36344-1-amit.kumar-mahapatra@amd.com> References: <20230615111649.36344-1-amit.kumar-mahapatra@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT054:EE_|MN2PR12MB4568:EE_ X-MS-Office365-Filtering-Correlation-Id: d3423403-08f0-452f-3db6-08db6d920a26 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h2POhLPixx5SY4x7dmV3xDq9hqgT3jvFyRxu2gTLoWjLiaEXSPJ7KnGpz9ewdHe3lLAhaCaoA34sdzWe9hPhsNcBSajaZEABv4Vaz7xgizAL4secGY75vep2B7ModfAwfOyO4RgRKdDwIxjS7854hl5Mfftm1bY5+V1azVO/cOuyQu0meEcrlD/ZpFCM06Y40WymQ1QuJY/M3k0dtxfVdxRv5ukPTM8+im8Yj70F8mq3DFyvRCV8d+1B5k1DfcQvIXLdDwLjJEe5D4dfXJcp/IaU2Io6N2Cg88n8eOFFFcyRwtnFJsMV06lqjbtdyDmjGV2+Z0rFnzbBMFyxveLhCla/9bMosS/amiI6U/OH5ErbU9sRHqemquhmDeYutPHRV8bBWlxSf3L+yNWlHZIWzm6QMOqvsBJq5dTIKLjh73WbRTq3ApEwW3cDZ+c9bmAMKKVumbg5DMZku7f5zqW1xaSFL4qeGgWgCFndLzNqE0Zo/EIqZUaLxJePteP2MMpQTPjsIGSMirrbGJ64HUpBio7V40K/5AJhXUz+ITyYoZn7op10J5wLKu/2+8fVSghudlC8na0zP3GIJUGa7EI3POwBaTC3zwXUXhV5pGroUswoQRghWDFo1uo14E862pZA5N2hjDeN/SDF7W+wFoNS+R5CPn0c5icu7EWV4kACLM0/L8jZOPI1c6WggYKA4lNbWFzCz2kLE7XOBlMEUaNgW0+qNiqN8KBaZm0w3wl7ikijlYT5tcuLPw89dIZ/htItsg775vpsqrHtiee5ttztvQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(136003)(396003)(346002)(451199021)(40470700004)(36840700001)(46966006)(36860700001)(2906002)(26005)(186003)(40460700003)(336012)(426003)(40480700001)(47076005)(2616005)(70206006)(70586007)(356005)(81166007)(82740400003)(4326008)(41300700001)(8936002)(8676002)(316002)(6666004)(110136005)(54906003)(86362001)(82310400005)(36756003)(478600001)(7416002)(1076003)(5660300002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 11:17:00.5207 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d3423403-08f0-452f-3db6-08db6d920a26 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT054.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4568 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768769632856315547?= X-GMAIL-MSGID: =?utf-8?q?1768769632856315547?= If the WP signal of the flash device is not connected and the software sets the status register write disable (SRWD) bit in the status register then thestatus register permanently becomes read-only. To avoid this added a new boolean DT property "broken-wp". If WP signal is not connected, then this property should be set in the DT to avoid setting the SRWD during status register write operation. Signed-off-by: Amit Kumar Mahapatra Reviewed-by: Conor Dooley --- .../devicetree/bindings/mtd/jedec,spi-nor.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml index 89959e5c47ba..a509d34f14b2 100644 --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml @@ -70,6 +70,19 @@ properties: be used on such systems, to denote the absence of a reliable reset mechanism. + broken-wp: + type: boolean + description: + The SRWD bit in status register, combined with the WP signal provides + hardware data protection for the device. When the SRWD bit is set to 1, + and the WP signal is driven LOW, the status register nonvolatile bits + become read-only and the WRITE STATUS REGISTER operation will not execute. + The only way to exit this hardware-protected mode is to drive WP HIGH. But + if the WP signal of the flash device is not connected then status register + permanently becomes read-only as the SRWD bit cannot be reset. This boolean + flag can be used on such systems in which WP signal is not connected, to + avoid setting the SRWD bit while writing the status register. + reset-gpios: description: A GPIO line connected to the RESET (active low) signal of the device. From patchwork Thu Jun 15 11:16:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mahapatra, Amit Kumar" X-Patchwork-Id: 108448 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp562102vqr; Thu, 15 Jun 2023 04:32:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4RVufcEVCPZYThTZl3hxZqHKjUtwVDIrysogU5cuIpq1fVvH/OYrZ8a6KkRgLsSoSrUaQS X-Received: by 2002:a17:907:8687:b0:982:5019:82d7 with SMTP id qa7-20020a170907868700b00982501982d7mr4504832ejc.77.1686828751257; Thu, 15 Jun 2023 04:32:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1686828751; cv=pass; d=google.com; s=arc-20160816; b=uyVHaHo6PQvrTdPi9eoq5BIKWNR7eLLhl9TwHHsT/WurTS282PrR2C1leyvArj06mx MRPXjqOcBBk4xVXiGgqytL2VTZ8dr4PNRLWVBrEFjsiGjn5oz0V4Ky/tVzUvHfcpCt+U yJ6sxKq5T0iNjPsSYsMJhHIY8qyODKSQckW/OSLMds4245wbQC3LmqNWWMqXpuK2/EQK RiMzcFv/VKBPbxdE95i8185j9eVmapBHFupyQSLQG34foG3GsgjvukU0j+MPCKjXQYnP 8eKGuITPlRYmJGx+lHkn8bjIBqfkIE1+erO7rm4Sn2KE/m/asxYGVJOVWXUWbTDk4xqJ LiIA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=zr1+zYjtepEiq7UlcHy7vwzAYrAfxjUoBXuNizs+2r0=; b=wRaYrYtnlBInWVPiBISpgm49Xkerp4rBwQVi6AE88vHofQ9ARULw4x7pMuCQ7Rh/Fw ZmraZQ7/jK0y/5WNrZnrmOLaNiIpn64lBCwDiDf/PN/1vwGALh44jzzwmk8xjn8OqDFE wq87UfzHPE1+Ms5RYCZ6C/7ybWhZjVsZBKlEs1Hia1SmLODUmDm4xOe4y3uL9CZW9VUa 6v5/6s8gPJBgboKTRwBQA2iRtp0oqCUBFlwSg+Oh7AzB5vR8p4rXq7/9WbZghAlsPI6Z htMUc685u9mzay/kvyarVYRzijeLhdKo13c8738YM0j8xrKyET8wXlgNBsSpBS8I9EZq 75JA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=ejScmY6c; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j16-20020a170906051000b0097885f7d639si9624984eja.837.2023.06.15.04.32.04; Thu, 15 Jun 2023 04:32:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=ejScmY6c; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241649AbjFOLRQ (ORCPT + 99 others); Thu, 15 Jun 2023 07:17:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343654AbjFOLRK (ORCPT ); Thu, 15 Jun 2023 07:17:10 -0400 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2054.outbound.protection.outlook.com [40.107.212.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFF982947; Thu, 15 Jun 2023 04:17:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RmorYjQyipi/fHroXiCpmy4YOP3Xim5Jqe1OEDWni3kGhFPvM1eYOSmVjViXRDiPY/zOApbGQGFqNtNy+J3gxAQFrXmBYAmdsRQvnFkdH9o8+UZB+QISQoWgKfN6uDHjbsbO6snul0cNDPT+a5KL3r65v/A49xzZYPd1Qh3SMhW1ZWWgW/u/OZgnXxEUvE/s+1DLKXQKgd5ZImhM8s7rivcrTVqilaQ1OQpBhA8PFvZuSJnK1ruFQ1YLRu9BysUiHr7Aa5CnyVG4ek/d3dCvnCokt5SVmhuvahO0bRtrRL2vgABuLZJAeY9ECpmChjBlS7/6tUjXbaA21gLbleISjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zr1+zYjtepEiq7UlcHy7vwzAYrAfxjUoBXuNizs+2r0=; b=jQ8PdOuBaq/vKFL3nGYYaHrKQlgXBqTyYQELFjGWbnxEafKIAX/i+K5CMKu1kEZkn2nP3Fw1VYNqhyONlVINbBZbOOFRS2/bkXXOXsrCqkSG+RUek9vzqRX2bf5Lqh9MkVgkxN7NkVbD75sjyDVnL+FmUtIkKyBsjU8mtyTvXGqtY4HeKSW5WCFfEgVmMaiAvFxcQ/ZSCyfHOihDMEqW1S6fhaR+5j9ASVO37qJxccxhlHBHpmzpb6WrDrqYnvCkXbBcJR+RgNSbrbP/6LGBYznfyW0y/1QHafgmc5ulc3tV+f9w6NrKz6Rx5Lng22SQNS+E3GKUXAY5sF0XuD+Q2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zr1+zYjtepEiq7UlcHy7vwzAYrAfxjUoBXuNizs+2r0=; b=ejScmY6cReE4MfJGi0GwMMytziCyoEMElCQhsEN2TT2Mdo6v2Ik6iu+WlqFhAgOWxjEoitBjHS86Pua0eZIT5BPEoBCypQuY94Fi2ot46nJgtIjDxm//fj1L5nq39UZXdLuIFHdwFNDlm7SIs9cRFF/bwZ5nXpp97hIs/jk0H4I= Received: from DS7PR03CA0088.namprd03.prod.outlook.com (2603:10b6:5:3bb::33) by SA3PR12MB8802.namprd12.prod.outlook.com (2603:10b6:806:312::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.25; Thu, 15 Jun 2023 11:17:05 +0000 Received: from DM6NAM11FT103.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3bb:cafe::d4) by DS7PR03CA0088.outlook.office365.com (2603:10b6:5:3bb::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37 via Frontend Transport; Thu, 15 Jun 2023 11:17:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT103.mail.protection.outlook.com (10.13.172.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6500.26 via Frontend Transport; Thu, 15 Jun 2023 11:17:05 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 15 Jun 2023 06:17:04 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.6; Thu, 15 Jun 2023 04:17:04 -0700 Received: from xhdakumarma40u.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Thu, 15 Jun 2023 06:17:00 -0500 From: Amit Kumar Mahapatra To: , , , , , , , CC: , , , , , , Amit Kumar Mahapatra Subject: [PATCH 2/2] mtd: spi-nor: Avoid setting SRWD bit in SR if WP signal not connected Date: Thu, 15 Jun 2023 16:46:49 +0530 Message-ID: <20230615111649.36344-3-amit.kumar-mahapatra@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230615111649.36344-1-amit.kumar-mahapatra@amd.com> References: <20230615111649.36344-1-amit.kumar-mahapatra@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT103:EE_|SA3PR12MB8802:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ae19120-460b-40a2-1693-08db6d920ce0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IyROXzdFB7BFYv71BvpiNkbF+DktKPNbimxweM94UZDypIWScPY3QhwpPdbGm+8MlgSnatyIwDHKczs9T3FjRaMr0SNanGNMp5ycB5QuqhjWcusO84kxRDq3lrbGdR/BuZb9tvHD6BH7YamO3E/ayhgLWiwgjebDwt4mbqfr5j0vXQdEwqlzZKmGerO4SH7LcRifRWYWuauCJ2E/kfDJzLb1DxK7dbsNlFH2iU0OhvPCEPhTe9HobMPt/2QaLVcFs/FGH9aYQL10+dVKk+hF1jlcOQKSXCjejrFXEATHQbiMKgw9NpudRMO06iSGAsipwo4ZKXg1U5DsUEooWBp23DSnslp47yHVXLa2zflwnFWZcUlhzJIL4t9b7bL9flHhE6iAb5Gx7VFelRaJKmqR0DshMI3/iJGM5VVKik8Qb0Mg1q8v3hZSANJ1/jVcw1db0F9t6GpLRsW/p0mtBnwMc5GD8O7MDA3b/XPkKzA1jq4iJ7IhmSfg2DlB44CRazKfiOHyZvrOW10d3M/tzsTEuHa70dxXsjv8XygU2FntprVE/eR5/GE1kAU+LOXV85Jm2cbHSSGfcNIXCTfka6SZEhnmRCnp4QEnTwUiEV4pXX5sBtvYFIp6nxc57GHu9QEZx01O5vKCrmeFzhzN4+ONS7azky1hBkFA3RZfLhxb8290092YjJfONqvubfF9Rx2ROG1fEmPzaxC4mjYKkiDJdv9nK9Xk9r7v7Dkuuw4nanaY7FDwjiMa4ed0Pl2cCBTN6raOayraDLBCXroV7ynlhA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(376002)(39860400002)(136003)(451199021)(36840700001)(46966006)(40470700004)(5660300002)(478600001)(54906003)(40480700001)(8936002)(41300700001)(316002)(8676002)(1076003)(7416002)(186003)(4326008)(70206006)(70586007)(110136005)(6666004)(26005)(2616005)(47076005)(40460700003)(36860700001)(336012)(426003)(2906002)(83380400001)(356005)(82740400003)(81166007)(82310400005)(86362001)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 11:17:05.0784 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1ae19120-460b-40a2-1693-08db6d920ce0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT103.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB8802 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768768144405310085?= X-GMAIL-MSGID: =?utf-8?q?1768768144405310085?= Setting the status register write disable (SRWD) bit in the status register (SR) with WP signal of the flash not connected will configure the SR permanently as read-only. If WP signal is not connected, avoid setting SRWD bit while writing the SR during flash protection. Signed-off-by: Amit Kumar Mahapatra --- drivers/mtd/spi-nor/core.c | 3 +++ drivers/mtd/spi-nor/core.h | 1 + drivers/mtd/spi-nor/swp.c | 5 +++-- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index 0bb0ad14a2fc..81b57c51f41c 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -2864,6 +2864,9 @@ static void spi_nor_init_flags(struct spi_nor *nor) if (flags & NO_CHIP_ERASE) nor->flags |= SNOR_F_NO_OP_CHIP_ERASE; + if (of_property_read_bool(np, "broken-wp")) + nor->flags |= SNOR_F_BROKEN_WP; + if (flags & SPI_NOR_RWW && nor->info->n_banks > 1 && !nor->controller_ops) nor->flags |= SNOR_F_RWW; diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h index 4fb5ff09c63a..6ac932eba913 100644 --- a/drivers/mtd/spi-nor/core.h +++ b/drivers/mtd/spi-nor/core.h @@ -132,6 +132,7 @@ enum spi_nor_option_flags { SNOR_F_SWP_IS_VOLATILE = BIT(13), SNOR_F_RWW = BIT(14), SNOR_F_ECC = BIT(15), + SNOR_F_BROKEN_WP = BIT(16), }; struct spi_nor_read_command { diff --git a/drivers/mtd/spi-nor/swp.c b/drivers/mtd/spi-nor/swp.c index 0ba716e84377..074f3bce2034 100644 --- a/drivers/mtd/spi-nor/swp.c +++ b/drivers/mtd/spi-nor/swp.c @@ -214,8 +214,9 @@ static int spi_nor_sr_lock(struct spi_nor *nor, loff_t ofs, uint64_t len) status_new = (status_old & ~mask & ~tb_mask) | val; - /* Disallow further writes if WP pin is asserted */ - status_new |= SR_SRWD; + /* Disallow further writes if WP pin is connected */ + if (!(nor->flags & SNOR_F_BROKEN_WP)) + status_new |= SR_SRWD; if (!use_top) status_new |= tb_mask;