From patchwork Wed Jun 14 06:32:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kai-Heng Feng X-Patchwork-Id: 107735 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1045691vqr; Tue, 13 Jun 2023 23:59:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ72KvZt1Q4WuguVMI4gF0YUbW7guJAGqDAPEz/AIgfkwgmDm3WiZ0ueCiGp+5WdYYWcO5QG X-Received: by 2002:a2e:984e:0:b0:2b1:c5c5:192c with SMTP id e14-20020a2e984e000000b002b1c5c5192cmr5736438ljj.44.1686725984870; Tue, 13 Jun 2023 23:59:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686725984; cv=none; d=google.com; s=arc-20160816; b=qKPIv9Kr8MgqdwYl2aOEARhhL8IYCdh8MGpJwtM1TKKJtX/o74ROf8K46iHPeQWusr kMGM5RNSbrrsGXLutneUwHCWz/6HX8N35PbZFGyVlT03CXFk1+WDjv6tCS0/V7vcu5xF LyslcAUvqPfSB7fk0F7Ev9GgpiE2dX0i0sWIy53W88y5FJjN7WybR8reoRTJI/QnpWgt j8C3Yt9BRTULSkLtCsi+1cXXSCs4VxaE0H6PMmH+zoBWLyon1jlr16jM5a+zV+xwG5iU Amn0TCrgUZ4p6+PRZ0DjlbwDx/eq84kQpsEZBKN+RCI7CpgkQYSJ7QJDvdyUZwAPI1f+ GsNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=+hqis1W8nQ4EkQUmco7jTscaaZbuSwY0XCyi+/U9QfM=; b=Lf69iA1RUOzvlnpfRSuE08nMSjIsux2HVvJM1hr8Ft0HqaWI/Io85zJm7Puq+XnrDt x2ZU7WfLR3leC2fIICsBrH1sCjaI/8Eqn8IKremd39OObxWPM1DJae3yQOt4sVyjZBwq tzzXdgZ/Y4XjqOU7oyYyu0l5YGdw2TMaAyoBOj0RpRNv46zJ7XbHWYmBsVyldcjWFvbc IzuTlvnk+iJctr57u+NKyQQmp5HBgpmWcNySUCyHLFo8KfHd2J1vQKQacOeNQvLBt0Pa ckItSHFRU7zX3PAErrnTWVqnOycRKHcjH5rsXiiiK59lyjGPZHBfJNvFfDDPNDd7Y+Y/ PIMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=wIVM1sNd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i20-20020aa7c714000000b00514934f0ddcsi8559613edq.113.2023.06.13.23.59.20; Tue, 13 Jun 2023 23:59:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=wIVM1sNd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243011AbjFNGfl (ORCPT + 99 others); Wed, 14 Jun 2023 02:35:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243281AbjFNGfH (ORCPT ); Wed, 14 Jun 2023 02:35:07 -0400 Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A75971709; Tue, 13 Jun 2023 23:33:48 -0700 (PDT) Received: from localhost.localdomain (unknown [10.101.196.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id ECD893FE8F; Wed, 14 Jun 2023 06:33:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1686724426; bh=+hqis1W8nQ4EkQUmco7jTscaaZbuSwY0XCyi+/U9QfM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=wIVM1sNd+ojHp6usjuvn93Ejfp9bdZeFSaG46lVPT9zOIp8wytXooK36JiMTSSn0l 2eDxchP16vkMHZh9WMeLMOU2uMYGl2IC72DT9wEtoCN8kE1SKDZyKISm6VclhVjH/K pM7P3JTy9iTfu8Met2cxNQk3SUybNSvxw4H3B5ZkrdBYvUX6a3HdEqTVRdIWGKE4bN cGy0m6IQJBwBfD+iG9SDVbKk8b6BQnCCFks9n+yETD6WkkbiY/dOe28fNPPKk/AY1w t7LdI6MxufhU+CLvZ7/233P6hdL4RZwqhDqF6cvYqn1aXRlc7irfxVq2mCg44OOzkJ Wu9959Z93e1Kg== From: Kai-Heng Feng To: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com Cc: Kai-Heng Feng , Shayne Chen , Sean Wang , Kalle Valo , Matthias Brugger , AngeloGioacchino Del Regno , Deren Wu , Leon Yen , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH] wifi: mt76: mt7921e: Perform FLR to recovery the device Date: Wed, 14 Jun 2023 14:32:50 +0800 Message-Id: <20230614063252.1650824-1-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768660386663793629?= X-GMAIL-MSGID: =?utf-8?q?1768660386663793629?= When "Pre-boot WiFi" is enabled in BIOS, the mt7921e device may not work: mt7921e 0000:02:00.0: ASIC revision: 79220010 mt7921e 0000:02:00.0: Message 00000010 (seq 1) timeout mt7921e 0000:02:00.0: Failed to get patch semaphore mt7921e 0000:02:00.0: Message 00000010 (seq 2) timeout mt7921e 0000:02:00.0: Failed to get patch semaphore mt7921e 0000:02:00.0: Message 00000010 (seq 3) timeout mt7921e 0000:02:00.0: Failed to get patch semaphore mt7921e 0000:02:00.0: Message 00000010 (seq 4) timeout mt7921e 0000:02:00.0: Failed to get patch semaphore mt7921e 0000:02:00.0: Message 00000010 (seq 5) timeout mt7921e 0000:02:00.0: Failed to get patch semaphore mt7921e 0000:02:00.0: Message 00000010 (seq 6) timeout mt7921e 0000:02:00.0: Failed to get patch semaphore mt7921e 0000:02:00.0: Message 00000010 (seq 7) timeout mt7921e 0000:02:00.0: Failed to get patch semaphore mt7921e 0000:02:00.0: Message 00000010 (seq 8) timeout mt7921e 0000:02:00.0: Failed to get patch semaphore mt7921e 0000:02:00.0: Message 00000010 (seq 9) timeout mt7921e 0000:02:00.0: Failed to get patch semaphore mt7921e 0000:02:00.0: Message 00000010 (seq 10) timeout mt7921e 0000:02:00.0: Failed to get patch semaphore mt7921e 0000:02:00.0: hardware init failed After some trials and errors, it shows that PCI function level reset can recover the device back to a functional state. So perform FLR at probe routine to workaround the issue. Signed-off-by: Kai-Heng Feng --- drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c index ddb1fa4ee01d..9671fbe35a8e 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c @@ -262,6 +262,10 @@ static int mt7921_pci_probe(struct pci_dev *pdev, int ret; u16 cmd; + ret = pci_reset_function_locked(pdev); + if (ret) + pci_info(pdev, "Unable to perform FLR\n"); + ret = pcim_enable_device(pdev); if (ret) return ret;