From patchwork Tue Jun 13 19:13:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 107518 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp778806vqr; Tue, 13 Jun 2023 12:30:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5cbRuz4Ot5Ky3m/yVyICczyK15eeq8J3yrqU1wuCtmF8FbcjM/5LNLU0YSAuF2IeOKUclk X-Received: by 2002:a17:907:970a:b0:961:69a2:c8d6 with SMTP id jg10-20020a170907970a00b0096169a2c8d6mr15572632ejc.69.1686684658348; Tue, 13 Jun 2023 12:30:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686684658; cv=none; d=google.com; s=arc-20160816; b=XnM3+95AWs+lr+66zcnqL4D2wLX+qBXx+uHA279xTd9qVayxkfI19DT2+jtf84t44b ATc++/W6ZsHg4Lu1NQuhgcRXtsxJpHqwTBHl/eE91cRTisEiNvDzROtI0Id/cfdkOVwP uJJEHT/ysvpz1ADlYbnbNtNjvgkxjxooJfnbOwdHWBJLgFvPe8WmGOUREBkCCAWr4Iq6 yRhrKiVj3c2RAUhketTWB3FC7jjNzY0NRgzQKlEjSQZTRN8UCxSUiKWEAQYmTCAr8EUG I/ozdzVWZrfOgiow3Au0yQTja/6n+SWwBEO/VllpFXsB8kzv/O5CUS0upCGvKPBG9Kr4 Wy1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=635jy0e2lhv+fSXWusJ9DIeLST1wGeeAsUy28K1WJGY=; b=ieSLnE0yqqsffXUpNSCHNmwP+Y5EHAx5onPDu9CkeYQQCrt9y/CiWh2OPJsKIiAA91 uOe//YP4dre9q4CvFV4/i/FnNKgAWKL910bJm2dgIRkq7L0dQr7TYIZWsUYYR+k+mtqU X+P2m62E/Gq2hJo+9YE9LZ6vApLtD64hXVIxznWGvNT9/ILcGc71BuJsFcEnLUCXPPuB 6Z+zGK1JGBH6QuDIlELHLdqphoXV5j8h6oJwLLBuT8ATUBtw0xlWiypst4EyyLlylR7t D/KWBA3IxQlwPNSY438QNkztPc6u/yu0FkMuIk7TLBTL0u/uhykExVqbLYFysivjV3AB EsRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wKr5ulDR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f21-20020a17090624d500b00977ec68f019si6819840ejb.228.2023.06.13.12.30.19; Tue, 13 Jun 2023 12:30:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wKr5ulDR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237203AbjFMTOI (ORCPT + 99 others); Tue, 13 Jun 2023 15:14:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235258AbjFMTOG (ORCPT ); Tue, 13 Jun 2023 15:14:06 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2601122 for ; Tue, 13 Jun 2023 12:14:03 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-4f6195d2b3fso7498063e87.1 for ; Tue, 13 Jun 2023 12:14:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686683642; x=1689275642; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=635jy0e2lhv+fSXWusJ9DIeLST1wGeeAsUy28K1WJGY=; b=wKr5ulDRcUGas1ZQElff+75ttyWitE9A2pG6uIyMcsh9rbZNbpQQPGy0e3xduAGF76 Dg8nnEIJGJAUnmqy9boYhZZXK5gqC4C1mgb1HAgvcZtiPrVXIURc0dBwOQOEWNyyroXq OXx22UUciThFQdfHJwzcuRPOPwhNQcFuSrHEUQNR1XFFrF56vz9qhdLJxj1oi+ztIiGY SH3cUlbqNGlWOdtchsZfmfGSe+DeykDru7LMjTqS7Uv7JUaMOaJXqtrs3xZ2PLs6DLNf NNr4X1ynAyzN9nkcEqe/OGt10fyC717jFt1AP/tNZPolq5hOgKFcJdPIj1OmWu569VHv jVAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686683642; x=1689275642; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=635jy0e2lhv+fSXWusJ9DIeLST1wGeeAsUy28K1WJGY=; b=UdwYWpaeBswV9dqGXXmI0YMb4cm9YKVVrMClbnMeZu+KYuXjNmbGuRuvYqFM/2DC06 0rgSbeLRGotz5d9Jm7Fw426NFhUvvDP4cn/ObN0UKPAUBmhsKclptPeM9kqi8qq7D6DO ELG2EKiKw9/PpWA1GjFngoSfmHGrtWltAGQCIt5KuxJ53d5YoD+PtR5IWbnuYbOjhR/X eEVX6eUF4eroVVLh4m3PnfpA5ASRi+uDD+MpmYkSkHkTETNKaqesoiIp6hsGCPu/mnor Gc6flbouXVleExT4O63flKl/4tz+kB/RiRfUmRzadEc4il/ebmgc9Y5s+Oma5bIOwPbL vrxw== X-Gm-Message-State: AC+VfDwaZZgDS6oUi57rtsIXY09qzuboZzGE5ZJVu/QbV5ISE1q42roY qCA5CwEnec8CWNbxlB5TDU9rPw== X-Received: by 2002:a19:655d:0:b0:4f3:5038:5857 with SMTP id c29-20020a19655d000000b004f350385857mr6843243lfj.55.1686683642073; Tue, 13 Jun 2023 12:14:02 -0700 (PDT) Received: from [192.168.1.101] (abyj190.neoplus.adsl.tpnet.pl. [83.9.29.190]) by smtp.gmail.com with ESMTPSA id r10-20020a19ac4a000000b004f01ae1e63esm1848443lfc.272.2023.06.13.12.14.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 12:14:01 -0700 (PDT) From: Konrad Dybcio Date: Tue, 13 Jun 2023 21:13:47 +0200 Subject: [PATCH] arm64: dts: qcom: sm6115: Fix up cluster idle states MIME-Version: 1.0 Message-Id: <20230613-topic-6115idlestates-v1-1-fa017052319d@linaro.org> X-B4-Tracking: v=1; b=H4sIAOq/iGQC/x2N0QrCMAwAf2Xk2cDSzon+ivjQdtEFSjeaToSxf zfs8Q6O20G5Cis8uh0qf0VlKQZ06SDNoXwYZTIG1zvfj+SxLaskHImuMmXWFhorxuAHut0dx+j A0hiUMdZQ0mxx2XI2uVZ+y+98PV/H8QfLQ2YCewAAAA== To: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bhupesh Sharma Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1686683640; l=2325; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=ufJhln1rknyOKoYvw+gm0MwBsfp76sKNCVfI2Po21t8=; b=27kXMW5EZ44Lbx87/FcPywSyvc5LxOtI9IAN063mDoObOoPsmxZiyav4YbG0+wtrGPnaX9WAT FliyoOQjYNcBgSpap2gGyIce5BCP9qzaFLDO8QAkVk0NwYjsL6jpXBW X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768616955235843461?= X-GMAIL-MSGID: =?utf-8?q?1768617052351168730?= The lowest nibble of the PSCI suspend param denotes the CPU state. It was mistakenly set to mimic the cluster state, resulting in poking PSCI with undocumented 0x2 and 0x4 states (both of which seem to be implemented and undocumented). Also, GDHS cluster param was wrong for C1. Fix that. Fixes: b5de1a9ff1f2 ("arm64: dts: qcom: sm6115: Add CPU idle-states") Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm6115.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- base-commit: 1f6ce8392d6ff486af5ca96df9ded5882c4b6977 change-id: 20230613-topic-6115idlestates-ba341792ebb2 Best regards, diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi index 55118577bf92..07d8b842d7be 100644 --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi @@ -225,7 +225,7 @@ domain-idle-states { CLUSTER_0_SLEEP_0: cluster-sleep-0-0 { /* GDHS */ compatible = "domain-idle-state"; - arm,psci-suspend-param = <0x40000022>; + arm,psci-suspend-param = <0x40000023>; entry-latency-us = <360>; exit-latency-us = <421>; min-residency-us = <782>; @@ -234,7 +234,7 @@ CLUSTER_0_SLEEP_0: cluster-sleep-0-0 { CLUSTER_0_SLEEP_1: cluster-sleep-0-1 { /* Power Collapse */ compatible = "domain-idle-state"; - arm,psci-suspend-param = <0x41000044>; + arm,psci-suspend-param = <0x41000043>; entry-latency-us = <800>; exit-latency-us = <2118>; min-residency-us = <7376>; @@ -243,7 +243,7 @@ CLUSTER_0_SLEEP_1: cluster-sleep-0-1 { CLUSTER_1_SLEEP_0: cluster-sleep-1-0 { /* GDHS */ compatible = "domain-idle-state"; - arm,psci-suspend-param = <0x40000042>; + arm,psci-suspend-param = <0x40000023>; entry-latency-us = <314>; exit-latency-us = <345>; min-residency-us = <660>; @@ -252,7 +252,7 @@ CLUSTER_1_SLEEP_0: cluster-sleep-1-0 { CLUSTER_1_SLEEP_1: cluster-sleep-1-1 { /* Power Collapse */ compatible = "domain-idle-state"; - arm,psci-suspend-param = <0x41000044>; + arm,psci-suspend-param = <0x41000043>; entry-latency-us = <640>; exit-latency-us = <1654>; min-residency-us = <8094>;