From patchwork Tue Jun 13 16:42:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 107462 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp684173vqr; Tue, 13 Jun 2023 09:43:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5x2NgXx1tTAYmQMJr8TXmhDM0ZV6jBsAlgJMp+rlLDpduQHatDMHfPcNRnYbbuqwvRfz7t X-Received: by 2002:a17:907:9349:b0:973:e4c2:2bcd with SMTP id bv9-20020a170907934900b00973e4c22bcdmr12235026ejc.18.1686674585501; Tue, 13 Jun 2023 09:43:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686674585; cv=none; d=google.com; s=arc-20160816; b=HmHpcZwIfjM1VoBQOUcSm3oTURFd24Zgow8S+E4r0hs0AH1UgEE/w9AP0fmJroBy2K ubqLTxANJH9tdyDFrWtlmG15h1mHd6k1Rrqj97d41mp4L5wUutfhJBufzYiAcGMVQ1c4 eqSvCD4AsxzH5Wbcjy467WK5QYutPadpgUIKJ6W4hBBAQUksUK9RGR9a77w/QF6vX/+P OyiGvrjWcMFnle4+4X5riAe8I8v17NCFkLxvfUrn+It8e+2axLdvUg0wgqf/10ElKejn FVdEjRfsjVZdy2zlMl/Gn9gluLs4OtIzMT0xrk3a+BXte/4W7ogWkuLW4hoJwdgKe/Ap w8vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:cc:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=h7fvxrCt5Xj/5inI4XNpc9hN+ojNbK04JAgLLodmId4=; b=n9+UV+ZI6YTK2euLGxWG1w0Xv28EBB/qTvzHyGb7ods/b98tXL9yJCcx2heSMTwHl4 INpKKB8jvswOvfa3sXaZqhlv32BQOdTBENTutXNEJOjaaXHTb1DKZTWhE95M9xJdOmz+ tMLq2+QZ26dRb515p/xLZo+U5nvVKuklimbNP6SVOUkSE1RsQDwvFUBqf4T9mr+YeYfV YuTdmd7pJkH/2/0la1cvyIPhys3lkK8gr4LVssvgsXP9cclW9ivDEkHdGckUOL3WkuLe EZuie4+Jhgqs64IF/XYCc7PphxMgzahd9T3JagXuQdw03vRNarCvhCCtl5SW+LthXFvh OuwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=mPplI+K9; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id i2-20020a17090685c200b0096aa522ff41si6756412ejy.336.2023.06.13.09.43.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 09:43:05 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=mPplI+K9; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2C2133858423 for ; Tue, 13 Jun 2023 16:43:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2C2133858423 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1686674584; bh=h7fvxrCt5Xj/5inI4XNpc9hN+ojNbK04JAgLLodmId4=; h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=mPplI+K9oyXyjpKlG80iKlr/KCltABDwu93DTOUA/PNCMWLNz+KB+yAVs0p3NmyYg 7ZX6xMxZHxNHiGodQDKUXHPFw4FC+ZKKaqhqgPaLxBwvmPhK4aWvjiG/zW4b7Ov9mg agiO0zl1v8NaXPXG6P0NSoWXt2F5SVlaLuAsqnsY= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2FB903858CDA for ; Tue, 13 Jun 2023 16:42:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2FB903858CDA Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-604-7DcCi2bgMXqkguvkEMIqZA-1; Tue, 13 Jun 2023 12:42:16 -0400 X-MC-Unique: 7DcCi2bgMXqkguvkEMIqZA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D448B858EEB; Tue, 13 Jun 2023 16:42:15 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 96A881121314; Tue, 13 Jun 2023 16:42:15 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 35DGgDIi1132361 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 13 Jun 2023 18:42:13 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 35DGgCZi1132360; Tue, 13 Jun 2023 18:42:12 +0200 Date: Tue, 13 Jun 2023 18:42:12 +0200 To: Uros Bizjak Cc: gcc-patches@gcc.gnu.org Subject: [committed] i386: Fix up whitespace in assembly Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jakub Jelinek via Gcc-patches From: Jakub Jelinek Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768606489839582603?= X-GMAIL-MSGID: =?utf-8?q?1768606489839582603?= Hi! I've noticed that standard_sse_constant_opcode emits some spurious whitespace around tab, that isn't something which is done for any other instruction and looks wrong. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2023-06-13 Jakub Jelinek * config/i386/i386.cc (standard_sse_constant_opcode): Remove superfluous spaces around \t for vpcmpeqd. Jakub --- gcc/config/i386/i386.cc.jj 2023-06-12 15:47:21.855511203 +0200 +++ gcc/config/i386/i386.cc 2023-06-13 14:33:49.940464312 +0200 @@ -5358,19 +5358,19 @@ standard_sse_constant_opcode (rtx_insn * if (GET_MODE_SIZE (mode) == 64) { gcc_assert (TARGET_AVX512F); - return "vpcmpeqd \t %t0, %t0, %t0"; + return "vpcmpeqd\t%t0, %t0, %t0"; } else if (GET_MODE_SIZE (mode) == 32) { gcc_assert (TARGET_AVX); - return "vpcmpeqd \t %x0, %x0, %x0"; + return "vpcmpeqd\t%x0, %x0, %x0"; } gcc_unreachable (); } else if (vector_all_ones_zero_extend_quarter_operand (x, mode)) { gcc_assert (TARGET_AVX512F); - return "vpcmpeqd \t %x0, %x0, %x0"; + return "vpcmpeqd\t%x0, %x0, %x0"; } gcc_unreachable ();