From patchwork Tue Jun 13 08:07:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 107192 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp392331vqr; Tue, 13 Jun 2023 01:45:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4TaHTYTVS/jYDWh5cXPxBoNqlE5rC2VmY5N8KofUZ3qVn513go9Gsob3QP+WLH/Iho4BM9 X-Received: by 2002:a05:6808:28d:b0:39a:bca0:3c28 with SMTP id z13-20020a056808028d00b0039abca03c28mr6331883oic.57.1686645929257; Tue, 13 Jun 2023 01:45:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686645929; cv=none; d=google.com; s=arc-20160816; b=RnXpMR3iBkRPxNeqo7HCWlDJhSsd8CU7c6N2d1X6P1luSOoQqMoOF2Y1wfhF5Ewxk0 YnharNsn8Zw0RQzcZcqwaFpL88ZM3fJmCz0296NRSOU1aSh8LfP3/uxlqWp4XxEAjIdJ VBsFYCsbiLjTmbbk856Sd3tt1xqEHenyJxyk/aR+gIn109f8TtXaU2KIMG3kPQsivZ14 L9iOWmUiviwVDr4rM3gjqQG+6poZ1lAXGp8c4DCOQxFGUfm7HG4akJKXTvTJIWvYNFkz A2qUJWCdkMHapGR35ZenbhaOWACe/B1keinuLE9q8CtE6EyFwhP94lJgKyUoVQ4h2Zpa O5MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=jVCvnuikxuMkayvXMhnhJV1W770twmco4K8oIyl6qVk=; b=NE5shS4e5vFfyo1iw8Uq83ezZxU12OiGaaD8/aHtSlnSSHCxJqw8xf9cXc6VS3wxot zwSr+tL+sn6umdPUKLscvHo1ac35wf9+6xmTcgVQOAOz4kDGnlzVLCF2ToHQ5zq9yynV /JquG0hQ3yPEkk2j0SHYwYhYr58WJlUZabZQ0cpC7kYcRoSLj6pa91br16tDMKSQb2AT isvezOwQp9kX/ChuDjgw64Ym5tbfiLsmVLbgz2A5Eo4stDomA62O32uww+CKEYOJSXQp sNcDESgnBNkb/kO+EDst79a7tb9qZ/D2FCKL4xuDSxP52+iMgfS4TKhokuLpHBZnsSxq 5A9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20221208 header.b=ITi8kRp3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g15-20020a17090a578f00b0025653dc2881si4571716pji.23.2023.06.13.01.45.14; Tue, 13 Jun 2023 01:45:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20221208 header.b=ITi8kRp3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241045AbjFMIHt (ORCPT + 99 others); Tue, 13 Jun 2023 04:07:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234993AbjFMIHr (ORCPT ); Tue, 13 Jun 2023 04:07:47 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05C3910CE; Tue, 13 Jun 2023 01:07:46 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-30aeee7c8a0so3834494f8f.1; Tue, 13 Jun 2023 01:07:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686643664; x=1689235664; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jVCvnuikxuMkayvXMhnhJV1W770twmco4K8oIyl6qVk=; b=ITi8kRp3sMI/PkbbTaZ89AQ3XwCLefwMYZr709m/UEKHYyqhIRR+6qCSdbsfHwGZMA 4pafBFCU5yMtOKM+SlmLu0OASrI+VO/29p00PEh3eA3xGPdJ2M5vsR4wZbV18YnoEte9 z0+8G3cabGgg3W20nVXdEZn43CIiFXhTJ2OZ7j+proaC3CSudp8dSfA/0/PuNVss1LIr jxY5cOA2qAAE2IXLf8MKRUt0/xZHhoyFXCcxCEj2ARrDQjQiM1T+4YB0gEmPmR+JjkgK jx3Qu9AHcngfJ/sGQIPVd/dttyxyFZ+V/UKUZuoKAZrQzl0d/fjwX4uPvMvumljrGvD7 j5Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686643664; x=1689235664; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jVCvnuikxuMkayvXMhnhJV1W770twmco4K8oIyl6qVk=; b=eYTkHYOI9bJaCvODOKA81oqJ9qYngrGDqZGxi/iAGE1bL4PdpCf64DGvK875Keqqv9 cdnSgL7lNlZJYz6lNV8TT5By/mtL6645+5Jy7PE9rypqFZN17EEk9/Og4cSu2oP3jYCb qMi0SfQEBwaJDrrIjaXMAJtBkNASI1aN45PrcVy2vJYWbWHQ5JB1P838fxfbe8L3/uyt hr2PumBAs2JFSr25dTV5tW7LMQV+VTZbPd2iHVbnr6cSr9jMGUUWgTnqaEt9W+iQK1bq vVIFRnNJsaggg372xROc5KkLpgO254Ce8Gt35AwM/nBp0Pb5iUPMFjjhXt1L+QWSW9fc e68w== X-Gm-Message-State: AC+VfDyweZezmPqRrRSLq3zyzcrFpvL3uqJfLrOaTXBpnQJGTxCDDqom XLz+It259ozPeuMalLfpMZdyAuF1yRs= X-Received: by 2002:a5d:60c5:0:b0:307:7959:6461 with SMTP id x5-20020a5d60c5000000b0030779596461mr7170270wrt.31.1686643664224; Tue, 13 Jun 2023 01:07:44 -0700 (PDT) Received: from tom-HP-ZBook-Fury-15-G7-Mobile-Workstation.. (mob-5-90-5-141.net.vodafone.it. [5.90.5.141]) by smtp.gmail.com with ESMTPSA id t18-20020adfeb92000000b003093a412310sm14559754wrn.92.2023.06.13.01.07.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 01:07:43 -0700 (PDT) From: Tommaso Merciai Cc: linuxfancy@googlegroups.com, Tommaso Merciai , Dave Stevenson , Manivannan Sadhasivam , Mauro Carvalho Chehab , Sakari Ailus , Laurent Pinchart , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] media: i2c: imx290: drop format param from imx290_ctrl_update Date: Tue, 13 Jun 2023 10:07:34 +0200 Message-Id: <20230613080734.8151-1-tomm.merciai@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768576441905427714?= X-GMAIL-MSGID: =?utf-8?q?1768576441905427714?= The format param actually is not used in imx290_ctrl_update function, let's drop this Fixes: bc35f9a21a55 ("media: i2c: imx290: Fix the pixel rate at 148.5Mpix/s") Signed-off-by: Tommaso Merciai Reviewed-by: Dave Stevenson --- Changes since v1: - Collected tag from DStevenson - Added Fixes as suggested by from DStevenson drivers/media/i2c/imx290.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c index 5ea25b7acc55..a84b581682a2 100644 --- a/drivers/media/i2c/imx290.c +++ b/drivers/media/i2c/imx290.c @@ -902,7 +902,6 @@ static const char * const imx290_test_pattern_menu[] = { }; static void imx290_ctrl_update(struct imx290 *imx290, - const struct v4l2_mbus_framefmt *format, const struct imx290_mode *mode) { unsigned int hblank_min = mode->hmax_min - mode->width; @@ -1195,7 +1194,7 @@ static int imx290_set_fmt(struct v4l2_subdev *sd, if (fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE) { imx290->current_mode = mode; - imx290_ctrl_update(imx290, &fmt->format, mode); + imx290_ctrl_update(imx290, mode); imx290_exposure_update(imx290, mode); } @@ -1300,7 +1299,6 @@ static const struct media_entity_operations imx290_subdev_entity_ops = { static int imx290_subdev_init(struct imx290 *imx290) { struct i2c_client *client = to_i2c_client(imx290->dev); - const struct v4l2_mbus_framefmt *format; struct v4l2_subdev_state *state; int ret; @@ -1335,8 +1333,7 @@ static int imx290_subdev_init(struct imx290 *imx290) } state = v4l2_subdev_lock_and_get_active_state(&imx290->sd); - format = v4l2_subdev_get_pad_format(&imx290->sd, state, 0); - imx290_ctrl_update(imx290, format, imx290->current_mode); + imx290_ctrl_update(imx290, imx290->current_mode); v4l2_subdev_unlock_state(state); return 0;