From patchwork Tue Jun 13 08:42:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 107191 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp391745vqr; Tue, 13 Jun 2023 01:43:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7qiQTPlVqfVJx1iQdpWsNJDkgi1+lhAGzfusrceCiQLctySQ440whGDkb9HjFGQkdZvUli X-Received: by 2002:aa7:d9d8:0:b0:518:6d88:7169 with SMTP id v24-20020aa7d9d8000000b005186d887169mr1540177eds.29.1686645821603; Tue, 13 Jun 2023 01:43:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686645821; cv=none; d=google.com; s=arc-20160816; b=aZ6WTgqzLeofdXHonbOK/MifhgYF+ckvlHxX+mE1n1ESwVeQbamwhOJ2eDomf5qFoJ xofwTeKX4C1JpjawnxmoXID1TCYijiuOggcI9ae8ArHLN6MjwAAOT8SjvbERmvGNTk6f 1fhXrKbk+nJlbRcOKmmY9zJv4yvYQUsqOWfY+07xWhkJw+AtaIagHe7DGb1JavVa2ByJ kDjvgb3F30bHfSqyFF7ao2ElohsA185GwEo0kT3uzQwy0/Cd+2p0nzN4en6MkTKaFV+r Q5wfpiZv6DrOiR8MfvKNUBDEaBLN/sBveAYleeQvg0u0F4slZodBpBFRBSbsC151VFFJ xf1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:sender:errors-to:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:user-agent:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=10wlgxTbw2u1+og8sxeEp1zr2HAfi4jxge06eJvxtlg=; b=edzFELhc9PtYTlC4mr/7WSAkNeCRUQNHVMEVV5ZGiAOqsH2yGHnuXaZSGgndZ5UeSg U8FJcguYJmKSQi79sLI1FpspROP7GIWc/WcHvb3PwsqEBh9i4JpYFXlldneIKhx7Heuf 10ysrjbtg/XWVGusvIqQXO2voe61vymzc3aQYn8+twLGVyJDoGUsbW0O0wiub2E+Wq7g tOgaMhx1Sn/ESM3jk/qU1H1tUR9iH4IlGplIGYtizgGTxZfOkTrx2dc1+GxtZ70Brpqd wLT5kdPaHa7bxq0c26SBOqnKf+cnh72/WPWK8hnttjXY5CYJhYdrj/wiMR0Djv47qr1y TQag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=PeBy9pbg; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id y3-20020a50e603000000b005186d996d0bsi1107029edm.376.2023.06.13.01.43.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 01:43:41 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=PeBy9pbg; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9F2843858414 for ; Tue, 13 Jun 2023 08:43:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9F2843858414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1686645817; bh=10wlgxTbw2u1+og8sxeEp1zr2HAfi4jxge06eJvxtlg=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=PeBy9pbge7I+8z3pO+eriyxezXAJtwjWEhmSwOLN8BcSVrwEkM7oEsHgnporGGIlj k9h4zu77NYcNJcaf7pBAKHebodQAP78PGaTXYfCGO0sg5WxsJYK0HdtHEjs7A5oTXX hKDKWwzdBI6Ty1qcdqwsAuKo51C9NiKS+BBvPESg= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 1FEB9385772D for ; Tue, 13 Jun 2023 08:42:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1FEB9385772D Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 4EB792250B for ; Tue, 13 Jun 2023 08:42:15 +0000 (UTC) Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 451D22C141 for ; Tue, 13 Jun 2023 08:42:15 +0000 (UTC) Date: Tue, 13 Jun 2023 08:42:15 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [PATCH] middle-end/110232 - fix native interpret of vector User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" Message-Id: <20230613084337.9F2843858414@sourceware.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768576329346954475?= X-GMAIL-MSGID: =?utf-8?q?1768576329346954475?= The following fixes native interpretation of a buffer as boolean vector with bit-precision elements such as AVX512 vectors. The check whether the buffer covers the whole vector was broken for bit-precision elements and the following instead implements it based on the vector type size. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR middle-end/110232 * fold-const.cc (native_interpret_vector): Use TYPE_SIZE_UNIT to check whether the buffer covers the whole vector. * gcc.target/i386/pr110232.c: New testcase. --- gcc/fold-const.cc | 11 ++++------- gcc/testsuite/gcc.target/i386/pr110232.c | 12 ++++++++++++ 2 files changed, 16 insertions(+), 7 deletions(-) create mode 100644 gcc/testsuite/gcc.target/i386/pr110232.c diff --git a/gcc/fold-const.cc b/gcc/fold-const.cc index 84b0d06b819..9ea055d4523 100644 --- a/gcc/fold-const.cc +++ b/gcc/fold-const.cc @@ -8796,16 +8796,13 @@ native_interpret_vector_part (tree type, const unsigned char *bytes, static tree native_interpret_vector (tree type, const unsigned char *ptr, unsigned int len) { - tree etype; - unsigned int size; - unsigned HOST_WIDE_INT count; + unsigned HOST_WIDE_INT size; - etype = TREE_TYPE (type); - size = GET_MODE_SIZE (SCALAR_TYPE_MODE (etype)); - if (!TYPE_VECTOR_SUBPARTS (type).is_constant (&count) - || size * count > len) + if (!tree_to_poly_uint64 (TYPE_SIZE_UNIT (type)).is_constant (&size) + || size > len) return NULL_TREE; + unsigned HOST_WIDE_INT count = TYPE_VECTOR_SUBPARTS (type).to_constant (); return native_interpret_vector_part (type, ptr, len, count, 1); } diff --git a/gcc/testsuite/gcc.target/i386/pr110232.c b/gcc/testsuite/gcc.target/i386/pr110232.c new file mode 100644 index 00000000000..43b74b15e00 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr110232.c @@ -0,0 +1,12 @@ +/* { dg-do compile } */ +/* { dg-options "-O3 -march=znver4 --param vect-partial-vector-usage=2 -fno-vect-cost-model -fdump-tree-vect" } */ + +int a[4096]; + +void foo () +{ + for (int i = 1; i < 4095; ++i) + a[i] = 42; +} + +/* { dg-final { scan-tree-dump-not "VIEW_CONVERT_EXPR" "vect" } } */