From patchwork Tue Jun 13 02:26:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "juzhe.zhong@rivai.ai" X-Patchwork-Id: 107026 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp258126vqr; Mon, 12 Jun 2023 19:26:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6IBU5I7VuMtz9N04eZ/KEBn0kEVg+xKVrcLt0rwrzZNGij4rCA+P+ZA+9+Aufs8hy6ga8P X-Received: by 2002:a17:906:fd88:b0:973:edba:df30 with SMTP id xa8-20020a170906fd8800b00973edbadf30mr11800787ejb.61.1686623215061; Mon, 12 Jun 2023 19:26:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686623215; cv=none; d=google.com; s=arc-20160816; b=nWomdoz/7kq60jyRUgVJkqSOUCgu0GnX9T8MjYAlJ5KPHNRtmlOtiPNGRlNI5hGLb/ 05YgX1j3rMnUaUYU1l+PPQhEPz8Pu0bKC3ovADIydss+wUEXadyefdbL1NLmaaC1DkG5 Q538RxlVKRAjG8gFM/GtL1cs91Or38JbZNW1+ulCssGpl68ZdKKeofdQ8b23SsQh+qma e1/f2b0CEOP5MJ3jkrX8Dcr1ZBOVrEccgijSXruawPPmvwX2b7cu9Xg2Nqa4ThAPMA/A 4SWV6WI9YgwUddR1Xr6skhUIXoytXJf+05nZT03ugsXHJWB5s2S/xvjoBLEHjK+z6GzC XjYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:feedback-id :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dmarc-filter:delivered-to; bh=+SMp62S/nCliRO+Z4THA7UToalI5Hc12zBMZ8uRi584=; b=ObuSsQrngK2W+EsJKOJAmta8OHWpc8+C7qz1lLvb/wf3WGpvcZEuxtbGMjgkzkSWWw y0h8x0XB1LC9AmpwfT1tkMzvc87FJ0xzAIWXxo0HIgFLrP5eTFc5kQ+RVOWaLmeerN/T 8Jk6ACGacf/J8MYx0xxgl2uXFxn5DsrJ9y8BEXd5X72nySSpAlLJJ2zFB/G9fKw8GdJn 3+rAB691pIz6sAldOyviU8oxzrYrnXREhrUBx76CyPnNno/Og9ETREixyAjlyYa+DiWf Bi5wF8B32uVoZMZqLmIOby4aEqBmWrXDw7hM7ZQX7kzW+Ekze+X0MaTJhvSpiQSOm31u EmYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id o10-20020a1709061d4a00b00977d0f093b5si6373821ejh.556.2023.06.12.19.26.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 19:26:55 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B03DE3858D32 for ; Tue, 13 Jun 2023 02:26:48 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtpbg153.qq.com (smtpbg153.qq.com [13.245.218.24]) by sourceware.org (Postfix) with ESMTPS id CD14E3858D38 for ; Tue, 13 Jun 2023 02:26:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CD14E3858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai X-QQ-mid: bizesmtp88t1686623174t5z11kzy Received: from rios-cad5.localdomain ( [58.60.1.11]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 13 Jun 2023 10:26:12 +0800 (CST) X-QQ-SSF: 01400000000000F0S000000A0000000 X-QQ-FEAT: ILHsT53NKPhzQSpgiKFKKZNzTpVfiHpwGqe428rVCdvybjQ1moFG163FX+Jqj Hr2kGGZziXdWBmYhJZQ031yOZExeqsFmG6cOAl4MBsfPfo2X2NsGTq1MH8PuJzze//5rafk E73K1xRc1TJ0Mi3f+RRj7djfko6we0Rw37rObbEoFJuBfgJfJWhx16Hy18Q5pJoteTJTKzc /+YW1GuwyIvjB7leLrM9KWWbAb/XcCsBiyCkDM1q/3/bCTATVO+X923s94bOGS9tLB1gTtg cZECL3ecwi2wzTpvIF5TJ2hwMSuoA2v7UdvRnFFsWiqhjc7bKfZRe3fJr5SKDtya0sP8Y33 Q6GaDbjMPBXeCOZMx/sCKpb4polzheVrJfvOkk8pnLpczkhe+T/wt33U2XjrgY7UYLRecVS X-QQ-GoodBg: 2 X-BIZMAIL-ID: 7270065862093572498 From: juzhe.zhong@rivai.ai To: gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, kito.cheng@sifive.com, palmer@dabbelt.com, palmer@rivosinc.com, jeffreyalaw@gmail.com, rdapp.gcc@gmail.com, Juzhe-Zhong Subject: [PATCH] RISC-V: Add comments of some functions Date: Tue, 13 Jun 2023 10:26:11 +0800 Message-Id: <20230613022611.2189297-1-juzhe.zhong@rivai.ai> X-Mailer: git-send-email 2.36.3 MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvrgz:qybglogicsvrgz7a-one-0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768552624008842642?= X-GMAIL-MSGID: =?utf-8?q?1768552624008842642?= From: Juzhe-Zhong gcc/ChangeLog: * config/riscv/riscv-v.cc (rvv_builder::single_step_npatterns_p): Add comment. (shuffle_generic_patterns): Ditto. (expand_vec_perm_const_1): Ditto. --- gcc/config/riscv/riscv-v.cc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gcc/config/riscv/riscv-v.cc b/gcc/config/riscv/riscv-v.cc index fb970344521..3ce2eb7f2ad 100644 --- a/gcc/config/riscv/riscv-v.cc +++ b/gcc/config/riscv/riscv-v.cc @@ -457,6 +457,9 @@ rvv_builder::single_step_npatterns_p () const { 2, 2, 2, 2, 4, 4, 4, 4, 8, 8, 8, 8, 16, 16, 16, 16, ... } E.g. NPATTERNS = 8: { 2, 2, 2, 2, 2, 2, 2, 2, 8, 8, 8, 8, 8, 8, 8, 8, ... } + We only check ele[0] ~ ele[NPATTERNS - 1] whether they are the same. + We don't need to check the elements[n] with n >= NPATTERNS since + they don't belong to the same pattern. */ bool rvv_builder::npatterns_all_equal_p () const @@ -2478,6 +2481,8 @@ shuffle_generic_patterns (struct expand_vec_perm_d *d) return true; } +/* This function recognizes and supports different permutation patterns + and enable VLA SLP auto-vectorization. */ static bool expand_vec_perm_const_1 (struct expand_vec_perm_d *d) { @@ -2509,6 +2514,8 @@ expand_vec_perm_const_1 (struct expand_vec_perm_d *d) return false; } +/* This function implements TARGET_VECTORIZE_VEC_PERM_CONST by using RVV + * instructions. */ bool expand_vec_perm_const (machine_mode vmode, machine_mode op_mode, rtx target, rtx op0, rtx op1, const vec_perm_indices &sel)