From patchwork Tue Jun 13 01:12:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 107014 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp246948vqr; Mon, 12 Jun 2023 18:53:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7fJXu9bJxO9OKf/JdkH7TsVMfWko5QcHK+kQZ9Bg+vm7PzPEO1o/AFJTdqUEcFj7BEaQQu X-Received: by 2002:a17:907:6e12:b0:977:ab43:731f with SMTP id sd18-20020a1709076e1200b00977ab43731fmr13778763ejc.66.1686621234058; Mon, 12 Jun 2023 18:53:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686621234; cv=none; d=google.com; s=arc-20160816; b=ObxFnheAZkFyUqvUll9aOVmcqZ3T6AFdiEr8pddrPOYcB6rqMIG8/c7dIJeLBhSlup 4w3UU4T8qgMH7ccvn0VuoTXR3v2fwLz+jNWcjhuOXFZzhMy9BzwJf86xqGDbU0IesYS9 IveS1MhtD0f665i9L2OYQCOTcEQIenK997zDH41ZxjdcxfjSASQIpOsvQduBFPSnBwUA DweijwY9SF9xnviAlSIoFYeFXgVHTQoJphRTMnt89v8/X5f7iCkk+R9KhFDc2ZYhpb5V WO9MYOKwek8j6LiZ3zSBRevi7M/LwWW03aAO9yYDHb/RXzDNW1KcP6UjbEj2LQZgaQCT Q/4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Bgse2RmmSKedQIBqqGcWB4yHTfxUKKJxQusL9JV1uAY=; b=Y64J5T/KPBkt8rO0go/wi2Tz324C64jKDfHPLfp+oqJSHTcX8qqxm0DQS6JbOmzkyx 0dcqtnm2PpVQd9OH/DFcUREZx7pw+u3e+jf+nbizQKHrw1RKLStgfcvbp7IeNnCpx9ik x5Fj449/hCT1Yr2XoMPk1w2/gwAsm5hgElD9sRwNS+EXWh4UoR41svqhA68gwVhaMnPj TVlC6xa2Sl507nOAc5zHQfsInjfN3Z8qvYNGpWF1W+Ra9AXkj6TRk37OIlRiuJi7BA99 rDbfPbpWcGO3K4qRamAqI2Frj4PYDBWc0ZhBjG1IP1eQSMkvxej6hyMp5Jv18I8Wp4Xs xmEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="MDtbZq/Y"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f6-20020a1709062c4600b0094f13e1a269si5171364ejh.970.2023.06.12.18.53.30; Mon, 12 Jun 2023 18:53:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="MDtbZq/Y"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229674AbjFMBMJ (ORCPT + 99 others); Mon, 12 Jun 2023 21:12:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238109AbjFMBMH (ORCPT ); Mon, 12 Jun 2023 21:12:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A599101; Mon, 12 Jun 2023 18:12:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F404863079; Tue, 13 Jun 2023 01:12:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CE91C433EF; Tue, 13 Jun 2023 01:12:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686618722; bh=s2B8jsyrAMp70vnL8t+VU1TAoQczCjHuMAecRCqHfbs=; h=From:To:Cc:Subject:Date:From; b=MDtbZq/YIgU4w5Mjy34aMseasppY5x6FJ2bJ3b/DNb3cmDYOXij8PSXRLNTtAlTPz oA06kJovpjEY4Ob3igRKSNBni3AWzrLC0k79X9basD0M9Uqc3bJK1kxUgbBMskamkC 55sRnsgbYtCaOORxmCLwiP1+sbm3MNkSQYyyZKHWyqE4lL6Z2Zp0xPTlvkNw0sbKoS vP3WutOLeUdWFjxLFXYXuXHD4EMmlnO6uGfmapFQQirR/wS4No1G+FtTsFL7bnxdIO kcn4m0RWFdtuKa9L7yiNYU8/DxpxwKB7MqpUObwanJPxa9oEoSEInekRzPg3mYBwiK fSlhp9xn9aaKA== From: Stephen Boyd To: Michael Turquette , Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, patches@lists.linux.dev, Maxime Ripard , kernel test robot Subject: [PATCH] ASoC: tlv320aic32x4: pll: Remove impossible condition in clk_aic32x4_pll_determine_rate() Date: Mon, 12 Jun 2023 18:12:00 -0700 Message-ID: <20230613011201.1166753-1-sboyd@kernel.org> X-Mailer: git-send-email 2.41.0.162.gfafddb0af9-goog MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768550547001449363?= X-GMAIL-MSGID: =?utf-8?q?1768550547001449363?= Smatch warns: sound/soc/codecs/tlv320aic32x4-clk.c:219 clk_aic32x4_pll_determine_rate() warn: unsigned 'rate' is never less than zero. Cc: Maxime Ripard Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306101217.08CRVGcK-lkp@intel.com/ Fixes: 25d43ec352ea ("ASoC: tlv320aic32x4: pll: Switch to determine_rate") Signed-off-by: Stephen Boyd Reviewed-by: Maxime Ripard --- sound/soc/codecs/tlv320aic32x4-clk.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/tlv320aic32x4-clk.c b/sound/soc/codecs/tlv320aic32x4-clk.c index a7ec501b4c69..c116e82f712d 100644 --- a/sound/soc/codecs/tlv320aic32x4-clk.c +++ b/sound/soc/codecs/tlv320aic32x4-clk.c @@ -208,18 +208,14 @@ static int clk_aic32x4_pll_determine_rate(struct clk_hw *hw, struct clk_rate_request *req) { struct clk_aic32x4_pll_muldiv settings; - unsigned long rate; int ret; ret = clk_aic32x4_pll_calc_muldiv(&settings, req->rate, req->best_parent_rate); if (ret < 0) return -EINVAL; - rate = clk_aic32x4_pll_calc_rate(&settings, req->best_parent_rate); - if (rate < 0) - return rate; + req->rate = clk_aic32x4_pll_calc_rate(&settings, req->best_parent_rate); - req->rate = rate; return 0; }