From patchwork Thu Oct 27 10:24:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 11723 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp148488wru; Thu, 27 Oct 2022 03:29:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7iTy9OYnK9yHfrHqb2u5KdIjZ060JepG5AQvs1Z+FBqfiN15n+PBDbrnQVlwICmF6lLBW+ X-Received: by 2002:a65:5886:0:b0:439:8dd3:18d4 with SMTP id d6-20020a655886000000b004398dd318d4mr41359768pgu.430.1666866596467; Thu, 27 Oct 2022 03:29:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1666866596; cv=pass; d=google.com; s=arc-20160816; b=FbDs62Xm75K8clBPI0xqpSZ65SdYfH8S1FW4mvgi4ExwD0juq3F/n84eXN2zXBUY/R 5E30V/fjBqJwD7oG3gE+Bo51QiCM9hUxgcmWt3ClYczKTHf5WnSt1oIesDpixKUFQvEJ eilmeentXyxZIuZX/ukhRkP8a0EaVyxGIckgkEzJ/OifVsgyUyte0jMhY+H9oxqyDl8p H5v1V0noR9/HeuGmqflG9g5qk49MW4pD8i/d4ZbVHakqztYOOvES/slVvLlV/Bok2nM5 sV25g27S6wgSFVoT+9sHvbxaovwlBWIxIxTNWFnZUdVPPhJX0BBzwvELCEYudl/tzQlE y7Lw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :message-id:date:subject:cc:to:from:dkim-signature; bh=kdKeIXNmrKcwNnQfF5gbRzjTfd/rQahJMwoyEt0vack=; b=u9SL3Y8S4HtA1Xr1HdxRDAD6Y6uy2A1DM6cfb5wrCoKpu6yYc1Oas4LX1+qXMEPQah yXr2DG26RX0yw50d+ur1P02K5hfbF02LIx8tPHn+p0ucMF5LI6IpDjEzabX9FWCfnpaz ZsyNPLStrjzXUVITVknXykGBK40JdUtJmyEwxEKZgzvfUkBUFpVninKnqsUnCFIdgg43 pP1toscyQw52VVs5vgBa4yhIScuNrj/Qj+3vB4Sb89ZjY6xUMOWFKnZK5e31o02gL5lK HWOYwmG3b7YzjVwle95EfFDjR/6AOUwEBXzmNpVR2YdYfHet3u/x7pQNwGDhKpD3zspg 2LRg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=XytWW3OF; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f3-20020a170902ce8300b0017e22aeca47si1205440plg.552.2022.10.27.03.29.43; Thu, 27 Oct 2022 03:29:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=XytWW3OF; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233775AbiJ0KZ0 (ORCPT + 99 others); Thu, 27 Oct 2022 06:25:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234826AbiJ0KZO (ORCPT ); Thu, 27 Oct 2022 06:25:14 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2095.outbound.protection.outlook.com [40.107.117.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39765357C0 for ; Thu, 27 Oct 2022 03:25:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Idavwb98DqAHJkxLV+P5o/deKUAFALq4eZB4HnnoqckfrHbtsRBzxpmjgGwTpOshFYksFUnUkifGlE65csJ+52aVdXcOuKc9hVbDMB65uk3p0xa//b4Wb9u5N/fNqephqTRsS/fsLDe7zTmd6AXsANhiFKMxWsZ+r4HgEQ6bvO288krNSJ1l2jsyuNttcJmrMkjGSIit9CLtsp/edGWVAKqcfdw51XDz0s7NRprvmh6wB6JMvXTEfpk70A53vsSu8FnCiQqlR/uK7ye/gO0FotwChz5NvhXLqg6dEYuvAYHcUqbSfwEhrxVi/IyUX4SRLJr60L4yiha1j/ilfXFiDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kdKeIXNmrKcwNnQfF5gbRzjTfd/rQahJMwoyEt0vack=; b=EneD5tlkW0C80CfLtQ9BPB1EzqR/EdJl45SyGqAhQzw70iD8UHy0eOEGAW6Rdb/aY6zs9imcBWMXL4WMQN9m5Ph5JIvPIgmw/77oDiThJJWv9wkZBGBDEgA222mtMoNk+niwoTfSUuDqYiFKhnwq9LSBrfbMRT5RouNKVJoAEr9U47KaBg75bab7cKaP9fWpwySPLla29T0xGqPuYbDwl+BmKXJyfE97VLvbSzQ5oSSiqw+rkGz8IVmHg2QmnTX38dhhrrsIG1k+M4ekLSRqkRM58MDucbCMj4bu96v0UnVxESnfiaBgrEQVimOFD34nwx17ko6qilR8/9il+/GD+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kdKeIXNmrKcwNnQfF5gbRzjTfd/rQahJMwoyEt0vack=; b=XytWW3OF2lXk3xiFfVGEK1+M92RJfm5Z/NMJYPVTX7UnoMO5KlyqtTzQm1wdFv6L1AdUGVJadmLhv6O0frHD1rLQogs1TSzhjknTAkb2uIMwGRdD4bM+2nDHmUWxwIkWLQN7bTqJiaM5nNbb5ut0aHtjCIE2vbGSZWcpyMuxWUJoRn7noF/el8L8P6RbdoOE2d+7F//6e+UimkooSDZvLwDTiCzB3ZdmqGaTdYTfbasVB170J+kx52jbBikAfP+LLacDlCj+gl3KseVNVG9ifW5Lz5wnZlyUI5lM59fubI2X1V6ph5dH5nkE6b8tGBy2kXmSLtBvZWIwgWPvhs9jXA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB5123.apcprd06.prod.outlook.com (2603:1096:400:1c1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Thu, 27 Oct 2022 10:25:04 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::c84b:5a6c:d66f:c0fd]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::c84b:5a6c:d66f:c0fd%3]) with mapi id 15.20.5746.023; Thu, 27 Oct 2022 10:25:04 +0000 From: Yangtao Li To: jaegeuk@kernel.org, chao@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Yangtao Li Subject: [PATCH 1/2] f2fs: cleanup in f2fs_create_flush_cmd_control() and f2fs_start_gc_thread() Date: Thu, 27 Oct 2022 18:24:46 +0800 Message-Id: <20221027102447.75708-1-frank.li@vivo.com> X-Mailer: git-send-email 2.35.1 X-ClientProxiedBy: SG2PR01CA0192.apcprd01.prod.exchangelabs.com (2603:1096:4:189::21) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB5123:EE_ X-MS-Office365-Filtering-Correlation-Id: 562a7ef8-a81b-4f92-6f5d-08dab80582d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IeXmZDxYvTlH5TNYOFOVP8jAnkAejiILXVmhiBbn8A46f2zP/h3ttuhAjeO8AR6pARJo1DScfFJLFMnf+PgT8i5ow+gf1U7TbewGCCNpBqJGxL3xoANZfaOsMYAn93LNHGQygXnyYjNdLiD5hy8AbM8LHpP5OkyqRDitcxtMShy7IzTHr+eG8nUMDy3lozS/eR3ldJAA/CYXBzMQeqaYGrxOW9WQ0T1yYDAuLkpFjeXzgMLY/2+O3cjqYcwZeP0B/hIFPo+3ZjM1zQLxFdF81HILf3+PQb7t1I+JZLeAK6U5MAjPTYeoQ9JcwnAa/W9uoSlw0raUzJNFgsqLN0IAUQu/EC1hIDsgDGuBvFAAEmQZ1tXjaHiH5snAM6xs2qP9UGxN4j8NXBRUVWMFKl4BcmPJcRbWDDrbnT4BM2MRnzTg2BStz6Pm/KKdxmOalefJcjWjEwkPdUiZoa6TrZWsI6JTCwwcqgmfQ40qdUwnVJGNKfpZgTctxB68uC1CJVU/TE7JTZHmDkohjj3JLMCK2CCOs7x3STNgZ2o/nClc1ZSDM21Ru22NWHon59QyBmjmedJh2lrO/wi86CKh2JUWeczJl/88j+l2ME3NGve6AoGjAgRbUxiDwqc0UuS4J79rU8tpXdocK2PMEBTJ/l5QSgVbBan2I4yxWg3VBMF3VbrTbSsm09SMrIBGb5FrZpalLZCVc17ERLmIzFpce3aIcR/9Xk4aPNdV2MNsKB7XY32D+RWZmkr3DMRaeFUlxEeIjoRWR0WOIoa4eC4kewpT1A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(396003)(346002)(136003)(366004)(451199015)(478600001)(6486002)(8936002)(5660300002)(83380400001)(38100700002)(66476007)(41300700001)(66556008)(4326008)(36756003)(316002)(66946007)(8676002)(2906002)(2616005)(6512007)(1076003)(186003)(107886003)(38350700002)(86362001)(6666004)(26005)(6506007)(52116002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: FqHN4OdCFhrO9kYF7wPOMLHPa3eyZCPbGe8MgxGWmzTCVweYxJ++lqSynY2ZP7Smd2cfSdfuu0f0Qe07lgArSZGr+lHO+GlEQ2Ef2H3KH0bMG6/jnc73JDyiVPG01JH9VyXoabmKLcUNXy2zJNc/dSTU5aOSRRedERGEe+nE3QhYud2Q6ymr8J8EZPZ82ppeE9nSTpTs4j5pJdGYDRkPhA3tSKgo0hwHwP98MkB2z3YG6dDQu2nl6XssWZD6mhFzINWwbqZsxCmwMa1qApjzpBjlGEWzukRomWd/YTz9Wp2n+VHqs5A7FalvfA/RL7zQv6H2DCcw/RQ+HBE1xrvbORa3EtL5EE6XIvvbibyCdmJOV4FHUgWuJNfdKt/UPAFxiIvltaaFvcdXMZETkOog/Vjr59w0sN7TTb6/rKGhicEQ8C8/rFHv/S0IPGOR+1qzIEZAYWGtgFIf/DgiFti5hMG3s8Zq8dWHjq//h4l+/aOvZolq1PlIbVFT5/HKmwNp3GC02cUjaN7Q55BT2RFl8oN7+wwPOHHfa52YUieo1uGATTDjMPCjJ7Fkx3T9lLP+DG60MzFYOqUeHDp1ZTC9h4LULc39s2NvwiaOKaW7k94PLrN2SFgw7XpRwrMvVmDFZJHxCkk7EbuKbY3KWnETzy1VOf5C7e33vEoJPDnxs00vh5JUHf3ha38lYsW2OhEemADnzGZe4xoAyHxlW+H30QjqNrLzM1O7gArHAdP7ftlF5ZWqyxho0qNHwSSOGUmEOGy8DDAGjNMWJo4HFPyb7S5XLn+szPfX+4GXHo9SVZU0NcGTwc0pglmlXGjgXiyV0AylIb5cSu9iRTR6thDqbiW8doKgDn7Up6eobgm+igXp5dHtjv+CQN1ZXOqdlbRPWv6QDBvUwT2bvOqb4X0gZdeaxk7f/NojusZVyZtKDIbqApp/KREYcko5E4LaWpY29Vc8sQlAzYbGozQGVSXT6Gcf5kDvHzCd/VkzDHu9zVWvq2fyZEfKL82HYGOr8vvAEqGB5wYht2KJ/tp+DJnabGjTMYhkl7L3rR+UJMuyZukMUe8QE4YvOmer29RgDrc8tQKuAcqSEgQ8cgzYObqRJW703cQ7YLNEc8zhdXITAAEC4l73YvqwDwLauseDIieME1WzcLw1UoX9lcjBu991Pq49bpDt/4St8WcQPF4mCNKJKMY7KLaV0gCjrOaNjME2Nrz/ITcjziEDmqTbCECaxOj0emvU7JsmWBfAhVdGovw4XPGT1jpGFry9TFtuXCHVpjGa4MwUxb57C6dq0ZJR9UKJBQMDJtMyWu7ju88gsrPHlRWB8m3e+N580kIk0AiFeknmfB/x+53+V48M+V3NGpUZ91JAxJORrTfdaGGieBTqOV6hfzrQ6VyA5gyyNZoX2JHodXfIEU4+v7f3UoiJVmaAaZ2p7PnzjJ9V7qXDcFTVBhR75iQ49gavGoA20rNa6SWrO/+BuhyVvIJqEqaVFT2y7Fl64JpU7bmjFd5gqAcNo00UUPjiJ+OVy9IDFK3ELTSCI8ctNBLfpzi1PYTmHHRrDvUcg45ukfv5k0aPOAzVhSiafEDXC5mZIHrvyCsl X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 562a7ef8-a81b-4f92-6f5d-08dab80582d2 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 10:25:03.7710 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HcczFp8YSZQ4Y+RxPA4Z73i+bJHvtr5nfIuAFRBn2bI8D4qclUPYSQVj28G6B612wil5lyxwK/XqKL1nu8gBFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5123 X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL,SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747836308572999180?= X-GMAIL-MSGID: =?utf-8?q?1747836308572999180?= Just cleanup for readable, no functional changes. Signed-off-by: Yangtao Li --- fs/f2fs/gc.c | 14 ++++++-------- fs/f2fs/segment.c | 3 +-- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 674a905063db..85d16f4106de 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -171,13 +171,10 @@ int f2fs_start_gc_thread(struct f2fs_sb_info *sbi) { struct f2fs_gc_kthread *gc_th; dev_t dev = sbi->sb->s_bdev->bd_dev; - int err = 0; gc_th = f2fs_kmalloc(sbi, sizeof(struct f2fs_gc_kthread), GFP_KERNEL); - if (!gc_th) { - err = -ENOMEM; - goto out; - } + if (!gc_th) + return -ENOMEM; gc_th->urgent_sleep_time = DEF_GC_THREAD_URGENT_SLEEP_TIME; gc_th->min_sleep_time = DEF_GC_THREAD_MIN_SLEEP_TIME; @@ -192,12 +189,13 @@ int f2fs_start_gc_thread(struct f2fs_sb_info *sbi) sbi->gc_thread->f2fs_gc_task = kthread_run(gc_thread_func, sbi, "f2fs_gc-%u:%u", MAJOR(dev), MINOR(dev)); if (IS_ERR(gc_th->f2fs_gc_task)) { - err = PTR_ERR(gc_th->f2fs_gc_task); + int err = PTR_ERR(gc_th->f2fs_gc_task); kfree(gc_th); sbi->gc_thread = NULL; + return err; } -out: - return err; + + return 0; } void f2fs_stop_gc_thread(struct f2fs_sb_info *sbi) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 282616e6852a..becceee8e337 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -638,7 +638,6 @@ int f2fs_create_flush_cmd_control(struct f2fs_sb_info *sbi) { dev_t dev = sbi->sb->s_bdev->bd_dev; struct flush_cmd_control *fcc; - int err; if (SM_I(sbi)->fcc_info) { fcc = SM_I(sbi)->fcc_info; @@ -662,7 +661,7 @@ int f2fs_create_flush_cmd_control(struct f2fs_sb_info *sbi) fcc->f2fs_issue_flush = kthread_run(issue_flush_thread, sbi, "f2fs_flush-%u:%u", MAJOR(dev), MINOR(dev)); if (IS_ERR(fcc->f2fs_issue_flush)) { - err = PTR_ERR(fcc->f2fs_issue_flush); + int err = PTR_ERR(fcc->f2fs_issue_flush); kfree(fcc); SM_I(sbi)->fcc_info = NULL; return err; From patchwork Thu Oct 27 10:24:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 11722 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp148487wru; Thu, 27 Oct 2022 03:29:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Augrz4SJT6uet+8Q0gO+7qY9bRvO1fCwr+iVLCs+HHLZi2l/PFPZ9cFrGKrdYWM4hQoUk X-Received: by 2002:a17:902:d3cc:b0:186:9720:b19b with SMTP id w12-20020a170902d3cc00b001869720b19bmr24605893plb.3.1666866596175; Thu, 27 Oct 2022 03:29:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1666866596; cv=pass; d=google.com; s=arc-20160816; b=VWQjdXzidKh0I+Ksj1VMQwMTaFqglZ8aQm5weRHP5cHNB/+BqMfhlEON2ZIv3dax+e NXQA60YbTuy401wZfiP2XL+VPKNpozW8BZbArO/WRDLcTbkVF42iZ4WT5INovP0GklVs JbgMlFSXKlSHg7gB9TGB6XJC1Fj+p7w1eE9Yo68OHQrjOfESP2/rNipwj1303KeiaNcE UHNDzCBkulv/8d7EocDYjFzwc3Rdp+hmVq+Iv3XimHjbNGQuzCQmso+G76M8+fXqvCxp ap4Ne+gqeYVcJbaCpqWZSgrY//G0K465gfQcjoD6wTnzejMcwRqZLpW7xzz5OIINobWB fMqA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=skSA7H6VRgAiz059YN9/VM/V3hCNY+z0ypuYCT9/0E8=; b=WrtjqcYdaDpt4Nkd68iXEWswktsFyF0nFZgmBTEyLcB4pDz4EnfeoRc5ECPDyS0T1E 5H6/CBJKn1DuGNqpETbNbGfje3qFVUejMhkhicqYYFu6EsRUWiHt4ICl3AwFcKFwkGFT 0BOniF3+24yUzVAjBGgKsVg4hDSXz7vNuGUTi2p1D0SAl0cOZxjXsCCWUBc2XXF5ROk9 xB+PKJOPtKmNGZRmyHBLJZaBdRg1bCRzwVdR03/OaEoKS2JGJRZgLUSgRqTeai4LPARM Ik/DKntPU8hRs8+Blda9jwtHSEGB5EmKKOm9rq7lZyFMKtP7Dfd2e+Tm4TP8A9usPGax RTog== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=X392nSv9; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id na3-20020a17090b4c0300b0020d2d54066csi1589273pjb.171.2022.10.27.03.29.43; Thu, 27 Oct 2022 03:29:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=X392nSv9; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235064AbiJ0KZV (ORCPT + 99 others); Thu, 27 Oct 2022 06:25:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234853AbiJ0KZO (ORCPT ); Thu, 27 Oct 2022 06:25:14 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2100.outbound.protection.outlook.com [40.107.117.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C92D3357C6 for ; Thu, 27 Oct 2022 03:25:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HbfKlDXvZ23YUQP4XEnk52ePxIQrHTCYmplz0oMI6fkx5Bxzxja7RvVsj0ELbAzsLg7TmiBM1qOYXVzE3f6vSJ0uug+NVSQMCt59PL9hJQ//sWfvlIluCqJA+4ea1/8PT0eSOsLEESW1Jb7dF4GgYARyAeeN28kij/XsVgW1h7jnRbdOZAB4ofd7ONZBes+DcCiwOV7Jh/eFEHj26h8i9QRZCNub0rmzaBt9BJqviZHrtku2+CaHMBWPKKYl8QRr1cTZ2hkU1Al2D/v6E3Oq7UDZAhHBNXdBdzFeXowbquj9VZ5o7SvhvVs75vPH1y4v5CPaCjzlwGPbfQVgsGRnNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=skSA7H6VRgAiz059YN9/VM/V3hCNY+z0ypuYCT9/0E8=; b=lO4LxlKjus0Ab4WulkEyvAJhLupXtYve6EfDso/gjJWkczi9Tloo5a+EW8ntTab3h6cf1tILTPN+ZNxnF7dThNu42B6xouEg5pDNRx4zuC6QxJrYMKM7mv+YqLlnM+j/EbF/eSyO66ppjBLueC6R478NxeHqPd19ry5KWd1lNOZDiX9N1KXA0pHMrEQhY1PpBYAuENDJr+i9KqzYA2ijORuw4O7T10I7h5y39bSzJurBc7/1MCL9OXzdgGHThuuYNP0j2q4HemErlzLPRNChiLOY9xkd7VrUO933fa99Sjw120kU4WWexpEcv1KuoR5RCpMsc0T39HMF+033Ct8z+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=skSA7H6VRgAiz059YN9/VM/V3hCNY+z0ypuYCT9/0E8=; b=X392nSv9sbXX9RWmn7ZJMV4KGj/3PZlPOqyRqt70utP7T0I8zKPEMQc4ILoR5R038JZ++KTXt1HA7m0urUX6E/x35BFwDeqMrSXoO+ZFtn1Uy8A+p3L42GS2sfU+szQXPR0mCa9dQVVWzGaWRyVcbzm+mRr+0yNqiwUKOfv1zxrH/9ZeizngfgdYutiC/4KvyvaSxHG9voMUI6dGLR7HQvaMZgUJEwWtUKjf/L1gjtd79YN86dPjLnY0mN+jzUgQyMB9G/BjlSyC6ZRn+9e3q3iJBjTsGG7CQCl8zR+h3Rq3vCqeOMFHRqi9X8zhmHtiPKNsbM2NT2H6tgn5UBygLQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEZPR06MB5366.apcprd06.prod.outlook.com (2603:1096:101:7e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Thu, 27 Oct 2022 10:25:05 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::c84b:5a6c:d66f:c0fd]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::c84b:5a6c:d66f:c0fd%3]) with mapi id 15.20.5746.023; Thu, 27 Oct 2022 10:25:05 +0000 From: Yangtao Li To: jaegeuk@kernel.org, chao@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Yangtao Li Subject: [PATCH 2/2] f2fs: fix return val in f2fs_start_ckpt_thread() Date: Thu, 27 Oct 2022 18:24:47 +0800 Message-Id: <20221027102447.75708-2-frank.li@vivo.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221027102447.75708-1-frank.li@vivo.com> References: <20221027102447.75708-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR01CA0192.apcprd01.prod.exchangelabs.com (2603:1096:4:189::21) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEZPR06MB5366:EE_ X-MS-Office365-Filtering-Correlation-Id: 59de766e-5f9d-491d-db7f-08dab8058382 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rmb4roGQzKbk5HxqmQ/KZXD72H4JA3698q5vGD4ayYweosb3fFGQ1UZSp0t+09e8reoKT0DNNQm/o+scolE7qmA6NuYwZ+SGE6K7uCsNayXBFnTgWCqwLTSjIGW2h0tx9Lpewg1ZgEJsR+KJJxfUz/2BwAoVH8nPb0XVlwyKH4FnPwOvFajjJnlGKSK3ZHbNk8ffkQvjkWaTh+6U1pDnz06BO0gsoPXczAOgwUcyPAQdXAX0u/gFC3etLaXMvKbRnK2RIy6kkPdffzobnfhNKNTTeYIIX9YmsV5f2ZMprSHDYi5wMVJKionvKTSmW9cM7g+zDYh+WjLG1SsJW5+GIXrAxBqP+g2CoYLaYeOsOsN72xq7iqHpss0AAYuZzEMd1Scr4h57ddRuY7K8OE88u1NxwwTdn8YugpZOhHuSVVS7T92LEdmvz2iVhIAutstgVEMGothLNW6etefxnabKmhpI26RxOhGxdAe33UUwdjjVgHJEwxOunVpei1vn3e6o1j37bYr6LXIKYDfV8ggRjxAlfNWytQu7XEVfye3ybS4BJfymou2dIWjaJe8PDr+qnRpg5jxJimOss4QpCtwlSV3yPdPbnrIeVoU+gt/9vEZWaSePwAlyyyK9R/3nBUfNm+WhsSonRPyJdjopnqxtQoYlhe/KD/+pz9DUzmkNTt5KJf3IaWb5Y2IWopJYRe3jGxuFk7uMLduTjmcR5kGF3p1jpuaxT6WnBgsmjBk9CkatjTqED4Z4nyJPeX1MHE6OoD77mT17HXPCXk6PzhtpVg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(346002)(396003)(39860400002)(136003)(451199015)(6666004)(8676002)(36756003)(4326008)(478600001)(83380400001)(6486002)(2906002)(316002)(6512007)(8936002)(4744005)(38100700002)(86362001)(38350700002)(26005)(41300700001)(2616005)(52116002)(5660300002)(6506007)(186003)(1076003)(107886003)(66476007)(66946007)(66556008);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: lrgoDOeRcxJMGfFhIqYWRBYenLYfrmg1+fO/fWTjQLzPmW5wFlP/SjKoQ3KOb0E1jmBHGmmDrPAzYPBPylnAPy/+Gp4X/H5lp+vCvpATRV/nkNWKpbsHll6cZxZWynZthK6RxV+zpCwwDEebwYDPoDZvlU5vBp7SBPt+agdRbGF3YcjkpAR8UPHGCkvbrA6umX/RliymiR+xk2i3yO6nzmjGPvQDHNGh6SeveCdKFyUkbhbB8zIZV3L96v0egZvGRnU/P1ITiI9F/4yQKYyEJBANc+3zszFT0wDbV5faGV/IQPptJ6g9/etZD+JLN/zy8Hnqppgn94srQLMWibWAqKWavmRtKGUGIMKqQoccwjUh1yPdkszOiCvuuedy7uxRej8v5ZhanVMXjFps0O3HyBE3p+YpcqhqFwf/NgaY5X1lAXvuhYpM+X3BwJnkC7pzwJ9bhwxusrWMSNbv4apNQQr/KguA4c7V5d0JdoXyqJi2Pc6ini8ltoFW0UNs2SsI24wiRsnMBJqKXFnDil1n/UJ088oTreyHfZfizlHtPi2qEbM3D6tfK4id2hqM13Fj5Kne7cWaJ84W+QPy65whfnrZC3mEMGeuKQc/Zk0NRO69J80x76WqEZK/2ZTKINvcONMh3boh4s6t8n6l41tYurYI6jkjNS1DY1NFaL3osm3TJpgRWiVB8GakQCOUXgXFBccs++cRVL8lT4K4rrSacIkFxY1Ckyd393H77rx1+ZsMHloIMop6769Q9XAuzyBs25wogznkbjRXDGRquRfX9okKmhAtcag6iv5UKhoQWxgHwW6zoJ9ou6hOKuxIFOKT9StGOf3MrQeFNEK1wLrOus80hCObS63KKVCuMHLSRqoNEfcEHx+vOlm2k+HLRhui03W/d2PLD6m/IWLRiq0gU76sXchk2kxbErECJVvD4Dgh+w4dZCgMjYcRC29DrDJdHBLrLdKlbvPUpgUwoZPjKMM2ujWjkoMM+csOXpmKs5Z19NkCK8OkySIBX7oWQKpTmm0OU1h8EqYbqmxHeEAep1o4KFvhh979wUoiNRqw/bfktYuydZf5VfLP+RfHiLXnxkVvWisYx7Nd9C5TyyTqbGOQRnvRarD8qb+3uTKanbux+kR2S4R/WJGCvpAplMZe9HYWIga9SmXRtlGqssYc6D4UgChr41hBSlvV5DJYzDu1nZtUMoQFGpivdP8N5vEx0074Z+5CesqVc2m0kp0U1NZ8FFYhUh+m4mgZlHdJhhiZZDUeQzMUssv2CBi1unfaEU/6GlhASMoXFCeQbSlliDXD8EN7aJhC7GoEwe5J9EsYW0dpnLBnfG+tZxOsqYf/OZaCjVXLR4FRh5gDyCygPHTAIHZw1uv8NYWcWfhxo4pYUp4/FBRAutBlO9i4N03cyq/g4UrJVd1iO9tdmcY4nDva+3R2AfeuobhWUJEmJ0SrSAkhjUQSH4ZYVMILIqaHA951js6nuvfhQ5QHxaws1o3HqBi2dsZ2kwti5aCOylUnrI4Et9WSZHDhDWTFbPfKof98XBSy9riQ73jAF4qKUJ0FR6IacLXjGdpWFearqEjnu9eiiPT5WnpUnZDzlXtp X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59de766e-5f9d-491d-db7f-08dab8058382 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 10:25:04.9272 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EnLgpI4m3RFkk+xlUOmebd2T9P9Jb8DRtHKW+c9R+eaw7zi0A5uxgAC2+/Xw6Uthf7iwSx1ZFzEoi0hBwtARZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB5366 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747836307619082172?= X-GMAIL-MSGID: =?utf-8?q?1747836307619082172?= Return PTR_ERR(cprc->f2fs_issue_ckpt) instead of -ENOMEM; Signed-off-by: Yangtao Li Reviewed-by: Chao Yu --- fs/f2fs/checkpoint.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index 2a5d9256a6f4..12fd12f2bb97 100644 --- a/fs/f2fs/checkpoint.c +++ b/fs/f2fs/checkpoint.c @@ -1899,8 +1899,9 @@ int f2fs_start_ckpt_thread(struct f2fs_sb_info *sbi) cprc->f2fs_issue_ckpt = kthread_run(issue_checkpoint_thread, sbi, "f2fs_ckpt-%u:%u", MAJOR(dev), MINOR(dev)); if (IS_ERR(cprc->f2fs_issue_ckpt)) { + int err = PTR_ERR(cprc->f2fs_issue_ckpt); cprc->f2fs_issue_ckpt = NULL; - return -ENOMEM; + return err; } set_task_ioprio(cprc->f2fs_issue_ckpt, cprc->ckpt_thread_ioprio);